Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Rick W. Chen 
On 06 Nov 2011 21:41 +0100, Bart Cerneels:
> On Sun, Nov 6, 2011 at 13:29, Rick W. Chen  wrote:
> > On 06 Nov 2011 09:22 +0100, Bart Cerneels:
> >> Micro option! And as far as I can tell because only one user
> >> complained on the forums. Unless Rick has a personal preference.
> >> Still, we need to be very hesitant to add micro options.
> >>
> >> The arguments for having the backgrounds:
> >> - Reduces the "field of grey" effect when the browsers are empty.
> >> - General prettyness
> >> - Recognition of browser without reading
> >>
> >> Any reasons to have the option to remove them besides: one user wants it?
> >
> > It is my personal preference. I didn't know about the user in the
> > forum.
> >
> > I almost always have the collection browser open. Sometimes the
> > background makes the texts harder to read. That's why I prefer not to
> > have them shown. I generally agree with the arguments you gave, but for
> > me readability is more important.
> >
> > A note on prettyness: If you have enabled qt tree collapse/expand
> > animations, during that time the background image would not be visible.
> > It is filled with base window colour and when the animation stops the
> > image will suddenly reappear. That's just how it works. You can also see
> > this in the album applet. Visually that's not too pleasing.
> 
> We are aware of this. Figured it's not that big of an issue and we
> would find a solution later. Still have not found a way to do it
> though. Would setting the background transparent and having the image
> *behind* the itemview work?

That's they way it looks at the moment, no?

-- 
Rick
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Most voted bugs in Amarok

2011-11-06 Thread Myriam Schweingruber 
Hi all,

please find below the list of the bugs most voted for:

187587 norNORNEW2.4.1Linucue
sheet not working for files in
collection488278897
norNORNEW2.4.3LinuAmarok uses ~40% of CPU until main window is maximized219
199483 norNORREOP2.4-GLinuVarious
artists album with album artist tag filled should appear under album artist
instead of "Various
Artists"185229452
norNORNEW2.4.1LinuAmarok doesn't follow kde color settings in playlist and
context184246029 norNORNEW2.4-G
LinuFilebrowser window grows in size while expanding
directories184192874
norNORNEW2.4-Gunsp[PATCH] queue tracks from collection
browser180198381
norNORNEW2.4-GunspRace condition when fetching
lyrics136208831
norNORNEW2.4.0LinuAmarok only searches Ampache by Artist
name120258555
norNORASSI2.4-GLinuamarok doesn't show duplicate
tracks120235184
norNORNEW2.4.1Linu[PATCH] Some Jamendo artists don't appear in the Jamendo
service100244896 norNORNEW2.4.3
LinuHigh CPU usage in kwin and xorg when Amarok playing and window is not
minimized94209684 norNORNEW
2.4.1LinuThe size of rating stars should not change in inline editing86
234827 norNORNEW2.4-Gunspmoodbar
displays previous song
75133762 norLONEW2.4-GLinuamarok
can't tell if a remote URL is a playlist or not70

-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Most often reported bugs in Amarok

2011-11-06 Thread Myriam Schweingruber 
Hi all,

Please find below the list of the most reported bugs in Amarok.

Regards, Myriam


197343 36Tools/Cover Manager
crashLinux2.4.1Amarok crashed when setting custom album cover
(SetCustomCoverAction::slotTriggered)233170
35Collection BrowsercrashLinux2.5Crash when browsing a category on Jamendo
[@ CollectionTreeItem::row]204251
28Media DevicescrashLinux2.5Various crashes with MTP media devices
[MtpHandler]172542 9Collection
BrowsermajorLinux2.4.2Collection Browser doesn't update when changes are
made to files in the collection90095
8CollectionwishlistLinux---Bad handling of the "Artist" ID3
tag265626
7generalcrashLinux2.5Amarok crash while browsing files [@
Amarok::ElidingButton::qt_metacall]




199483 6Collection Browser
normalLinux2.4.2Various artists album with album artist tag filled should
appear under album artist instead of "Various
Artists"246029
5File BrowsernormalLinux2.4.0Filebrowser window grows in size while
expanding directories198381
5Context
View/Lyricsnormalunspecified---Race condition when fetching
lyrics187587
5CollectionnormalLinux2.4.0cue sheet not working for files in collection--
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7986
---

Ship it!


Ship It!

- Matěj Laitl


On Nov. 6, 2011, 7:29 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> ---
> 
> (Updated Nov. 6, 2011, 7:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The filters (eg. filesize, artist) can be translated but without this patch 
> components like the EditFilterDialog won't recognize the keywords.
> 
> I haven't committed it yet because it also changes the keyword 'modifydate' 
> to 'modified' since i think that that's a bug, too.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
>   src/core/meta/support/MetaConstants.cpp fabb146 
> 
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Bart Cerneels 
On Sun, Nov 6, 2011 at 13:29, Rick W. Chen  wrote:
> On 06 Nov 2011 09:22 +0100, Bart Cerneels:
>> Micro option! And as far as I can tell because only one user
>> complained on the forums. Unless Rick has a personal preference.
>> Still, we need to be very hesitant to add micro options.
>>
>> The arguments for having the backgrounds:
>> - Reduces the "field of grey" effect when the browsers are empty.
>> - General prettyness
>> - Recognition of browser without reading
>>
>> Any reasons to have the option to remove them besides: one user wants it?
>
> It is my personal preference. I didn't know about the user in the
> forum.
>
> I almost always have the collection browser open. Sometimes the
> background makes the texts harder to read. That's why I prefer not to
> have them shown. I generally agree with the arguments you gave, but for
> me readability is more important.
>
> A note on prettyness: If you have enabled qt tree collapse/expand
> animations, during that time the background image would not be visible.
> It is filled with base window colour and when the animation stops the
> image will suddenly reappear. That's just how it works. You can also see
> this in the album applet. Visually that's not too pleasing.

We are aware of this. Figured it's not that big of an issue and we
would find a solution later. Still have not found a way to do it
though. Would setting the background transparent and having the image
*behind* the itemview work?
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust 


On Nov. 6, 2011, 6:10 p.m., Daniel Faust wrote:
> > Good work, Daniel! Please fix remaining minor fix and I'll be happy to 
> > merge this. (or, do you have commit access yourself?)

I can commit myself once everything is fine.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7978
---


On Nov. 6, 2011, 7:29 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> ---
> 
> (Updated Nov. 6, 2011, 7:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The filters (eg. filesize, artist) can be translated but without this patch 
> components like the EditFilterDialog won't recognize the keywords.
> 
> I haven't committed it yet because it also changes the keyword 'modifydate' 
> to 'modified' since i think that that's a bug, too.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
>   src/core/meta/support/MetaConstants.cpp fabb146 
> 
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/
---

(Updated Nov. 6, 2011, 7:29 p.m.)


Review request for Amarok.


Changes
---

-some code refactoring - i hope there are no copy'n'past errors


Description
---

The filters (eg. filesize, artist) can be translated but without this patch 
components like the EditFilterDialog won't recognize the keywords.

I haven't committed it yet because it also changes the keyword 'modifydate' to 
'modified' since i think that that's a bug, too.


Diffs (updated)
-

  src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
  src/core/meta/support/MetaConstants.cpp fabb146 

Diff: http://git.reviewboard.kde.org/r/103014/diff/diff


Testing
---


Thanks,

Daniel Faust

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7978
---



src/core-impl/collections/support/TextualQueryFilter.cpp


Good! Now this looks much more nicer.

But.. what about turing this into a switch..case now? This has additional 
benefit that compiler can warn about enum values not used in switch.

I forgot what convention is used in Amarok for indenting switches, but it 
is in HACKING/conding_styel..



src/core/meta/support/MetaConstants.cpp


You may perhaps want to wrap all these entries not to be that long, 
suggestion:

else if( name.compare( "filename", Qt::CaseInsensitive ) == 0
  || name.compare( shortI18nForField( Meta::valUrl ), 
Qt::CaseInsensitive ) == 0 )
  return Meta::valUrl;



src/core/meta/support/MetaConstants.cpp


Please accept also "first" as a special case - some users may have 
memorised it and now it would'n work for them.



src/core/meta/support/MetaConstants.cpp


Please also accept "played" as a special case to be backward-compatible.


Good work, Daniel! Please fix remaining minor fix and I'll be happy to merge 
this. (or, do you have commit access yourself?)

- Matěj Laitl


On Nov. 6, 2011, 5:45 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> ---
> 
> (Updated Nov. 6, 2011, 5:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The filters (eg. filesize, artist) can be translated but without this patch 
> components like the EditFilterDialog won't recognize the keywords.
> 
> I haven't committed it yet because it also changes the keyword 'modifydate' 
> to 'modified' since i think that that's a bug, too.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
>   src/core/meta/support/MetaConstants.cpp fabb146 
> 
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/
---

(Updated Nov. 6, 2011, 5:45 p.m.)


Review request for Amarok.


Changes
---

-changed keywords 'first'/'played' back to 'firstplay'/'lastplay'
-made TextualQueryFilter use Meta::fieldForName


Description
---

The filters (eg. filesize, artist) can be translated but without this patch 
components like the EditFilterDialog won't recognize the keywords.

I haven't committed it yet because it also changes the keyword 'modifydate' to 
'modified' since i think that that's a bug, too.


Diffs (updated)
-

  src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
  src/core/meta/support/MetaConstants.cpp fabb146 

Diff: http://git.reviewboard.kde.org/r/103014/diff/diff


Testing
---


Thanks,

Daniel Faust

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Rick W. Chen 
On 06 Nov 2011 09:22 +0100, Bart Cerneels:
> Micro option! And as far as I can tell because only one user
> complained on the forums. Unless Rick has a personal preference.
> Still, we need to be very hesitant to add micro options.
> 
> The arguments for having the backgrounds:
> - Reduces the "field of grey" effect when the browsers are empty.
> - General prettyness
> - Recognition of browser without reading
> 
> Any reasons to have the option to remove them besides: one user wants it?

It is my personal preference. I didn't know about the user in the
forum.

I almost always have the collection browser open. Sometimes the
background makes the texts harder to read. That's why I prefer not to
have them shown. I generally agree with the arguments you gave, but for
me readability is more important.

A note on prettyness: If you have enabled qt tree collapse/expand
animations, during that time the background image would not be visible.
It is filled with base window colour and when the animation stops the
image will suddenly reappear. That's just how it works. You can also see
this in the album applet. Visually that's not too pleasing.

> 
> Bart
> 
> On Sun, Nov 6, 2011 at 05:18, Rick W. Chen  wrote:
> > Git commit 07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46 by Rick W. Chen.
> > Committed on 05/11/2011 at 14:03.
> > Pushed by rickc into branch 'master'.
> >
> > Add option to toggle showing of browser background images
> >
> > M  +1    -0    ChangeLog
> > M  +4    -0    src/amarokconfig.kcfg
> > M  +8    -0    src/browsers/BrowserCategory.cpp
> > M  +3    -0    src/browsers/BrowserCategory.h
> > M  +3    -2    src/browsers/collectionbrowser/CollectionWidget.cpp
> > M  +3    -2    src/browsers/filebrowser/FileBrowser.cpp
> > M  +2    -2    src/browsers/playlistbrowser/APGCategory.cpp
> > M  +3    -2    src/browsers/playlistbrowser/DynamicCategory.cpp
> > M  +4    -2    src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
> > M  +3    -2    src/browsers/playlistbrowser/PodcastCategory.cpp
> > M  +11   -4    src/configdialog/dialogs/GeneralConfig.ui
> >
> > http://commits.kde.org/amarok/07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46

-- 
Rick
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Bart Cerneels 
Micro option! And as far as I can tell because only one user
complained on the forums. Unless Rick has a personal preference.
Still, we need to be very hesitant to add micro options.

The arguments for having the backgrounds:
- Reduces the "field of grey" effect when the browsers are empty.
- General prettyness
- Recognition of browser without reading

Any reasons to have the option to remove them besides: one user wants it?

Bart

On Sun, Nov 6, 2011 at 05:18, Rick W. Chen  wrote:
> Git commit 07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46 by Rick W. Chen.
> Committed on 05/11/2011 at 14:03.
> Pushed by rickc into branch 'master'.
>
> Add option to toggle showing of browser background images
>
> M  +1    -0    ChangeLog
> M  +4    -0    src/amarokconfig.kcfg
> M  +8    -0    src/browsers/BrowserCategory.cpp
> M  +3    -0    src/browsers/BrowserCategory.h
> M  +3    -2    src/browsers/collectionbrowser/CollectionWidget.cpp
> M  +3    -2    src/browsers/filebrowser/FileBrowser.cpp
> M  +2    -2    src/browsers/playlistbrowser/APGCategory.cpp
> M  +3    -2    src/browsers/playlistbrowser/DynamicCategory.cpp
> M  +4    -2    src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
> M  +3    -2    src/browsers/playlistbrowser/PodcastCategory.cpp
> M  +11   -4    src/configdialog/dialogs/GeneralConfig.ui
>
> http://commits.kde.org/amarok/07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46
>
> diff --git a/ChangeLog b/ChangeLog
> index b602581..fdb05a4 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -26,6 +26,7 @@ Version 2.5.0-Beta 1
>     * Auto-save the playlist so that it is not lost if Amarok crashes.
>
>   CHANGES:
> +    * Browser widget backgrounds can now be enabled/disabled.
>     * Playlist: Don't group albums without name. (BR 243344)
>     * Make delete confirmation dialog text less confusing. Patch by Gilles 
> Habran.
>       (BR 263693)
> diff --git a/src/amarokconfig.kcfg b/src/amarokconfig.kcfg
> index 1172e79..5610c4a 100644
> --- a/src/amarokconfig.kcfg
> +++ b/src/amarokconfig.kcfg
> @@ -107,6 +107,10 @@
>         Whether to automatically attempt to fetch cover art as 
> needed
>         false
>     
> +    
> +        Whether to show background images in the browser pane
> +        true
> +    
>     
>         Automatically scroll the playlist to make the currently 
> playing song visible
>         true
> diff --git a/src/browsers/BrowserCategory.cpp 
> b/src/browsers/BrowserCategory.cpp
> index e0ce09e..34da991 100644
> --- a/src/browsers/BrowserCategory.cpp
> +++ b/src/browsers/BrowserCategory.cpp
> @@ -16,6 +16,8 @@
>
>  #include "BrowserCategory.h"
>
> +#include "App.h"
> +#include "amarokconfig.h"
>  #include "BrowserBreadcrumbItem.h"
>  #include "BrowserCategoryList.h"
>
> @@ -32,6 +34,7 @@ BrowserCategory::BrowserCategory( const QString &name, 
> QWidget *parent )
>     setObjectName( name );
>     setSizePolicy( QSizePolicy::Expanding, QSizePolicy::Expanding );
>     setFrameShape( QFrame::NoFrame );
> +    connect( App::instance(), SIGNAL(settingsChanged()), 
> SLOT(slotSettingsChanged()) );
>  }
>
>  BrowserCategory::~BrowserCategory()
> @@ -111,6 +114,11 @@ BrowserCategory::setBackgroundImage(const QString& path)
>     );
>  }
>
> +void BrowserCategory::slotSettingsChanged()
> +{
> +    setBackgroundImage( AmarokConfig::showBrowserBackgroundImage() ? 
> m_imagePath : QString() );
> +}
> +
>  void BrowserCategory::setParentList( BrowserCategoryList * parent )
>  {
>     m_parentList = parent;
> diff --git a/src/browsers/BrowserCategory.h b/src/browsers/BrowserCategory.h
> index e753b1d..85cba7c 100644
> --- a/src/browsers/BrowserCategory.h
> +++ b/src/browsers/BrowserCategory.h
> @@ -157,6 +157,9 @@ public slots:
>     //Called if this category itself is re-clicked in the breadcrumb
>     virtual void reActivate() {}
>
> +private slots:
> +    void slotSettingsChanged();
> +
>  private:
>     QString m_name;
>     QString m_prettyName;
> diff --git a/src/browsers/collectionbrowser/CollectionWidget.cpp 
> b/src/browsers/collectionbrowser/CollectionWidget.cpp
> index d5d86c2..ac1c26d 100644
> --- a/src/browsers/collectionbrowser/CollectionWidget.cpp
> +++ b/src/browsers/collectionbrowser/CollectionWidget.cpp
> @@ -22,6 +22,7 @@
>
>  #include "CollectionWidget.h"
>
> +#include "amarokconfig.h"
>  #include "CollectionTreeItemModel.h"
>  #include "CollectionTreeItemModelBase.h"
>  #include "CollectionTreeItemDelegate.h"
> @@ -146,8 +147,8 @@ CollectionWidget::CollectionWidget( const QString &name , 
> QWidget *parent )
>     setImagePath( KStandardDirs::locate( "data", 
> "amarok/images/hover_info_collections.png" ) );
>
>     // set background
> -    const QString bgImage = KStandardDirs::locate("data", 
> "amarok/images/hover_info_collections.png");
> -    setBackgroundImage( bgImage );
> +    if( AmarokConfig::showBrowserBackgroundImage() )
> +        setBackgroundImage( imagePath() );
>
>     // --- the box for the UI elements.
>     KHBox *hbox = new KHBox( this );
> diff --git a/src/browsers/fi

Re: Review Request: Add new collection filter to find exact matches

2011-11-06 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/#review7972
---


This review has been submitted with commit 
3e7122a2879260b531f9b2df4bdeaf0710ae303f by Daniel Faust to branch master.

- Commit Hook


On Nov. 1, 2011, 3:02 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102252/
> ---
> 
> (Updated Nov. 1, 2011, 3:02 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Since I use labels quite intensive it sometimes comes handy to search for 
> songs with an exact label, not just a label containing the string I'm 
> searching for.
> So I added a new filter type for this and used the '=' sign.
> 
> Searching for label=pop finds songs labeled with 'pop' but not with 'electro 
> pop'.
> While searching for label:pop finds songs labeled with 'pop' and 'electro 
> pop'.
> 
> This is not integrated into the GUI like the EditFilterDialog since I wanted 
> to hear your opinions first.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/support/Expression.h 1e49f45 
>   src/core-impl/collections/support/Expression.cpp 531850a 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 735772b 
>   src/dialogs/EditFilterDialog.cpp 91628ff 
>   src/widgets/MetaQueryWidget.h 3db49d3 
>   src/widgets/MetaQueryWidget.cpp 5db1ded 
> 
> Diff: http://git.reviewboard.kde.org/r/102252/diff/diff
> 
> 
> Testing
> ---
> 
> I'm using this patch for a few weeks now without any problems.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/102252/s/221/
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: make all like conditions case insensitive

2011-11-06 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103015/#review7971
---


This review has been submitted with commit 
be77608b9ba0386c3bfc6f1d7daa78b80dd48826 by Daniel Faust to branch master.

- Commit Hook


On Nov. 1, 2011, 3:15 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103015/
> ---
> 
> (Updated Nov. 1, 2011, 3:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> When creating a sql like condition and booth, the beginning and the ending of 
> the string have to match, the comparison is case sensitive.
> I haven't seen it being used until my proposed patch to add a new collection 
> filter to exactly do that. (http://git.reviewboard.kde.org/r/102252/)
> But I would suggest using case insensitivity there, too.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp 398bcdc 
> 
> Diff: http://git.reviewboard.kde.org/r/103015/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel