Re: Review Request: Bump the taglib dependency to 1.7
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103781/#review10068 --- Ship it! Needs to be mentioned in the README as well. - Bart Cerneels On Jan. 24, 2012, 11:39 a.m., Christophe Giboudeaux wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103781/ > --- > > (Updated Jan. 24, 2012, 11:39 a.m.) > > > Review request for Amarok. > > > Description > --- > > A build error was detected by our unstable package in Opensuse: > https://build.opensuse.org/package/show?package=amarok&project=KDE%3AUnstable%3APlayground > > A closer look points to commit 717342ed which includes taglib/flacpicture.h. > This header doesn't exist in taglib 1.6.x > > > Diffs > - > > CMakeLists.txt 2247390 > > Diff: http://git.reviewboard.kde.org/r/103781/diff/diff > > > Testing > --- > > > Thanks, > > Christophe Giboudeaux > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fix for bug 289751
> On Jan. 24, 2012, 8:39 a.m., Bart Cerneels wrote: > > Good catch. Something that could have been discovered in code review a lot > > earlier I guess. > > > > Will you commit? I think i am not able to commit as i didn't have permisions therefor. Shall i request for a developer account? - Volker --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103774/#review10036 --- On Jan. 23, 2012, 9:46 a.m., Volker Christian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103774/ > --- > > (Updated Jan. 23, 2012, 9:46 a.m.) > > > Review request for Amarok. > > > Description > --- > > Fix crash when a device holding a UmsCollection is mounted again after an > unmount without removing the device in between. This will fix bug 289751. > > The crash occours because the QSharedPointer m_mc is cleared during an > unmount but not initialized when mounted again. I fixed this issue by > initializing m_mc in the init-method and not in the constructor. > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.cpp df3445f > > Diff: http://git.reviewboard.kde.org/r/103774/diff/diff > > > Testing > --- > > > Thanks, > > Volker Christian > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: [amarok] cmake/modules: Revert "FindMySQLAmarok.cmake fix argumets when calling mysql_config"
On 19. 12. 2011 Christophe Giboudeaux wrote: > On Monday 19 December 2011 00:38:47 Matěj Laitl wrote: > > I tried to solve http://mail.kde.org/pipermail/amarok-devel/2011- > > December/009663.html > > > > Specifically, the problem is that mysql_config (at least 5.1.56) > > doesn't accept --variable=pkgincludedir - it accepts only --include > > argument which returns something like -I/usr/include/mysql > > > > -- Found MySQL: Usage: /usr/bin/mysql_config [OPTIONS] > > ok, then it only exists in higher version (the option exists in 5.5.x). > > I see two solutions: > - only rely on find_path(MYSQL_INCLUDE_DIR...), so move it outside the > else(MYSQLCONFIG_EXECUTABLE) loop [1] > > - Drop FindMysqlAmarok.cmake and use FindAmarok.cmake from kdelibs instead > (which worked fine here). > > I prefer the second solution as the FindMysql from kdelibs is really cleaner > than the Amarok copy: > > - MYSQL_CFLAGS doesn't look that important > > - the linked targets gathered with 'mysql_config --libs' are already > explicitly added in the CMakeLists.txt files (./src/core- > impl/collections/db/sql/mysqlecollection/CMakeLists.txt, ./src/core- > impl/collections/db/sql/mysqlservercollection/CMakeLists.txt and some unit > tests) and the output variable is different if mysql_config is not present: > > * with mysql_config, MYSQL_LIBRARIES="-L/usr/lib64 -lmysqlclient -lpthread > - lz -lm -lrt -lssl -lcrypto -ldl" > * without it, MYSQL_LIBRARIES=/usr/lib64/libmysqlclient.so. The second one > is enough Hmm, I've tried dropping FindMySQLAmarok.cmake, but using kdelibs one doesn't work for me (you probably don't build tests): Linking CXX executable ../../../../testsqlcollection /usr/lib64/mysql/libmysqld.so: undefined reference to `DH_new' /usr/lib64/mysql/libmysqld.so: undefined reference to `SSL_get_current_cipher' /usr/lib64/mysql/libmysqld.so: undefined reference to `SSL_CIPHER_get_name' (...) I don't know why core mysqlcollection builds fine (probably something else pulls OpenSSL? AFAIK undefined symbols are allowed in shared libs, but not final executables), but apparently the additional entries in MYSQL_LIBRARIES are needed. (and I really don't feel like hard-coding them in Amarok) So I will commit your patch if no-one disagrees. Matěj ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Fwd: Re: qtscriptgenerator with Qt 4.8 / Amarok
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - Original Message From: - Tue Jan 24 18:30:31 2012 Subject: Re: qtscriptgenerator with Qt 4.8 / Amarok From: Kent Hansen In-Reply-To: <4f16f9da.6060...@asbest-online.de> Date: Tue, 24 Jan 2012 18:34:27 +0100 To: Sven Krohlas Den Jan 18, 2012 kl. 5:56 PM skrev Sven Krohlas: > -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > Hi, > > Kent Hansen wrote: >> Den Jan 3, 2012 kl. 3:10 PM skrev Sven Krohlas: As the bug report is already >> relatively old >> and very severe may I ask about the maintenance status of the project? Will >> it still be >> maintained in the future or do we have to migrate away from QtScript? >> >>> The QtScript module in Qt is marked as "Done", which means it's no longer >>> in active >>> development. In practice, only crashes and regressions will be fixed. >> >>> I haven't tried the bindings generator with 4.8 yet, but if I manage to >>> reproduce the >>> issue and find a sensible fix, I can make a new release. > > that would be great, thanks. :-) OK I made a new release (0.2.0), feel free to give it a spin. :) Kent > - -- Darkerradio Free Music Charts November 2011: > http://www.darkerradio.com/news/free-music-charts-november-2011/ Klarmachen > zum Ändern! -> > http://www.piratenpartei.de/ -BEGIN PGP SIGNATURE- Version: GnuPG > v2.0.18 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAk8W+dkACgkQOOggGLjBlhbdigCfecpIgG137gu6r4wBg7gmZdwL > MNAAn2hk61b6fXEDzagx5dHAMoW1HgAA =CIRl -END PGP SIGNATURE- -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8e7rgACgkQOOggGLjBlhYQiwCeOxvFf591ltAJCvT4mSyZQTsU gN0An2ZQGtucfs6w0F3TCOhiPcuK6+L6 =vZpw -END PGP SIGNATURE- ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Fix for bug 289751
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103774/#review10036 --- Ship it! Good catch. Something that could have been discovered in code review a lot earlier I guess. Will you commit? - Bart Cerneels On Jan. 23, 2012, 9:46 a.m., Volker Christian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103774/ > --- > > (Updated Jan. 23, 2012, 9:46 a.m.) > > > Review request for Amarok. > > > Description > --- > > Fix crash when a device holding a UmsCollection is mounted again after an > unmount without removing the device in between. This will fix bug 289751. > > The crash occours because the QSharedPointer m_mc is cleared during an > unmount but not initialized when mounted again. I fixed this issue by > initializing m_mc in the init-method and not in the constructor. > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.cpp df3445f > > Diff: http://git.reviewboard.kde.org/r/103774/diff/diff > > > Testing > --- > > > Thanks, > > Volker Christian > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
