Re: GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-20 Thread Christoph Obexer 
Thats an awesome idea!
You could solve last.fm's downsides with ownCloud.
Also it would be cool if this could work with android based devices, not
sure if there are android music players that support statistics tough...

cobexer
--
Sent from my HTC DHD
Am 21.03.2012 00:06 schrieb "Matěj Laitl" :

> Hi Teo, Bart and list,
> as suggested by Teo, I've decided to try to take part in GSoC 2012 working
> as
> a student on Amarok. My idea is not on the KDE Ideas page, but I've been
> playing with (a variant of it) for months.
>
> Continues a very draft of my GSoC proposal. I'd be very grateful for any
> possible comments, pointed-out omissions or questions that may arise.
>
> Introduction
> ===
> Amarok has an ability to store per-track play statistics such as play
> count,
> first & last played date, rating and labels. It then has powerful means to
> generate custom-tailored playlists based on gathered statistics (e.g.:
> play me
> what I've listened to last month) that many users like to exploit. This
> works
> well when your computer is the only device you play music from. More likely
> situation is that you play music using Amarok at home, listen to iPod while
> commuting and use Amarok or another music player at work. All these 3
> devices
> are able to keep track of what you've listened to, but each one only a
> third
> of it, which makes Amarok statistics more or less useless. This project
> aims
> to remedy the situation; Last.fm is an online service that can keep track
> of
> music a user listens to[1] and can help us with a part of this project.
> Amarok
> Users group on Last.fm has over 23 000 users.[2]
>
> Project Goals
> 
> This project will implement:
>  * track statistics synchronization between Amarok collections that support
> statistics; these are currently Local Collection and iPod Collection, but
> the
> framework will be general
>  * Last.fm scrobbling from pluggable media players that support statistics
> (iPods, currently) using the general framework from previous point
>  * ability to synchronize labels from Amarok to Last.fm
>  * ability to synchronize play counts, first & last played date from
> Last.fm to
> Amarok collections (other way around is already implemented by scrobbling)
>  * GUI dialogue for performing the synchronization/resolving conflicts
>
> Bonus points (what will Amarok gain for free):
>  * ability to synchronize statistics of Amarok and other media player that
> scrobbles to Last.fm
>  * track statistics backup through Last.fm
>
> Caveats:
>  * Last.fm has no concept of track ratings. This can be however worked
> around
> by special Last.fm-side labels such as "7/10 stars"
>  * advanced features will be only available for Last.fm users; Last.fm is
> free
> to use, but the data are public which may be unpleasant for certain users
>
> Implementation
> =
> Amarok represents audio tracks by Meta::Track abstract C++ class that
> provides
> getter methods for meta-data (title, artist, album..) and getter/setter
> methods for statistics (rating, play count...). These tracks are grouped
> into
> so-called Collections, where each Collection represents one source of songs
> (iPod, Local, USB Mass Storage..). Tracks from different collections will
> be
> matched together using their meta-data and other collection's QueryMaker to
> perform the search. Moreover, iPods provide additional data that can be
> used for conflict-resolution: app_rating and recent_playcount. [3] I plan
> to
> expose these as new capability offered by Collections. This capability will
> also be used to implement Last.fm scrobbling from iPods (in fact, every
> collection that will support this capability), exploiting recent_playcount
> field in the iPod case. It should be noted that I have already implemented
> similar synchronization in my spare time back in summer 2011 [4], but I was
> not satisfied with its iPod-specific design and GUI, so I decided not to
> strive
> for its inclusion. But I have the code working and ported to Amarok 2.5,
> so it
> can be used to fast-start this project.
>
> Another interesting note is that scrobble-from-iPod-to-Last.fm was
> functional
> in Amarok 1.4 days, but this feature got dropped during rewrites leading to
> 2.0, so this will fix one long-overdue regression.
>
> Speaking about Last.fm integration, Last.fm provides rather nice RESTful
> API
> [5] a subset of which is already used through liblastfm [6] library in
> Amarok
> to submit (scrobble) currently played songs. I plan to reuse this library
> and
> Amarok code dealing with it; the Last.fm API is powerful enough to support
> all
> claimed features. There is already even Last.fm on-line service Collection,
> but it focuses on playing Last.fm radio streams and doesn't handle
> individual
> tracks. In order to implement actual synchronization with Last.fm, user's
> Last.fm Library (that contains relevant track data) can be represented as a
> new (invisible) Collection or as special case in synch

GSoC Proposal: Statistics synchronization for pluggable devices and Last.fm

2012-03-20 Thread Matěj Laitl 
Hi Teo, Bart and list,
as suggested by Teo, I've decided to try to take part in GSoC 2012 working as 
a student on Amarok. My idea is not on the KDE Ideas page, but I've been 
playing with (a variant of it) for months.

Continues a very draft of my GSoC proposal. I'd be very grateful for any 
possible comments, pointed-out omissions or questions that may arise.

Introduction
===
Amarok has an ability to store per-track play statistics such as play count, 
first & last played date, rating and labels. It then has powerful means to 
generate custom-tailored playlists based on gathered statistics (e.g.: play me 
what I've listened to last month) that many users like to exploit. This works 
well when your computer is the only device you play music from. More likely 
situation is that you play music using Amarok at home, listen to iPod while 
commuting and use Amarok or another music player at work. All these 3 devices 
are able to keep track of what you've listened to, but each one only a third 
of it, which makes Amarok statistics more or less useless. This project aims 
to remedy the situation; Last.fm is an online service that can keep track of 
music a user listens to[1] and can help us with a part of this project. Amarok 
Users group on Last.fm has over 23 000 users.[2]

Project Goals

This project will implement:
 * track statistics synchronization between Amarok collections that support 
statistics; these are currently Local Collection and iPod Collection, but the 
framework will be general
 * Last.fm scrobbling from pluggable media players that support statistics 
(iPods, currently) using the general framework from previous point
 * ability to synchronize labels from Amarok to Last.fm
 * ability to synchronize play counts, first & last played date from Last.fm to 
Amarok collections (other way around is already implemented by scrobbling)
 * GUI dialogue for performing the synchronization/resolving conflicts

Bonus points (what will Amarok gain for free):
 * ability to synchronize statistics of Amarok and other media player that 
scrobbles to Last.fm
 * track statistics backup through Last.fm

Caveats:
 * Last.fm has no concept of track ratings. This can be however worked around 
by special Last.fm-side labels such as "7/10 stars"
 * advanced features will be only available for Last.fm users; Last.fm is free 
to use, but the data are public which may be unpleasant for certain users

Implementation
=
Amarok represents audio tracks by Meta::Track abstract C++ class that provides 
getter methods for meta-data (title, artist, album..) and getter/setter 
methods for statistics (rating, play count...). These tracks are grouped into 
so-called Collections, where each Collection represents one source of songs 
(iPod, Local, USB Mass Storage..). Tracks from different collections will be 
matched together using their meta-data and other collection's QueryMaker to 
perform the search. Moreover, iPods provide additional data that can be 
used for conflict-resolution: app_rating and recent_playcount. [3] I plan to 
expose these as new capability offered by Collections. This capability will 
also be used to implement Last.fm scrobbling from iPods (in fact, every 
collection that will support this capability), exploiting recent_playcount 
field in the iPod case. It should be noted that I have already implemented 
similar synchronization in my spare time back in summer 2011 [4], but I was 
not satisfied with its iPod-specific design and GUI, so I decided not to strive 
for its inclusion. But I have the code working and ported to Amarok 2.5, so it 
can be used to fast-start this project.

Another interesting note is that scrobble-from-iPod-to-Last.fm was functional 
in Amarok 1.4 days, but this feature got dropped during rewrites leading to 
2.0, so this will fix one long-overdue regression.

Speaking about Last.fm integration, Last.fm provides rather nice RESTful API 
[5] a subset of which is already used through liblastfm [6] library in Amarok 
to submit (scrobble) currently played songs. I plan to reuse this library and 
Amarok code dealing with it; the Last.fm API is powerful enough to support all 
claimed features. There is already even Last.fm on-line service Collection, 
but it focuses on playing Last.fm radio streams and doesn't handle individual 
tracks. In order to implement actual synchronization with Last.fm, user's 
Last.fm Library (that contains relevant track data) can be represented as a 
new (invisible) Collection or as special case in synchronizer, I have yet to 
decide this design choice.

Timeline
=
[To be done when the general idea is accepted.] Generally: inter-collection 
synchronization will be first and will be done by the midterm evaluation, 
Last.fm support will be second. I'm already quite bound to Amarok community, 
so I can finish the design, iron-out some details and perhaps present some GUI 
mockups during the community bonding period.

If accepted, GSoC will be my

[Bug 296423] Amarok fails to compile with taglib from master

2012-03-20 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=296423

Christoph Feck  changed:

   What|Removed |Added

 CC||amarok-devel@kde.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Stefan Derkits 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/#review11658
---

Ship it!


only looked at the code, didn't try out yet ... code looks fine


ChangeLog


a expected -> an expected

so as to synchronize -> to snychronise (or change synchronisation to 
synchronization)




src/services/gpodder/GpodderService.cpp


maybe merge this debug output into one line



src/services/gpodder/GpodderServiceConfig.cpp


what about suggestions? they also need user & password


- Stefan Derkits


On March 19, 2012, 8 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104335/
> ---
> 
> (Updated March 19, 2012, 8 p.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> ---
> 
> GPodder Improvements Patch Rev1
> 
> Put messages to show that gpodder service failed to get data from
> gpodder.net. Done some cleanup and added some comments.
> 
> GPodder Service improvements
> 
> Full status synchronisation implemented. Cleanup and some refactoring.
> GPodder Provider saves podcast subscriptions changes if the user closes
> amarok before a expected synchronisation to end, so as to synchronize them
> in the next start. Forcing GPodderService to verify if the username and
> password is not empty before creating a mygpo::ApiRequest. Solved some
> problems related to the KWallet use in GPodderService.
> 
> 
> Diffs
> -
> 
>   ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 
> 0a450ae2420de11ab221cf2dec9fc942a7118dd1 
>   src/browsers/playlistbrowser/PodcastModel.h 
> e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
>   src/browsers/playlistbrowser/PodcastModel.cpp 
> 18334f6eb970eed241f172cc71396cca8bcaf04b 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.h 
> c3d5e56e79c86e2be8c39f47df928bfeb291a920 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
> 183005f652989167952b0c8cf16e742de2fb94e1 
>   src/services/gpodder/GpodderPodcastRequestHandler.h 
> 8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
>   src/services/gpodder/GpodderPodcastRequestHandler.cpp 
> 66e8ea8a3aeec054c82a180f84d199aba5547f5a 
>   src/services/gpodder/GpodderProvider.h 
> 4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
>   src/services/gpodder/GpodderProvider.cpp 
> 6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
>   src/services/gpodder/GpodderService.cpp 
> b518de33e01d20c7293c50e9edbb2dff78419e53 
>   src/services/gpodder/GpodderServiceConfig.h 
> 111455aeeb2a579caf1dd938249b8d832a775a89 
>   src/services/gpodder/GpodderServiceConfig.cpp 
> 750272e4f2c6c7ad411e9d12c622e97789a29bcd 
>   src/services/gpodder/GpodderServiceSettings.h 
> 81bc218428d2b8bc78235852548a337579b35b24 
>   src/services/gpodder/GpodderServiceSettings.cpp 
> 8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
>   src/services/gpodder/GpodderSortFilterProxyModel.h 
> 638fe992cba553cc317febdf049b6b0f301018b5 
>   src/services/gpodder/GpodderSortFilterProxyModel.cpp 
> ed1e8301f6f415e86e5367b7827817fff45feb98 
> 
> Diff: http://git.reviewboard.kde.org/r/104335/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Load all tracks from saved playlists using MetaProxy.

2012-03-20 Thread Bart Cerneels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104256/
---

(Updated March 20, 2012, 12:14 p.m.)


Review request for Amarok.


Changes
---

Proxy load all saved playlist types: XSPF, PLS, M3U and SQL


Summary (updated)
-

Load all tracks from saved playlists using MetaProxy.


Description
---

Load all tracks from XSPF using MetaProxy.

Added a worker that does the actual trackForUrl call and subscribes to
trackProviderAdded signal as needed.


This addresses bug 295199.
https://bugs.kde.org/show_bug.cgi?id=295199


Diffs (updated)
-

  src/CMakeLists.txt 6e590e8 
  src/core-impl/collections/support/CollectionManager.cpp 37fe03a 
  src/core-impl/meta/proxy/MetaProxy.h d8329be 
  src/core-impl/meta/proxy/MetaProxy.cpp d1577a2 
  src/core-impl/meta/proxy/MetaProxyWorker.h PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxyWorker.cpp PRE-CREATION 
  src/core-impl/meta/proxy/MetaProxy_p.h 792675d 
  src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 
  src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 67ed68e 
  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 4cb49fb 
  src/core/collections/support/TrackForUrlWorker.h 64d23bd 
  src/core/collections/support/TrackForUrlWorker.cpp 7e8f289 
  src/playlistmanager/sql/SqlPlaylist.cpp 39ad759 
  src/services/ampache/AmpacheServiceCollection.h a48c8f2 
  src/services/ampache/AmpacheServiceCollection.cpp b684e34 

Diff: http://git.reviewboard.kde.org/r/104256/diff/


Testing
---

Loaded XSPF attached to https://bugs.kde.org/show_bug.cgi?id=295199 

Could impact AmpacheService. Not checked yet.


Thanks,

Bart Cerneels

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC: Extending "Remove duplicates" in Amarok

2012-03-20 Thread Bart Cerneels 
On Mon, Mar 19, 2012 at 20:27, sunil kumar  wrote:
> Hello,
>
> Amarok have an option in "Playlist->Remove duplicates" to remove songs which
> are binary identical. I would like to extend this feature so that it not
> only remove binary identical songs but also uses fuzzy comparison to find
> identical songs having different tags or formats, as my GSoC 2012 project.
> This tool would present user with a choice to remove those songs which are
> similar but have different format/tags/encoding or have slight variation in
> time. It would also show that by how much amount two songs are similar. This
> tool can help us when we have collected our songs from different people.
>
> --

My first thought is that this would not qualify as a GSoC project
because of it's workload. Remember that GSoC is 15 weeks full time,
even a bit longer. As a season of KDE task it's possible, along with
some more cleanup.
If you want to implement this for yourself and send us a patch on
reviewboard.kde.org, we will certainly take note of that if you apply
for another GSoC or Season of KDE project.

If you want help with this feature, ask on #amarok @freenode.irc.org

Bart
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add composer button to wikipedia applet

2012-03-20 Thread Ryan McCoskrie 


> On March 18, 2012, 10:22 a.m., Matěj Laitl wrote:
> > src/context/engines/wikipedia/WikipediaEngine.cpp, line 462
> > 
> >
> > Hmm, why don't we use i18nc() for creating the pattern here? Something 
> > with a very descriptive context string should do. This applies to all cases 
> > in the swich, not just this patch.

The strings here are for fetching data from Wikipedia rather than displaying to 
the user. It seems best to me that such data should be hard coded. That said, I 
am new to writing translatable software so I'll do some research on how these 
functions work and take any subsequent advice.


- Ryan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104327/#review11530
---


On March 18, 2012, 6:27 a.m., Ryan McCoskrie wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104327/
> ---
> 
> (Updated March 18, 2012, 6:27 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Adds a new composer button for the Wikipedia applet.
> 
> Currently only works in English.
> 
> 
> This addresses bug 272982.
> https://bugs.kde.org/show_bug.cgi?id=272982
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet_p.h b0d6116 
>   src/context/engines/wikipedia/WikipediaEngine.cpp a4ee870 
>   src/context/applets/wikipedia/WikipediaApplet.h 897a32c 
>   src/context/applets/wikipedia/WikipediaApplet.cpp e326804 
> 
> Diff: http://git.reviewboard.kde.org/r/104327/diff/
> 
> 
> Testing
> ---
> 
> Compiled Amarok, changed a file to have a different musician name to the 
> composer name and pressed button. Everything works as expected.
> This patch is simply a case of copying, pasting, substituteing artist with 
> composer so new bugs are extremely unlikely.
> 
> 
> Thanks,
> 
> Ryan McCoskrie
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add composer button to wikipedia applet

2012-03-20 Thread Ryan McCoskrie 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104327/
---

(Updated March 19, 2012, 8:55 p.m.)


Review request for Amarok.


Changes
---

Clarified no tag error messages.


Description
---

Adds a new composer button for the Wikipedia applet.

Currently only works in English.


This addresses bug 272982.
https://bugs.kde.org/show_bug.cgi?id=272982


Diffs (updated)
-

  src/context/applets/wikipedia/WikipediaApplet.h 897a32c 
  src/context/applets/wikipedia/WikipediaApplet.cpp e326804 
  src/context/applets/wikipedia/WikipediaApplet_p.h b0d6116 
  src/context/engines/wikipedia/WikipediaEngine.cpp a4ee870 

Diff: http://git.reviewboard.kde.org/r/104327/diff/


Testing
---

Compiled Amarok, changed a file to have a different musician name to the 
composer name and pressed button. Everything works as expected.
This patch is simply a case of copying, pasting, substituteing artist with 
composer so new bugs are extremely unlikely.


Thanks,

Ryan McCoskrie

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/
---

(Updated March 19, 2012, 7:40 p.m.)


Review request for Amarok, Stefan Derkits and Bart Cerneels.


Summary (updated)
-

GPodder Improvements Patch Rev1


Description (updated)
---

GPodder Service improvements Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.


Diffs (updated)
-

  ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 
0a450ae2420de11ab221cf2dec9fc942a7118dd1 
  src/browsers/playlistbrowser/PodcastModel.h 
e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
  src/browsers/playlistbrowser/PodcastModel.cpp 
18334f6eb970eed241f172cc71396cca8bcaf04b 
  src/core-impl/podcasts/sql/SqlPodcastProvider.h 
c3d5e56e79c86e2be8c39f47df928bfeb291a920 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
183005f652989167952b0c8cf16e742de2fb94e1 
  src/services/gpodder/GpodderPodcastRequestHandler.h 
8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
  src/services/gpodder/GpodderPodcastRequestHandler.cpp 
66e8ea8a3aeec054c82a180f84d199aba5547f5a 
  src/services/gpodder/GpodderProvider.h 
4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
  src/services/gpodder/GpodderProvider.cpp 
6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
  src/services/gpodder/GpodderService.cpp 
b518de33e01d20c7293c50e9edbb2dff78419e53 
  src/services/gpodder/GpodderServiceConfig.h 
111455aeeb2a579caf1dd938249b8d832a775a89 
  src/services/gpodder/GpodderServiceConfig.cpp 
750272e4f2c6c7ad411e9d12c622e97789a29bcd 
  src/services/gpodder/GpodderServiceSettings.h 
81bc218428d2b8bc78235852548a337579b35b24 
  src/services/gpodder/GpodderServiceSettings.cpp 
8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
  src/services/gpodder/GpodderSortFilterProxyModel.h 
638fe992cba553cc317febdf049b6b0f301018b5 
  src/services/gpodder/GpodderSortFilterProxyModel.cpp 
ed1e8301f6f415e86e5367b7827817fff45feb98 

Diff: http://git.reviewboard.kde.org/r/104335/diff/


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/
---

(Updated March 19, 2012, 8 p.m.)


Review request for Amarok, Stefan Derkits and Bart Cerneels.


Changes
---

There were a bug in revision 2. Use revision 3.


Description (updated)
---

GPodder Improvements Patch Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.


Diffs (updated)
-

  ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 
0a450ae2420de11ab221cf2dec9fc942a7118dd1 
  src/browsers/playlistbrowser/PodcastModel.h 
e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
  src/browsers/playlistbrowser/PodcastModel.cpp 
18334f6eb970eed241f172cc71396cca8bcaf04b 
  src/core-impl/podcasts/sql/SqlPodcastProvider.h 
c3d5e56e79c86e2be8c39f47df928bfeb291a920 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
183005f652989167952b0c8cf16e742de2fb94e1 
  src/services/gpodder/GpodderPodcastRequestHandler.h 
8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
  src/services/gpodder/GpodderPodcastRequestHandler.cpp 
66e8ea8a3aeec054c82a180f84d199aba5547f5a 
  src/services/gpodder/GpodderProvider.h 
4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
  src/services/gpodder/GpodderProvider.cpp 
6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
  src/services/gpodder/GpodderService.cpp 
b518de33e01d20c7293c50e9edbb2dff78419e53 
  src/services/gpodder/GpodderServiceConfig.h 
111455aeeb2a579caf1dd938249b8d832a775a89 
  src/services/gpodder/GpodderServiceConfig.cpp 
750272e4f2c6c7ad411e9d12c622e97789a29bcd 
  src/services/gpodder/GpodderServiceSettings.h 
81bc218428d2b8bc78235852548a337579b35b24 
  src/services/gpodder/GpodderServiceSettings.cpp 
8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
  src/services/gpodder/GpodderSortFilterProxyModel.h 
638fe992cba553cc317febdf049b6b0f301018b5 
  src/services/gpodder/GpodderSortFilterProxyModel.cpp 
ed1e8301f6f415e86e5367b7827817fff45feb98 

Diff: http://git.reviewboard.kde.org/r/104335/diff/


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

GSoC: Extending "Remove duplicates" in Amarok

2012-03-20 Thread sunil kumar 
Hello,

Amarok have an option in "Playlist->Remove duplicates" to remove songs
which are binary identical. I would like to extend this feature so that it
not only remove binary identical songs but also uses fuzzy comparison to
find identical songs having different tags or formats, as my GSoC 2012
project. This tool would present user with a choice to remove those songs
which are similar but have different format/tags/encoding or have slight
variation in time. It would also show that by how much amount two songs are
similar. This tool can help us when we have collected our songs from
different people.

-- 
Sunil Kumar
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Bart Cerneels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/#review11646
---


Still can't test because of 503 error on gpodder.net/api.
Code is good.


src/services/gpodder/GpodderProvider.cpp


Note to self: use Solid::Networking::status() to prevent offline running of 
that 10 second loop.


- Bart Cerneels


On March 19, 2012, 8 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104335/
> ---
> 
> (Updated March 19, 2012, 8 p.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> ---
> 
> GPodder Improvements Patch Rev1
> 
> Put messages to show that gpodder service failed to get data from
> gpodder.net. Done some cleanup and added some comments.
> 
> GPodder Service improvements
> 
> Full status synchronisation implemented. Cleanup and some refactoring.
> GPodder Provider saves podcast subscriptions changes if the user closes
> amarok before a expected synchronisation to end, so as to synchronize them
> in the next start. Forcing GPodderService to verify if the username and
> password is not empty before creating a mygpo::ApiRequest. Solved some
> problems related to the KWallet use in GPodderService.
> 
> 
> Diffs
> -
> 
>   ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 
> 0a450ae2420de11ab221cf2dec9fc942a7118dd1 
>   src/browsers/playlistbrowser/PodcastModel.h 
> e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
>   src/browsers/playlistbrowser/PodcastModel.cpp 
> 18334f6eb970eed241f172cc71396cca8bcaf04b 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.h 
> c3d5e56e79c86e2be8c39f47df928bfeb291a920 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
> 183005f652989167952b0c8cf16e742de2fb94e1 
>   src/services/gpodder/GpodderPodcastRequestHandler.h 
> 8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
>   src/services/gpodder/GpodderPodcastRequestHandler.cpp 
> 66e8ea8a3aeec054c82a180f84d199aba5547f5a 
>   src/services/gpodder/GpodderProvider.h 
> 4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
>   src/services/gpodder/GpodderProvider.cpp 
> 6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
>   src/services/gpodder/GpodderService.cpp 
> b518de33e01d20c7293c50e9edbb2dff78419e53 
>   src/services/gpodder/GpodderServiceConfig.h 
> 111455aeeb2a579caf1dd938249b8d832a775a89 
>   src/services/gpodder/GpodderServiceConfig.cpp 
> 750272e4f2c6c7ad411e9d12c622e97789a29bcd 
>   src/services/gpodder/GpodderServiceSettings.h 
> 81bc218428d2b8bc78235852548a337579b35b24 
>   src/services/gpodder/GpodderServiceSettings.cpp 
> 8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
>   src/services/gpodder/GpodderSortFilterProxyModel.h 
> 638fe992cba553cc317febdf049b6b0f301018b5 
>   src/services/gpodder/GpodderSortFilterProxyModel.cpp 
> ed1e8301f6f415e86e5367b7827817fff45feb98 
> 
> Diff: http://git.reviewboard.kde.org/r/104335/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel