Re: Participating in the GSoC

2012-04-02 Thread Xavier Claude 
2012/3/31 Teo Mrnjavac :
> On Thu, Mar 29, 2012 at 22:16, Xavier Claude  wrote:
>>        Hello,
>>
>>    I'm interesting in joining the Google summer of code. I hope it's not too
>> late. I'm using KDE for more than 5 years and I'm a member of the French
>> translation team, that's why I choose KDE as the GSoc organization. I'm a
>> student in computer science in Belgium, I'm in the third and the final 
>> academic
>> year of my study.
>>
>>    I've read the ideas page and I've found the nepomuk backend for Amarok. As
>> I'm currently doing an internship about semantic data for some countries
>> budget, I already know RDF and Sparql. And I've also written some Qt
>> applications for my course.
>>
>>    Cordially,
>>
>
> Hello,
>
> thanks for contacting us. It is very good that you already have
> experience with RDF and SPARQL. I suggest that you start by building
> Amarok from git and taking a look at the collection code to get an
> idea of the result you'd need to achieve. What we need is a collection
> backend that could replace the current SQL collection (if needed)
> without feature regressions, but you should plan on both backends
> being available rather than one being a drop-in replacement of the
> other. Please see this article [1] for some guidelines on how to
> structure a GSoC proposal for Amarok. When you prepare a first draft,
> please submit it for review on this mailing list.
>
> [1] 
> http://teom.wordpress.com/2012/03/01/how-to-write-a-kick-ass-proposal-for-google-summer-of-code/
>
> Cheers,
> --
> Teo

Thank you for the explanation, the blog post was very useful. Here is
what I've write:

Name: Xavier Claude


Email Address: claude.xav...@gmail.com


Freenode IRC Nick: claudex


IM Service and Username: N/A


Location (City, Country and/or Time Zone): Arlon, Belgium


Proposal Title: Semantic desktop collection in Amarok


Introduction:

Amarok currently uses MySQL (embedded or external) to store the
collection  but this doesn't allow other applications to easily use
Amarok collections.

Motivation for Proposal / Goal:

- A fully functionnal Nepomuk backend to store Amarok collection
- A GUI to choose the backend
- A tool to migrate an existing MySQL collection to the Nepomuk backend.
Implementation Details:

Nepomuk is a tool used by KDE to provide a semantic desktop that all
applications can use. I'll have to define how to store the data
currently stored in the MySQL database. This mean that I'll have to
use the class already defined and used by Nepomuk and other
applications which use Nepomuk such as Dolphin. If the ontology does
not cover all the information in the database, I'll have to extend it.

When the data model will be defined, I'll have to write C++ code and
the SPARQL queries to retrieve the data and insert/modify them when
they are added/changed by another application or by Amarok. When doing
that, I'll reuse as much as possible the existing code used by the
MySQL backend, the UI code should be used with the two backends
without disctinction.

The GUI will consist on two radio buttons in the current database tab
in the Amarok configuration. One will say Nepomuk and the other MySQL,
if the second is chosen, the external MySQL database could be checked.
If Nepomuk is disabled, the Nepomuk button will be inactive and their
will be an explanation why.

The migration tool will be a tool that will read the MySQL database
and write the data in Nepomuk. The GUI will automatically ask if the
user want to use it when he switches from MySQL to Nepomuk and could
be manually triggered if the Nepomuk backend is chosen. It could read
both embedded or external MySQL database.

Tentative Timeline (in weekly intervals until 2 weeks after the end of GSoC):

- List the needed functions and define their specifications (2 weeks,
21st May to 3rd June): lists which functions are used and,
particularly, what are the limits behavior. This will allow me to
understand how the Amarok code is designed and written.
- Define the data model (1 week, 4th June to 10th June): define which
class in the ontology I'll use and understant how to use Nepomuk API.
- Writing the functions (3 weeks, 11th June to 1st July): write the backend.
- Performance tests and improving code if needed (2 weeks, 9th July to
22nd July): find the bottleneck and improve the code, this should
mostly be SPARQL queries improvement.
- Migration tool (2 weeks, 16th July to 29th July)
- GUI (1 week, 30th July to 5th August)
- Advanced tests (1 week, 6th August to 12th August): creating exotic
collection and test the migration tools and the backend.
- Documentation (1 week, 13th August to 19th August): writing
documentation to user on userbase to explain them how to use the
backend and to developers on techbase to explain how the backend work.

Do you have other obligations from late May to early August (school,
work, vacation, etc.)?

I have  final work and internship presentations in mid-June but since
most of the work should be done by

[KDE Bugtracking System] Release blockers

2012-04-02 Thread bugzilla_noreply 
The following bugs are blocking the next Amarok release:

  This search was scheduled by bcooks...@kde.org.




Bug 258741:
  https://bugs.kde.org/show_bug.cgi?id=258741
  Priority: HI  Severity: crash  Platform: Compiled Sources
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: amarok crashes on startup [@ 
Context::ContextView::addCollapseAnimation]
Bug 280774:
  https://bugs.kde.org/show_bug.cgi?id=280774
  Priority: HI  Severity: crash  Platform: openSUSE RPMs
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Amarok is crashed every time it is launched [@ 
Daap::Reader::contentCodesReceived]
Bug 281312:
  https://bugs.kde.org/show_bug.cgi?id=281312
  Priority: HI  Severity: crash  Platform: Compiled Sources
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Deadlock in FAM/KDirWatch usage
Bug 285720:
  https://bugs.kde.org/show_bug.cgi?id=285720
  Priority: NOR  Severity: normal  Platform: Gentoo Packages
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: Amarok crashes on start with following message: ASSERT failure in 
QVector::at: "index out of range"


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

2012-04-02 Thread Lachlan Dufton 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104464/
---

(Updated April 2, 2012, 3:15 p.m.)


Review request for Amarok.


Changes
---

Thanks for the review.  I've made the changes as suggested.


Description
---

Fix for bug #292081

AnimatedBarWidget is modified to wrap text when widget is too narrow.


This addresses bug 292081.
https://bugs.kde.org/show_bug.cgi?id=292081


Diffs (updated)
-

  src/aboutdialog/AnimatedBarWidget.h 8ec32ad 
  src/aboutdialog/AnimatedBarWidget.cpp f40dd6d 

Diff: http://git.reviewboard.kde.org/r/104464/diff/


Testing
---

Tested changed widget correctly wraps text when About dialog is resized.


Thanks,

Lachlan Dufton

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Diagnostics Dialog for Amarok.

2012-04-02 Thread Andrzej Hunt 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104449/
---

(Updated April 2, 2012, 1:37 p.m.)


Review request for Amarok.


Changes
---

Thanks for the comments, here's an updated patch (and screenshot).

I've just applied for git access, so I'll commit once/if it's enabled.

(The reason I used a QWeakPointer was because I had seen the same being done in 
the ExtendedAboutDialog (I now see why that is done there) -- I've changed it 
to a normal pointer.)

(I'll do the changes to ScriptManager/PluginManager as described in 
https://bugs.kde.org/show_bug.cgi?id=296415#c4 as a separate patch when I next 
have time.)


Description
---

Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, 
the Phonon backend, and all scripts and plugins.

As described in https://bugs.kde.org/show_bug.cgi?id=296415.

This patch also changes/corrects PluginManager::plugins() to be const.


This addresses bug 296415.
https://bugs.kde.org/show_bug.cgi?id=296415


Diffs (updated)
-

  src/CMakeLists.txt 6e590e8 
  src/MainWindow.h b149cb9 
  src/MainWindow.cpp 98b1c77 
  src/PluginManager.h 6b9f3ca 
  src/PluginManager.cpp c46b12f 
  src/dialogs/DiagnosticDialog.h PRE-CREATION 
  src/dialogs/DiagnosticDialog.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104449/diff/


Testing
---


Screenshots (updated)
---

Screenshot of Dialog
  http://git.reviewboard.kde.org/r/104449/s/501/
Updated Screenshot (Version 2)
  http://git.reviewboard.kde.org/r/104449/s/502/


Thanks,

Andrzej Hunt

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

2012-04-02 Thread Sam Lade 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104464/#review12113
---


A couple of minor things - first, in the heightForWidth code, it's not at all 
clear what's going on with the padding (you use padding * 4 at first, and later 
just use 8). Clean that up and comment it. Second, the else keyword is 
superfluous.

Otherwise, looks good. I haven't tested myself (I'm away and don't have Amarok 
built), but the code's plausible and you've tested.

- Sam Lade


On April 1, 2012, 11:10 p.m., Lachlan Dufton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104464/
> ---
> 
> (Updated April 1, 2012, 11:10 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Fix for bug #292081
> 
> AnimatedBarWidget is modified to wrap text when widget is too narrow.
> 
> 
> This addresses bug 292081.
> https://bugs.kde.org/show_bug.cgi?id=292081
> 
> 
> Diffs
> -
> 
>   src/aboutdialog/AnimatedBarWidget.h 8ec32ad 
>   src/aboutdialog/AnimatedBarWidget.cpp f40dd6d 
> 
> Diff: http://git.reviewboard.kde.org/r/104464/diff/
> 
> 
> Testing
> ---
> 
> Tested changed widget correctly wraps text when About dialog is resized.
> 
> 
> Thanks,
> 
> Lachlan Dufton
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

2012-04-02 Thread Lachlan Dufton 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104464/
---

Review request for Amarok.


Description
---

Fix for bug #292081

AnimatedBarWidget is modified to wrap text when widget is too narrow.


This addresses bug 292081.
https://bugs.kde.org/show_bug.cgi?id=292081


Diffs
-

  src/aboutdialog/AnimatedBarWidget.h 8ec32ad 
  src/aboutdialog/AnimatedBarWidget.cpp f40dd6d 

Diff: http://git.reviewboard.kde.org/r/104464/diff/


Testing
---

Tested changed widget correctly wraps text when About dialog is resized.


Thanks,

Lachlan Dufton

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Diagnostics Dialog for Amarok.

2012-04-02 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104449/#review12109
---

Ship it!


As Bart said, very good patch, thanks for it! Besides to what Bart already 
pointed out, I've found 2 minor things.


src/MainWindow.h


Nitpicking: perhaps unnecessary newline



src/dialogs/DiagnosticDialog.h


Any special reason why the QWeakPointer is used? If there is none, plain 
pointer should be used instead.


- Matěj Laitl


On March 31, 2012, 6:15 p.m., Andrzej Hunt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104449/
> ---
> 
> (Updated March 31, 2012, 6:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, 
> the Phonon backend, and all scripts and plugins.
> 
> As described in https://bugs.kde.org/show_bug.cgi?id=296415.
> 
> This patch also changes/corrects PluginManager::plugins() to be const.
> 
> 
> This addresses bug 296415.
> https://bugs.kde.org/show_bug.cgi?id=296415
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6e590e8 
>   src/MainWindow.h b149cb9 
>   src/MainWindow.cpp 98b1c77 
>   src/PluginManager.h 6b9f3ca 
>   src/PluginManager.cpp c46b12f 
>   src/dialogs/DiagnosticDialog.h PRE-CREATION 
>   src/dialogs/DiagnosticDialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104449/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Screenshot of Dialog
>   http://git.reviewboard.kde.org/r/104449/s/501/
> 
> 
> Thanks,
> 
> Andrzej Hunt
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Diagnostics Dialog for Amarok.

2012-04-02 Thread Bart Cerneels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104449/#review12106
---

Ship it!


Looks quite perfect style wise (ok, I found one thing to nitpick on ;). Code is 
clean and functional. 

There is one thing I noticed while testing: all are plugins are version 1.0 
(X-KDE-PluginInfo-Version=1.0)
We bump X-KDE-Amarok-framework-version an each release and use that to check if 
a plugin can be used or not. It's currently not relevant to include this anyway 
since we have never committed to ABI stability of our APIs and hence always 
bump the framework version.

If you already have a developer account (identity.kde.org and request write 
access to the git repos via sysadmin request on bugs.kde.org) you can push it 
with the changes I mentioned. If not I can push it for you but urge you to get 
that account for future contributions.


src/dialogs/DiagnosticDialog.cpp


I would put the body on a newline. Just a bit more readable within the rest 
of the amarok codebase.



src/dialogs/DiagnosticDialog.cpp


Either separate them into running/stopped lists or append "(stopped)". The 
rational is that if that line is partially copy/pasted on IRC, we'll know that 
it's incomplete.



src/dialogs/DiagnosticDialog.cpp


Same as for plugins but with enabled/disabled.



src/dialogs/DiagnosticDialog.cpp


We spell Qt with lower case t and make apple QuickTime jokes about those 
who don't ;)



src/dialogs/DiagnosticDialog.cpp


The phonon backend also needs a version. Might help track down bugs to 
specific versions or builds. Hope you can get it easily.


- Bart Cerneels


On March 31, 2012, 6:15 p.m., Andrzej Hunt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104449/
> ---
> 
> (Updated March 31, 2012, 6:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, 
> the Phonon backend, and all scripts and plugins.
> 
> As described in https://bugs.kde.org/show_bug.cgi?id=296415.
> 
> This patch also changes/corrects PluginManager::plugins() to be const.
> 
> 
> This addresses bug 296415.
> https://bugs.kde.org/show_bug.cgi?id=296415
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6e590e8 
>   src/MainWindow.h b149cb9 
>   src/MainWindow.cpp 98b1c77 
>   src/PluginManager.h 6b9f3ca 
>   src/PluginManager.cpp c46b12f 
>   src/dialogs/DiagnosticDialog.h PRE-CREATION 
>   src/dialogs/DiagnosticDialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104449/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> Screenshot of Dialog
>   http://git.reviewboard.kde.org/r/104449/s/501/
> 
> 
> Thanks,
> 
> Andrzej Hunt
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel