Re: Review Request 113777: Lazy load scriptable service tracks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113777/#review43325 --- Looks good to me, but please test that scriptable service tracks that are (remote) playlists do play right away when you double-click on them. (with play on double-click enabled) src/services/scriptable/ScriptableServiceMeta.h http://git.reviewboard.kde.org/r/113777/#comment31198 Please initialize (to false, probably) this basic type in constructor as it is random otherwise. - Matěj Laitl On Nov. 9, 2013, 10:21 p.m., Anmol Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113777/ --- (Updated Nov. 9, 2013, 10:21 p.m.) Review request for Amarok. Repository: amarok Description --- Prevent all the scriptable services from loading playlists at Amarok launch. Diffs - src/services/scriptable/ScriptableServiceMeta.h 2db3951 src/services/scriptable/ScriptableServiceMeta.cpp 8e96785 Diff: http://git.reviewboard.kde.org/r/113777/diff/ Testing --- Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Change in stream URL, then crash
Hi Valorie, On Mon, Nov 11, 2013 at 7:18 AM, Valorie Zimmerman valorie.zimmer...@gmail.com wrote: This station used to work; that said I haven't used amarok to listen to it for awhile, since my phone has a built-in FM tuner and I've been using that instead. But I wanted to set it up again in Amarok. King FM in Seattle gives me this as the stream URL: http://filesource.abacast.com/king/mp3.m3u By the way, this URL brings up VLC through the browser, where it plays fine. I use the Playlist Add Media dialog, and paste the URL in. Amarok changes it to http://sc1.abacast.com:8246 (displayed in the playlist) and doesn't play it. If I double-click, Amarok crashes. Not sure if this is a bug, and if so exactly what I should file against it. Here is the end of the output from -d --nofork: Is it reproducible? The run it in gdb, get a backtrace and make a bug report. Regards, Myriam -- Proud member of the Amarok and KDE Community Protect your freedom and join the Fellowship of FSFE: http://www.fsfe.org Please don't send me proprietary file formats, use ISO standard ODF instead (ISO/IEC 26300) ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
