Re: Review Request 112417: FIX: 283022 - Performance with large feed (6000 items) very poor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112417/#review58228 --- This review has been submitted with commit 22486a5d6bd7a6c9f1b88008b81a47bef2f8d6fe by Vedant Agarwala on behalf of Frank Meerkötter to branch tagguessing. - Commit Hook On Sept. 8, 2013, 6:29 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112417/ > --- > > (Updated Sept. 8, 2013, 6:29 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Using callgrind it was very visible that amarok is spending an enormous > amount of time to turn podcast episodes into tracks. > > Initially i noticed that the PlaylistBrowserModel is calling > Playlist::tracks().count() while it should be calling Playlist::trackCount(). > Constructing a list of tracks is expensive for the case of Podcasts (as > internally podcast episodes are converted into tracks which > get added to a new list). This change already improved the situation a bit, > but the UI was still sluggish. Callgrind was still showing > that we are turning episodes into tracks - over and over. > > To fix that i added a cache to the PodcastChannel. As long as the episodes > haven't changed, there is no point in constructing > a new list of tracks each time tracks() is called. > > With that second fix the UI is now pretty useable. > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 281694a > src/core-impl/podcasts/sql/SqlPodcastMeta.h 02a18d3 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 20bcaff > > Diff: https://git.reviewboard.kde.org/r/112417/diff/ > > > Testing > --- > > Tested with http://www.justing.com.cn/justpod/justpod_ch.xml > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112266/#review58227 --- This review has been submitted with commit 4bec1504d99a24db4288585ac7b6cc8d4cf416f2 by Vedant Agarwala on behalf of Bruno Léon to branch tagguessing. - Commit Hook On Aug. 30, 2013, 4:38 p.m., Bruno Léon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112266/ > --- > > (Updated Aug. 30, 2013, 4:38 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Fix reading of Album Artist and Compilation tag in APE tags. > Add support for reading Disc Number in APE tags. > > > Diffs > - > > shared/tag_helpers/APETagHelper.cpp c628694 > > Diff: https://git.reviewboard.kde.org/r/112266/diff/ > > > Testing > --- > > Tested with Musepack files (that do use APE tags) > > > File Attachments > > > Taglib output > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output > > > Thanks, > > Bruno Léon > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112706: Allow to use Wikipedia over SSL
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112706/#review58229 --- This review has been submitted with commit b773bc838147a45c8c9a8e4c9a3ba8cf2338abab by Vedant Agarwala on behalf of Frank Meerkötter to branch tagguessing. - Commit Hook On Sept. 13, 2013, 8:38 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112706/ > --- > > (Updated Sept. 13, 2013, 8:38 p.m.) > > > Review request for Amarok. > > > Bugs: 322249 > https://bugs.kde.org/show_bug.cgi?id=322249 > > > Repository: amarok > > > Description > --- > > Allow to use wikipedia over SSL. Make encrypted connections the default. Add > an option to fall back to plain HTTP. > > > Diffs > - > > src/context/applets/wikipedia/WikipediaApplet.cpp 507db96 > src/context/applets/wikipedia/WikipediaApplet_p.h c52a0bf > src/context/applets/wikipedia/wikipediaGeneralSettings.ui a615dee > src/context/engines/wikipedia/WikipediaEngine.cpp f22e443 > > Diff: https://git.reviewboard.kde.org/r/112706/diff/ > > > Testing > --- > > Switched several times between HTTP and HTTPS. Switched between the normal > and the mobile version. > Checked the traffic with wireshark. Verified that this setting is actually > persisted. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112263: EBN: Check for foreach loop issues.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112263/#review58226 --- This review has been submitted with commit 5491d4ba8bdf8bcfba2a1f46cf2417c1b45f5914 by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing. - Commit Hook On Aug. 26, 2013, 10:11 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112263/ > --- > > (Updated Aug. 26, 2013, 10:11 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > More janitor work. > > EBN: Check for foreach loop issues. > > Fixing a number of issues from > http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html > [...] > 13. Check for foreach loop issues [foreach]... > [...] > > Calling values() isn't necessary here. foreach will iterate over the values > by default. > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 4d2352d > src/context/applets/upcomingevents/UpcomingEventsStack.cpp dd9e149 > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp f19ff4d > src/core-impl/collections/support/MemoryMatcher.cpp 6e94647 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 793358b > > Diff: https://git.reviewboard.kde.org/r/112263/diff/ > > > Testing > --- > > Unit tests still pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112221/#review58224 --- This review has been submitted with commit dee7c2465cb744a13ff6cf183ce71510f66bff5b by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing. - Commit Hook On Aug. 25, 2013, 8:45 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112221/ > --- > > (Updated Aug. 25, 2013, 8:45 a.m.) > > > Review request for Amarok. > > > Bugs: 313504 > https://bugs.kde.org/show_bug.cgi?id=313504 > > > Repository: amarok > > > Description > --- > > Fix the few remaining cases i missed on the first run. See: > https://git.reviewboard.kde.org/r/112148/ > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 > src/dialogs/DiagnosticDialog.cpp a5f2e17 > tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 > > Diff: https://git.reviewboard.kde.org/r/112221/diff/ > > > Testing > --- > > unit tests pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112199: 313504: Check for foreach loop issues
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112199/#review58225 --- This review has been submitted with commit 4e254c6107166ddf0838990e908dc885dad8f1ba by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing. - Commit Hook On Aug. 25, 2013, 8:40 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112199/ > --- > > (Updated Aug. 25, 2013, 8:40 a.m.) > > > Review request for Amarok. > > > Bugs: 313504 > https://bugs.kde.org/show_bug.cgi?id=313504 > > > Repository: amarok > > > Description > --- > > Fixing a number of issues from > http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html > [...] > 13. Check for foreach loop issues [foreach]... > [...] > > Prefer a const reference over a copy. This patch is only a first batch - > fixing the simple cases. > > > Diffs > - > > shared/TagsFromFileNameGuesser.cpp 0ae8dbd > src/EngineController.cpp 99adb53 > src/OpmlParser.cpp e47e103 > src/configdialog/dialogs/MetadataConfig.cpp 5701d77 > src/context/applets/labels/LabelsApplet.cpp f5bc55d > src/core-impl/collections/daap/DaapCollection.cpp 20e7b4f > src/core-impl/collections/daap/daapreader/Reader.cpp a80922c > src/core-impl/collections/db/MountPointManager.cpp dc74896 > src/core-impl/collections/db/sql/SqlCollectionLocation.cpp c11a6bd > src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp 7ecdcfa > src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp ff9e4ad > src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp > b699b6e > src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp > 2926e77 > src/core-impl/collections/playdarcollection/support/Query.cpp 29619a9 > src/core-impl/collections/support/CollectionManager.cpp db5c984 > src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp > 7579ba2 > src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp 6467964 > src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 80ea8de > src/core-impl/collections/upnpcollection/UpnpQuery.cpp e945bfd > src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 67e153f > src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp c77f920 > src/core-impl/meta/cue/CueFileSupport.cpp 77d27e6 > src/core/transcoding/TranscodingConfiguration.cpp dbcd0b3 > src/core/transcoding/formats/TranscodingAacFormat.cpp 2b0a02c > src/core/transcoding/formats/TranscodingFlacFormat.cpp fd8a832 > src/core/transcoding/formats/TranscodingMp3Format.cpp 83d0e2f > src/core/transcoding/formats/TranscodingOpusFormat.cpp 3ee991b > src/core/transcoding/formats/TranscodingVorbisFormat.cpp 8c32d69 > src/core/transcoding/formats/TranscodingWmaFormat.cpp d7646d2 > src/covermanager/CoverCache.cpp 14a4646 > src/databaseimporter/amarok14/FastForwardWorker.cpp 113141d > src/dialogs/CollectionSetup.cpp 0672421 > src/dialogs/OrganizeCollectionDialog.cpp a29e626 > src/dialogs/TagDialog.cpp 3c07fd1 > src/network/NetworkAccessViewer.cpp f5a91dd > src/playlist/layouts/PlaylistLayoutEditDialog.cpp 4211010 > src/playlistmanager/file/KConfigSyncRelStore.cpp b8dd4c4 > src/services/lastfm/ScrobblerAdapter.cpp 3c81546 > src/services/lastfm/SynchronizationAdapter.cpp ae4b820 > src/services/opmldirectory/OpmlDirectoryView.cpp feba375 > src/statsyncing/Config.cpp 40dc79d > src/transcoding/TranscodingOptionsStackedWidget.cpp 26128d5 > src/widgets/FilenameLayoutWidget.cpp aee4175 > utilities/collectionscanner/CollectionScanner.cpp dd4ae37 > > Diff: https://git.reviewboard.kde.org/r/112199/diff/ > > > Testing > --- > > All unit tests pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112255: UMS: Fix set album cover
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112255/#review58223 --- This review has been submitted with commit 319e08834cff69e9d83e1d8f9967d7f0950bf73d by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing. - Commit Hook On Aug. 25, 2013, 8:39 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112255/ > --- > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > When Setting->Config->Metadata->Write covers to file is enabled, it should be > possible to write covers for albums located on an UMS collection. The current > status is that amarok does the write but never updates itself to reflect the > new cover. There is code to achive this but is has been broken at some point. > > /home/frank/kde/src/amarok/src/core-impl/meta/file/File_p.h:358 tries to > create a signal/slot connection (to re-read the tags after the write is done) > to an invalid slot. This is fixed by my patch. > > > Diffs > - > > src/core-impl/meta/file/File.cpp f2abea4 > src/core-impl/meta/file/File_p.h 40f631c > > Diff: https://git.reviewboard.kde.org/r/112255/diff/ > > > Testing > --- > > Writing album covers for files located on an USB stick. > The album is updated now (collection browser, playlist). The current track > applet isn't updating but i guess this is a different problem. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 117580: Patch for "AFT tagger always recalculating a new tag in m4a/mp4 files"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117580/#review57613 --- This review has been submitted with commit dca658b98adaa843699dfbcc267dac0c2f00b350 by Daniel Meltzer to branch master. - Commit Hook On April 16, 2014, 9:09 a.m., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117580/ > --- > > (Updated April 16, 2014, 9:09 a.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 332811 > https://bugs.kde.org/show_bug.cgi?id=332811 > > > Repository: amarok > > > Description > --- > > Short bug description: > Basically for m4a/mp4 files the tag is inserted but it's not recognized if > the tool runs again. So the file is modified and a possibly-new tag is > rewritten. > > Please see bug tracking for more information. > > > Diffs > - > > utilities/afttagger/AFTTagger.cpp 5a60c6b > > Diff: https://git.reviewboard.kde.org/r/117580/diff/ > > > Testing > --- > > Tested myself on the same installation on which I could reproduce the bug. > > Thank you, > Stefano > > INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/12 - Reaktor > (Original mix).m4a > INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/12 - > Reaktor (Original mix).m4a.amarok-afttaggertemp.pid-20234.random-xrczmmvk.m4a > INFO: File is a MP4 file, opening... > INFO: Found an existing AFT identifier: :com.apple.iTunes:Amarok 2 AFTv1 > - amarok.kde.org > INFO: AFT identifier is version 1 > INFO: ID is current > INFO: Cleaning up... > INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/13 - Without > You (Zprochek mix).m4a > INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/13 - > Without You (Zprochek > mix).m4a.amarok-afttaggertemp.pid-20234.random-fbNJp3UM.m4a > INFO: File is a MP4 file, opening... > INFO: Found an existing AFT identifier: :com.apple.iTunes:Amarok 2 AFTv1 > - amarok.kde.org > INFO: AFT identifier is version 1 > INFO: ID is current > INFO: Cleaning up... > INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/14 - Without > You (Spektron mix).m4a > INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/14 - > Without You (Spektron > mix).m4a.amarok-afttaggertemp.pid-20234.random-OLe7wC54.m4a > INFO: File is a MP4 file, opening... > INFO: Found an existing AFT identifier: :com.apple.iTunes:Amarok 2 AFTv1 > - amarok.kde.org > INFO: AFT identifier is version 1 > INFO: ID is current > INFO: Cleaning up... > INFO: All done, exiting... > > > Thanks, > > Stefano Pettini > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 118005: Amarok use wrong url to query ampache
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118005/#review57606 --- This review has been submitted with commit f47edef016b7011f8d0699a2a5f32ea80fdbe3fe by Daniel Meltzer to branch master. - Commit Hook On May 5, 2014, 6:29 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118005/ > --- > > (Updated May 5, 2014, 6:29 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > in AmpacheServiceQueryMaker.cpp, it append server/xml.server.php twice to the > request url, which is obviously wrong. I can confirm this behaviour from > server side log. Simply remove one of them will fix it. > > > Diffs > - > > src/services/ampache/AmpacheServiceQueryMaker.cpp b94c3b0 > > Diff: https://git.reviewboard.kde.org/r/118005/diff/ > > > Testing > --- > > amarok now work with ampache again. > > > Thanks, > > Xuetian Weng > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 116741: Fixed Bug 331934 (JJ- Jamendo API change causes the service not to work anymore) and corrects update button behaviour
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116741/#review57538 --- This review has been submitted with commit 01b3ab9fd70b158bfc6f4529ce22a671c5d2820c by Daniel Meltzer to branch master. - Commit Hook On March 11, 2014, 8:45 p.m., yash ladia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116741/ > --- > > (Updated March 11, 2014, 8:45 p.m.) > > > Review request for Amarok. > > > Bugs: 331934 > https://bugs.kde.org/show_bug.cgi?id=331934 > > > Repository: amarok > > > Description > --- > > I have corrected the URL to the new one. > Also, when there was an error in downloading the relatively large (17.3 mb) > file, it just used to quit silently. With my patch it still does, but the > "update" button becomes enabled so that the download can be attempted again > without restarting Amarok. I had to make sure that the 'm_listDownloadJob = > 0;' (line 205) was called so I placed it before the return statement. > Otherwise, it was giving a segfault error when Amarok was being quit. > > > Diffs > - > > src/services/jamendo/JamendoService.cpp e4a7ecc > src/services/jamendo/JamendoXmlParser.h 6bdc67d > > Diff: https://git.reviewboard.kde.org/r/116741/diff/ > > > Testing > --- > > Jamendo works now. File downloads as expected. > Also, I testing the working of the new update button behavior by running the > update without any internet connection. The "update" button became enabled in > this case. > > > Thanks, > > yash ladia > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 115122: BugFix :299883 - Progress Slider shows wrong position when it is restored from system tray.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115122/#review57539 --- This review has been submitted with commit 84c15fdb0c3e7b854a7c7cdef417a54f5d3376ce by Daniel Meltzer to branch master. - Commit Hook On Jan. 19, 2014, 1:07 p.m., Abhay Sombanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115122/ > --- > > (Updated Jan. 19, 2014, 1:07 p.m.) > > > Review request for Amarok. > > > Bugs: 299883 > https://bugs.kde.org/show_bug.cgi?id=299883 > > > Repository: amarok > > > Description > --- > > Now , toolbar shows correct progress slider position and timelabel values > after restoring amarok from system tray. > > > Diffs > - > > ChangeLog 0eb03c8 > src/toolbar/MainToolbar.cpp 47f8ae5 > src/widgets/ProgressWidget.cpp 5b6702b > > Diff: https://git.reviewboard.kde.org/r/115122/diff/ > > > Testing > --- > > * works as expected. > > > Thanks, > > Abhay Sombanshi > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review57426 --- This review has been submitted with commit 01d512aa1168c8dffdf8942026563be164053116 by Yuri Chornoivan on behalf of Abhay Sombanshi to branch master. - Commit Hook On Jan. 5, 2014, 2:17 p.m., Abhay Sombanshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114752/ > --- > > (Updated Jan. 5, 2014, 2:17 p.m.) > > > Review request for Amarok and Yuri Chornoivan. > > > Bugs: 291400 > https://bugs.kde.org/show_bug.cgi?id=291400 > > > Repository: amarok > > > Description > --- > > CollectionBrowser filter dialog will now allow a length of 24 hours. > > > Diffs > - > > ChangeLog 0eb03c8 > src/widgets/MetaQueryWidget.cpp 58601cc > > Diff: https://git.reviewboard.kde.org/r/114752/diff/ > > > Testing > --- > > works as expected. > > > Thanks, > > Abhay Sombanshi > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 113275: GSoC 2013 - Advanced Importers - 2/4: Importers framework and concrete importers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113275/#review49379 --- This review has been submitted with commit d77864e758a2162d88aafd432a7eb1e813907f8f by Konrad Zemek to branch master. - Commit Hook On Nov. 6, 2013, 7:26 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113275/ > --- > > (Updated Nov. 6, 2013, 7:26 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > These are the most important changes of my project - implementing the > framework > for importers and creating concrete importers for Amarok 1.4, Amarok 2.x, > Banshee, Clementine, iTunes and Rhythmbox. > > > Diffs > - > > src/importers/CMakeLists.txt PRE-CREATION > src/importers/ImporterManager.h PRE-CREATION > src/importers/ImporterManager.cpp PRE-CREATION > src/importers/ImporterProvider.h PRE-CREATION > src/importers/ImporterProvider.cpp PRE-CREATION > src/importers/ImporterSqlConnection.h PRE-CREATION > src/importers/ImporterSqlConnection.cpp PRE-CREATION > src/importers/SimpleImporterConfigWidget.h PRE-CREATION > src/importers/SimpleImporterConfigWidget.cpp PRE-CREATION > src/importers/SimpleImporterManager.h PRE-CREATION > src/importers/amarok/AmarokConfigWidget.h PRE-CREATION > src/importers/amarok/AmarokConfigWidget.cpp PRE-CREATION > src/importers/amarok/AmarokConfigWidget.ui PRE-CREATION > src/importers/amarok/AmarokEmbeddedSqlConnection.h PRE-CREATION > src/importers/amarok/AmarokEmbeddedSqlConnection.cpp PRE-CREATION > src/importers/amarok/AmarokManager.h PRE-CREATION > src/importers/amarok/AmarokManager.cpp PRE-CREATION > src/importers/amarok/AmarokProvider.h PRE-CREATION > src/importers/amarok/AmarokProvider.cpp PRE-CREATION > src/importers/amarok/AmarokTrack.h PRE-CREATION > src/importers/amarok/AmarokTrack.cpp PRE-CREATION > src/importers/amarok/CMakeLists.txt PRE-CREATION > src/importers/amarok/amarok_importer-amarok.desktop PRE-CREATION > src/importers/banshee/BansheeConfigWidget.h PRE-CREATION > src/importers/banshee/BansheeConfigWidget.cpp PRE-CREATION > src/importers/banshee/BansheeManager.cpp PRE-CREATION > src/importers/banshee/BansheeProvider.h PRE-CREATION > src/importers/banshee/BansheeProvider.cpp PRE-CREATION > src/importers/banshee/BansheeTrack.h PRE-CREATION > src/importers/banshee/BansheeTrack.cpp PRE-CREATION > src/importers/banshee/CMakeLists.txt PRE-CREATION > src/importers/banshee/amarok_importer-banshee.desktop PRE-CREATION > src/importers/clementine/CMakeLists.txt PRE-CREATION > src/importers/clementine/ClementineConfigWidget.h PRE-CREATION > src/importers/clementine/ClementineConfigWidget.cpp PRE-CREATION > src/importers/clementine/ClementineManager.cpp PRE-CREATION > src/importers/clementine/ClementineProvider.h PRE-CREATION > src/importers/clementine/ClementineProvider.cpp PRE-CREATION > src/importers/clementine/ClementineTrack.h PRE-CREATION > src/importers/clementine/ClementineTrack.cpp PRE-CREATION > src/importers/clementine/amarok_importer-clementine.desktop PRE-CREATION > src/importers/fastforward/CMakeLists.txt PRE-CREATION > src/importers/fastforward/FastForwardConfigWidget.h PRE-CREATION > src/importers/fastforward/FastForwardConfigWidget.cpp PRE-CREATION > src/importers/fastforward/FastForwardConfigWidget.ui PRE-CREATION > src/importers/fastforward/FastForwardManager.cpp PRE-CREATION > src/importers/fastforward/FastForwardProvider.h PRE-CREATION > src/importers/fastforward/FastForwardProvider.cpp PRE-CREATION > src/importers/fastforward/FastForwardTrack.h PRE-CREATION > src/importers/fastforward/FastForwardTrack.cpp PRE-CREATION > src/importers/fastforward/amarok_importer-fastforward.desktop PRE-CREATION > src/importers/itunes/CMakeLists.txt PRE-CREATION > src/importers/itunes/ITunesConfigWidget.h PRE-CREATION > src/importers/itunes/ITunesConfigWidget.cpp PRE-CREATION > src/importers/itunes/ITunesManager.cpp PRE-CREATION > src/importers/itunes/ITunesProvider.h PRE-CREATION > src/importers/itunes/ITunesProvider.cpp PRE-CREATION > src/importers/itunes/ITunesTrack.h PRE-CREATION > src/importers/itunes/ITunesTrack.cpp PRE-CREATION > src/importers/itunes/amarok_importer-itunes.desktop PRE-CREATION > src/importers/rhythmbox/CMakeLists.tx
Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113277/#review49380 --- This review has been submitted with commit d77864e758a2162d88aafd432a7eb1e813907f8f by Konrad Zemek to branch master. - Commit Hook On Dec. 10, 2013, 9:14 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113277/ > --- > > (Updated Dec. 10, 2013, 9:14 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > This review contains importers tests. > > The tests/importers/TestImporterBase.cpp contains common tests for concrete > importers. The tests load a prepared database and read it through the > importer. > It's therefore important that the prepared database contain certain data. > The tests/importers/files/testCollection directory contains very small mp3 > files that are *not* used as a part of the tests, and instead are meant for > creating the test database: one would just import these files into a media > player, copy the media player's database and have it instantly ready for > the common tests. > > > Diffs > - > > tests/CMakeLists.txt e18aaa1 > tests/CollectionTestImpl.h 183c3c2 > tests/importers/CMakeLists.txt PRE-CREATION > tests/importers/ImporterMocks.h PRE-CREATION > tests/importers/ImporterMocks.cpp PRE-CREATION > tests/importers/TestAmarokImporter.h PRE-CREATION > tests/importers/TestAmarokImporter.cpp PRE-CREATION > tests/importers/TestBansheeImporter.h PRE-CREATION > tests/importers/TestBansheeImporter.cpp PRE-CREATION > tests/importers/TestClementineImporter.h PRE-CREATION > tests/importers/TestClementineImporter.cpp PRE-CREATION > tests/importers/TestFastForwardImporter.h PRE-CREATION > tests/importers/TestFastForwardImporter.cpp PRE-CREATION > tests/importers/TestITunesImporter.h PRE-CREATION > tests/importers/TestITunesImporter.cpp PRE-CREATION > tests/importers/TestImporterBase.h PRE-CREATION > tests/importers/TestImporterBase.cpp PRE-CREATION > tests/importers/TestImporterManager.h PRE-CREATION > tests/importers/TestImporterManager.cpp PRE-CREATION > tests/importers/TestImporterProvider.h PRE-CREATION > tests/importers/TestImporterProvider.cpp PRE-CREATION > tests/importers/TestRhythmboxImporter.h PRE-CREATION > tests/importers/TestRhythmboxImporter.cpp PRE-CREATION > tests/importers/TestSimpleImporterConfigWidget.h PRE-CREATION > tests/importers/TestSimpleImporterConfigWidget.cpp PRE-CREATION > tests/importers/files/README PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/admin.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/admin.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/admin.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/albums.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/albums.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/albums.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/amazon.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/amazon.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/artists.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/artists.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/artists.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/bookmark_groups.MYI > PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/bookmark_groups.frm > PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/bookmarks.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/bookmarks.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/composers.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/composers.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/composers.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/db.opt PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/devices.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/devices.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/devices.frm PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/directories.MYD PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/directories.MYI PRE-CREATION > tests/importers/files/amarok2_mysqle/amarok/dir
Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113272/#review49382 --- This review has been submitted with commit d77864e758a2162d88aafd432a7eb1e813907f8f by Konrad Zemek to branch master. - Commit Hook On Dec. 10, 2013, 9:12 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113272/ > --- > > (Updated Dec. 10, 2013, 9:12 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > These are changes in the StatSyncing framework that I made as a part of my > project. > > > Diffs > - > > src/statsyncing/Config.h 140e647 > src/statsyncing/Config.cpp dd82dbe > src/statsyncing/Controller.h 10c72a8 > src/statsyncing/Controller.cpp bf4c5d8 > src/statsyncing/Provider.h d9663f9 > src/statsyncing/Provider.cpp 775fce3 > src/statsyncing/ProviderFactory.h PRE-CREATION > src/statsyncing/ProviderFactory.cpp PRE-CREATION > src/statsyncing/SimpleTrack.h PRE-CREATION > src/statsyncing/SimpleTrack.cpp PRE-CREATION > src/statsyncing/SimpleWritableTrack.h PRE-CREATION > src/statsyncing/SimpleWritableTrack.cpp PRE-CREATION > src/statsyncing/Track.h 2f91704 > src/statsyncing/Track.cpp 9655cc1 > src/statsyncing/TrackTuple.h 157d604 > src/statsyncing/TrackTuple.cpp 9442794 > src/statsyncing/jobs/SynchronizeTracksJob.cpp b789aa3 > src/statsyncing/ui/ConfigureProviderDialog.h PRE-CREATION > src/statsyncing/ui/ConfigureProviderDialog.cpp PRE-CREATION > src/statsyncing/ui/CreateProviderDialog.h PRE-CREATION > src/statsyncing/ui/CreateProviderDialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/113272/diff/ > > > Testing > --- > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113278/#review49381 --- This review has been submitted with commit d77864e758a2162d88aafd432a7eb1e813907f8f by Konrad Zemek to branch master. - Commit Hook On Dec. 10, 2013, 9:32 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113278/ > --- > > (Updated Dec. 10, 2013, 9:32 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > This review contains other changes made as a part of my project, i.e. changes > outside of src/statsyncing , src/importers and tests/importers directories. > > > Diffs > - > > images/icons/hi16-action-view-importers-banshee-amarok.png PRE-CREATION > images/icons/hi16-action-view-importers-clementine-amarok.png PRE-CREATION > images/icons/hi16-action-view-importers-rhythmbox-amarok.png PRE-CREATION > images/icons/hi22-action-view-importers-banshee-amarok.png PRE-CREATION > images/icons/hi22-action-view-importers-clementine-amarok.png PRE-CREATION > images/icons/hi22-action-view-importers-rhythmbox-amarok.png PRE-CREATION > images/icons/hi32-action-view-importers-banshee-amarok.png PRE-CREATION > images/icons/hi32-action-view-importers-clementine-amarok.png PRE-CREATION > images/icons/hi32-action-view-importers-rhythmbox-amarok.png PRE-CREATION > images/icons/hi48-action-view-importers-banshee-amarok.png PRE-CREATION > images/icons/hi48-action-view-importers-clementine-amarok.png PRE-CREATION > images/icons/hi48-action-view-importers-rhythmbox-amarok.png PRE-CREATION > src/CMakeLists.txt 70fb67b > src/PluginManager.cpp c48a99b > src/configdialog/dialogs/MetadataConfig.h 72ef69b > src/configdialog/dialogs/MetadataConfig.cpp 7d19f93 > src/configdialog/dialogs/MetadataConfig.ui ff5d332 > src/configdialog/dialogs/PluginsConfig.cpp d5011b8 > src/core-impl/collections/support/CollectionManager.h 062418c > src/core/support/PluginFactory.h 8acd354 > src/databaseimporter/DatabaseImporter.h 602f332 > src/databaseimporter/DatabaseImporter.cpp 00dd895 > src/databaseimporter/amarok14/FastForwardImporter.h 76a2519 > src/databaseimporter/amarok14/FastForwardImporter.cpp 31e1c3c > src/databaseimporter/amarok14/FastForwardImporterConfig.h 21048c7 > src/databaseimporter/amarok14/FastForwardImporterConfig.cpp e803cf5 > src/databaseimporter/amarok14/FastForwardWorker.h 6a4640f > src/databaseimporter/amarok14/FastForwardWorker.cpp b40b8a3 > src/databaseimporter/itunes/ITunesImporter.h a8b8f54 > src/databaseimporter/itunes/ITunesImporter.cpp 5da190e > src/databaseimporter/itunes/ITunesImporterConfig.h 78fe10b > src/databaseimporter/itunes/ITunesImporterConfig.cpp 8aa9733 > src/databaseimporter/itunes/ITunesImporterWorker.h e8a104d > src/databaseimporter/itunes/ITunesImporterWorker.cpp e7149c8 > src/databaseimporter/sqlbatch/SqlBatchImporter.h f233652 > src/databaseimporter/sqlbatch/SqlBatchImporter.cpp 79bcd0c > src/databaseimporter/sqlbatch/SqlBatchImporterConfig.h fab735c > src/databaseimporter/sqlbatch/SqlBatchImporterConfig.cpp 26b68d4 > src/dialogs/CollectionSetup.cpp 2b120e3 > src/dialogs/DatabaseImporterDialog.h f0ae7c3 > src/dialogs/DatabaseImporterDialog.cpp 5159ce8 > src/services/lastfm/SynchronizationTrack.h d6fb593 > src/services/lastfm/SynchronizationTrack.cpp 39c51d4 > tests/CMakeLists.txt e18aaa1 > tests/CollectionTestImpl.h 183c3c2 > tests/mocks/MetaMock.h 37a50ce > > Diff: https://git.reviewboard.kde.org/r/113278/diff/ > > > Testing > --- > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 114563: Make sure not to use video stream when transcoding to Opus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114563/#review46683 --- This review has been submitted with commit e98ef767a4a5188df61cdc2dae075375e529e130 by Matěj Laitl on behalf of Martin Brodbeck to branch master. - Commit Hook On Dec. 20, 2013, 10:06 a.m., Martin Brodbeck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114563/ > --- > > (Updated Dec. 20, 2013, 10:06 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > I stumbled over a problem with transcoding to Opus. For example, if a MP3 > file contains cover art and you transcode it to Opus, ffmpeg creates an Opus > file with two streams: Ogg Theora (because of the picture) and Opus. Thus, > this patch makes sure not to use video streams. > > > Diffs > - > > src/core/transcoding/formats/TranscodingOpusFormat.cpp dc6b743 > > Diff: https://git.reviewboard.kde.org/r/114563/diff/ > > > Testing > --- > > > Thanks, > > Martin Brodbeck > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114406/#review45920 --- This review has been submitted with commit 19fc23445bdb2da894ad6ca4096236de2e9fcb1f by Mark Kretschmann on behalf of Martin Brodbeck to branch master. - Commit Hook On Dec. 12, 2013, 10:51 a.m., Martin Brodbeck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114406/ > --- > > (Updated Dec. 12, 2013, 10:51 a.m.) > > > Review request for Amarok and Matěj Laitl. > > > Bugs: 328451 > https://bugs.kde.org/show_bug.cgi?id=328451 > > > Repository: amarok > > > Description > --- > > With this patch, covers from Ogg files (for example Vorbis and Opus) using > the recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix > bug #328451. > > > Diffs > - > > ChangeLog 107aa48 > shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c > > Diff: http://git.reviewboard.kde.org/r/114406/diff/ > > > Testing > --- > > > Thanks, > > Martin Brodbeck > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 114282: Make the scripts translatable through KDE translation system
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/#review45315 --- This review has been submitted with commit 6f11b6d7376507ef79c16e08da6ee0fe0b5a48fa by Yuri Chornoivan to branch master. - Commit Hook On Dec. 7, 2013, 5:06 p.m., Yuri Chornoivan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114282/ > --- > > (Updated Dec. 7, 2013, 5:06 p.m.) > > > Review request for Amarok. > > > Bugs: 305264 > https://bugs.kde.org/show_bug.cgi?id=305264 > > > Repository: amarok > > > Description > --- > > Scripty can effectively help to translate .desktop files, so this patch tries > to trick scripty. The target translated files still installed as .spec by > renaming during installation. > > > Diffs > - > > src/scripts/librivox_service/CMakeLists.txt f4ef2da > src/scripts/librivox_service/script.desktop PRE-CREATION > src/scripts/librivox_service/script.spec 26719d5 > src/scripts/lyrics_lyricwiki/CMakeLists.txt aa25589 > src/scripts/lyrics_lyricwiki/script.desktop PRE-CREATION > src/scripts/lyrics_lyricwiki/script.spec d3346dc > src/scripts/radio_station_service/CMakeLists.txt d053697 > src/scripts/radio_station_service/script.desktop PRE-CREATION > src/scripts/radio_station_service/script.spec 9e7fb0e > src/scripts/script_console/CMakeLists.txt 4d31f7c > src/scripts/script_console/script.desktop PRE-CREATION > src/scripts/script_console/script.spec 7d0a59d > > Diff: http://git.reviewboard.kde.org/r/114282/diff/ > > > Testing > --- > > Compiles, installs, can be translated through KDE translation system. > > > Thanks, > > Yuri Chornoivan > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 114148: Clean up the leftover of strigi removal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114148/#review44643 --- This review has been submitted with commit 81ad30537c90da4bacddede446f814cfc70bef5c by Jekyll Wu to branch master. - Commit Hook On Nov. 27, 2013, 11:02 a.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114148/ > --- > > (Updated Nov. 27, 2013, 11:02 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > No need to keep those strigi header paths, since amarok now doesn't need > strigi any more. > > > Diffs > - > > src/services/amazon/CMakeLists.txt 5bfd352 > src/services/ampache/CMakeLists.txt 039e7fc > src/services/gpodder/CMakeLists.txt bab6941 > src/services/jamendo/CMakeLists.txt 809b771 > src/services/magnatune/CMakeLists.txt 91f24c0 > src/services/mp3tunes/CMakeLists.txt dfa70b2 > src/services/opmldirectory/CMakeLists.txt 05ff1eb > > Diff: http://git.reviewboard.kde.org/r/114148/diff/ > > > Testing > --- > > > Thanks, > > Jekyll Wu > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389/#review44460 --- This review has been submitted with commit 889b70307da7c95457b62d487c86c479c7a3bbb2 by Anmol Ahuja to branch master. - Commit Hook On Nov. 19, 2013, 6:27 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113389/ > --- > > (Updated Nov. 19, 2013, 6:27 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Changes made to the tagging framework in shared/. > > > Diffs > - > > shared/MetaValues.h 4b003ed > shared/tag_helpers/APETagHelper.cpp ba39a10 > shared/tag_helpers/ASFTagHelper.cpp 3439845 > shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 > shared/tag_helpers/MP4TagHelper.cpp 23d8879 > shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 > > Diff: http://git.reviewboard.kde.org/r/113389/diff/ > > > Testing > --- > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113346/#review42155 --- This review has been submitted with commit d42e43fbd5bdcb1a75bb7891f3248597daefe86f by Matěj Laitl on behalf of Jai Luthra to branch master. - Commit Hook On Oct. 19, 2013, 8:52 p.m., Jai Luthra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113346/ > --- > > (Updated Oct. 19, 2013, 8:52 p.m.) > > > Review request for Amarok. > > > Bugs: 317902 > https://bugs.kde.org/show_bug.cgi?id=317902 > > > Repository: amarok > > > Description > --- > > When ffmpeg is not available, the transcoding dialog will not be skipped; > rather it will add a note for the user to install an encoder. > > > Diffs > - > > src/core/collections/CollectionLocation.cpp 2385570 > src/transcoding/TranscodingAssistantDialog.cpp 17fc250 > src/transcoding/TranscodingAssistantDialog.ui 0ad83b2 > > Diff: http://git.reviewboard.kde.org/r/113346/diff/ > > > Testing > --- > > * Compiles > * Works as expected > > > File Attachments > > > Transcoding dialog with the note. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/424771d9-a0ae-4eaf-824b-4b6bd2b840ee__snapshot1.png > Transcoding dialog UI Revision > > http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/9a2c58c1-5597-40a5-951b-3783226156e4__snapshotv2.png > > > Thanks, > > Jai Luthra > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112706: Allow to use Wikipedia over SSL
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 13, 2013, 8:38 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Allow to use wikipedia over SSL. Make encrypted connections the default. Add an option to fall back to plain HTTP. This addresses bug 322249. https://bugs.kde.org/show_bug.cgi?id=322249 Diffs - src/context/applets/wikipedia/WikipediaApplet.cpp 507db96 src/context/applets/wikipedia/WikipediaApplet_p.h c52a0bf src/context/applets/wikipedia/wikipediaGeneralSettings.ui a615dee src/context/engines/wikipedia/WikipediaEngine.cpp f22e443 Diff: http://git.reviewboard.kde.org/r/112706/diff/ Testing --- Switched several times between HTTP and HTTPS. Switched between the normal and the mobile version. Checked the traffic with wireshark. Verified that this setting is actually persisted. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112706: Allow to use Wikipedia over SSL
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39993 --- This review has been submitted with commit 284342b48dc32341c3553fd2b0ee5069d75b58f9 by Frank Meerkötter to branch master. - Commit Hook On Sept. 13, 2013, 8:32 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112706/ > --- > > (Updated Sept. 13, 2013, 8:32 p.m.) > > > Review request for Amarok. > > > Description > --- > > Allow to use wikipedia over SSL. Make encrypted connections the default. Add > an option to fall back to plain HTTP. > > > This addresses bug 322249. > https://bugs.kde.org/show_bug.cgi?id=322249 > > > Diffs > - > > src/context/applets/wikipedia/WikipediaApplet.cpp 507db96 > src/context/applets/wikipedia/WikipediaApplet_p.h c52a0bf > src/context/applets/wikipedia/wikipediaGeneralSettings.ui a615dee > src/context/engines/wikipedia/WikipediaEngine.cpp f22e443 > > Diff: http://git.reviewboard.kde.org/r/112706/diff/ > > > Testing > --- > > Switched several times between HTTP and HTTPS. Switched between the normal > and the mobile version. > Checked the traffic with wireshark. Verified that this setting is actually > persisted. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112417: FIX: 283022 - Performance with large feed (6000 items) very poor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112417/ --- (Updated Sept. 8, 2013, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Using callgrind it was very visible that amarok is spending an enormous amount of time to turn podcast episodes into tracks. Initially i noticed that the PlaylistBrowserModel is calling Playlist::tracks().count() while it should be calling Playlist::trackCount(). Constructing a list of tracks is expensive for the case of Podcasts (as internally podcast episodes are converted into tracks which get added to a new list). This change already improved the situation a bit, but the UI was still sluggish. Callgrind was still showing that we are turning episodes into tracks - over and over. To fix that i added a cache to the PodcastChannel. As long as the episodes haven't changed, there is no point in constructing a new list of tracks each time tracks() is called. With that second fix the UI is now pretty useable. Diffs - src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 281694a src/core-impl/podcasts/sql/SqlPodcastMeta.h 02a18d3 src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 20bcaff Diff: http://git.reviewboard.kde.org/r/112417/diff/ Testing --- Tested with http://www.justing.com.cn/justpod/justpod_ch.xml Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112417: FIX: 283022 - Performance with large feed (6000 items) very poor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112417/#review39594 --- This review has been submitted with commit a5b0f2afe1b62de636798b7452e4e3abae86db72 by Frank Meerkötter to branch master. - Commit Hook On Aug. 31, 2013, 7:16 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112417/ > --- > > (Updated Aug. 31, 2013, 7:16 p.m.) > > > Review request for Amarok. > > > Description > --- > > Using callgrind it was very visible that amarok is spending an enormous > amount of time to turn podcast episodes into tracks. > > Initially i noticed that the PlaylistBrowserModel is calling > Playlist::tracks().count() while it should be calling Playlist::trackCount(). > Constructing a list of tracks is expensive for the case of Podcasts (as > internally podcast episodes are converted into tracks which > get added to a new list). This change already improved the situation a bit, > but the UI was still sluggish. Callgrind was still showing > that we are turning episodes into tracks - over and over. > > To fix that i added a cache to the PodcastChannel. As long as the episodes > haven't changed, there is no point in constructing > a new list of tracks each time tracks() is called. > > With that second fix the UI is now pretty useable. > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 281694a > src/core-impl/podcasts/sql/SqlPodcastMeta.h 02a18d3 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 20bcaff > > Diff: http://git.reviewboard.kde.org/r/112417/diff/ > > > Testing > --- > > Tested with http://www.justing.com.cn/justpod/justpod_ch.xml > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/ --- (Updated Aug. 30, 2013, 4:38 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Fix reading of Album Artist and Compilation tag in APE tags. Add support for reading Disc Number in APE tags. Diffs - shared/tag_helpers/APETagHelper.cpp c628694 Diff: http://git.reviewboard.kde.org/r/112266/diff/ Testing --- Tested with Musepack files (that do use APE tags) File Attachments Taglib output http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output Thanks, Bruno Léon ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38952 --- This review has been submitted with commit df6d5c3ded956787797c90cc9ecec8b009b1b096 by Mark Kretschmann on behalf of Bruno Léon to branch master. - Commit Hook On Aug. 30, 2013, 1:33 p.m., Bruno Léon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112266/ > --- > > (Updated Aug. 30, 2013, 1:33 p.m.) > > > Review request for Amarok. > > > Description > --- > > Fix reading of Album Artist and Compilation tag in APE tags. > Add support for reading Disc Number in APE tags. > > > Diffs > - > > shared/tag_helpers/APETagHelper.cpp c628694 > > Diff: http://git.reviewboard.kde.org/r/112266/diff/ > > > Testing > --- > > Tested with Musepack files (that do use APE tags) > > > File Attachments > > > Taglib output > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/25/taglib_output > > > Thanks, > > Bruno Léon > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112263: EBN: Check for foreach loop issues.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/ --- (Updated Aug. 26, 2013, 10:11 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- More janitor work. EBN: Check for foreach loop issues. Fixing a number of issues from http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html [...] 13. Check for foreach loop issues [foreach]... [...] Calling values() isn't necessary here. foreach will iterate over the values by default. Diffs - src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 4d2352d src/context/applets/upcomingevents/UpcomingEventsStack.cpp dd9e149 src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp f19ff4d src/core-impl/collections/support/MemoryMatcher.cpp 6e94647 src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 793358b Diff: http://git.reviewboard.kde.org/r/112263/diff/ Testing --- Unit tests still pass. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112263: EBN: Check for foreach loop issues.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/#review38604 --- This review has been submitted with commit 552a100adaffdb6352e2104014b22d9849c9bf15 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 25, 2013, 10:57 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112263/ > --- > > (Updated Aug. 25, 2013, 10:57 a.m.) > > > Review request for Amarok. > > > Description > --- > > More janitor work. > > EBN: Check for foreach loop issues. > > Fixing a number of issues from > http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html > [...] > 13. Check for foreach loop issues [foreach]... > [...] > > Calling values() isn't necessary here. foreach will iterate over the values > by default. > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 4d2352d > src/context/applets/upcomingevents/UpcomingEventsStack.cpp dd9e149 > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp f19ff4d > src/core-impl/collections/support/MemoryMatcher.cpp 6e94647 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 793358b > > Diff: http://git.reviewboard.kde.org/r/112263/diff/ > > > Testing > --- > > Unit tests still pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112255: UMS: Fix set album cover
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112255/#review38516 --- This review has been submitted with commit c62665ccbd053d83d4f15c39d31027d3a0bcc35f by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 24, 2013, 10:11 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112255/ > --- > > (Updated Aug. 24, 2013, 10:11 p.m.) > > > Review request for Amarok. > > > Description > --- > > When Setting->Config->Metadata->Write covers to file is enabled, it should be > possible to write covers for albums located on an UMS collection. The current > status is that amarok does the write but never updates itself to reflect the > new cover. There is code to achive this but is has been broken at some point. > > /home/frank/kde/src/amarok/src/core-impl/meta/file/File_p.h:358 tries to > create a signal/slot connection (to re-read the tags after the write is done) > to an invalid slot. This is fixed by my patch. > > > Diffs > - > > src/core-impl/meta/file/File.cpp f2abea4 > src/core-impl/meta/file/File_p.h 40f631c > > Diff: http://git.reviewboard.kde.org/r/112255/diff/ > > > Testing > --- > > Writing album covers for files located on an USB stick. > The album is updated now (collection browser, playlist). The current track > applet isn't updating but i guess this is a different problem. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112199: 313504: Check for foreach loop issues
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112199/ --- (Updated Aug. 25, 2013, 8:40 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Fixing a number of issues from http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html [...] 13. Check for foreach loop issues [foreach]... [...] Prefer a const reference over a copy. This patch is only a first batch - fixing the simple cases. This addresses bug 313504. https://bugs.kde.org/show_bug.cgi?id=313504 Diffs - shared/TagsFromFileNameGuesser.cpp 0ae8dbd src/EngineController.cpp 99adb53 src/OpmlParser.cpp e47e103 src/configdialog/dialogs/MetadataConfig.cpp 5701d77 src/context/applets/labels/LabelsApplet.cpp f5bc55d src/core-impl/collections/daap/DaapCollection.cpp 20e7b4f src/core-impl/collections/daap/daapreader/Reader.cpp a80922c src/core-impl/collections/db/MountPointManager.cpp dc74896 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp c11a6bd src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp 7ecdcfa src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp ff9e4ad src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp b699b6e src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp 2926e77 src/core-impl/collections/playdarcollection/support/Query.cpp 29619a9 src/core-impl/collections/support/CollectionManager.cpp db5c984 src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp 7579ba2 src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp 6467964 src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 80ea8de src/core-impl/collections/upnpcollection/UpnpQuery.cpp e945bfd src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 67e153f src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp c77f920 src/core-impl/meta/cue/CueFileSupport.cpp 77d27e6 src/core/transcoding/TranscodingConfiguration.cpp dbcd0b3 src/core/transcoding/formats/TranscodingAacFormat.cpp 2b0a02c src/core/transcoding/formats/TranscodingFlacFormat.cpp fd8a832 src/core/transcoding/formats/TranscodingMp3Format.cpp 83d0e2f src/core/transcoding/formats/TranscodingOpusFormat.cpp 3ee991b src/core/transcoding/formats/TranscodingVorbisFormat.cpp 8c32d69 src/core/transcoding/formats/TranscodingWmaFormat.cpp d7646d2 src/covermanager/CoverCache.cpp 14a4646 src/databaseimporter/amarok14/FastForwardWorker.cpp 113141d src/dialogs/CollectionSetup.cpp 0672421 src/dialogs/OrganizeCollectionDialog.cpp a29e626 src/dialogs/TagDialog.cpp 3c07fd1 src/network/NetworkAccessViewer.cpp f5a91dd src/playlist/layouts/PlaylistLayoutEditDialog.cpp 4211010 src/playlistmanager/file/KConfigSyncRelStore.cpp b8dd4c4 src/services/lastfm/ScrobblerAdapter.cpp 3c81546 src/services/lastfm/SynchronizationAdapter.cpp ae4b820 src/services/opmldirectory/OpmlDirectoryView.cpp feba375 src/statsyncing/Config.cpp 40dc79d src/transcoding/TranscodingOptionsStackedWidget.cpp 26128d5 src/widgets/FilenameLayoutWidget.cpp aee4175 utilities/collectionscanner/CollectionScanner.cpp dd4ae37 Diff: http://git.reviewboard.kde.org/r/112199/diff/ Testing --- All unit tests pass. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112199: 313504: Check for foreach loop issues
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112199/#review38515 --- This review has been submitted with commit 01a4ce741420f76c7945063e58a2ccd5acdd5209 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 22, 2013, 7:04 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112199/ > --- > > (Updated Aug. 22, 2013, 7:04 p.m.) > > > Review request for Amarok. > > > Description > --- > > Fixing a number of issues from > http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html > [...] > 13. Check for foreach loop issues [foreach]... > [...] > > Prefer a const reference over a copy. This patch is only a first batch - > fixing the simple cases. > > > This addresses bug 313504. > https://bugs.kde.org/show_bug.cgi?id=313504 > > > Diffs > - > > shared/TagsFromFileNameGuesser.cpp 0ae8dbd > src/EngineController.cpp 99adb53 > src/OpmlParser.cpp e47e103 > src/configdialog/dialogs/MetadataConfig.cpp 5701d77 > src/context/applets/labels/LabelsApplet.cpp f5bc55d > src/core-impl/collections/daap/DaapCollection.cpp 20e7b4f > src/core-impl/collections/daap/daapreader/Reader.cpp a80922c > src/core-impl/collections/db/MountPointManager.cpp dc74896 > src/core-impl/collections/db/sql/SqlCollectionLocation.cpp c11a6bd > src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp 7ecdcfa > src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp ff9e4ad > src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp > b699b6e > src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp > 2926e77 > src/core-impl/collections/playdarcollection/support/Query.cpp 29619a9 > src/core-impl/collections/support/CollectionManager.cpp db5c984 > src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp > 7579ba2 > src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp 6467964 > src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 80ea8de > src/core-impl/collections/upnpcollection/UpnpQuery.cpp e945bfd > src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 67e153f > src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp c77f920 > src/core-impl/meta/cue/CueFileSupport.cpp 77d27e6 > src/core/transcoding/TranscodingConfiguration.cpp dbcd0b3 > src/core/transcoding/formats/TranscodingAacFormat.cpp 2b0a02c > src/core/transcoding/formats/TranscodingFlacFormat.cpp fd8a832 > src/core/transcoding/formats/TranscodingMp3Format.cpp 83d0e2f > src/core/transcoding/formats/TranscodingOpusFormat.cpp 3ee991b > src/core/transcoding/formats/TranscodingVorbisFormat.cpp 8c32d69 > src/core/transcoding/formats/TranscodingWmaFormat.cpp d7646d2 > src/covermanager/CoverCache.cpp 14a4646 > src/databaseimporter/amarok14/FastForwardWorker.cpp 113141d > src/dialogs/CollectionSetup.cpp 0672421 > src/dialogs/OrganizeCollectionDialog.cpp a29e626 > src/dialogs/TagDialog.cpp 3c07fd1 > src/network/NetworkAccessViewer.cpp f5a91dd > src/playlist/layouts/PlaylistLayoutEditDialog.cpp 4211010 > src/playlistmanager/file/KConfigSyncRelStore.cpp b8dd4c4 > src/services/lastfm/ScrobblerAdapter.cpp 3c81546 > src/services/lastfm/SynchronizationAdapter.cpp ae4b820 > src/services/opmldirectory/OpmlDirectoryView.cpp feba375 > src/statsyncing/Config.cpp 40dc79d > src/transcoding/TranscodingOptionsStackedWidget.cpp 26128d5 > src/widgets/FilenameLayoutWidget.cpp aee4175 > utilities/collectionscanner/CollectionScanner.cpp dd4ae37 > > Diff: http://git.reviewboard.kde.org/r/112199/diff/ > > > Testing > --- > > All unit tests pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112221/#review38517 --- This review has been submitted with commit 61350cc9e95ba228f7ec78625c38411cfb636ce3 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 23, 2013, 6:57 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112221/ > --- > > (Updated Aug. 23, 2013, 6:57 a.m.) > > > Review request for Amarok. > > > Description > --- > > Fix the few remaining cases i missed on the first run. See: > https://git.reviewboard.kde.org/r/112148/ > > > This addresses bug 313504. > https://bugs.kde.org/show_bug.cgi?id=313504 > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 > src/dialogs/DiagnosticDialog.cpp a5f2e17 > tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 > > Diff: http://git.reviewboard.kde.org/r/112221/diff/ > > > Testing > --- > > unit tests pass. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111626: Fix Amarok crash with Audio CD inserted
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111626/
---
(Updated Aug. 16, 2013, 12:34 p.m.)
Status
--
This change has been marked as submitted.
Review request for Amarok, kdelibs and Solid.
Description
---
https://bugs.kde.org/show_bug.cgi?id=314544#c40 says:
"Looking at the backtrace, KFilePlacesItem tries to detect Audio CDs as follows:
Solid::Device d = device();
if (d.isValid()) {
if (m_access) {
return QUrl(KUrl(m_access->filePath()));
} else if (m_disc && (m_disc->availableContent() &
Solid::OpticalDisc::Audio)!=0) {
QString device = d.as()->device();
return QUrl(QString("audiocd:/?device=%1").arg(device));
}
}
The crash happens, because d.as returns 0, in other words, Audio
CDs are no longer treated as block devices.
Failure of said cast can be easily detected, but the question is rather, if
it's not a Solid bug, how the code needs to be modified to correctly get the
audiocd:/ URL for the block device."
While I did not yet figure out, how I can get the block device URL for a disc
in case block is 0, I propose this temporary fix. It should fix the crash, but
could fail to correctly invoke the audiocd:/ kio with multiple disc drives.
This addresses bug 314544.
http://bugs.kde.org/show_bug.cgi?id=314544
Diffs
-
kfile/kfileplacesitem.cpp 5a12486
Diff: http://git.reviewboard.kde.org/r/111626/diff/
Testing
---
I could not test, my system has no disc drives.
Thanks,
Christoph Feck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111626: Fix Amarok crash with Audio CD inserted
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111626/#review37949
---
This review has been submitted with commit
31fdb4ab1b72fa39290931f6a8934eda4eb4f636 by Christoph Feck to branch KDE/4.11.
- Commit Hook
On July 21, 2013, 12:28 p.m., Christoph Feck wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111626/
> ---
>
> (Updated July 21, 2013, 12:28 p.m.)
>
>
> Review request for Amarok, kdelibs and Solid.
>
>
> Description
> ---
>
> https://bugs.kde.org/show_bug.cgi?id=314544#c40 says:
>
> "Looking at the backtrace, KFilePlacesItem tries to detect Audio CDs as
> follows:
>
> Solid::Device d = device();
> if (d.isValid()) {
> if (m_access) {
> return QUrl(KUrl(m_access->filePath()));
> } else if (m_disc && (m_disc->availableContent() &
> Solid::OpticalDisc::Audio)!=0) {
> QString device = d.as()->device();
> return QUrl(QString("audiocd:/?device=%1").arg(device));
> }
> }
>
> The crash happens, because d.as returns 0, in other words,
> Audio CDs are no longer treated as block devices.
>
> Failure of said cast can be easily detected, but the question is rather, if
> it's not a Solid bug, how the code needs to be modified to correctly get the
> audiocd:/ URL for the block device."
>
> While I did not yet figure out, how I can get the block device URL for a disc
> in case block is 0, I propose this temporary fix. It should fix the crash,
> but could fail to correctly invoke the audiocd:/ kio with multiple disc
> drives.
>
>
> This addresses bug 314544.
> http://bugs.kde.org/show_bug.cgi?id=314544
>
>
> Diffs
> -
>
> kfile/kfileplacesitem.cpp 5a12486
>
> Diff: http://git.reviewboard.kde.org/r/111626/diff/
>
>
> Testing
> ---
>
> I could not test, my system has no disc drives.
>
>
> Thanks,
>
> Christoph Feck
>
>
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112040/#review37920 --- This review has been submitted with commit 9d12f655f1ac1f518aa67f2bba1dfcad05b673fa by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 12, 2013, 7:46 p.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112040/ > --- > > (Updated Aug. 12, 2013, 7:46 p.m.) > > > Review request for Amarok. > > > Description > --- > > When I plug an encrypted USB-stick amarok is creating two UMS collections for > it. Both have the same mount point. > > $ solid-hardware list details > [...] > udi = '/org/freedesktop/UDisks/devices/dm_2d5' > parent = '/org/freedesktop/UDisks/devices/sdd1' (string) > vendor = '' (string) > product = '' (string) > description = '29.9 GiB Removable Media' (string) > Block.major = 252 (0xfc) (int) > Block.minor = 5 (0x5) (int) > Block.device = '/dev/dm-5' (string) > StorageAccess.accessible = true (bool) > StorageAccess.filePath = '/media/62a745fa-6350-4ee5-ba37-0462dfa3530f' > (string) > StorageAccess.ignored = false (bool) > StorageVolume.ignored = false (bool) > StorageVolume.usage = 'FileSystem' (0x2) (enum) > StorageVolume.fsType = 'ext4' (string) > StorageVolume.label = '' (string) > StorageVolume.uuid = '62a745fa-6350-4ee5-ba37-0462dfa3530f' (string) > StorageVolume.size = 32125222912 (0x77ad0) (qulonglong) > [...] > udi = '/org/freedesktop/UDisks/devices/sdd1' > parent = '/org/freedesktop/UDisks/devices/sdd' (string) > vendor = 'JetFlash' (string) > product = 'Transcend 32GB' (string) > description = '29.9 GiB Encrypted Container' (string) > Block.major = 8 (0x8) (int) > Block.minor = 49 (0x31) (int) > Block.device = '/dev/sdd1' (string) > StorageAccess.accessible = true (bool) > StorageAccess.filePath = '/media/62a745fa-6350-4ee5-ba37-0462dfa3530f' > (string) > StorageAccess.ignored = false (bool) > StorageVolume.ignored = false (bool) > StorageVolume.usage = 'Encrypted' (0x5) (enum) > StorageVolume.fsType = 'crypto_LUKS' (string) > StorageVolume.label = '' (string) > StorageVolume.uuid = '1a38165b-2eee-41d0-acd1-6d34032f47fd' (string) > StorageVolume.size = 32127320064 (0x77af0) (qulonglong) > > This patch is filtering out the storage volume where the usage field is set > to "Encrypted" (as opposed to "Filesystem"). > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.cpp 028966e > src/core-impl/collections/umscollection/UmsCollection.h 749ff81 > > Diff: http://git.reviewboard.kde.org/r/112040/diff/ > > > Testing > --- > > I have tested plugin an USB-stick containing an dmcrypt/luks encrypted > ext4fs. I also tested with an USB-stick that was not encrypted. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112040/ --- (Updated Aug. 16, 2013, 7:16 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- When I plug an encrypted USB-stick amarok is creating two UMS collections for it. Both have the same mount point. $ solid-hardware list details [...] udi = '/org/freedesktop/UDisks/devices/dm_2d5' parent = '/org/freedesktop/UDisks/devices/sdd1' (string) vendor = '' (string) product = '' (string) description = '29.9 GiB Removable Media' (string) Block.major = 252 (0xfc) (int) Block.minor = 5 (0x5) (int) Block.device = '/dev/dm-5' (string) StorageAccess.accessible = true (bool) StorageAccess.filePath = '/media/62a745fa-6350-4ee5-ba37-0462dfa3530f' (string) StorageAccess.ignored = false (bool) StorageVolume.ignored = false (bool) StorageVolume.usage = 'FileSystem' (0x2) (enum) StorageVolume.fsType = 'ext4' (string) StorageVolume.label = '' (string) StorageVolume.uuid = '62a745fa-6350-4ee5-ba37-0462dfa3530f' (string) StorageVolume.size = 32125222912 (0x77ad0) (qulonglong) [...] udi = '/org/freedesktop/UDisks/devices/sdd1' parent = '/org/freedesktop/UDisks/devices/sdd' (string) vendor = 'JetFlash' (string) product = 'Transcend 32GB' (string) description = '29.9 GiB Encrypted Container' (string) Block.major = 8 (0x8) (int) Block.minor = 49 (0x31) (int) Block.device = '/dev/sdd1' (string) StorageAccess.accessible = true (bool) StorageAccess.filePath = '/media/62a745fa-6350-4ee5-ba37-0462dfa3530f' (string) StorageAccess.ignored = false (bool) StorageVolume.ignored = false (bool) StorageVolume.usage = 'Encrypted' (0x5) (enum) StorageVolume.fsType = 'crypto_LUKS' (string) StorageVolume.label = '' (string) StorageVolume.uuid = '1a38165b-2eee-41d0-acd1-6d34032f47fd' (string) StorageVolume.size = 32127320064 (0x77af0) (qulonglong) This patch is filtering out the storage volume where the usage field is set to "Encrypted" (as opposed to "Filesystem"). Diffs - src/core-impl/collections/umscollection/UmsCollection.cpp 028966e src/core-impl/collections/umscollection/UmsCollection.h 749ff81 Diff: http://git.reviewboard.kde.org/r/112040/diff/ Testing --- I have tested plugin an USB-stick containing an dmcrypt/luks encrypted ext4fs. I also tested with an USB-stick that was not encrypted. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110920: Fight warnings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/ --- (Updated Aug. 16, 2013, 6:57 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Fight warnings. Nobody will write that string after it has beed set. Diffs - src/services/mp3tunes/libmp3tunes/harmony.h e0941e348db09ba69c39426077b6798e758d6354 Diff: http://git.reviewboard.kde.org/r/110920/diff/ Testing --- Thanks, Wolf-Michael Bolle ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110920: Fight warnings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/#review37918 --- This review has been submitted with commit e97db1eb0daf06089776ca7bad8aba8063be8d8a by Mark Kretschmann on behalf of Wolf-Michael Bolle to branch master. - Commit Hook On June 9, 2013, 7:53 p.m., Wolf-Michael Bolle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110920/ > --- > > (Updated June 9, 2013, 7:53 p.m.) > > > Review request for Amarok. > > > Description > --- > > Fight warnings. > > Nobody will write that string after it has beed set. > > > Diffs > - > > src/services/mp3tunes/libmp3tunes/harmony.h > e0941e348db09ba69c39426077b6798e758d6354 > > Diff: http://git.reviewboard.kde.org/r/110920/diff/ > > > Testing > --- > > > Thanks, > > Wolf-Michael Bolle > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/album hasn't changed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112044/ --- (Updated Aug. 13, 2013, 7:50 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- This patch (hopefully) fixes 30. This (cut&paste?) error undermined the function of _checkRequireUpdate() if the artist and the composer are different for a track. Diffs - src/context/engines/wikipedia/WikipediaEngine.cpp 0b75f15 Diff: http://git.reviewboard.kde.org/r/112044/diff/ Testing --- I have tested with several mp3s where artist and composer are different, i also tested with mp3s where they are the same. No unnecessary reloading for the artist page was observerd. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 112044: Fixes: 322220 - Wikipedia applet shouldn't reload content if the artist/album hasn't changed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112044/#review37646 --- This review has been submitted with commit cee4167bf1a27da90202142ac773edb6a3ec7f40 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 13, 2013, 6:41 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112044/ > --- > > (Updated Aug. 13, 2013, 6:41 a.m.) > > > Review request for Amarok. > > > Description > --- > > This patch (hopefully) fixes 30. > > This (cut&paste?) error undermined the function of _checkRequireUpdate() if > the artist and the composer are different for a track. > > > Diffs > - > > src/context/engines/wikipedia/WikipediaEngine.cpp 0b75f15 > > Diff: http://git.reviewboard.kde.org/r/112044/diff/ > > > Testing > --- > > I have tested with several mp3s where artist and composer are different, i > also tested with mp3s where they are the same. No unnecessary reloading for > the artist page was observerd. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111991: Better handling of non-writeable UMS collections
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/#review37616 --- This review has been submitted with commit 77df753b706d664fef3818116f0aa40189ccc1c2 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 11, 2013, 11:17 a.m., Frank Meerkoetter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111991/ > --- > > (Updated Aug. 11, 2013, 11:17 a.m.) > > > Review request for Amarok. > > > Description > --- > > If an UMS-collection is non-writeable (think freshly created ext4 on an > USB-stick) a copy/move to > collection will silently fail. It can only be seen in the debug logs on the > console. > > The reason is that the UMS-collection is not actually checking if its > writeable. Its just assuming > to be always writeable. > > My change consists of two parts: > 1. I check if the UMS-collection is actually writeable (mount point and if > set the "music folder"). > 2. To give the user a hint what is going on I added a warning message, > informing the user that >this collection is read-only (otherwise he might be confused why certain > operations (move/copy/organize) >are missing. > > > Diffs > - > > src/core-impl/collections/umscollection/UmsCollection.h 749ff81 > src/core-impl/collections/umscollection/UmsCollection.cpp 028966e > src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 1cd1ba8 > > Diff: http://git.reviewboard.kde.org/r/111991/diff/ > > > Testing > --- > > I have tested with an USB-Stick containing an ext4 filesystem. First i had > the base-dir owned by root.root (non-writeable), next i made it writeable and > verified that its correctly detected as such. Next i created a "Music" folder > and configured it for this USB-Stick. I checked that it was detected as > writeable. Next i made the "Music" folder non-writeable and checked that > amarok also detected that. > > > Thanks, > > Frank Meerkoetter > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111991: Better handling of non-writeable UMS collections
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/ --- (Updated Aug. 12, 2013, 8:33 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- If an UMS-collection is non-writeable (think freshly created ext4 on an USB-stick) a copy/move to collection will silently fail. It can only be seen in the debug logs on the console. The reason is that the UMS-collection is not actually checking if its writeable. Its just assuming to be always writeable. My change consists of two parts: 1. I check if the UMS-collection is actually writeable (mount point and if set the "music folder"). 2. To give the user a hint what is going on I added a warning message, informing the user that this collection is read-only (otherwise he might be confused why certain operations (move/copy/organize) are missing. Diffs - src/core-impl/collections/umscollection/UmsCollection.h 749ff81 src/core-impl/collections/umscollection/UmsCollection.cpp 028966e src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 1cd1ba8 Diff: http://git.reviewboard.kde.org/r/111991/diff/ Testing --- I have tested with an USB-Stick containing an ext4 filesystem. First i had the base-dir owned by root.root (non-writeable), next i made it writeable and verified that its correctly detected as such. Next i created a "Music" folder and configured it for this USB-Stick. I checked that it was detected as writeable. Next i made the "Music" folder non-writeable and checked that amarok also detected that. Thanks, Frank Meerkoetter ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111804: Fix a crash on startup
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36909 --- This review has been submitted with commit 02be4ec8e8fe5c4ebd29785257252a9e50d44d8e by Fabian Kosmale to branch master. - Commit Hook On July 31, 2013, 11:59 a.m., Fabian Kosmale wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111804/ > --- > > (Updated July 31, 2013, 11:59 a.m.) > > > Review request for Amarok. > > > Description > --- > > Without this patch, Amarok would crash with > ASSERT failure in QList::at: "index out of range" > when amarokrc contained > [Playlist Sorting] > SortPath=Shuffle > > > Diffs > - > > src/playlist/PlaylistSortWidget.cpp > 384e4a0eaa28f82eb27665a1a0d497e018a61161 > > Diff: http://git.reviewboard.kde.org/r/111804/diff/ > > > Testing > --- > > Compiled and started Amarok. It doesn't crash anymore. > > > Thanks, > > Fabian Kosmale > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111804: Fix a crash on startup
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated Aug. 1, 2013, 12:11 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Without this patch, Amarok would crash with ASSERT failure in QList::at: "index out of range" when amarokrc contained [Playlist Sorting] SortPath=Shuffle Diffs - src/playlist/PlaylistSortWidget.cpp 384e4a0eaa28f82eb27665a1a0d497e018a61161 Diff: http://git.reviewboard.kde.org/r/111804/diff/ Testing --- Compiled and started Amarok. It doesn't crash anymore. Thanks, Fabian Kosmale ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111655: Reimplement RecentlyPlayedListWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36554 --- This review has been submitted with commit 5bfcf25fa06fc09c9bc951c7f9bf05dc5f6d66a9 by Konrad Zemek to branch master. - Commit Hook On July 26, 2013, 10:02 a.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111655/ > --- > > (Updated July 26, 2013, 10:02 a.m.) > > > Review request for Amarok. > > > Description > --- > > Reimplement RecentlyPlayedListWidget > > Rewrote RecentlyPlayedListWidget from the basics. There was a major > inconsistency in this widget, where tracks were added to it if they were > recently played at all, but the time shown was the "Last Played" > statistic which is only updated after whole song is played. This > caused gravely incorrect data to be displayed (see bug 302485). > > There were two different methods of solving the inconsistency: focusing > on the "Last Played" time, and adding songs to the widget only if the > "Last Played" changed; and focusing on recent plays completely > disregarding "Last Played". I opted for the latter as I felt it fits the > widget's nature better. > > Because we can't rely on already available data, the widget needs to do > its own housekeeping. It saves its data on shutdown, to be restored > on next startup. One other major benefit of this approach is that > widget's data remains correct even if collections change, while > previously tracks from removed collections would disappear. > > Finally, I added the feature to add tracks to playlist directly from the > widget, provided that the track exists. > > BUG: 302485 > FEATURE: 279263 > FEATURE: 296090 > FIXED-IN: 2.8 > REVIEW: 111655 > > > Diffs > - > > ChangeLog 87e4708a6330e7a612db59052a50eef053294b06 > src/context/widgets/RecentlyPlayedListWidget.h > caa78039b891511ca36ada8f61cd4f776d1f3c6d > src/context/widgets/RecentlyPlayedListWidget.cpp > 6ea501affcf6e61d237002e15f7ed4e26989b91b > > Diff: http://git.reviewboard.kde.org/r/111655/diff/ > > > Testing > --- > > Manual. > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111655: Reimplement RecentlyPlayedListWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 26, 2013, 4:19 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Reimplement RecentlyPlayedListWidget Rewrote RecentlyPlayedListWidget from the basics. There was a major inconsistency in this widget, where tracks were added to it if they were recently played at all, but the time shown was the "Last Played" statistic which is only updated after whole song is played. This caused gravely incorrect data to be displayed (see bug 302485). There were two different methods of solving the inconsistency: focusing on the "Last Played" time, and adding songs to the widget only if the "Last Played" changed; and focusing on recent plays completely disregarding "Last Played". I opted for the latter as I felt it fits the widget's nature better. Because we can't rely on already available data, the widget needs to do its own housekeeping. It saves its data on shutdown, to be restored on next startup. One other major benefit of this approach is that widget's data remains correct even if collections change, while previously tracks from removed collections would disappear. Finally, I added the feature to add tracks to playlist directly from the widget, provided that the track exists. BUG: 302485 FEATURE: 279263 FEATURE: 296090 FIXED-IN: 2.8 REVIEW: 111655 Diffs - ChangeLog 87e4708a6330e7a612db59052a50eef053294b06 src/context/widgets/RecentlyPlayedListWidget.h caa78039b891511ca36ada8f61cd4f776d1f3c6d src/context/widgets/RecentlyPlayedListWidget.cpp 6ea501affcf6e61d237002e15f7ed4e26989b91b Diff: http://git.reviewboard.kde.org/r/111655/diff/ Testing --- Manual. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111687: Indicator of tracks is now aligned 16px left from the border. This is a response to Mark's request in Bug 279527: "Now, if you could also figure out how to make the text sti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111687/#review36522 --- This review has been submitted with commit f3111ba4ee0943798f05ad3855ba5032fb42d498 by Mark Kretschmann to branch master. - Commit Hook On July 25, 2013, 3:43 p.m., Ricardo Varas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111687/ > --- > > (Updated July 25, 2013, 3:43 p.m.) > > > Review request for Amarok. > > > Description > --- > > Indicator of tracks is now aligned 16px left from the border. This is a > response to Mark's request in Bug 279527: "Now, if you could also figure out > how to make the text stick less close to the right border, that'd be gold." > > > Diffs > - > > PlaylistDock.cpp a3cfbd9 > > Diff: http://git.reviewboard.kde.org/r/111687/diff/ > > > Testing > --- > > > Thanks, > > Ricardo Varas > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111687: Indicator of tracks is now aligned 16px left from the border. This is a response to Mark's request in Bug 279527: "Now, if you could also figure out how to make the text sti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111687/ --- (Updated July 26, 2013, 6:38 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Indicator of tracks is now aligned 16px left from the border. This is a response to Mark's request in Bug 279527: "Now, if you could also figure out how to make the text stick less close to the right border, that'd be gold." Diffs - PlaylistDock.cpp a3cfbd9 Diff: http://git.reviewboard.kde.org/r/111687/diff/ Testing --- Thanks, Ricardo Varas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111510/#review36029 --- This review has been submitted with commit e1cf50a6a8a8f0e378b72751fb2114502918e8c7 by Alex Merry to branch master. - Commit Hook On July 15, 2013, 1:18 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111510/ > --- > > (Updated July 15, 2013, 1:18 p.m.) > > > Review request for Amarok. > > > Description > --- > > Consistently use FindFFMpeg.cmake from kdelibs > > FindFFMpeg from kdelibs works differently to our internal one (and, in > fact, more consistently with standard Find* files). Since we depends on > kdelibs anyway, we now just use the kdelibs one and don't bother > shipping our own. > > > Diffs > - > > ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c > cmake/modules/FindFFmpeg.cmake 0aa2cdc33a88953fe8b94532cb45c43ad35e0da8 > src/CMakeLists.txt 589fddb9ea2177102cabd3a193a9e6848ea9c12d > > Diff: http://git.reviewboard.kde.org/r/111510/diff/ > > > Testing > --- > > Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5. No other > configurations tested. (Without the patch, the build fails with this > configuration). > > > Thanks, > > Alex Merry > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111510/ --- (Updated July 16, 2013, 9:37 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Consistently use FindFFMpeg.cmake from kdelibs FindFFMpeg from kdelibs works differently to our internal one (and, in fact, more consistently with standard Find* files). Since we depends on kdelibs anyway, we now just use the kdelibs one and don't bother shipping our own. Diffs - ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c cmake/modules/FindFFmpeg.cmake 0aa2cdc33a88953fe8b94532cb45c43ad35e0da8 src/CMakeLists.txt 589fddb9ea2177102cabd3a193a9e6848ea9c12d Diff: http://git.reviewboard.kde.org/r/111510/diff/ Testing --- Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5. No other configurations tested. (Without the patch, the build fails with this configuration). Thanks, Alex Merry ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111512: MPRIS2: avoid updating Metadata when between tracks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111512/#review36015 --- This review has been submitted with commit f5d15e9465c6fa3d0a3997bf57130fe5e592c56e by Alex Merry to branch master. - Commit Hook On July 15, 2013, 1:18 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111512/ > --- > > (Updated July 15, 2013, 1:18 p.m.) > > > Review request for Amarok. > > > Description > --- > > MPRIS2: avoid updating Metadata when between tracks > > When changing tracks, we would emit PropertiesChanged for Metadata > twice, once with mpris:trackid set to /org/kde/amarok/PendingTrack and > once with the actual new trackid (because the first time the playlist > code had not yet updated the active track). If the track was changed > manually (not just progressing to the next one) we would often also emit > a PropertiesChanged with an empty Metadata before repopulating it. > > This solves the first issue by making the signal connection for > trackChanged from EngineController queued, meaning that by the time the > MPRIS2 code gets the signal, the playlist has updated the activeTrack > and we can easily figure out the correct trackid. > > It solves the second issue by ignoring the trackLengthChanged signal > when it has a meaningless value (<0), which seems to happen at some > point during track changes that are not predictable. > > BUG: 321602 > > > Diffs > - > > ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c > src/dbus/mpris2/MediaPlayer2Player.cpp > a633756bf558a89ba2a3db2307c0ebbc373a759b > > Diff: http://git.reviewboard.kde.org/r/111512/diff/ > > > Testing > --- > > Tested using a tool that listens to the PropertiesChanged signal of the > MPRIS2 interface and lists when the mpris:trackid changes. > > Without the patch, I get output like > Track change: "/org/kde/amarok/Track/5739423209746661216" -> > "/org/kde/amarok/PendingTrack" > Track change: "/org/kde/amarok/PendingTrack" -> > "/org/kde/amarok/Track/8264712350997591513" > when the track progresses because the previous track finished, and > Track change: "/org/kde/amarok/Track/5739423209746661216" -> "" > Track change: "" -> "/org/kde/amarok/Track/8264712350997591513" > when I manually change the track (eg: by clicking "next" or by > double-clicking another track). > > With the patch, I only get things like > Track change: "/org/kde/amarok/Track/5739423209746661216" -> > "/org/kde/amarok/Track/8264712350997591513" > > > Thanks, > > Alex Merry > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111512: MPRIS2: avoid updating Metadata when between tracks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111512/ --- (Updated July 15, 2013, 10:44 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- MPRIS2: avoid updating Metadata when between tracks When changing tracks, we would emit PropertiesChanged for Metadata twice, once with mpris:trackid set to /org/kde/amarok/PendingTrack and once with the actual new trackid (because the first time the playlist code had not yet updated the active track). If the track was changed manually (not just progressing to the next one) we would often also emit a PropertiesChanged with an empty Metadata before repopulating it. This solves the first issue by making the signal connection for trackChanged from EngineController queued, meaning that by the time the MPRIS2 code gets the signal, the playlist has updated the activeTrack and we can easily figure out the correct trackid. It solves the second issue by ignoring the trackLengthChanged signal when it has a meaningless value (<0), which seems to happen at some point during track changes that are not predictable. BUG: 321602 Diffs - ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c src/dbus/mpris2/MediaPlayer2Player.cpp a633756bf558a89ba2a3db2307c0ebbc373a759b Diff: http://git.reviewboard.kde.org/r/111512/diff/ Testing --- Tested using a tool that listens to the PropertiesChanged signal of the MPRIS2 interface and lists when the mpris:trackid changes. Without the patch, I get output like Track change: "/org/kde/amarok/Track/5739423209746661216" -> "/org/kde/amarok/PendingTrack" Track change: "/org/kde/amarok/PendingTrack" -> "/org/kde/amarok/Track/8264712350997591513" when the track progresses because the previous track finished, and Track change: "/org/kde/amarok/Track/5739423209746661216" -> "" Track change: "" -> "/org/kde/amarok/Track/8264712350997591513" when I manually change the track (eg: by clicking "next" or by double-clicking another track). With the patch, I only get things like Track change: "/org/kde/amarok/Track/5739423209746661216" -> "/org/kde/amarok/Track/8264712350997591513" Thanks, Alex Merry ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110082/#review35435 --- This review has been submitted with commit 6ef8e597851e8e5638c7714c9b2649213db2732e by Mark Kretschmann on behalf of Vedant Agarwala to branch master. - Commit Hook On June 3, 2013, 8:23 p.m., Vedant Agarwala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110082/ > --- > > (Updated June 3, 2013, 8:23 p.m.) > > > Review request for Amarok. > > > Description > --- > > As agreed on the review for https://git.reviewboard.kde.org/r/104048/ , > Qt::TooltipRole has been updated so that now the tooltip displays full name > of the playlist. Occurrences of "description" have been removed (from the > Playlist base class as well as the subclasses). > > > This addresses bug 275821. > https://bugs.kde.org/show_bug.cgi?id=275821 > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp d2b55ff > > src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h > 6b25e59 > > src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp > 1ad4d55 > src/core-impl/playlists/types/file/PlaylistFile.h bd88199 > src/core-impl/playlists/types/file/PlaylistFile.cpp 073e140 > src/core/playlists/Playlist.h 39ecb30 > src/playlistmanager/SyncedPlaylist.h fd2f966 > src/playlistmanager/SyncedPlaylist.cpp 985f087 > src/playlistmanager/sql/SqlPlaylist.h d28d161 > src/playlistmanager/sql/SqlPlaylist.cpp 98f24d2 > src/playlistmanager/sql/SqlPlaylistGroup.cpp 2862034 > src/playlistmanager/sql/SqlUserPlaylistProvider.h 273a050 > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp d9209d2 > > Diff: http://git.reviewboard.kde.org/r/110082/diff/ > > > Testing > --- > > Testing done. Works. Builds successfully and passes the tests. > > > File Attachments > > > displays the new tooltip > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot1.png > displays the new tooltip > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot.png > > > Thanks, > > Vedant Agarwala > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111038/#review35429 --- This review has been submitted with commit 9dbdb8bde9836f2e17da9ef063cea66961324639 by Mark Kretschmann on behalf of Vedant Agarwala to branch master. - Commit Hook On June 15, 2013, 11:22 a.m., Vedant Agarwala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111038/ > --- > > (Updated June 15, 2013, 11:22 a.m.) > > > Review request for Amarok. > > > Description > --- > > After the track was changed the "scroll to current playing track" worked as > per user settings. But in case of dynamic playlists after the tracks were > added (automatically) the PrettyListView scrolled to the tracks added (i.e. > it scrolled to the bottom). It took me so long to figure this out and even > longer to find a solution; but the patch was only of 2 lines. Anyway I got a > better understanding of the Playlist Model-View architecture :) > > > This addresses bug 284214. > https://bugs.kde.org/show_bug.cgi?id=284214 > > > Diffs > - > > src/playlist/view/listview/PrettyListView.cpp 8723875 > > Diff: http://git.reviewboard.kde.org/r/111038/diff/ > > > Testing > --- > > Builds successfully and runs as expected > > > Thanks, > > Vedant Agarwala > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111038/ --- (Updated July 2, 2013, 10:15 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- After the track was changed the "scroll to current playing track" worked as per user settings. But in case of dynamic playlists after the tracks were added (automatically) the PrettyListView scrolled to the tracks added (i.e. it scrolled to the bottom). It took me so long to figure this out and even longer to find a solution; but the patch was only of 2 lines. Anyway I got a better understanding of the Playlist Model-View architecture :) This addresses bug 284214. https://bugs.kde.org/show_bug.cgi?id=284214 Diffs - src/playlist/view/listview/PrettyListView.cpp 8723875 Diff: http://git.reviewboard.kde.org/r/111038/diff/ Testing --- Builds successfully and runs as expected Thanks, Vedant Agarwala ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111334: text color in toolbar below playlist is no longer always white. I tested it with all color schemes installed by default in openSUSE and text is very readable now.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111334/#review35337 --- This review has been submitted with commit 8d3faf37cc2283e5d4038e864adb2343961f1470 by Mark Kretschmann to branch master. - Commit Hook On June 30, 2013, 10:02 p.m., Ricardo Varas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111334/ > --- > > (Updated June 30, 2013, 10:02 p.m.) > > > Review request for Amarok. > > > Description > --- > > text color in toolbar below playlist is no longer always white. I tested it > with all color schemes installed by default in openSUSE and text is very > readable now. > > > This addresses bug 279527. > https://bugs.kde.org/show_bug.cgi?id=279527 > > > Diffs > - > > home/ricardo/amarok/src/playlist/PlaylistDock.cpp 7faf1ba > > Diff: http://git.reviewboard.kde.org/r/111334/diff/ > > > Testing > --- > > > Thanks, > > Ricardo Varas > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111334: text color in toolbar below playlist is no longer always white. I tested it with all color schemes installed by default in openSUSE and text is very readable now.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111334/ --- (Updated July 1, 2013, 5:51 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- text color in toolbar below playlist is no longer always white. I tested it with all color schemes installed by default in openSUSE and text is very readable now. This addresses bug 279527. https://bugs.kde.org/show_bug.cgi?id=279527 Diffs - home/ricardo/amarok/src/playlist/PlaylistDock.cpp 7faf1ba Diff: http://git.reviewboard.kde.org/r/111334/diff/ Testing --- Thanks, Ricardo Varas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111275/#review35302 --- This review has been submitted with commit 684a218b3e223a3189b7290df90e6b22f52a514a by Mark Kretschmann on behalf of fleissig fleissig to branch master. - Commit Hook On June 28, 2013, 8:57 p.m., fleissig fleissig wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111275/ > --- > > (Updated June 28, 2013, 8:57 p.m.) > > > Review request for Amarok. > > > Description > --- > > putting Artist - Title of the current track to the clipboard using a shortcut > > > This addresses bug 228872. > https://bugs.kde.org/show_bug.cgi?id=228872 > > > Diffs > - > > src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 > src/MainWindow.cpp af47db7226244cc81f1a4f5d3c980d758b93 > > Diff: http://git.reviewboard.kde.org/r/111275/diff/ > > > Testing > --- > > > Thanks, > > fleissig fleissig > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111275/ --- (Updated June 30, 2013, 11:54 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- putting Artist - Title of the current track to the clipboard using a shortcut This addresses bug 228872. https://bugs.kde.org/show_bug.cgi?id=228872 Diffs - src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 src/MainWindow.cpp af47db7226244cc81f1a4f5d3c980d758b93 Diff: http://git.reviewboard.kde.org/r/111275/diff/ Testing --- Thanks, fleissig fleissig ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110855: Add dbus methods for updating all existing podcast and adding new podcast
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110855/ --- (Updated June 19, 2013, 10:09 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Bug 205509 - JJ: add dbus functions to update podcasts and download podcast tracks I added two new methods for dbus: UpdateAllPodcast and AddPodcast This addresses bugs 205509 and Bug. https://bugs.kde.org/show_bug.cgi?id=205509 https://bugs.kde.org/show_bug.cgi?id=Bug Diffs - src/dbus/mpris1/TrackListHandler.h 551999a src/dbus/mpris1/TrackListHandler.cpp b1f01cf src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml ee512b7 Diff: http://git.reviewboard.kde.org/r/110855/diff/ Testing --- Tested both of these methods using qdbus qdbus org.kde.amarok /TrackList AddPodcast "http://feeds.feedburner.com/freakonomicsradio"; qdbus org.kde.amarok /TrackList UpdateAllPodcast Thanks, Shubham Chaudhary ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110855: Add dbus methods for updating all existing podcast and adding new podcast
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110855/#review34709 --- This review has been submitted with commit c894719060e4fb0e98fac14bc787ca2cc0e1c890 by Mark Kretschmann on behalf of Shubham Chaudhary to branch master. - Commit Hook On June 19, 2013, 9:59 p.m., Shubham Chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110855/ > --- > > (Updated June 19, 2013, 9:59 p.m.) > > > Review request for Amarok. > > > Description > --- > > Bug 205509 - JJ: add dbus functions to update podcasts and download podcast > tracks > I added two new methods for dbus: UpdateAllPodcast and AddPodcast > > > This addresses bugs 205509 and Bug. > https://bugs.kde.org/show_bug.cgi?id=205509 > https://bugs.kde.org/show_bug.cgi?id=Bug > > > Diffs > - > > src/dbus/mpris1/TrackListHandler.h 551999a > src/dbus/mpris1/TrackListHandler.cpp b1f01cf > src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml ee512b7 > > Diff: http://git.reviewboard.kde.org/r/110855/diff/ > > > Testing > --- > > Tested both of these methods using qdbus > qdbus org.kde.amarok /TrackList AddPodcast > "http://feeds.feedburner.com/freakonomicsradio"; > qdbus org.kde.amarok /TrackList UpdateAllPodcast > > > Thanks, > > Shubham Chaudhary > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110917: Remove usage of (fake) Amarok-Mockup theme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110917/#review34013 --- This review has been submitted with commit e899704b3db4af2ff228eb0d4dbbec05fb9a2448 by Mark Kretschmann on behalf of Hrvoje Senjan to branch master. - Commit Hook On June 9, 2013, 7:22 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110917/ > --- > > (Updated June 9, 2013, 7:22 p.m.) > > > Review request for Amarok, Plasma and Aaron J. Seigo. > > > Description > --- > > This is due to https://bugs.kde.org/show_bug.cgi?id=320855 > Amarok-Mockup is unused, as far i can see, and also makes Amarok crash with > kdelibs master/4.11 > If it is still needed, or there is a better solution, i'll discard the > review... > > > Diffs > - > > src/context/ContextView.cpp f61518f > > Diff: http://git.reviewboard.kde.org/r/110917/diff/ > > > Testing > --- > > Compiled, no crash, no (yet at least) side-effects. > > > Thanks, > > Hrvoje Senjan > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110917: Remove usage of (fake) Amarok-Mockup theme
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110917/ --- (Updated June 10, 2013, 7:36 a.m.) Status -- This change has been marked as submitted. Review request for Amarok, Plasma and Aaron J. Seigo. Description --- This is due to https://bugs.kde.org/show_bug.cgi?id=320855 Amarok-Mockup is unused, as far i can see, and also makes Amarok crash with kdelibs master/4.11 If it is still needed, or there is a better solution, i'll discard the review... Diffs - src/context/ContextView.cpp f61518f Diff: http://git.reviewboard.kde.org/r/110917/diff/ Testing --- Compiled, no crash, no (yet at least) side-effects. Thanks, Hrvoje Senjan ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/ --- (Updated May 31, 2013, 12:24 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Playlist sort widget: reimplement Shuffle "sort" as an action. Remove now-unnecessary Shuffle handlers in sort-related functions. Additionally, PlaylistController::MoveRows has been modified to help with big move actions (validation complexity reduced). Playlist::BreadcrumbItemMenu introduced to deduplicate logic between Playlist::BreadcrumbItem and Playlist::BreadcrumbAddMenuButton. GUI: In the playlist sort widget, the Shuffle menu entry is now separated from other entries. Activating the entry no longer results in a "Shuffle" sort level being added. BUG: 320129 FIXED-IN: 2.8 REVIEW: 110658 Diffs - src/playlist/PlaylistActions.cpp 1decce7c3d7bef36f314b8abcc337064438a92e0 src/playlist/PlaylistBreadcrumbItem.h d6ff243d7b78358f3a943de9a345d694c613aec9 src/playlist/PlaylistBreadcrumbItem.cpp 59fc6d2a68d86e4d0cd4c1def343ac6973bc5965 src/playlist/PlaylistBreadcrumbItemSortButton.h c141597614ac40c3c4adaf212f3d46b9ff360293 src/playlist/PlaylistBreadcrumbItemSortButton.cpp 8bf861cfcd4234a0d34c3542b9fa806ce66454de src/playlist/PlaylistBreadcrumbLevel.h d87c88d02c383f34b2321ef294508eaa75dbc9a3 src/playlist/PlaylistBreadcrumbLevel.cpp 185ebfbafcbc3ef8ca80d9fd9ae42b0663a59eca src/playlist/PlaylistController.h 5047e473b7d236d5be5bd99342d8ed731913634b src/playlist/PlaylistController.cpp df293a994798299335aeeb3221e2231ecb357356 src/playlist/PlaylistDefines.h 3e10b552f86b68946b6883b0ee49c226d83315f6 src/playlist/PlaylistModel.cpp a562bdbf0789d23e5712223593d9e09de0e29520 ChangeLog 9dd0c3dfb9c2a275ef9796bce18f7c8ae7b39360 src/playlist/PlaylistActions.h dee8793e5386d3a44c98698631f6e8dd13a7d62f src/playlist/PlaylistSortWidget.h 71aefe5ad008a260a3ae8455ed2d87ffdaae17c6 src/playlist/PlaylistSortWidget.cpp 62f760cc6a201a67be65c80bf03ae696bd4c src/playlist/proxymodels/SortAlgorithms.h 2eba6a7dd4c227f55d519083f9af9cf7b08f043d src/playlist/proxymodels/SortAlgorithms.cpp 47b468c99e37d3ff8b148704791c5058726ac812 src/playlist/proxymodels/SortScheme.cpp d29f9dec6b1c2ae555146853782819328ae192f0 tests/playlist/TestPlaylistModels.h 3751e6a2c3d56be1a6abcea742eec088e2a1123b tests/playlist/TestPlaylistModels.cpp ec8adb8f2c5bbb141f291989499e361d5a73381d Diff: http://git.reviewboard.kde.org/r/110658/diff/ Testing --- Test added for the shuffle action. GUI tested manually. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33517 --- This review has been submitted with commit 5659f0f8ad73a2894ebe8d5da3f7925e75ce6901 by Matěj Laitl on behalf of Konrad Zemek to branch master. - Commit Hook On May 30, 2013, 11:18 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110658/ > --- > > (Updated May 30, 2013, 11:18 p.m.) > > > Review request for Amarok. > > > Description > --- > > Playlist sort widget: reimplement Shuffle "sort" as an action. > > Remove now-unnecessary Shuffle handlers in sort-related functions. > Additionally, PlaylistController::MoveRows has been modified to help with big > move actions (validation complexity reduced). > > Playlist::BreadcrumbItemMenu introduced to deduplicate logic between > Playlist::BreadcrumbItem and Playlist::BreadcrumbAddMenuButton. > > GUI: In the playlist sort widget, the Shuffle menu entry is now separated > from other entries. Activating the entry no longer results in a "Shuffle" > sort level being added. > BUG: 320129 > FIXED-IN: 2.8 > REVIEW: 110658 > > > Diffs > - > > src/playlist/PlaylistActions.cpp 1decce7c3d7bef36f314b8abcc337064438a92e0 > src/playlist/PlaylistBreadcrumbItem.h > d6ff243d7b78358f3a943de9a345d694c613aec9 > src/playlist/PlaylistBreadcrumbItem.cpp > 59fc6d2a68d86e4d0cd4c1def343ac6973bc5965 > src/playlist/PlaylistBreadcrumbItemSortButton.h > c141597614ac40c3c4adaf212f3d46b9ff360293 > src/playlist/PlaylistBreadcrumbItemSortButton.cpp > 8bf861cfcd4234a0d34c3542b9fa806ce66454de > src/playlist/PlaylistBreadcrumbLevel.h > d87c88d02c383f34b2321ef294508eaa75dbc9a3 > src/playlist/PlaylistBreadcrumbLevel.cpp > 185ebfbafcbc3ef8ca80d9fd9ae42b0663a59eca > src/playlist/PlaylistController.h 5047e473b7d236d5be5bd99342d8ed731913634b > src/playlist/PlaylistController.cpp > df293a994798299335aeeb3221e2231ecb357356 > src/playlist/PlaylistDefines.h 3e10b552f86b68946b6883b0ee49c226d83315f6 > src/playlist/PlaylistModel.cpp a562bdbf0789d23e5712223593d9e09de0e29520 > ChangeLog 9dd0c3dfb9c2a275ef9796bce18f7c8ae7b39360 > src/playlist/PlaylistActions.h dee8793e5386d3a44c98698631f6e8dd13a7d62f > src/playlist/PlaylistSortWidget.h 71aefe5ad008a260a3ae8455ed2d87ffdaae17c6 > src/playlist/PlaylistSortWidget.cpp > 62f760cc6a201a67be65c80bf03ae696bd4c > src/playlist/proxymodels/SortAlgorithms.h > 2eba6a7dd4c227f55d519083f9af9cf7b08f043d > src/playlist/proxymodels/SortAlgorithms.cpp > 47b468c99e37d3ff8b148704791c5058726ac812 > src/playlist/proxymodels/SortScheme.cpp > d29f9dec6b1c2ae555146853782819328ae192f0 > tests/playlist/TestPlaylistModels.h > 3751e6a2c3d56be1a6abcea742eec088e2a1123b > tests/playlist/TestPlaylistModels.cpp > ec8adb8f2c5bbb141f291989499e361d5a73381d > > Diff: http://git.reviewboard.kde.org/r/110658/diff/ > > > Testing > --- > > Test added for the shuffle action. GUI tested manually. > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110520: create new collections without restart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110520/ --- (Updated May 20, 2013, 5:04 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- create new collections without restart Diffs - src/PluginManager.cpp 5250011fe21be01abe3247d30a735dcad2d53d17 src/core-impl/collections/support/CollectionManager.h a3cb6cefc958fb2875c7bef075f4a5319fc8b958 src/core-impl/collections/support/CollectionManager.cpp 0775206655b47d660c92bf6ebf23623de356bb69 Diff: http://git.reviewboard.kde.org/r/110520/diff/ Testing --- Thanks, Edward Hades Toroshchin ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110520: create new collections without restart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110520/#review32842 --- This review has been submitted with commit c399ec3170ea2582aaddfbed58c1e3902ff68d52 by Edward Hades to branch master. - Commit Hook On May 20, 2013, 4:53 p.m., Edward Hades Toroshchin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110520/ > --- > > (Updated May 20, 2013, 4:53 p.m.) > > > Review request for Amarok. > > > Description > --- > > create new collections without restart > > > Diffs > - > > src/PluginManager.cpp 5250011fe21be01abe3247d30a735dcad2d53d17 > src/core-impl/collections/support/CollectionManager.h > a3cb6cefc958fb2875c7bef075f4a5319fc8b958 > src/core-impl/collections/support/CollectionManager.cpp > 0775206655b47d660c92bf6ebf23623de356bb69 > > Diff: http://git.reviewboard.kde.org/r/110520/diff/ > > > Testing > --- > > > Thanks, > > Edward Hades Toroshchin > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110139: Small bugfixes. Fixes clang warnings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/ --- (Updated April 28, 2013, 10:33 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Small bugfixes. Fixes clang warnings. A few legitimate, non critical bugs. Also minor changes to explicitly cover all enums in switch statements. Diffs - src/browsers/playlistbrowser/PlaylistBrowserView.cpp fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d src/core-impl/collections/daap/daapreader/authentication/md5.c 089118ff8bcd20aecade257c31d56a0447fc04de src/core-impl/collections/db/sql/SqlQueryMaker.cpp fc5f6df29d9e22a97712a31b2aa71bc0e6424b40 src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 93e068124beae4ba4f294e476d696cc0196dd298 src/dialogs/EditFilterDialog.cpp ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34 Diff: http://git.reviewboard.kde.org/r/110139/diff/ Testing --- Changed lines no longer generate warnings. Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110139: Small bugfixes. Fixes clang warnings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31695 --- This review has been submitted with commit 17f3e7a9cd2dbb201dfc580c8c1d40b4fec85922 by Matěj Laitl on behalf of Konrad Zemek to branch master. - Commit Hook On April 27, 2013, 10:11 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110139/ > --- > > (Updated April 27, 2013, 10:11 p.m.) > > > Review request for Amarok. > > > Description > --- > > Small bugfixes. Fixes clang warnings. > > A few legitimate, non critical bugs. Also minor changes to explicitly cover > all enums in switch statements. > > > Diffs > - > > src/browsers/playlistbrowser/PlaylistBrowserView.cpp > fc7fe14a10ae0f4b25f9b0e0ccb85c246b82313d > src/core-impl/collections/daap/daapreader/authentication/md5.c > 089118ff8bcd20aecade257c31d56a0447fc04de > src/core-impl/collections/db/sql/SqlQueryMaker.cpp > fc5f6df29d9e22a97712a31b2aa71bc0e6424b40 > src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp > 93e068124beae4ba4f294e476d696cc0196dd298 > src/dialogs/EditFilterDialog.cpp ac26497dcc5e5cf7cb9e2ea1a821dbce83276d34 > > Diff: http://git.reviewboard.kde.org/r/110139/diff/ > > > Testing > --- > > Changed lines no longer generate warnings. > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/#review31667 --- This review has been submitted with commit e84b44ebbb6c470af1272852ba8afd258aa858d0 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On April 22, 2013, 6:58 a.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109781/ > --- > > (Updated April 22, 2013, 6:58 a.m.) > > > Review request for Amarok. > > > Description > --- > > Added 3 checkbox in the TranscodingAssistantDialog: > "Transcode all tracks" - transcode all tracks, the current default behavior > "Ignore files which're already the selected format" - transcode only if > source and destination file formats are different > "Transcode only when needed for playability" - transcode only when needed for > playability in the destination collection > > > Diffs > - > > src/core-impl/collections/support/CollectionLocationDelegateImpl.h b59beec > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c > src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 3c2d9f2 > src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 8bc4552 > ChangeLog c007887 > src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp > f19cd9d > src/core-impl/collections/umscollection/UmsCollectionLocation.h 45ba596 > src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 2a30c9f > src/core/collections/CollectionLocation.cpp 08f6910 > src/core/collections/CollectionLocationDelegate.h 6316d6f > src/core/transcoding/TranscodingConfiguration.h 98b2bb8 > src/core/transcoding/TranscodingConfiguration.cpp f97a43d > src/transcoding/TranscodingAssistantDialog.h 76287a7 > src/transcoding/TranscodingAssistantDialog.cpp 8348b12 > src/transcoding/TranscodingAssistantDialog.ui 2505bd3 > src/transcoding/TranscodingOptionsStackedWidget.h 9495d44 > src/transcoding/TranscodingOptionsStackedWidget.cpp cf4f328 > src/transcoding/TranscodingSelectConfigWidget.h aa5f196 > src/transcoding/TranscodingSelectConfigWidget.cpp adb593c > tests/core/collections/MockCollectionLocationDelegate.h 5efbe2e7 > > Diff: http://git.reviewboard.kde.org/r/109781/diff/ > > > Testing > --- > > Works as expected > All build tests passed > > > File Attachments > > > TranscodingAssistantDialog > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 27, 2013, 10:44 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Added 3 checkbox in the TranscodingAssistantDialog: "Transcode all tracks" - transcode all tracks, the current default behavior "Ignore files which're already the selected format" - transcode only if source and destination file formats are different "Transcode only when needed for playability" - transcode only when needed for playability in the destination collection Diffs - src/core-impl/collections/support/CollectionLocationDelegateImpl.h b59beec src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 3c2d9f2 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 8bc4552 ChangeLog c007887 src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp f19cd9d src/core-impl/collections/umscollection/UmsCollectionLocation.h 45ba596 src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 2a30c9f src/core/collections/CollectionLocation.cpp 08f6910 src/core/collections/CollectionLocationDelegate.h 6316d6f src/core/transcoding/TranscodingConfiguration.h 98b2bb8 src/core/transcoding/TranscodingConfiguration.cpp f97a43d src/transcoding/TranscodingAssistantDialog.h 76287a7 src/transcoding/TranscodingAssistantDialog.cpp 8348b12 src/transcoding/TranscodingAssistantDialog.ui 2505bd3 src/transcoding/TranscodingOptionsStackedWidget.h 9495d44 src/transcoding/TranscodingOptionsStackedWidget.cpp cf4f328 src/transcoding/TranscodingSelectConfigWidget.h aa5f196 src/transcoding/TranscodingSelectConfigWidget.cpp adb593c tests/core/collections/MockCollectionLocationDelegate.h 5efbe2e7 Diff: http://git.reviewboard.kde.org/r/109781/diff/ Testing --- Works as expected All build tests passed File Attachments TranscodingAssistantDialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/TranscodingAssistantDialog_1.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110070/ --- (Updated April 27, 2013, 9:11 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting. It fixes an issue with two albums being merged on the playlist when they happen to have the same name, and sorting by album is enabled. Originally thought to fix bug 271105, it actually fixes some other, but connected, one (see my comment https://bugs.kde.org/show_bug.cgi?id=271105#c10 ). I'll search for a bug report and submit one if I find none. This addresses bug 271105. https://bugs.kde.org/show_bug.cgi?id=271105 Diffs - src/playlist/proxymodels/SortAlgorithms.h da18fcc2107d83515ff176746e751fe00e786362 src/playlist/proxymodels/SortAlgorithms.cpp c7d0df9f6b86318fd896a6de08fef6d85623215b src/playlist/proxymodels/SortScheme.h 0fcd3a580deff7f2b4e6e65d0551c7332e0b6c9e src/playlist/proxymodels/SortScheme.cpp de4f37adaeb6e8bb914eb7c91ff4803d01fc5623 tests/mocks/MetaMock.h 03fea2aaf7f27236c43a8cb78c241078414dd39c tests/playlist/TestPlaylistModels.cpp 8964333517e431487b6ad4ba50d3e359f51bf3f6 Diff: http://git.reviewboard.kde.org/r/110070/diff/ Testing --- Manual tests + relevant unittest added in testplaylistmodels Thanks, Konrad Zemek ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110070/#review31661 --- This review has been submitted with commit 583158f4c4d25098aa1f0bb6b683813488580d52 by Matěj Laitl on behalf of Konrad Zemek to branch master. - Commit Hook On April 19, 2013, 3:13 p.m., Konrad Zemek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110070/ > --- > > (Updated April 19, 2013, 3:13 p.m.) > > > Review request for Amarok. > > > Description > --- > > Cleaned up playlist multilevel sorting algorithm. Added album artist special > case to playlist sorting. > > It fixes an issue with two albums being merged on the playlist when they > happen to have the same name, and sorting by album is enabled. > Originally thought to fix bug 271105, it actually fixes some other, but > connected, one (see my comment > https://bugs.kde.org/show_bug.cgi?id=271105#c10 ). > I'll search for a bug report and submit one if I find none. > > > This addresses bug 271105. > https://bugs.kde.org/show_bug.cgi?id=271105 > > > Diffs > - > > src/playlist/proxymodels/SortAlgorithms.h > da18fcc2107d83515ff176746e751fe00e786362 > src/playlist/proxymodels/SortAlgorithms.cpp > c7d0df9f6b86318fd896a6de08fef6d85623215b > src/playlist/proxymodels/SortScheme.h > 0fcd3a580deff7f2b4e6e65d0551c7332e0b6c9e > src/playlist/proxymodels/SortScheme.cpp > de4f37adaeb6e8bb914eb7c91ff4803d01fc5623 > tests/mocks/MetaMock.h 03fea2aaf7f27236c43a8cb78c241078414dd39c > tests/playlist/TestPlaylistModels.cpp > 8964333517e431487b6ad4ba50d3e359f51bf3f6 > > Diff: http://git.reviewboard.kde.org/r/110070/diff/ > > > Testing > --- > > Manual tests + relevant unittest added in testplaylistmodels > > > Thanks, > > Konrad Zemek > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/ --- (Updated April 19, 2013, 3:30 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- 1. Added notPlayableReason() to class Track 2. Display track tooltip with the prettyNotPlayableReason() if track not playable Diffs - src/core-impl/collections/audiocd/AudioCdMeta.h fc26fcc src/core-impl/collections/audiocd/AudioCdMeta.cpp 218ce2a src/core-impl/collections/daap/DaapMeta.h 9a9c257 src/core-impl/collections/daap/DaapMeta.cpp e66afb7 src/core-impl/collections/db/sql/SqlMeta.h b7f0a71 src/core-impl/collections/db/sql/SqlMeta.cpp 19ec936 src/core-impl/collections/ipodcollection/IpodMeta.h 1d380b1 src/core-impl/collections/ipodcollection/IpodMeta.cpp 9ffcf7e src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 5d1b9f9 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 2b66574 src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf7 src/core-impl/collections/playdarcollection/PlaydarMeta.h 7a39a4f src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 5f4ec3c src/core-impl/collections/proxycollection/ProxyCollectionMeta.h ef342a4 src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp e58a20a src/core-impl/collections/support/MemoryMeta.h 40061d2 src/core-impl/collections/upnpcollection/UpnpMeta.h 55bc131 src/core-impl/collections/upnpcollection/UpnpMeta.cpp 00cc915 src/core-impl/meta/file/File.h 7d3359d src/core-impl/meta/file/File.cpp 2cd0a61 src/core-impl/meta/multi/MultiTrack.h be55170 src/core-impl/meta/proxy/MetaProxy.h 15967df src/core-impl/meta/proxy/MetaProxy.cpp 6a35bc5 src/core-impl/meta/stream/Stream.h 3e19b45 src/core-impl/meta/stream/Stream.cpp 6e35960 src/core-impl/meta/timecode/TimecodeMeta.h 3aed4f9 src/core-impl/meta/timecode/TimecodeMeta.cpp e3490e4 src/core/meta/Meta.h f86cf39 src/core/meta/Meta.cpp cd1b38a src/core/podcasts/PodcastMeta.h f3b21de src/playlist/PlaylistModel.cpp 246b9a1 src/services/ServiceMetaBase.h f25159d src/services/ServiceMetaBase.cpp 7537649 src/services/ampache/AmpacheMeta.h 934fe75 src/services/ampache/AmpacheMeta.cpp b59715c src/services/lastfm/meta/LastFmMeta.h 9c54a10 src/services/lastfm/meta/LastFmMeta.cpp 424d136 tests/CMakeLists.txt d6b23ec tests/synchronization/CMakeLists.txt db73c25 Diff: http://git.reviewboard.kde.org/r/109817/diff/ Testing --- Works as expected Build tests passed Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/#review31295 --- This review has been submitted with commit 0b1391318ae98c5f077b301ccb76a23b7efd1c3f by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On April 19, 2013, 12:42 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109817/ > --- > > (Updated April 19, 2013, 12:42 p.m.) > > > Review request for Amarok. > > > Description > --- > > 1. Added notPlayableReason() to class Track > 2. Display track tooltip with the prettyNotPlayableReason() if track not > playable > > > Diffs > - > > src/core-impl/collections/audiocd/AudioCdMeta.h fc26fcc > src/core-impl/collections/audiocd/AudioCdMeta.cpp 218ce2a > src/core-impl/collections/daap/DaapMeta.h 9a9c257 > src/core-impl/collections/daap/DaapMeta.cpp e66afb7 > src/core-impl/collections/db/sql/SqlMeta.h b7f0a71 > src/core-impl/collections/db/sql/SqlMeta.cpp 19ec936 > src/core-impl/collections/ipodcollection/IpodMeta.h 1d380b1 > src/core-impl/collections/ipodcollection/IpodMeta.cpp 9ffcf7e > src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 5d1b9f9 > src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 2b66574 > src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h 27ff06d > src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp 6d5bcf7 > src/core-impl/collections/playdarcollection/PlaydarMeta.h 7a39a4f > src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 5f4ec3c > src/core-impl/collections/proxycollection/ProxyCollectionMeta.h ef342a4 > src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp e58a20a > src/core-impl/collections/support/MemoryMeta.h 40061d2 > src/core-impl/collections/upnpcollection/UpnpMeta.h 55bc131 > src/core-impl/collections/upnpcollection/UpnpMeta.cpp 00cc915 > src/core-impl/meta/file/File.h 7d3359d > src/core-impl/meta/file/File.cpp 2cd0a61 > src/core-impl/meta/multi/MultiTrack.h be55170 > src/core-impl/meta/proxy/MetaProxy.h 15967df > src/core-impl/meta/proxy/MetaProxy.cpp 6a35bc5 > src/core-impl/meta/stream/Stream.h 3e19b45 > src/core-impl/meta/stream/Stream.cpp 6e35960 > src/core-impl/meta/timecode/TimecodeMeta.h 3aed4f9 > src/core-impl/meta/timecode/TimecodeMeta.cpp e3490e4 > src/core/meta/Meta.h f86cf39 > src/core/meta/Meta.cpp cd1b38a > src/core/podcasts/PodcastMeta.h f3b21de > src/playlist/PlaylistModel.cpp 246b9a1 > src/services/ServiceMetaBase.h f25159d > src/services/ServiceMetaBase.cpp 7537649 > src/services/ampache/AmpacheMeta.h 934fe75 > src/services/ampache/AmpacheMeta.cpp b59715c > src/services/lastfm/meta/LastFmMeta.h 9c54a10 > src/services/lastfm/meta/LastFmMeta.cpp 424d136 > tests/CMakeLists.txt d6b23ec > tests/synchronization/CMakeLists.txt db73c25 > > Diff: http://git.reviewboard.kde.org/r/109817/diff/ > > > Testing > --- > > Works as expected > Build tests passed > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109758: Asx playlist implementation.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/ --- (Updated April 15, 2013, 9:27 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Asx playlist implementation. P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ will be accepted This addresses bug 170207. https://bugs.kde.org/show_bug.cgi?id=170207 Diffs - ChangeLog ef6790f src/CMakeLists.txt d667d95 src/MainWindow.cpp 07dca94 src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d src/core-impl/playlists/types/file/PlaylistFile.cpp c327082 src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION src/core/playlists/PlaylistFormat.cpp 6b3cb6b src/playlistmanager/file/PlaylistFileProvider.cpp 8f4669a tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109758/diff/ Testing --- Loading and saving works Thanks, Tatjana Gornak ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109758: Asx playlist implementation.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/#review31123 --- This review has been submitted with commit e1eddb4a00b0d5bece5b9eb59e95b460c762 by Matěj Laitl on behalf of Tatjana Gornak to branch master. - Commit Hook On April 14, 2013, 5:40 p.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109758/ > --- > > (Updated April 14, 2013, 5:40 p.m.) > > > Review request for Amarok. > > > Description > --- > > Asx playlist implementation. > > P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ > will be accepted > > > This addresses bug 170207. > https://bugs.kde.org/show_bug.cgi?id=170207 > > > Diffs > - > > ChangeLog ef6790f > src/CMakeLists.txt d667d95 > src/MainWindow.cpp 07dca94 > src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d > src/core-impl/playlists/types/file/PlaylistFile.cpp c327082 > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 > src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION > src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION > src/core/playlists/PlaylistFormat.cpp 6b3cb6b > src/playlistmanager/file/PlaylistFileProvider.cpp 8f4669a > tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109758/diff/ > > > Testing > --- > > Loading and saving works > > > Thanks, > > Tatjana Gornak > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 15, 2013, 8:09 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- 1. Disabled Pre-amplifier in equalizer if it is not supported by phonon. 2. Fixed top and bottom labels of first slider. Earlier band name label was at the top and slider value label was at the bottom for first slider. 3. Removed an extra semicolon EqualizerDialog.h . Note : I have made an assumption that if at all preamp is present then it will the first element of Effect Parameter list. This addresses bug 301311. https://bugs.kde.org/show_bug.cgi?id=301311 Diffs - ChangeLog a278be3 src/EngineController.h 5de4beb src/EngineController.cpp 28fb256 src/dialogs/EqualizerDialog.cpp f42a033 src/dialogs/EqualizerDialog.ui 43b0187 Diff: http://git.reviewboard.kde.org/r/108995/diff/ Testing --- All unit test cases passed. Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC. File Attachments Equalizer snapshot http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31119 --- This review has been submitted with commit e344f608faf236e8faa455e0516f55d4ffeee80c by Matěj Laitl on behalf of Harsh Gupta to branch master. - Commit Hook On April 15, 2013, 3:55 p.m., Harsh Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108995/ > --- > > (Updated April 15, 2013, 3:55 p.m.) > > > Review request for Amarok. > > > Description > --- > > 1. Disabled Pre-amplifier in equalizer if it is not supported by phonon. > 2. Fixed top and bottom labels of first slider. Earlier band name label was > at the top and slider value label was at the bottom for first slider. > 3. Removed an extra semicolon EqualizerDialog.h . > Note : I have made an assumption that if at all preamp is present then it > will the first element of Effect Parameter list. > > > This addresses bug 301311. > https://bugs.kde.org/show_bug.cgi?id=301311 > > > Diffs > - > > ChangeLog a278be3 > src/EngineController.h 5de4beb > src/EngineController.cpp 28fb256 > src/dialogs/EqualizerDialog.cpp f42a033 > src/dialogs/EqualizerDialog.ui 43b0187 > > Diff: http://git.reviewboard.kde.org/r/108995/diff/ > > > Testing > --- > > All unit test cases passed. > Note : I have tested it with gstreamer only. Xine phonon keep crashing on my > PC. > > > File Attachments > > > Equalizer snapshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png > > > Thanks, > > Harsh Gupta > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109984: Renamed attribute names to match Amarok coding style.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109984/ --- (Updated April 13, 2013, 2 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Renamed attribute names to match Amarok coding style. Note : This patch must be applied before "FIX Pre-amplifier in equalizer doesn't work" patch. Diffs - src/dialogs/EqualizerDialog.cpp 7299e9a src/dialogs/EqualizerDialog.h fd9032b src/EngineController.cpp 86ad837 Diff: http://git.reviewboard.kde.org/r/109984/diff/ Testing --- Ok Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109984: Renamed attribute names to match Amarok coding style.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109984/#review30988 --- This review has been submitted with commit 8d4001baf95bf726e038a5feb0f5ffaa0c76a819 by Matěj Laitl on behalf of Harsh Gupta to branch master. - Commit Hook On April 12, 2013, 10:37 p.m., Harsh Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109984/ > --- > > (Updated April 12, 2013, 10:37 p.m.) > > > Review request for Amarok. > > > Description > --- > > Renamed attribute names to match Amarok coding style. > Note : This patch must be applied before "FIX Pre-amplifier in equalizer > doesn't work" patch. > > > Diffs > - > > src/dialogs/EqualizerDialog.cpp 7299e9a > src/dialogs/EqualizerDialog.h fd9032b > src/EngineController.cpp 86ad837 > > Diff: http://git.reviewboard.kde.org/r/109984/diff/ > > > Testing > --- > > Ok > > > Thanks, > > Harsh Gupta > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109758: Asx playlist implementation.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/ --- (Updated April 13, 2013, 12:50 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Asx playlist implementation. P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ will be accepted This addresses bug 170207. https://bugs.kde.org/show_bug.cgi?id=170207 Diffs - ChangeLog 7b394ac src/CMakeLists.txt d667d95 src/MainWindow.cpp 07dca94 src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION src/core/playlists/PlaylistFormat.cpp 6b3cb6b src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109758/diff/ Testing --- Loading and saving works Thanks, Tatjana Gornak ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109758: Asx playlist implementation.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/#review30984 --- This review has been submitted with commit c91a2017116789ecb5c63c7e850cb69cfeb6b6f1 by Matěj Laitl on behalf of Tatjana Gornak to branch master. - Commit Hook On April 9, 2013, 8:24 p.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109758/ > --- > > (Updated April 9, 2013, 8:24 p.m.) > > > Review request for Amarok. > > > Description > --- > > Asx playlist implementation. > > P.S. This patch make sense only if https://git.reviewboard.kde.org/r/107473/ > will be accepted > > > This addresses bug 170207. > https://bugs.kde.org/show_bug.cgi?id=170207 > > > Diffs > - > > ChangeLog 7b394ac > src/CMakeLists.txt d667d95 > src/MainWindow.cpp 07dca94 > src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp e19769d > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 82de3a6 > src/core-impl/playlists/types/file/asx/ASXPlaylist.h PRE-CREATION > src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION > src/core/playlists/PlaylistFormat.cpp 6b3cb6b > src/playlistmanager/file/PlaylistFileProvider.cpp 4a5639e > tests/core-impl/playlists/types/file/CMakeLists.txt ef69236 > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.h PRE-CREATION > tests/core-impl/playlists/types/file/asx/TestASXPlaylist.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109758/diff/ > > > Testing > --- > > Loading and saving works > > > Thanks, > > Tatjana Gornak > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109879: Small cleanups in playlists
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109879/ --- (Updated April 9, 2013, 5 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- In review request 109758 Mat?j has pointed on some issues which appear not only in new asx implementation. - number of includes was minimalized - common routine for relative urls processing - trackLocation is const method now Diffs - src/core-impl/playlists/types/file/PlaylistFile.h d3bc640 src/core-impl/playlists/types/file/PlaylistFile.cpp 36987c6 src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 6280442 src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 225dc0b src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 6ec7bfd Diff: http://git.reviewboard.kde.org/r/109879/diff/ Testing --- Thanks, Tatjana Gornak ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109879: Small cleanups in playlists
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109879/#review30798 --- This review has been submitted with commit 1e4789d5df9329654c4eb2d94263d81cf72b8014 by Matěj Laitl on behalf of Tatjana Gornak to branch master. - Commit Hook On April 7, 2013, 2:27 a.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109879/ > --- > > (Updated April 7, 2013, 2:27 a.m.) > > > Review request for Amarok. > > > Description > --- > > In review request 109758 Mat?j has pointed on some issues which appear not > only in new asx implementation. > > - number of includes was minimalized > - common routine for relative urls processing > - trackLocation is const method now > > > Diffs > - > > src/core-impl/playlists/types/file/PlaylistFile.h d3bc640 > src/core-impl/playlists/types/file/PlaylistFile.cpp 36987c6 > src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 6280442 > src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 225dc0b > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 6ec7bfd > > Diff: http://git.reviewboard.kde.org/r/109879/diff/ > > > Testing > --- > > > Thanks, > > Tatjana Gornak > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109846/ --- (Updated April 6, 2013, 4:13 p.m.) Status -- This change has been marked as submitted. Review request for Amarok and Oliver Henshaw. Description --- 1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options: Pause playback on suspend Inhibit suspend if playing 2. Created a PowerManager class to handle suspend behavior Fixes: BR 259862 - Amarok does not inhibit suspend while playing BR 222571 - Amarok pause on suspend Diffs - src/playback/PowerManager.h PRE-CREATION src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 src/amarokconfig.kcfg fbe5497 src/EngineController.cpp 52bfd90 ChangeLog 3422cad src/CMakeLists.txt 990f313 src/playback/PowerManager.cpp PRE-CREATION tests/core-impl/meta/multi/CMakeLists.txt 327b555 tests/playlist/CMakeLists.txt c2e4c06 Diff: http://git.reviewboard.kde.org/r/109846/diff/ Testing --- Works as expected File Attachments PlaybackConfig Dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109846: BR 259862, 222571: Add options to pause playback on suspend and inhibit automatic suspend if playing
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109846/#review30570 --- This review has been submitted with commit 71e55e7bdd9b31642d09145a5801777c0e120454 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On April 5, 2013, 6:31 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109846/ > --- > > (Updated April 5, 2013, 6:31 p.m.) > > > Review request for Amarok and Oliver Henshaw. > > > Description > --- > > 1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options: > Pause playback on suspend > Inhibit suspend if playing > 2. Created a PowerManager class to handle suspend behavior > > Fixes: > BR 259862 - Amarok does not inhibit suspend while playing > BR 222571 - Amarok pause on suspend > > > Diffs > - > > src/playback/PowerManager.h PRE-CREATION > src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 > src/amarokconfig.kcfg fbe5497 > src/EngineController.cpp 52bfd90 > ChangeLog 3422cad > src/CMakeLists.txt 990f313 > src/playback/PowerManager.cpp PRE-CREATION > tests/core-impl/meta/multi/CMakeLists.txt 327b555 > tests/playlist/CMakeLists.txt c2e4c06 > > Diff: http://git.reviewboard.kde.org/r/109846/diff/ > > > Testing > --- > > Works as expected > > > File Attachments > > > PlaybackConfig Dialog > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109794/ --- (Updated April 2, 2013, 6:06 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines Used this script: https://qt.gitorious.org/qt/qt/trees/v4.7.3/util/normalize UPDATE: Ran normalize on new master, fixed whtespaces, tested Uploading a patch generated using "git format-patch" too, it's more convenient to apply Diffs - src/context/applets/tabs/TabsApplet.cpp 531a257 src/context/applets/songkick/SongkickApplet.cpp 8d1b468 src/context/applets/photos/PhotosScrollWidget.cpp 555dfda src/context/applets/photos/PhotosApplet.cpp ed26f33 src/context/applets/lyrics/LyricsApplet.cpp 2394964 src/context/applets/labels/LabelsApplet.cpp 2df1173 src/context/applets/info/InfoApplet.cpp 8974519 src/context/applets/currenttrack/CurrentTrack.cpp ff3bec7 src/context/ToolbarView.cpp 679f027 src/context/ContextView.cpp e41638d src/context/ContextDock.cpp a445677 src/context/Applet.cpp fd5abe9 src/configdialog/dialogs/PlaybackConfig.cpp c4f357b src/configdialog/dialogs/NotificationsConfig.cpp d558325 src/configdialog/dialogs/DatabaseConfig.cpp 77ea254 src/configdialog/dialogs/CollectionConfig.cpp 5f546ac src/configdialog/ConfigDialog.cpp 320e6ab src/browsers/servicebrowser/ServiceBrowser.cpp 6f576a1 src/browsers/playlistbrowser/QtGroupingProxy.cpp 24f611c src/browsers/playlistbrowser/PodcastCategory.cpp 4631d27 src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 0ccaf93 src/browsers/playlistbrowser/PlaylistBrowserView.cpp c885f7c src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 658af22 src/browsers/playlistbrowser/PlaylistBrowserFilterProxy.cpp 84439fa playground/src/context/applets/coverbling/CoverBling.cpp 9401514 playground/src/context/applets/coverbling/CoverBlingApplet.cpp 5b355ba playground/src/context/applets/coverbling/PhotoBrowser.cpp 856e9c2 playground/src/context/applets/coverbling/pictureflow.cpp 057e8d1 playground/src/context/applets/covergrid/CoverGridApplet.cpp 2432df6 src/ActionClasses.cpp bb68c64 src/AmarokMimeData.cpp edd4279 src/AmarokProcess.cpp fc13307 src/App.cpp 416d4dc src/EngineController.cpp 58d7360 src/LastfmReadLabelCapability.cpp f0929ea src/MainWindow.cpp da2e0f2 src/MediaDeviceCache.cpp c9758cd src/MediaDeviceMonitor.cpp dd22114 src/OpmlParser.cpp a935038 src/ScriptManager.cpp 022a65f src/ScriptUpdater.cpp d1b1ccb src/SvgHandler.cpp 4f5335b src/TrayIcon.cpp 606b644 src/aboutdialog/ExtendedAboutDialog.cpp eca67d9 src/aboutdialog/OcsPersonItem.cpp 1174c0b src/aboutdialog/OcsPersonListWidget.cpp 1a4af3d src/aboutdialog/libattica-ocsclient/activitylistjob.cpp d8c4bef src/aboutdialog/libattica-ocsclient/categorylistjob.cpp cf8fadc src/aboutdialog/libattica-ocsclient/contentjob.cpp 132fe36 src/aboutdialog/libattica-ocsclient/contentlistjob.cpp c85d1ba src/aboutdialog/libattica-ocsclient/eventjob.cpp d458905 src/aboutdialog/libattica-ocsclient/eventlistjob.cpp 7cf59b7 src/aboutdialog/libattica-ocsclient/folderlistjob.cpp de30a74 src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp 8558719 src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp 2dab20a src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 3f32a84f src/aboutdialog/libattica-ocsclient/personjob.cpp 722f343 src/aboutdialog/libattica-ocsclient/personlistjob.cpp 6dc415b src/aboutdialog/libattica-ocsclient/postjob.cpp fd790ac src/amarokurls/AmarokUrlAction.cpp b04b7a4 src/amarokurls/BookmarkCurrentButton.cpp d4b3a19 src/amarokurls/BookmarkManagerWidget.cpp 1806a6b src/amarokurls/BookmarkMetaActions.cpp 9a11a94 src/amarokurls/BookmarkTreeView.cpp 7a033e0 src/browsers/BrowserBreadcrumbItem.cpp ad485c6 src/browsers/BrowserBreadcrumbWidget.cpp 3b789c2 src/browsers/BrowserCategoryList.cpp ad0079b src/browsers/BrowserDock.cpp dabe43d src/browsers/BrowserMessageArea.cpp dc36257 src/browsers/CollectionTreeItem.cpp 26cd253 src/browsers/CollectionTreeItemModel.cpp fa194b1 src/browsers/CollectionTreeItemModelBase.cpp 30067a1 src/browsers/CollectionTreeView.cpp aac232a src/browsers/SingleCollectionTreeItemModel.cpp babfc64 src/browsers/collectionbrowser/CollectionWidget.cpp 81960b1 src/browsers/filebrowser/FileBrowser.cpp 167fd33 src/browsers/filebrowser/FileView.cpp 61b27ea src/browsers/playlistbrowser/APGCategory.cpp e2acb9a src/browsers/playlistbrowser/DynamicBiasWidgets.cpp 092f27b src/browsers/playlistbrowser/DynamicCategory.cpp 0e1a4af src/browsers/playlistbrowser/DynamicView.cpp 58c82e4 src/browsers/playlistb
Re: Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109794/#review30285 --- This review has been submitted with commit 7a72f13d7f57e83efdae66b5078b7f1aa0131b2d by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On April 2, 2013, 5:41 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109794/ > --- > > (Updated April 2, 2013, 5:41 p.m.) > > > Review request for Amarok. > > > Description > --- > > Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok > style guidelines > > Used this script: > https://qt.gitorious.org/qt/qt/trees/v4.7.3/util/normalize > > UPDATE: Ran normalize on new master, fixed whtespaces, tested > > Uploading a patch generated using "git format-patch" too, it's more > convenient to apply > > > Diffs > - > > src/context/applets/tabs/TabsApplet.cpp 531a257 > src/context/applets/songkick/SongkickApplet.cpp 8d1b468 > src/context/applets/photos/PhotosScrollWidget.cpp 555dfda > src/context/applets/photos/PhotosApplet.cpp ed26f33 > src/context/applets/lyrics/LyricsApplet.cpp 2394964 > src/context/applets/labels/LabelsApplet.cpp 2df1173 > src/context/applets/info/InfoApplet.cpp 8974519 > src/context/applets/currenttrack/CurrentTrack.cpp ff3bec7 > src/context/ToolbarView.cpp 679f027 > src/context/ContextView.cpp e41638d > src/context/ContextDock.cpp a445677 > src/context/Applet.cpp fd5abe9 > src/configdialog/dialogs/PlaybackConfig.cpp c4f357b > src/configdialog/dialogs/NotificationsConfig.cpp d558325 > src/configdialog/dialogs/DatabaseConfig.cpp 77ea254 > src/configdialog/dialogs/CollectionConfig.cpp 5f546ac > src/configdialog/ConfigDialog.cpp 320e6ab > src/browsers/servicebrowser/ServiceBrowser.cpp 6f576a1 > src/browsers/playlistbrowser/QtGroupingProxy.cpp 24f611c > src/browsers/playlistbrowser/PodcastCategory.cpp 4631d27 > src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 0ccaf93 > src/browsers/playlistbrowser/PlaylistBrowserView.cpp c885f7c > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 658af22 > src/browsers/playlistbrowser/PlaylistBrowserFilterProxy.cpp 84439fa > playground/src/context/applets/coverbling/CoverBling.cpp 9401514 > playground/src/context/applets/coverbling/CoverBlingApplet.cpp 5b355ba > playground/src/context/applets/coverbling/PhotoBrowser.cpp 856e9c2 > playground/src/context/applets/coverbling/pictureflow.cpp 057e8d1 > playground/src/context/applets/covergrid/CoverGridApplet.cpp 2432df6 > src/ActionClasses.cpp bb68c64 > src/AmarokMimeData.cpp edd4279 > src/AmarokProcess.cpp fc13307 > src/App.cpp 416d4dc > src/EngineController.cpp 58d7360 > src/LastfmReadLabelCapability.cpp f0929ea > src/MainWindow.cpp da2e0f2 > src/MediaDeviceCache.cpp c9758cd > src/MediaDeviceMonitor.cpp dd22114 > src/OpmlParser.cpp a935038 > src/ScriptManager.cpp 022a65f > src/ScriptUpdater.cpp d1b1ccb > src/SvgHandler.cpp 4f5335b > src/TrayIcon.cpp 606b644 > src/aboutdialog/ExtendedAboutDialog.cpp eca67d9 > src/aboutdialog/OcsPersonItem.cpp 1174c0b > src/aboutdialog/OcsPersonListWidget.cpp 1a4af3d > src/aboutdialog/libattica-ocsclient/activitylistjob.cpp d8c4bef > src/aboutdialog/libattica-ocsclient/categorylistjob.cpp cf8fadc > src/aboutdialog/libattica-ocsclient/contentjob.cpp 132fe36 > src/aboutdialog/libattica-ocsclient/contentlistjob.cpp c85d1ba > src/aboutdialog/libattica-ocsclient/eventjob.cpp d458905 > src/aboutdialog/libattica-ocsclient/eventlistjob.cpp 7cf59b7 > src/aboutdialog/libattica-ocsclient/folderlistjob.cpp de30a74 > src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp 8558719 > src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp 2dab20a > src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 3f32a84f > src/aboutdialog/libattica-ocsclient/personjob.cpp 722f343 > src/aboutdialog/libattica-ocsclient/personlistjob.cpp 6dc415b > src/aboutdialog/libattica-ocsclient/postjob.cpp fd790ac > src/amarokurls/AmarokUrlAction.cpp b04b7a4 > src/amarokurls/BookmarkCurrentButton.cpp d4b3a19 > src/amarokurls/BookmarkManagerWidget.cpp 1806a6b > src/amarokurls/BookmarkMetaActions.cpp 9a11a94 > src/amarokurls/BookmarkTreeView.cpp 7a033e0 > src/browsers/BrowserBreadcrumbItem.c
Re: Review Request 107473: Changes in processing playlist files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/ --- (Updated April 2, 2013, 10:47 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- I've started my changes with an implementation of a ASXPlaylist class, due this work I've found that implementation of different playlist file types has different logic, as result I end up with a rewriting playlist's implementations. As example of difference: -- Constructor M3UPlaylist::M3UPlaylist( const KUrl &url ) sets a url, but does not load playlist, therefore loading of playlist are posponed till data from playlist are actualy needed (lazy loading) On the other hand constructor XSPFPlaylist::XSPFPlaylist( const KUrl &url, bool autoAppend ) loads playlist. The main idea of proposed changes is to create a unify code for processing playlist files: -- lazy loading through LazyLoadPlaylist -- common functionality was moved to PlaylistFile. It is worth to be noticed that this patch changes structure of playlist's classes, bit does not changes their behavior, even if this behavior is inconsistent in some cases. In following patch-requests I plan to submit ASX Playlist parser and organize playlists processing in more consistent way. This addresses bug 291934. https://bugs.kde.org/show_bug.cgi?id=291934 Diffs - src/CMakeLists.txt 4cdee5e src/DirectoryLoader.h e53a30d src/DirectoryLoader.cpp bd7fa34 src/browsers/playlistbrowser/PlaylistBrowserModel.h 1b7a44d src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 213af3b src/context/applets/info/InfoApplet.cpp f215885 src/core-impl/collections/ipodcollection/IpodPlaylistProvider.h 4dd79f3 src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp 1a4a934 src/core-impl/playlists/types/file/PlaylistFile.h 43dfdeb src/core-impl/playlists/types/file/PlaylistFile.cpp 2730354 src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h PRE-CREATION src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp PRE-CREATION src/core-impl/playlists/types/file/PlaylistFileSupport.h b1a1c26 src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd src/core-impl/playlists/types/file/m3u/M3UPlaylist.h 7b982fe src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 2395260 src/core-impl/playlists/types/file/pls/PLSPlaylist.h e69e133 src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 8fe4b51 src/core-impl/playlists/types/file/xspf/XSPFPlaylist.h 6cf33e9 src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp bbcecc3 src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1a025ce src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 0da9b51 src/core/playlists/Playlist.h 018d2af src/core/playlists/Playlist.cpp 36879a1 src/core/playlists/PlaylistProvider.h 0fb5818 src/playlist/PlaylistActions.cpp 00bf13a src/playlist/PlaylistController.cpp e5bde8b src/playlist/PlaylistRestorer.h PRE-CREATION src/playlist/PlaylistRestorer.cpp PRE-CREATION src/playlistmanager/PlaylistManager.h cbf65b0 src/playlistmanager/PlaylistManager.cpp 89c754b src/playlistmanager/SyncedPlaylist.h fce3d14 src/playlistmanager/SyncedPlaylist.cpp 4f7c0b7 src/playlistmanager/file/PlaylistFileProvider.cpp e4e7284 src/playlistmanager/sql/SqlPlaylist.cpp 88e685b src/playlistmanager/sql/SqlUserPlaylistProvider.cpp 5eb6987 src/services/gpodder/GpodderProvider.h 8e856e3 tests/TestDirectoryLoader.h 0583a9e tests/TestDirectoryLoader.cpp b98247d tests/core-impl/meta/multi/CMakeLists.txt bda6387 tests/core-impl/meta/multi/TestMetaMultiTrack.h 8379bf4 tests/core-impl/meta/multi/TestMetaMultiTrack.cpp 8e9e47d tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp b25d059 tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.h 1183599 tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp 5eab2f3 tests/core-impl/playlists/types/file/xspf/TestXSPFPlaylist.cpp 5ea3a41 tests/core/playlists/CMakeLists.txt e2e0ce4 tests/core/playlists/TestPlaylistObserver.h PRE-CREATION tests/core/playlists/TestPlaylistObserver.cpp PRE-CREATION tests/playlistmanager/file/TestPlaylistFileProvider.cpp 7d0971a Diff: http://git.reviewboard.kde.org/r/107473/diff/ Testing --- 1) All unit-tests were passed. 2) For all playlists I've also checked loading and saving through gui. File Attachments Cleanups and fixes; please rebase v11 on top of current master and apply this http://git.reviewboard.kde.org/media/uploaded/files/2013/03/27/0001-Cleanups-and-fixes-for-Tatjana-s-changes_1.patch Thanks, Tatjana Gornak ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-deve
Re: Review Request 107473: Changes in processing playlist files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review30255 --- This review has been submitted with commit 6f87755c9ab292dc0c590140f133dadead7304f3 by Matěj Laitl on behalf of Tatjana Gornak to branch master. - Commit Hook On April 1, 2013, 6:57 p.m., Tatjana Gornak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107473/ > --- > > (Updated April 1, 2013, 6:57 p.m.) > > > Review request for Amarok. > > > Description > --- > > > I've started my changes with an implementation of a ASXPlaylist class, > due this work I've found that implementation of different playlist file > types has different logic, as result I end up with a rewriting > playlist's implementations. > > As example of difference: > -- Constructor M3UPlaylist::M3UPlaylist( const KUrl &url ) sets a url, but > does not load playlist, therefore loading of playlist are > posponed till data from playlist are actualy needed (lazy loading) > On the other hand constructor XSPFPlaylist::XSPFPlaylist( const > KUrl &url, bool autoAppend ) loads playlist. > > The main idea of proposed changes is to create a unify code for > processing playlist files: > -- lazy loading through LazyLoadPlaylist > -- common functionality was moved to PlaylistFile. > > It is worth to be noticed that this patch changes structure of > playlist's classes, bit does not changes their behavior, even if this behavior > is inconsistent in some cases. > > In following patch-requests I plan to submit ASX Playlist parser and > organize playlists processing in more consistent way. > > > This addresses bug 291934. > https://bugs.kde.org/show_bug.cgi?id=291934 > > > Diffs > - > > src/CMakeLists.txt 4cdee5e > src/DirectoryLoader.h e53a30d > src/DirectoryLoader.cpp bd7fa34 > src/browsers/playlistbrowser/PlaylistBrowserModel.h 1b7a44d > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 213af3b > src/context/applets/info/InfoApplet.cpp f215885 > src/core-impl/collections/ipodcollection/IpodPlaylistProvider.h 4dd79f3 > src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp > 1a4a934 > src/core-impl/playlists/types/file/PlaylistFile.h 43dfdeb > src/core-impl/playlists/types/file/PlaylistFile.cpp 2730354 > src/core-impl/playlists/types/file/PlaylistFileLoaderJob.h PRE-CREATION > src/core-impl/playlists/types/file/PlaylistFileLoaderJob.cpp PRE-CREATION > src/core-impl/playlists/types/file/PlaylistFileSupport.h b1a1c26 > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd > src/core-impl/playlists/types/file/m3u/M3UPlaylist.h 7b982fe > src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp 2395260 > src/core-impl/playlists/types/file/pls/PLSPlaylist.h e69e133 > src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp 8fe4b51 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.h 6cf33e9 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp bbcecc3 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1a025ce > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 0da9b51 > src/core/playlists/Playlist.h 018d2af > src/core/playlists/Playlist.cpp 36879a1 > src/core/playlists/PlaylistProvider.h 0fb5818 > src/playlist/PlaylistActions.cpp 00bf13a > src/playlist/PlaylistController.cpp e5bde8b > src/playlist/PlaylistRestorer.h PRE-CREATION > src/playlist/PlaylistRestorer.cpp PRE-CREATION > src/playlistmanager/PlaylistManager.h cbf65b0 > src/playlistmanager/PlaylistManager.cpp 89c754b > src/playlistmanager/SyncedPlaylist.h fce3d14 > src/playlistmanager/SyncedPlaylist.cpp 4f7c0b7 > src/playlistmanager/file/PlaylistFileProvider.cpp e4e7284 > src/playlistmanager/sql/SqlPlaylist.cpp 88e685b > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp 5eb6987 > src/services/gpodder/GpodderProvider.h 8e856e3 > tests/TestDirectoryLoader.h 0583a9e > tests/TestDirectoryLoader.cpp b98247d > tests/core-impl/meta/multi/CMakeLists.txt bda6387 > tests/core-impl/meta/multi/TestMetaMultiTrack.h 8379bf4 > tests/core-impl/meta/multi/TestMetaMultiTrack.cpp 8e9e47d > tests/core-impl/playlists/types/file/m3u/TestM3UPlaylist.cpp b25d059 > tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.h 1183599 > tests/core-impl/playlists/types/file/pls/TestPLSPlaylist.cpp 5eab2f3
Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109585/ --- (Updated March 30, 2013, 11:03 a.m.) Status -- This change has been marked as submitted. Review request for Amarok and Myriam Schweingruber. Description --- Added a label in moodbar options saying moodbar files must be generated manually. This addresses bug 289483. https://bugs.kde.org/show_bug.cgi?id=289483 Diffs - ChangeLog 284f188 src/configdialog/dialogs/GeneralConfig.ui 4e33f64 Diff: http://git.reviewboard.kde.org/r/109585/diff/ Testing --- All test case passed. File Attachments Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png Thanks, Harsh Gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109585/#review30103 --- This review has been submitted with commit d92e270ad727823580bec6d007446609d8fe0918 by Matěj Laitl on behalf of Harsh Gupta to branch master. - Commit Hook On March 28, 2013, 7:31 p.m., Harsh Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109585/ > --- > > (Updated March 28, 2013, 7:31 p.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Description > --- > > Added a label in moodbar options saying moodbar files must be generated > manually. > > > This addresses bug 289483. > https://bugs.kde.org/show_bug.cgi?id=289483 > > > Diffs > - > > ChangeLog 284f188 > src/configdialog/dialogs/GeneralConfig.ui 4e33f64 > > Diff: http://git.reviewboard.kde.org/r/109585/diff/ > > > Testing > --- > > All test case passed. > > > File Attachments > > > Screenshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/moodbar.png > > > Thanks, > > Harsh Gupta > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/ --- (Updated March 28, 2013, 8:48 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Bug 241066 - JJ: Add Signals trackStop and amarokShutdown to Amarok scripting interface Changes: 1. Added a prepareToQuit() signal to amarokWindowScript 2. Replaced kapp macro calls with App::instance() because quit() is not virtual Note: Signal trackFinished()[trackStop] already exists, so only added prepareToQuit()[amarokShutdown] Diffs - src/scriptengine/AmarokScript.cpp 922e71d src/dbus/mpris2/MediaPlayer2.cpp f86ccb3 src/scriptengine/AmarokWindowScript.h 5407579 src/dbus/mpris1/RootHandler.cpp e60eb1b src/MainWindow.cpp 66f4f76 ChangeLog 284f188 src/App.cpp fdb4255 src/scriptengine/AmarokWindowScript.cpp 897e2da Diff: http://git.reviewboard.kde.org/r/109695/diff/ Testing --- Tested the new signal in a script Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/#review30040 --- This review has been submitted with commit b0c79900429e8987c018112f875e09e565126408 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On March 27, 2013, 6:21 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109695/ > --- > > (Updated March 27, 2013, 6:21 p.m.) > > > Review request for Amarok. > > > Description > --- > > Bug 241066 - JJ: Add Signals trackStop and amarokShutdown to Amarok scripting > interface > > Changes: > 1. Added a prepareToQuit() signal to amarokWindowScript > 2. Replaced kapp macro calls with App::instance() because quit() is not > virtual > > Note: > Signal trackFinished()[trackStop] already exists, so only added > prepareToQuit()[amarokShutdown] > > > Diffs > - > > src/scriptengine/AmarokScript.cpp 922e71d > src/dbus/mpris2/MediaPlayer2.cpp f86ccb3 > src/scriptengine/AmarokWindowScript.h 5407579 > src/dbus/mpris1/RootHandler.cpp e60eb1b > src/MainWindow.cpp 66f4f76 > ChangeLog 284f188 > src/App.cpp fdb4255 > src/scriptengine/AmarokWindowScript.cpp 897e2da > > Diff: http://git.reviewboard.kde.org/r/109695/diff/ > > > Testing > --- > > Tested the new signal in a script > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109752: JJ 316128: Handle Data CDs in Amarok
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109752/ --- (Updated March 28, 2013, 8:05 p.m.) Status -- This change has been marked as submitted. Review request for Amarok. Description --- Added a check for data CDs in UmsCollection.cpp so they can be handled by UmsCollection in Amarok Diffs - ChangeLog 284f188 src/core-impl/collections/umscollection/UmsCollection.cpp 2b5c53b Diff: http://git.reviewboard.kde.org/r/109752/diff/ Testing --- Tested a data CD to see if it plays (Not tested with mixed mode disks) Environment: Ubunu 12.04 (KDE 4.8.5, udisks1) Thanks, Anmol Ahuja ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109752: JJ 316128: Handle Data CDs in Amarok
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109752/#review30035 --- This review has been submitted with commit 6dd3e1e190118dd079c7c414a44f22eaecffc5d5 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On March 27, 2013, 5:11 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109752/ > --- > > (Updated March 27, 2013, 5:11 p.m.) > > > Review request for Amarok. > > > Description > --- > > Added a check for data CDs in UmsCollection.cpp so they can be handled by > UmsCollection in Amarok > > > Diffs > - > > ChangeLog 284f188 > src/core-impl/collections/umscollection/UmsCollection.cpp 2b5c53b > > Diff: http://git.reviewboard.kde.org/r/109752/diff/ > > > Testing > --- > > Tested a data CD to see if it plays > (Not tested with mixed mode disks) > > Environment: > Ubunu 12.04 (KDE 4.8.5, udisks1) > > > Thanks, > > Anmol Ahuja > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/#review28812 --- This review has been submitted with commit 405c14ec387acfca28898494959a97ec7512efa1 by Matěj Laitl on behalf of Vedant Agarwala to branch master. - Commit Hook On March 7, 2013, 6:19 p.m., Vedant Agarwala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109283/ > --- > > (Updated March 7, 2013, 6:19 p.m.) > > > Review request for Amarok. > > > Description > --- > > Added a check-box to disable scobbling for tracks with a particular label. > The label can be selected from a drop-down list or entered manually. Any > track that contains this label is skipped from being submitted to last.fm for > being scrobbled. > > > Diffs > - > > src/services/lastfm/LastFmConfigWidget.ui 5c5e51b > src/services/lastfm/LastFmServiceConfig.h 3f33b72 > src/services/lastfm/LastFmServiceSettings.h 41b2ead > src/services/lastfm/LastFmServiceSettings.cpp f6e1564 > src/services/lastfm/ScrobblerAdapter.h ea74196 > src/services/lastfm/ScrobblerAdapter.cpp b1a09f8 > src/statsyncing/Process.cpp c42fdc4 > src/statsyncing/ScrobblingService.h 971edd7 > > Diff: http://git.reviewboard.kde.org/r/109283/diff/ > > > Testing > --- > > Builds and runs successfully. > > > File Attachments > > > screen shot of the last fm service settings > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/modifiedLastFm.png > updated settings widget > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/06/modifiedLastFm1.png > settings widget (with the correct tooltip) > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/07/modifiedLastFm5.png > > > Thanks, > > Vedant Agarwala > > ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
