Re: Review Request: Correctly read & save last track played time to/from iPods

2011-10-21 Thread Matěj Laitl

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101723/#review7528
---

Ship it!


Ship It!

- Matěj Laitl


On June 22, 2011, noon, Matěj Laitl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101723/
> ---
> 
> (Updated June 22, 2011, noon)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> This patch adds capability to store last play date/time onto iPods when 
> copying files from collection. The read capability is also tweaked to detect 
> invalid dates.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 216b200 
> 
> Diff: http://git.reviewboard.kde.org/r/101723/diff/diff
> 
> 
> Testing
> ---
> 
> Works on iPod nano 2 gen and iPod Nano 5 gen.
> 
> 
> Thanks,
> 
> Matěj Laitl
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: Review Request: Correctly read & save last track played time to/from iPods

2011-07-24 Thread Mark Kretschmann

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101723/#review5039
---

Ship it!


Great. I have an iPod Touch here, latest gen, so I could test.

I suggest pushing to Git Master, with the option of reverting it later if it 
causes problems.

- Mark


On June 22, 2011, noon, Matěj Laitl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101723/
> ---
> 
> (Updated June 22, 2011, noon)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> ---
> 
> This patch adds capability to store last play date/time onto iPods when 
> copying files from collection. The read capability is also tweaked to detect 
> invalid dates.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 216b200 
> 
> Diff: http://git.reviewboard.kde.org/r/101723/diff
> 
> 
> Testing
> ---
> 
> Works on iPod nano 2 gen and iPod Nano 5 gen.
> 
> 
> Thanks,
> 
> Matěj
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel