Re: Review Request 110036: WIP - Simple equalizer scripting
On July 2, 2013, 10:50 a.m., Mark Kretschmann wrote: Any news on this? Could you please upload the patch again? Matěj Laitl wrote: There has been no feedback for 6 months and I believe this could have been superseded by Scripting GSoC 2013 project - should this be discarded? Ok, discarding this patch as it is redundant now. - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110036/#review35436 --- On April 18, 2013, 8:03 a.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110036/ --- (Updated April 18, 2013, 8:03 a.m.) Review request for Amarok. Repository: amarok Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs - src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/EngineController.h 5de4beb Diff: https://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110036: WIP - Simple equalizer scripting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110036/ --- (Updated Jan. 5, 2014, 5:06 p.m.) Status -- This change has been discarded. Review request for Amarok. Repository: amarok Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs - src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/EngineController.h 5de4beb Diff: https://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110036: WIP - Simple equalizer scripting
On July 2, 2013, 12:50 p.m., Mark Kretschmann wrote: Any news on this? Could you please upload the patch again? There has been no feedback for 6 months and I believe this could have been superseded by Scripting GSoC 2013 project - should this be discarded? - Matěj --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110036/#review35436 --- On April 18, 2013, 10:03 a.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110036/ --- (Updated April 18, 2013, 10:03 a.m.) Review request for Amarok. Repository: amarok Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs - src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/EngineController.h 5de4beb Diff: https://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110036: WIP - Simple equalizer scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ --- (Updated April 18, 2013, 7:50 a.m.) Review request for Amarok. Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs (updated) - src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/scriptengine/AmarokEngineScript.h f1cdb8c src/EngineController.cpp 28fb256 src/EngineController.h 5de4beb Diff: http://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110036: WIP - Simple equalizer scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ --- (Updated April 18, 2013, 8:03 a.m.) Review request for Amarok. Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs (updated) - src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/EngineController.h 5de4beb Diff: http://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request 110036: WIP - Simple equalizer scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/#review31242 --- Hi, first thanks for your work. The reviewboard however says for the latest diff: Diff currently unavailable. Error: The patch to 'src/EngineController.h' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.RlKFX8' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.RlKFX8/tmpj1DP4Q patch: malformed patch at line 17: @@ -292,6 +302,26 @@ public slots: Please update the patch, checking you upload the correct one. (i.e. a difference between Amarok upstream master and the desired state; parent diff shouldn't be needed if you work on top of Amarok master) - Matěj Laitl On April 18, 2013, 8:03 a.m., Ryan McCoskrie wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ --- (Updated April 18, 2013, 8:03 a.m.) Review request for Amarok. Description --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs - src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/EngineController.h 5de4beb Diff: http://git.reviewboard.kde.org/r/110036/diff/ Testing --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Review Request 110036: WIP - Simple equalizer scripting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ --- Review request for Amarok. Summary (updated) - WIP - Simple equalizer scripting Description (updated) --- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs (updated) - src/EngineController.h 5de4beb src/EngineController.cpp 28fb256 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 4d52bbe Diff: http://git.reviewboard.kde.org/r/110036/diff/ Testing (updated) --- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
