Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Olivier Churlaud]

> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote:
> > Looks well, one minor thing below - unrelated change.
> > 
> > Also please mention:
> > BUG: 348313
> > ..in the commit message and include a ChangeLog entry in the patch.
> 
> Olivier Churlaud wrote:
> What is a changelog entry?
> 
> If I call the commit:
> ```
> Disable SSL in wikipedia applet.
> REVIEW: 128248
> BUG: 348313
> ```
> is it ok or is something missing?

Nevermind I got it.


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96755
---


On June 21, 2016, 12:17 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated June 21, 2016, 12:17 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/
---

(Updated June 21, 2016, 12:17 a.m.)


Status
--

This change has been marked as submitted.


Review request for Amarok and Myriam Schweingruber.


Changes
---

Submitted with commit 8c15258b28870b6d9990b24f87ce913e2049bac8 by Olivier 
CHURLAUD to branch master.


Bugs: 349313
https://bugs.kde.org/show_bug.cgi?id=349313


Repository: amarok


Description
---

I removed every possibility to use non SSL links


Diffs
-

  src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
  src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
  src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
  src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 

Diff: https://git.reviewboard.kde.org/r/128248/diff/


Testing
---

It compiles. However not tested, because make install always install in 
/usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to mess 
my install.


Thanks,

Olivier Churlaud

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Olivier Churlaud]

> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicDNSAudioDecoder.cpp, line 226
> > 
> >
> > This looks like an unrelated change. Please strip of a probably post as 
> > a separate patch. Applies also to the change few lines below.

Do I commit separately or do i open a review request?


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96755
---


On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated June 19, 2016, 11:44 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Matěj Laitl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96755
---



Looks well, one minor thing below - unrelated change.

Also please mention:
BUG: 348313
..in the commit message and include a ChangeLog entry in the patch.


src/musicbrainz/MusicDNSAudioDecoder.cpp (line 226)


This looks like an unrelated change. Please strip of a probably post as a 
separate patch. Applies also to the change few lines below.


- Matěj Laitl


On Čer. 19, 2016, 11:44 dop., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated Čer. 19, 2016, 11:44 dop.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Stefano Pettini]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96754
---



I verified that the patch works, there's a boolean field called useSSL left in 
WikipediaApplet_p.h that should be removed, together with the MusicBrainz file.

- Stefano Pettini


On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated June 19, 2016, 11:44 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Olivier Churlaud]

> On June 19, 2016, 12:37 p.m., Stefano Pettini wrote:
> > I'll review this patch soon. Btw there's a file, 
> > src/musicbrainz/MusicDNSAudioDecoder.cpp, that is not related to this patch.

Oh yes, but I could not compile without this change.I can put that in a second 
review


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96712
---


On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated June 19, 2016, 11:44 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

[Stefano Pettini]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96712
---



I'll review this patch soon. Btw there's a file, 
src/musicbrainz/MusicDNSAudioDecoder.cpp, that is not related to this patch.

- Stefano Pettini


On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> ---
> 
> (Updated June 19, 2016, 11:44 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> I removed every possibility to use non SSL links
> 
> 
> Diffs
> -
> 
>   src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
>   src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
>   src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
> 
> 
> Testing
> ---
> 
> It compiles. However not tested, because make install always install in 
> /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to 
> mess my install.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

Review Request 128248: Remove non SSL option for Wikipedia applet

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/
---

Review request for Amarok and Myriam Schweingruber.


Bugs: 349313
https://bugs.kde.org/show_bug.cgi?id=349313


Repository: amarok


Description
---

I removed every possibility to use non SSL links


Diffs
-

  src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0 
  src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df 
  src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc 
  src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 

Diff: https://git.reviewboard.kde.org/r/128248/diff/


Testing
---

It compiles. However not tested, because make install always install in 
/usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to mess 
my install.


Thanks,

Olivier Churlaud