Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/ --- (Updated Oct. 24, 2016, 5:43 a.m.) Status -- This change has been marked as submitted. Review request for Amarok. Changes --- Submitted with commit 0b2b243b2b70471c32d282157624379da5214051 by Alexandr Akulich to branch kf5. Repository: amarok Description --- There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : ```diff setText( i18n( "Play/Pause" ) ); -setShortcut( Qt::Key_Space ); -setGlobalShortcut( KShortcut() ); +KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); ``` The change globally binds Key_Space, which breaks the key usage for the session. Diffs - src/ActionClasses.cpp 77334fc Diff: https://git.reviewboard.kde.org/r/129055/diff/ Testing --- Compiles. Thanks, Alexandr Akulich
Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).
> On Окт. 16, 2016, 3:12 п.п., Matěj Laitl wrote: > > Looks good. Feel free to push if you have commit access. Since kf5 is a > > development branch and there are few people to review, feel free to push to > > it directly unless you explicitly want a review (perhaps for something > > controversial). Thanks for the review, I have the access and will push the commit soon. - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/#review100036 --- On Сен. 28, 2016, 1:13 д.п., Alexandr Akulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129055/ > --- > > (Updated Сен. 28, 2016, 1:13 д.п.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : > ```diff > setText( i18n( "Play/Pause" ) ); > -setShortcut( Qt::Key_Space ); > -setGlobalShortcut( KShortcut() ); > +KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); > ``` > > The change globally binds Key_Space, which breaks the key usage for the > session. > > > Diffs > - > > src/ActionClasses.cpp 77334fc > > Diff: https://git.reviewboard.kde.org/r/129055/diff/ > > > Testing > --- > > Compiles. > > > Thanks, > > Alexandr Akulich > >
Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/#review100036 --- Ship it! Looks good. Feel free to push if you have commit access. Since kf5 is a development branch and there are few people to review, feel free to push to it directly unless you explicitly want a review (perhaps for something controversial). - Matěj Laitl On Zář. 27, 2016, 10:13 odp., Alexandr Akulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129055/ > --- > > (Updated Zář. 27, 2016, 10:13 odp.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : > ```diff > setText( i18n( "Play/Pause" ) ); > -setShortcut( Qt::Key_Space ); > -setGlobalShortcut( KShortcut() ); > +KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); > ``` > > The change globally binds Key_Space, which breaks the key usage for the > session. > > > Diffs > - > > src/ActionClasses.cpp 77334fc > > Diff: https://git.reviewboard.kde.org/r/129055/diff/ > > > Testing > --- > > Compiles. > > > Thanks, > > Alexandr Akulich > >
Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/ --- Review request for Amarok. Repository: amarok Description --- There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : ```diff setText( i18n( "Play/Pause" ) ); -setShortcut( Qt::Key_Space ); -setGlobalShortcut( KShortcut() ); +KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); ``` The change globally binds Key_Space, which breaks the key usage for the session. Diffs - src/ActionClasses.cpp 77334fc Diff: https://git.reviewboard.kde.org/r/129055/diff/ Testing --- Compiles. Thanks, Alexandr Akulich
