Review Request: Update Amarok to work with Cagibi >= 0.2.0 D-BUS API
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102384/ --- Review request for Amarok and Bart Cerneels. Summary --- Cagibi 0.2.0 changed the D-BUS API including method locations and the return format of deviceDetails. At the same time, since Amarok still has KDE 4.4 as the lowest requirement, Cagibi 0.1.0 compatibility is required. This patch adds support for both versions Diffs - src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h f36030e src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 9fdaa45 src/core-impl/collections/upnpcollection/dbuscodec.h 158896e src/core-impl/collections/upnpcollection/dbuscodec.cpp b6842cb src/core-impl/collections/upnpcollection/deviceinfo.h 00b5b7f Diff: http://git.reviewboard.kde.org/r/102384/diff Testing --- Tested with one device, on both Cagibi 0.1.1 and 0.2.0 Thanks, Nikhil Shantanu ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Add new collection filter to find exact matches
On Mon, Aug 8, 2011 at 8:08 PM, Daniel Faust wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102252/ > Review request for Amarok. > By Daniel Faust. > Description > > Since I use labels quite intensive it sometimes comes handy to search for > songs with an exact label, not just a label containing the string I'm > searching for. > So I added a new filter type for this and used the '=' sign. > > Searching for label=pop finds songs labeled with 'pop' but not with 'electro > pop'. > While searching for label:pop finds songs labeled with 'pop' and 'electro > pop'. > > This is not integrated into the GUI like the EditFilterDialog since I wanted > to hear your opinions first. > > Testing > > I'm using this patch for a few weeks now without any problems. > > > This seems like a pretty useful feature and the change is small and clean, could someone more knowledgeable take a look so it could be added to the edit filter dialog. Nikhil ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Add new collection filter to find exact matches
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, > This seems like a pretty useful feature and the change is small and > clean, could someone more knowledgeable take a look so it could be > added to the edit filter dialog. The Feature looks usefull, didn't look at the Sourcecode. But I find it a little bit non-intuitive. OK most user would use it via the Dialog anyway, but label: vs. label= doesn't sound intuitive to me. Maybe we should make this a bigger change, what about: label:pop vs. label:"pop" The first would find all that contain pop, the second one only pop. Like Google Searches where you can put quotes around it to search for the exact order of words. Or is there already a difference in Amarok how it handels "foo" vs. foo in the edit filter? Stefan P.S.: In a side-note, do more People find the current Edit Filter Dialog confusing? ;) -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk5PoJEACgkQlZvAMV/NgGK+xACfUjtDI+njrhCEberd3ECDLAjs K+UAnjRZuQSO+P9CxfmugtRqKFXh/Fwk =42cp -END PGP SIGNATURE- ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Add new collection filter to find exact matches
On Sat, Aug 20, 2011 at 5:24 PM, Stefan Derkits wrote: > Maybe we should make this a bigger change, what about: > > label:pop vs. label:"pop" > > The first would find all that contain pop, the second one only pop. > Like Google Searches where you can put quotes around it to search for > the exact order of words. > > Or is there already a difference in Amarok how it handels "foo" vs. > foo in the edit filter? Quotes are already used to treat space seperated words as a whole ie artist: "Arctic Monkeys" still does a contains match what about label: ="Arctic Monkeys"? Nikhil ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: Add new collection filter to find exact matches
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey, > Quotes are already used to treat space seperated words as a whole > > ie artist: "Arctic Monkeys" still does a contains match > > what about label: ="Arctic Monkeys"? Sure it does, but what would be the use case? Search for artist:Arctic Monkeys to find everything by the Artist Arctic that also contains as Artist or Songtitle or Albumtitle the Name Monkeys ... don't know ... maybe we could change the Tokenizer of the Search Box to treat everything that has "word:" in front as new token? Are there some specifications/standards out there how Search Terms should look? ;) Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk5PpesACgkQlZvAMV/NgGK4XACfV2dZyRezEVpDabS6bogpyKvA 2eEAoICTER1CfOlL6bBP6F1nE+k2fhmD =N9HN -END PGP SIGNATURE- ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
