D11299: Fixed a crash in magnatune service

[Malte Veerman]

malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  This fixes a crash in the magnatune service introduced by revision 


REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11299

AFFECTED FILES
  src/services/magnatune/MagnatuneXmlParser.cpp

To: malteveerman, #amarok
Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11171: Port NetworkAccessManager to new signal/slot syntax

[Malte Veerman]

malteveerman updated this revision to Diff 29438.
malteveerman added a comment.


  Previous diff relied on a function of QMetaObject added in Qt 5.10. This now 
works with older versions of Qt, too.

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11171?vs=29063=29438

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11171

AFFECTED FILES
  src/context/applets/photos/plugin/PhotosEngine.cpp
  src/covermanager/CoverFetcher.cpp
  src/covermanager/CoverFoundDialog.cpp
  src/network/NetworkAccessManagerProxy.cpp
  src/network/NetworkAccessManagerProxy.h
  src/scripting/scriptengine/AmarokNetworkScript.cpp
  src/scripting/scriptengine/AmarokNetworkScript.h
  src/services/ampache/AmpacheAccountLogin.cpp
  src/services/ampache/AmpacheServiceQueryMaker.cpp

To: malteveerman, #amarok, markey
Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11171: Port NetworkAccessManager to new signal/slot syntax

[Mark Kretschmann]

markey requested changes to this revision.
markey added a comment.
This revision now requires changes to proceed.


  This does not build for me (GCC 7.2.0).
  
  Error: https://pastebin.com/5Pmk1ELp

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11171

To: malteveerman, #amarok, markey
Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11192: Ported playdar collection away from qjson

[Mark Kretschmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R181:16d4997c3792: Ported playdar collection away from qjson 
(authored by malteveerman, committed by markey).

REPOSITORY
  R181 Amarok

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11192?vs=29167=29431

REVISION DETAIL
  https://phabricator.kde.org/D11192

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindQJSON.cmake
  src/core-impl/collections/CMakeLists.txt
  src/core-impl/collections/playdarcollection/CMakeLists.txt
  src/core-impl/collections/playdarcollection/PlaydarCollection.cpp
  
src/core-impl/collections/playdarcollection/amarok_collection-playdarcollection.desktop
  src/core-impl/collections/playdarcollection/support/Controller.cpp
  src/core-impl/collections/playdarcollection/support/Query.cpp

To: malteveerman, #amarok, markey
Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11192: Ported playdar collection away from qjson

[Mark Kretschmann]

markey accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11192

To: malteveerman, #amarok, markey
Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, 
tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker