Re: [PATCH] PCI: Add vf reset notification for pf

[Keith Busch]

On Sun, Feb 04, 2024 at 02:12:57PM +0800, Emily Deng wrote:
> @@ -926,6 +926,7 @@ struct pci_driver {
>   int  (*sriov_configure)(struct pci_dev *dev, int num_vfs); /* On PF */
>   int  (*sriov_set_msix_vec_count)(struct pci_dev *vf, int 
> msix_vec_count); /* On PF */
>   u32  (*sriov_get_vf_total_msix)(struct pci_dev *pf);
> + void  (*sriov_vf_reset_notification)(struct pci_dev *pf, struct pci_dev 
> *vf);

You've created a new callback, but there is no user. Could you resubmit
this with an in-kernel use case?

Re: [PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()

[Keith Busch]

On Thu, Aug 01, 2019 at 07:19:57PM -0700, john.hubb...@gmail.com wrote:
> From: John Hubbard 
> 
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
> 
> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: introduce put_user_page*(), placeholder versions").
> 
> Cc: Dan Carpenter 
> Cc: Greg Kroah-Hartman 
> Cc: Keith Busch 
> Cc: Kirill A. Shutemov 
> Cc: Michael S. Tsirkin 
> Cc: YueHaibing 
> Signed-off-by: John Hubbard 

Looks fine.

Reviewed-by: Keith Busch 

>  mm/gup_benchmark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c
> index 7dd602d7f8db..515ac8eeb6ee 100644
> --- a/mm/gup_benchmark.c
> +++ b/mm/gup_benchmark.c
> @@ -79,7 +79,7 @@ static int __gup_benchmark_ioctl(unsigned int cmd,
>   for (i = 0; i < nr_pages; i++) {
>   if (!pages[i])
>   break;
> - put_page(pages[i]);
> + put_user_page(pages[i]);
>   }
>   end_time = ktime_get();
>   gup->put_delta_usec = ktime_us_delta(end_time, start_time);
> -- 
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx