Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
On Thu, Aug 16, 2018 at 9:56 PM Leo Li wrote: > On 2018-08-11 11:54 AM, Arnd Bergmann wrote: > > > > I tried implementing the two functions in KCOV: __sanitizer_cov_trace_cmpd > > and __sanitizer_cov_trace_cmpf, but that fails to build on architectures > > that do not support any floating-point functions, or would require making > > that code x86 specific as well. I also looked at what it would take to > > Hi Arnd, > > Is there a reason why we can't make __sanitizer_cov_trace_cmpd and > __sanitizer_cov_trace_cmpf X86 dependent? > > I sent out two patches to disable DCN1, but would prefer implementing > these two functions as opposed to disabling a component. I think it should be possible to implement them, perhaps not even hard to do it in an architecture independent way. I tried this at some point and couldn't figure it out, but I suppose it would fix the problem nicely. This would assume that the two functions can only ever be called from a context that already has access to the fpu, which I think is the case here. Arnd ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
allmodconfig/allyesconfig doesn't work with Kernel 4.18 - Was: Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
Em Sat, 11 Aug 2018 17:54:12 +0200 Arnd Bergmann escreveu: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > `dcn_bw_calc_rq_dlg_ttu': > dcn_calcs.c:(.text+0x263): undefined reference to `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > `hack_force_pipe_split': > dcn_calcs.c:(.text+0x155b): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > `dcn_find_dcfclk_suits_all': > dcn_calcs.c:(.text+0x190e): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > `dcn_validate_bandwidth': > dcn_calcs.c:(.text+0xe121): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_mod': > dcn_calc_math.c:(.text+0x22): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_min2': > dcn_calc_math.c:(.text+0xb2): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_ceil2': > dcn_calc_math.c:(.text+0x2a0): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_max3': > dcn_calc_math.c:(.text+0x325): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_max5': > dcn_calc_math.c:(.text+0x3c3): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > `dcn_bw_log': > dcn_calc_math.c:(.text+0x54e): undefined reference to > `__sanitizer_cov_trace_cmpd' > dcn_calc_math.c:(.text+0x57c): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `scaler_settings_calculation': > dcn_calc_auto.c:(.text+0x5c5): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `mode_support_and_system_configuration': > dcn_calc_auto.c:(.text+0x137c): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `mode_support_and_system_configuration': > dcn_calc_auto.c:(.text+0x9233): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `mode_support_and_system_configuration': > dcn_calc_auto.c:(.text+0xb70f): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `mode_support_and_system_configuration': > dcn_calc_auto.c:(.text+0x121fd): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `display_pipe_configuration': > dcn_calc_auto.c:(.text+0x15a2f): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > dcn_calc_auto.c:(.text+0x17c2d): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > dcn_calc_auto.c:(.text+0x19362): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > dcn_calc_auto.c:(.text+0x25575): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > dcn_calc_auto.c:(.text+0x27f33): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function > `get_refcyc_per_delivery': > display_rq_dlg_calc.c:(.text+0xb5): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function > `calculate_ttu_cursor.isra.1': > display_rq_dlg_calc.c:(.text+0x9f6): undefined reference to > `__sanitizer_cov_trace_cmpd' > drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function > `dml_rq_dlg_get_dlg_params': > display_rq_dlg_calc.c:(.text+0x82cc): undefined reference to > `__sanitizer_cov_trace_cmpf' > drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.o: In function >
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
On Tue, Aug 14, 2018 at 10:54 AM Michel Dänzer wrote:
>
> On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
> > On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher wrote:
> >>
> >> On Sun, Aug 12, 2018 at 3:55 AM Christian König
> >> wrote:
> >>> Adding Harry as well.
> >>> Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
>
> Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
> Fixes: 4841203102a3 ("drm/amdgpu/display: Replace
> CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86")
> >>
> >> Maybe it would be better to revert 4841203102a3 so we can limit the
> >> scope of this to DCN support.
> >
> > That would help, but we would still require the patch at
> > https://patchwork.kernel.org/patch/10090227/ or something else to avoid
> > broken randconfig builds.
>
> FWIW, please don't revert 4841203102a3 in a way which allows
> CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
> is reinstated, it should be strictly derived from other options, not
> changeable by the user.
How about making all of AMDGPU depend on
" !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) || BROKEN"
then?
Arnd
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
Am 14.08.2018 um 11:15 schrieb Arnd Bergmann:
On Tue, Aug 14, 2018 at 10:54 AM Michel Dänzer wrote:
On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher wrote:
On Sun, Aug 12, 2018 at 3:55 AM Christian König
wrote:
Adding Harry as well.
Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
Fixes: 4841203102a3 ("drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with
CONFIG_X86")
Maybe it would be better to revert 4841203102a3 so we can limit the
scope of this to DCN support.
That would help, but we would still require the patch at
https://patchwork.kernel.org/patch/10090227/ or something else to avoid
broken randconfig builds.
FWIW, please don't revert 4841203102a3 in a way which allows
CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
is reinstated, it should be strictly derived from other options, not
changeable by the user.
How about making all of AMDGPU depend on
" !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) || BROKEN"
then?
Well, certainly not a good idea.
We don't want to disable the whole driver just because one broken component.
Christian.
Arnd
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
> On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher wrote:
>>
>> On Sun, Aug 12, 2018 at 3:55 AM Christian König
>> wrote:
>>> Adding Harry as well.
>>> Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
Fixes: 4841203102a3 ("drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0
with CONFIG_X86")
>>
>> Maybe it would be better to revert 4841203102a3 so we can limit the
>> scope of this to DCN support.
>
> That would help, but we would still require the patch at
> https://patchwork.kernel.org/patch/10090227/ or something else to avoid
> broken randconfig builds.
FWIW, please don't revert 4841203102a3 in a way which allows
CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
is reinstated, it should be strictly derived from other options, not
changeable by the user.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher wrote:
>
> On Sun, Aug 12, 2018 at 3:55 AM Christian König
> wrote:
> > Adding Harry as well.
> > Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
> > >
> > > Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
> > > Fixes: 4841203102a3 ("drm/amdgpu/display: Replace
> > > CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86")
>
> Maybe it would be better to revert 4841203102a3 so we can limit the
> scope of this to DCN support.
That would help, but we would still require the patch at
https://patchwork.kernel.org/patch/10090227/ or something else to avoid
broken randconfig builds.
Arnd
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
On Sun, Aug 12, 2018 at 3:55 AM Christian König wrote: > > Adding Harry as well. > > Am 11.08.2018 um 17:54 schrieb Arnd Bergmann: > > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many > > functions > > that do a comparison of floating-point variables: > > > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > > `dcn_bw_calc_rq_dlg_ttu': > > dcn_calcs.c:(.text+0x263): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > > `hack_force_pipe_split': > > dcn_calcs.c:(.text+0x155b): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > > `dcn_find_dcfclk_suits_all': > > dcn_calcs.c:(.text+0x190e): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function > > `dcn_validate_bandwidth': > > dcn_calcs.c:(.text+0xe121): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_mod': > > dcn_calc_math.c:(.text+0x22): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_min2': > > dcn_calc_math.c:(.text+0xb2): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_ceil2': > > dcn_calc_math.c:(.text+0x2a0): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_max3': > > dcn_calc_math.c:(.text+0x325): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_max5': > > dcn_calc_math.c:(.text+0x3c3): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function > > `dcn_bw_log': > > dcn_calc_math.c:(.text+0x54e): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > dcn_calc_math.c:(.text+0x57c): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `scaler_settings_calculation': > > dcn_calc_auto.c:(.text+0x5c5): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `mode_support_and_system_configuration': > > dcn_calc_auto.c:(.text+0x137c): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `mode_support_and_system_configuration': > > dcn_calc_auto.c:(.text+0x9233): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `mode_support_and_system_configuration': > > dcn_calc_auto.c:(.text+0xb70f): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `mode_support_and_system_configuration': > > dcn_calc_auto.c:(.text+0x121fd): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `display_pipe_configuration': > > dcn_calc_auto.c:(.text+0x15a2f): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > > dcn_calc_auto.c:(.text+0x17c2d): undefined reference to > > `__sanitizer_cov_trace_cmpf' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > > dcn_calc_auto.c:(.text+0x19362): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > > dcn_calc_auto.c:(.text+0x25575): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function > > `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': > > dcn_calc_auto.c:(.text+0x27f33): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function > > `get_refcyc_per_delivery': > > display_rq_dlg_calc.c:(.text+0xb5): undefined reference to > > `__sanitizer_cov_trace_cmpd' > > drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function > > `calculate_ttu_cursor.isra.1': > > display_rq_dlg_calc.c:(.text+0x9f6): undefined reference to > > `__sanitizer_cov_trace_cmpd' > >
[PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions that do a comparison of floating-point variables: drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_bw_calc_rq_dlg_ttu': dcn_calcs.c:(.text+0x263): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `hack_force_pipe_split': dcn_calcs.c:(.text+0x155b): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_find_dcfclk_suits_all': dcn_calcs.c:(.text+0x190e): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_validate_bandwidth': dcn_calcs.c:(.text+0xe121): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_mod': dcn_calc_math.c:(.text+0x22): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_min2': dcn_calc_math.c:(.text+0xb2): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_ceil2': dcn_calc_math.c:(.text+0x2a0): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_max3': dcn_calc_math.c:(.text+0x325): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_max5': dcn_calc_math.c:(.text+0x3c3): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_log': dcn_calc_math.c:(.text+0x54e): undefined reference to `__sanitizer_cov_trace_cmpd' dcn_calc_math.c:(.text+0x57c): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `scaler_settings_calculation': dcn_calc_auto.c:(.text+0x5c5): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x137c): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x9233): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0xb70f): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x121fd): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `display_pipe_configuration': dcn_calc_auto.c:(.text+0x15a2f): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x17c2d): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x19362): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x25575): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x27f33): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `get_refcyc_per_delivery': display_rq_dlg_calc.c:(.text+0xb5): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `calculate_ttu_cursor.isra.1': display_rq_dlg_calc.c:(.text+0x9f6): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `dml_rq_dlg_get_dlg_params': display_rq_dlg_calc.c:(.text+0x82cc): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.o: In function `get_refcyc_per_delivery.isra.0': dml1_display_rq_dlg_calc.c:(.text+0x6c4): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.o: In function `get_vratio_pre.isra.2': dml1_display_rq_dlg_calc.c:(.text+0x957):
Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
Adding Harry as well. Am 11.08.2018 um 17:54 schrieb Arnd Bergmann: Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions that do a comparison of floating-point variables: drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_bw_calc_rq_dlg_ttu': dcn_calcs.c:(.text+0x263): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `hack_force_pipe_split': dcn_calcs.c:(.text+0x155b): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_find_dcfclk_suits_all': dcn_calcs.c:(.text+0x190e): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.o: In function `dcn_validate_bandwidth': dcn_calcs.c:(.text+0xe121): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_mod': dcn_calc_math.c:(.text+0x22): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_min2': dcn_calc_math.c:(.text+0xb2): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_ceil2': dcn_calc_math.c:(.text+0x2a0): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_max3': dcn_calc_math.c:(.text+0x325): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_max5': dcn_calc_math.c:(.text+0x3c3): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.o: In function `dcn_bw_log': dcn_calc_math.c:(.text+0x54e): undefined reference to `__sanitizer_cov_trace_cmpd' dcn_calc_math.c:(.text+0x57c): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `scaler_settings_calculation': dcn_calc_auto.c:(.text+0x5c5): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x137c): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x9233): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0xb70f): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `mode_support_and_system_configuration': dcn_calc_auto.c:(.text+0x121fd): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `display_pipe_configuration': dcn_calc_auto.c:(.text+0x15a2f): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x17c2d): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x19362): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x25575): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.o: In function `dispclkdppclkdcfclk_deep_sleep_prefetch_parameters_watermarks_and_performance_calculation': dcn_calc_auto.c:(.text+0x27f33): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `get_refcyc_per_delivery': display_rq_dlg_calc.c:(.text+0xb5): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `calculate_ttu_cursor.isra.1': display_rq_dlg_calc.c:(.text+0x9f6): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.o: In function `dml_rq_dlg_get_dlg_params': display_rq_dlg_calc.c:(.text+0x82cc): undefined reference to `__sanitizer_cov_trace_cmpf' drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.o: In function `get_refcyc_per_delivery.isra.0': dml1_display_rq_dlg_calc.c:(.text+0x6c4): undefined reference to `__sanitizer_cov_trace_cmpd' drivers/gpu/drm/amd/display/dc/dml/dml1_display_rq_dlg_calc.o: In function
