Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-28 Thread Jason Yan 

ping...

在 2020/9/12 10:22, Jason Yan 写道:

The 'trigger_hotplug' entry in debugfs is defined but not wired up. This
causes a gcc warning build with W=1.

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37:
warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used
[-Wunused-const-variable=]
  2045 | static const struct file_operations
   dp_trigger_hotplug_debugfs_fops = {
   |
^~~

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 94fcb086154c..972c780b6293 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -2115,6 +2115,7 @@ static const struct {
{"dsc_pic_height", _dsc_pic_height_debugfs_fops},
{"dsc_chunk_size", _dsc_chunk_size_debugfs_fops},
{"dsc_slice_bpg", _dsc_slice_bpg_offset_debugfs_fops},
+   {"trigger_hotplug", _trigger_hotplug_debugfs_fops},
{"dp_dsc_fec_support", _dsc_fec_support_fops}
  };
  


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-28 Thread Harry Wentland 
On 2020-09-28 10:06 a.m., Jason Yan wrote:
> ping...
> 

Fix by YueHaibing is already merged for this:

commit 73b1acd54e13686fbb002afdf892c670177f0c57
Author: YueHaibing 
Date:   Thu Sep 10 11:13:52 2020 +0800

drm/amd/display: Create trigger_hotplug entry

Add trigger_hotplug debugfs entry.

Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger
debugfs entry")
Reviewed-by: Harry Wentland 
Signed-off-by: YueHaibing 
Signed-off-by: Alex Deucher 

Harry

> 在 2020/9/12 10:22, Jason Yan 写道:
>> The 'trigger_hotplug' entry in debugfs is defined but not wired up. This
>> causes a gcc warning build with W=1.
>>
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37:
>>
>> warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used
>> [-Wunused-const-variable=]
>>   2045 | static const struct file_operations
>>    dp_trigger_hotplug_debugfs_fops = {
>>    |
>> ^~~
>>
>> Reported-by: Hulk Robot 
>> Signed-off-by: Jason Yan 
>> ---
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> index 94fcb086154c..972c780b6293 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
>> @@ -2115,6 +2115,7 @@ static const struct {
>>   {"dsc_pic_height", _dsc_pic_height_debugfs_fops},
>>   {"dsc_chunk_size", _dsc_chunk_size_debugfs_fops},
>>   {"dsc_slice_bpg", _dsc_slice_bpg_offset_debugfs_fops},
>> +    {"trigger_hotplug", _trigger_hotplug_debugfs_fops},
>>   {"dp_dsc_fec_support", _dsc_fec_support_fops}
>>   };
>>  
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-13 Thread Jason Yan 
The 'trigger_hotplug' entry in debugfs is defined but not wired up. This
causes a gcc warning build with W=1.

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37:
warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used
[-Wunused-const-variable=]
 2045 | static const struct file_operations
  dp_trigger_hotplug_debugfs_fops = {
  |
^~~

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 94fcb086154c..972c780b6293 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -2115,6 +2115,7 @@ static const struct {
{"dsc_pic_height", _dsc_pic_height_debugfs_fops},
{"dsc_chunk_size", _dsc_chunk_size_debugfs_fops},
{"dsc_slice_bpg", _dsc_slice_bpg_offset_debugfs_fops},
+   {"trigger_hotplug", _trigger_hotplug_debugfs_fops},
{"dp_dsc_fec_support", _dsc_fec_support_fops}
 };
 
-- 
2.25.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx