Re: [PATCH] drm/amd/display: remove unneeded semicolon
Applied. Thanks! Alex On Tue, Oct 27, 2020 at 4:07 PM wrote: > > From: Tom Rix > > A semicolon is not needed after a switch statement. > > Signed-off-by: Tom Rix > --- > drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > index 7b4b2304bbff..5feb804af4be 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > @@ -858,7 +858,7 @@ static struct clock_source *find_matching_pll( > return pool->clock_sources[DCE112_CLK_SRC_PLL5]; > default: > return NULL; > - }; > + } > > return 0; > } > diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c > b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c > index fb6a19d020f9..ee5230ccf3c4 100644 > --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c > +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c > @@ -280,6 +280,6 @@ char *mod_hdcp_state_id_to_str(int32_t id) > return "D2_A9_VALIDATE_STREAM_READY"; > default: > return "UNKNOWN_STATE_ID"; > - }; > + } > } > > -- > 2.18.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amd/display: remove unneeded semicolon
From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c index 7b4b2304bbff..5feb804af4be 100644 --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c @@ -858,7 +858,7 @@ static struct clock_source *find_matching_pll( return pool->clock_sources[DCE112_CLK_SRC_PLL5]; default: return NULL; - }; + } return 0; } diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c index fb6a19d020f9..ee5230ccf3c4 100644 --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c @@ -280,6 +280,6 @@ char *mod_hdcp_state_id_to_str(int32_t id) return "D2_A9_VALIDATE_STREAM_READY"; default: return "UNKNOWN_STATE_ID"; - }; + } } -- 2.18.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amd/display: Remove unneeded semicolon
On Mon, Dec 16, 2019 at 9:32 AM Harry Wentland wrote: > > On 2019-12-14 4:12 a.m., zhengbin wrote: > > Fixes coccicheck warning: > > > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: > > Unneeded semicolon > > > > Reported-by: Hulk Robot > > Signed-off-by: zhengbin > > Reviewed-by: Harry Wentland > Applied. Thanks! Alex > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > > b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > > index de51ef1..a1b7e76 100644 > > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > > @@ -409,7 +409,7 @@ void build_watermark_ranges(struct clk_bw_params > > *bw_params, struct pp_smu_wm_ra > > continue; > > > > ranges->reader_wm_sets[num_valid_sets].wm_inst = > > bw_params->wm_table.entries[i].wm_inst; > > - ranges->reader_wm_sets[num_valid_sets].wm_type = > > bw_params->wm_table.entries[i].wm_type;; > > + ranges->reader_wm_sets[num_valid_sets].wm_type = > > bw_params->wm_table.entries[i].wm_type; > > /* We will not select WM based on dcfclk, so leave it as > > unconstrained */ > > ranges->reader_wm_sets[num_valid_sets].min_drain_clk_mhz = > > PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MIN; > > ranges->reader_wm_sets[num_valid_sets].max_drain_clk_mhz = > > PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; > > -- > > 2.7.4 > > > ___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amd/display: Remove unneeded semicolon
On 2019-12-14 4:12 a.m., zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: Unneeded > semicolon > > Reported-by: Hulk Robot > Signed-off-by: zhengbin Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > index de51ef1..a1b7e76 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c > @@ -409,7 +409,7 @@ void build_watermark_ranges(struct clk_bw_params > *bw_params, struct pp_smu_wm_ra > continue; > > ranges->reader_wm_sets[num_valid_sets].wm_inst = > bw_params->wm_table.entries[i].wm_inst; > - ranges->reader_wm_sets[num_valid_sets].wm_type = > bw_params->wm_table.entries[i].wm_type;; > + ranges->reader_wm_sets[num_valid_sets].wm_type = > bw_params->wm_table.entries[i].wm_type; > /* We will not select WM based on dcfclk, so leave it as > unconstrained */ > ranges->reader_wm_sets[num_valid_sets].min_drain_clk_mhz = > PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MIN; > ranges->reader_wm_sets[num_valid_sets].max_drain_clk_mhz = > PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; > -- > 2.7.4 > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amd/display: Remove unneeded semicolon
Fixes coccicheck warning: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c index de51ef1..a1b7e76 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c @@ -409,7 +409,7 @@ void build_watermark_ranges(struct clk_bw_params *bw_params, struct pp_smu_wm_ra continue; ranges->reader_wm_sets[num_valid_sets].wm_inst = bw_params->wm_table.entries[i].wm_inst; - ranges->reader_wm_sets[num_valid_sets].wm_type = bw_params->wm_table.entries[i].wm_type;; + ranges->reader_wm_sets[num_valid_sets].wm_type = bw_params->wm_table.entries[i].wm_type; /* We will not select WM based on dcfclk, so leave it as unconstrained */ ranges->reader_wm_sets[num_valid_sets].min_drain_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MIN; ranges->reader_wm_sets[num_valid_sets].max_drain_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; -- 2.7.4 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
