Re: [PATCH] drm/amd/display : Log DP link training failure reason

[Leo]

On 2022-06-23 12:48, Alex Deucher wrote:
> On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj
>  wrote:
>>
>> [Why]
>> Existing logs doesn't print DP LT failure reason
>>
>> [How]
>> Update the existing log with DP LT failure reason
>>
>> Signed-off-by: Chandan Vurdigere Nataraj 
> 
> Acked-by: Alex Deucher 

Reviewed-by: Leo Li 

> 
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c 
>> b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> index 4027f439a5a4..c8355acd3672 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
>> @@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
>> break;
>> }
>>
>> -   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d 
>> failed @ rate(%d) x lane(%d)\n",
>> +   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d 
>> failed @ rate(%d) x lane(%d) : fail reason:(%d)\n",
>> __func__, link->link_index, (unsigned int)j + 1, 
>> attempts, cur_link_settings.link_rate,
>> -   cur_link_settings.lane_count);
>> +   cur_link_settings.lane_count, status);
>>
>> dp_disable_link_phy(link, _ctx->link_res, signal);
>>
>> --
>> 2.25.1
>>

Re: [PATCH] drm/amd/display : Log DP link training failure reason

[Alex Deucher]

On Thu, Jun 23, 2022 at 3:33 AM Chandan Vurdigere Nataraj
 wrote:
>
> [Why]
> Existing logs doesn't print DP LT failure reason
>
> [How]
> Update the existing log with DP LT failure reason
>
> Signed-off-by: Chandan Vurdigere Nataraj 

Acked-by: Alex Deucher 

>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c 
> b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 4027f439a5a4..c8355acd3672 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
> break;
> }
>
> -   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed 
> @ rate(%d) x lane(%d)\n",
> +   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed 
> @ rate(%d) x lane(%d) : fail reason:(%d)\n",
> __func__, link->link_index, (unsigned int)j + 1, 
> attempts, cur_link_settings.link_rate,
> -   cur_link_settings.lane_count);
> +   cur_link_settings.lane_count, status);
>
> dp_disable_link_phy(link, _ctx->link_res, signal);
>
> --
> 2.25.1
>

[PATCH] drm/amd/display : Log DP link training failure reason

[Chandan Vurdigere Nataraj]

[Why]
Existing logs doesn't print DP LT failure reason

[How]
Update the existing log with DP LT failure reason

Signed-off-by: Chandan Vurdigere Nataraj 

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c 
b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 4027f439a5a4..c8355acd3672 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -2786,9 +2786,9 @@ bool perform_link_training_with_retries(
break;
}
 
-   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ 
rate(%d) x lane(%d)\n",
+   DC_LOG_WARNING("%s: Link(%d) training attempt %u of %d failed @ 
rate(%d) x lane(%d) : fail reason:(%d)\n",
__func__, link->link_index, (unsigned int)j + 1, 
attempts, cur_link_settings.link_rate,
-   cur_link_settings.lane_count);
+   cur_link_settings.lane_count, status);
 
dp_disable_link_phy(link, _ctx->link_res, signal);
 
-- 
2.25.1