RE: [PATCH] drm/amd/pm: remove the average clock value in sysfs

2020-10-21 Thread Gao, Likun
[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Likun Gao 

Regards,
Likun

-Original Message-
From: Kenneth Feng  
Sent: Wednesday, October 21, 2020 5:33 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Feng, Kenneth 
Subject: [PATCH] drm/amd/pm: remove the average clock value in sysfs

if it's fine-grained clock dpm, remove the average clock value and reflects the 
real clock.

Signed-off-by: Kenneth Feng 
---
 .../gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c  | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index d2851f8e9c11..fa3842f460fc 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -955,12 +955,16 @@ static int sienna_cichlid_print_clk_levels(struct 
smu_context *smu,
freq_values[1] = cur_value;
mark_index = cur_value == freq_values[0] ? 0 :
 cur_value == freq_values[2] ? 2 : 1;
-   if (mark_index != 1)
-   freq_values[1] = (freq_values[0] + 
freq_values[2]) / 2;
 
-   for (i = 0; i < 3; i++) {
+   count = 3;
+   if (mark_index != 1) {
+   count = 2;
+   freq_values[1] = freq_values[2];
+   }
+
+   for (i = 0; i < count; i++) {
size += sprintf(buf + size, "%d: %uMhz %s\n", 
i, freq_values[i],
-   i == mark_index ? "*" : "");
+   cur_value  == freq_values[i] ? 
"*" : "");
}
 
}
--
2.17.1
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amd/pm: remove the average clock value in sysfs

2020-10-21 Thread Kenneth Feng
if it's fine-grained clock dpm, remove the average clock value and
reflects the real clock.

Signed-off-by: Kenneth Feng 
---
 .../gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c  | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index d2851f8e9c11..fa3842f460fc 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -955,12 +955,16 @@ static int sienna_cichlid_print_clk_levels(struct 
smu_context *smu,
freq_values[1] = cur_value;
mark_index = cur_value == freq_values[0] ? 0 :
 cur_value == freq_values[2] ? 2 : 1;
-   if (mark_index != 1)
-   freq_values[1] = (freq_values[0] + 
freq_values[2]) / 2;
 
-   for (i = 0; i < 3; i++) {
+   count = 3;
+   if (mark_index != 1) {
+   count = 2;
+   freq_values[1] = freq_values[2];
+   }
+
+   for (i = 0; i < count; i++) {
size += sprintf(buf + size, "%d: %uMhz %s\n", 
i, freq_values[i],
-   i == mark_index ? "*" : "");
+   cur_value  == freq_values[i] ? 
"*" : "");
}
 
}
-- 
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx