RE: [PATCH] drm/amd/powerplay: grant Arcturus softmin/max setting on latest PM firmware

2020-08-04 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Kenneth Feng 


-Original Message-
From: Quan, Evan  
Sent: Wednesday, August 5, 2020 11:24 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Feng, Kenneth 
; Quan, Evan 
Subject: [PATCH] drm/amd/powerplay: grant Arcturus softmin/max setting on 
latest PM firmware

For Arcturus, the softmin/max settings from driver are permitted on the
latest(54.26 later) SMU firmware. Thus enabling them in driver.

Change-Id: Iff9ac326610075aa7f61cb89c64d2c4128678755
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c 
b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index a2ba6633fc21..73de3c013834 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -942,9 +942,10 @@ static int arcturus_force_clk_levels(struct smu_context 
*smu,
return ret;
}
 
-   if (smu_version >= 0x361200) {
+   if ((smu_version >= 0x361200) &&
+   (smu_version <= 0x361a00)) {
dev_err(smu->adev->dev, "Forcing clock level is not supported 
with "
-  "54.18 and onwards SMU firmwares\n");
+  "54.18 - 54.26(included) SMU firmwares\n");
return -EOPNOTSUPP;
}
 
@@ -1437,9 +1438,10 @@ static int arcturus_set_performance_level(struct 
smu_context *smu,
case AMD_DPM_FORCED_LEVEL_PROFILE_MIN_SCLK:
case AMD_DPM_FORCED_LEVEL_PROFILE_MIN_MCLK:
case AMD_DPM_FORCED_LEVEL_PROFILE_PEAK:
-   if (smu_version >= 0x361200) {
+   if ((smu_version >= 0x361200) &&
+   (smu_version <= 0x361a00)) {
dev_err(smu->adev->dev, "Forcing clock level is not 
supported with "
-  "54.18 and onwards SMU firmwares\n");
+  "54.18 - 54.26(included) SMU firmwares\n");
return -EOPNOTSUPP;
}
break;
-- 
2.28.0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amd/powerplay: grant Arcturus softmin/max setting on latest PM firmware

2020-08-04 Thread Evan Quan
For Arcturus, the softmin/max settings from driver are permitted on the
latest(54.26 later) SMU firmware. Thus enabling them in driver.

Change-Id: Iff9ac326610075aa7f61cb89c64d2c4128678755
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c 
b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index a2ba6633fc21..73de3c013834 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -942,9 +942,10 @@ static int arcturus_force_clk_levels(struct smu_context 
*smu,
return ret;
}
 
-   if (smu_version >= 0x361200) {
+   if ((smu_version >= 0x361200) &&
+   (smu_version <= 0x361a00)) {
dev_err(smu->adev->dev, "Forcing clock level is not supported 
with "
-  "54.18 and onwards SMU firmwares\n");
+  "54.18 - 54.26(included) SMU firmwares\n");
return -EOPNOTSUPP;
}
 
@@ -1437,9 +1438,10 @@ static int arcturus_set_performance_level(struct 
smu_context *smu,
case AMD_DPM_FORCED_LEVEL_PROFILE_MIN_SCLK:
case AMD_DPM_FORCED_LEVEL_PROFILE_MIN_MCLK:
case AMD_DPM_FORCED_LEVEL_PROFILE_PEAK:
-   if (smu_version >= 0x361200) {
+   if ((smu_version >= 0x361200) &&
+   (smu_version <= 0x361a00)) {
dev_err(smu->adev->dev, "Forcing clock level is not 
supported with "
-  "54.18 and onwards SMU firmwares\n");
+  "54.18 - 54.26(included) SMU firmwares\n");
return -EOPNOTSUPP;
}
break;
-- 
2.28.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx