Re: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map array

2019-07-11 Thread Yin, Tianci (Rico)
Thanks Feifei and Xiaojie!

From: Xu, Feifei
Sent: Thursday, July 11, 2019 16:28
To: Yin, Tianci (Rico); amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack; Yuan, Xiaojie; Yin, Tianci (Rico); Zhang, Hawking
Subject: RE: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in 
hw_id_map array

Reviewed-by: Feifei Xu 

Regards,
Feifei

-Original Message-
From: amd-gfx  On Behalf Of Tianci Yin
Sent: 2019年7月11日 16:01
To: amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack ; Yuan, Xiaojie ; Yin, 
Tianci (Rico) ; Zhang, Hawking 
Subject: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map 
array

From: tiancyin 

ID of DCE_HWIP from vbios is DMU_HWID,
mismatch cause null pointer crash in navi10 modprobe.

Change-Id: I3be363cf5248de904b3bdae2f34d3bbe0bbbc07d
Signed-off-by: tiancyin 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index e049ae6..1481899 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -123,7 +123,7 @@ static int hw_id_map[MAX_HWIP] = {
 [UVD_HWIP]  = UVD_HWID,
 [VCE_HWIP]  = VCE_HWID,
 [DF_HWIP]   = DF_HWID,
-   [DCE_HWIP]  = DCEAZ_HWID,
+   [DCE_HWIP]  = DMU_HWID,
 [OSSSYS_HWIP]   = OSSSYS_HWID,
 [SMUIO_HWIP]= SMUIO_HWID,
 [PWR_HWIP]  = PWR_HWID,
--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map array

2019-07-11 Thread Yuan, Xiaojie
Reviewed-by: Xiaojie Yuan 

BR,
Xiaojie


From: amd-gfx  on behalf of Tianci Yin 

Sent: Thursday, July 11, 2019 4:00 PM
To: amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack; Yuan, Xiaojie; Yin, Tianci (Rico); Zhang, Hawking
Subject: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map 
array

From: tiancyin 

ID of DCE_HWIP from vbios is DMU_HWID,
mismatch cause null pointer crash in navi10 modprobe.

Change-Id: I3be363cf5248de904b3bdae2f34d3bbe0bbbc07d
Signed-off-by: tiancyin 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index e049ae6..1481899 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -123,7 +123,7 @@ static int hw_id_map[MAX_HWIP] = {
[UVD_HWIP]  = UVD_HWID,
[VCE_HWIP]  = VCE_HWID,
[DF_HWIP]   = DF_HWID,
-   [DCE_HWIP]  = DCEAZ_HWID,
+   [DCE_HWIP]  = DMU_HWID,
[OSSSYS_HWIP]   = OSSSYS_HWID,
[SMUIO_HWIP]= SMUIO_HWID,
[PWR_HWIP]  = PWR_HWID,
--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map array

2019-07-11 Thread Xu, Feifei
Reviewed-by: Feifei Xu 

Regards,
Feifei

-Original Message-
From: amd-gfx  On Behalf Of Tianci Yin
Sent: 2019年7月11日 16:01
To: amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack ; Yuan, Xiaojie ; Yin, 
Tianci (Rico) ; Zhang, Hawking 
Subject: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map 
array

From: tiancyin 

ID of DCE_HWIP from vbios is DMU_HWID,
mismatch cause null pointer crash in navi10 modprobe.

Change-Id: I3be363cf5248de904b3bdae2f34d3bbe0bbbc07d
Signed-off-by: tiancyin 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index e049ae6..1481899 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -123,7 +123,7 @@ static int hw_id_map[MAX_HWIP] = {
[UVD_HWIP]  = UVD_HWID,
[VCE_HWIP]  = VCE_HWID,
[DF_HWIP]   = DF_HWID,
-   [DCE_HWIP]  = DCEAZ_HWID,
+   [DCE_HWIP]  = DMU_HWID,
[OSSSYS_HWIP]   = OSSSYS_HWID,
[SMUIO_HWIP]= SMUIO_HWID,
[PWR_HWIP]  = PWR_HWID,
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map array

2019-07-11 Thread Tianci Yin
From: tiancyin 

ID of DCE_HWIP from vbios is DMU_HWID,
mismatch cause null pointer crash in navi10 modprobe.

Change-Id: I3be363cf5248de904b3bdae2f34d3bbe0bbbc07d
Signed-off-by: tiancyin 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index e049ae6..1481899 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -123,7 +123,7 @@ static int hw_id_map[MAX_HWIP] = {
[UVD_HWIP]  = UVD_HWID,
[VCE_HWIP]  = VCE_HWID,
[DF_HWIP]   = DF_HWID,
-   [DCE_HWIP]  = DCEAZ_HWID,
+   [DCE_HWIP]  = DMU_HWID,
[OSSSYS_HWIP]   = OSSSYS_HWID,
[SMUIO_HWIP]= SMUIO_HWID,
[PWR_HWIP]  = PWR_HWID,
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx