Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland 
On 2018-08-21 03:47 PM, Alex Deucher wrote:
> On Tue, Aug 21, 2018 at 3:38 PM Harry Wentland  wrote:
>>
>> On 2018-08-16 04:38 PM, Alex Deucher wrote:
>>> Seems to cause blank screens.
>>>
>>> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
>>> Signed-off-by: Alex Deucher 
>>
>> Your SOB is using a different email from the author. Mind if I change it to 
>> your gmail?
> 
> Weird.  not sure what happened there.  I'd prefer you just override
> the author to my amd address.
> 

Done and pushed.

It looks like you sent the patch from your gmail, which is why that's shown as 
author.

Harry

> Alex
> 
>>
>> Harry
>>
>>> ---
>>>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
>>> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>>> index 350ee3e3e34d..2e3f85ceeaa9 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>>> @@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, 
>>> struct dc_state *context)
>>>   bool can_eDP_fast_boot_optimize = false;
>>>
>>>   if (edp_link) {
>>> - can_eDP_fast_boot_optimize =
>>> + /* this seems to cause blank screens on DCE8 */
>>> + if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
>>> + (dc->ctx->dce_version == DCE_VERSION_8_1) ||
>>> + (dc->ctx->dce_version == DCE_VERSION_8_3))
>>> + can_eDP_fast_boot_optimize = false;
>>> + else
>>> + can_eDP_fast_boot_optimize =
>>>   
>>> edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
>>>   }
>>>
>>>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Alex Deucher 
On Tue, Aug 21, 2018 at 3:38 PM Harry Wentland  wrote:
>
> On 2018-08-16 04:38 PM, Alex Deucher wrote:
> > Seems to cause blank screens.
> >
> > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
> > Signed-off-by: Alex Deucher 
>
> Your SOB is using a different email from the author. Mind if I change it to 
> your gmail?

Weird.  not sure what happened there.  I'd prefer you just override
the author to my amd address.

Alex

>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
> > b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > index 350ee3e3e34d..2e3f85ceeaa9 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > @@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, 
> > struct dc_state *context)
> >   bool can_eDP_fast_boot_optimize = false;
> >
> >   if (edp_link) {
> > - can_eDP_fast_boot_optimize =
> > + /* this seems to cause blank screens on DCE8 */
> > + if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
> > + (dc->ctx->dce_version == DCE_VERSION_8_1) ||
> > + (dc->ctx->dce_version == DCE_VERSION_8_3))
> > + can_eDP_fast_boot_optimize = false;
> > + else
> > + can_eDP_fast_boot_optimize =
> >   
> > edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
> >   }
> >
> >
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland 
On 2018-08-16 04:38 PM, Alex Deucher wrote:
> Seems to cause blank screens.
> 
> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
> Signed-off-by: Alex Deucher 

Your SOB is using a different email from the author. Mind if I change it to 
your gmail?

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 350ee3e3e34d..2e3f85ceeaa9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, 
> struct dc_state *context)
>   bool can_eDP_fast_boot_optimize = false;
>  
>   if (edp_link) {
> - can_eDP_fast_boot_optimize =
> + /* this seems to cause blank screens on DCE8 */
> + if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
> + (dc->ctx->dce_version == DCE_VERSION_8_1) ||
> + (dc->ctx->dce_version == DCE_VERSION_8_3))
> + can_eDP_fast_boot_optimize = false;
> + else
> + can_eDP_fast_boot_optimize =
>   
> edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
>   }
>  
> 
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-21 Thread Harry Wentland 
On 2018-08-16 04:38 PM, Alex Deucher wrote:
> Seems to cause blank screens.
> 
> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
> Signed-off-by: Alex Deucher 

Reviewed-by: Harry Wentland 

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 350ee3e3e34d..2e3f85ceeaa9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, 
> struct dc_state *context)
>   bool can_eDP_fast_boot_optimize = false;
>  
>   if (edp_link) {
> - can_eDP_fast_boot_optimize =
> + /* this seems to cause blank screens on DCE8 */
> + if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
> + (dc->ctx->dce_version == DCE_VERSION_8_1) ||
> + (dc->ctx->dce_version == DCE_VERSION_8_3))
> + can_eDP_fast_boot_optimize = false;
> + else
> + can_eDP_fast_boot_optimize =
>   
> edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
>   }
>  
> 
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu/display: disable eDP fast boot optimization on DCE8

2018-08-16 Thread Alex Deucher 
Seems to cause blank screens.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=106940
Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 350ee3e3e34d..2e3f85ceeaa9 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -1562,7 +1562,13 @@ void dce110_enable_accelerated_mode(struct dc *dc, 
struct dc_state *context)
bool can_eDP_fast_boot_optimize = false;
 
if (edp_link) {
-   can_eDP_fast_boot_optimize =
+   /* this seems to cause blank screens on DCE8 */
+   if ((dc->ctx->dce_version == DCE_VERSION_8_0) ||
+   (dc->ctx->dce_version == DCE_VERSION_8_1) ||
+   (dc->ctx->dce_version == DCE_VERSION_8_3))
+   can_eDP_fast_boot_optimize = false;
+   else
+   can_eDP_fast_boot_optimize =

edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc);
}
 
-- 
2.13.6

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx