Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c
Ok. I will remove the code. Best Regards Rex From: Christian König Sent: Wednesday, September 26, 2018 8:45 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c Am 26.09.2018 um 14:41 schrieb Rex Zhu: > Signed-off-by: Rex Zhu Actually that code can just be removed because uvd_*_enc_get_destroy_msg is only called with direct=true. Christian. > --- > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > index 8ef4a53..2ceab76 100644 > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > @@ -313,7 +313,7 @@ static int uvd_v6_0_enc_get_destroy_msg(struct > amdgpu_ring *ring, >if (direct) >r = amdgpu_job_submit_direct(job, ring, ); >else > - r = amdgpu_job_submit(job, >adev->vce.entity, > + r = amdgpu_job_submit(job, >adev->uvd.entity, > AMDGPU_FENCE_OWNER_UNDEFINED, ); >if (r) >goto err; > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c > b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c > index a289f6a..31a9665 100644 > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c > @@ -320,7 +320,7 @@ int uvd_v7_0_enc_get_destroy_msg(struct amdgpu_ring > *ring, uint32_t handle, >if (direct) >r = amdgpu_job_submit_direct(job, ring, ); >else > - r = amdgpu_job_submit(job, >adev->vce.entity, > + r = amdgpu_job_submit(job, >adev->uvd.entity, > AMDGPU_FENCE_OWNER_UNDEFINED, ); >if (r) >goto err; ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c
Am 26.09.2018 um 14:41 schrieb Rex Zhu: Signed-off-by: Rex Zhu Actually that code can just be removed because uvd_*_enc_get_destroy_msg is only called with direct=true. Christian. --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c index 8ef4a53..2ceab76 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c @@ -313,7 +313,7 @@ static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, if (direct) r = amdgpu_job_submit_direct(job, ring, ); else - r = amdgpu_job_submit(job, >adev->vce.entity, + r = amdgpu_job_submit(job, >adev->uvd.entity, AMDGPU_FENCE_OWNER_UNDEFINED, ); if (r) goto err; diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c index a289f6a..31a9665 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c @@ -320,7 +320,7 @@ int uvd_v7_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, if (direct) r = amdgpu_job_submit_direct(job, ring, ); else - r = amdgpu_job_submit(job, >adev->vce.entity, + r = amdgpu_job_submit(job, >adev->uvd.entity, AMDGPU_FENCE_OWNER_UNDEFINED, ); if (r) goto err; ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c index 8ef4a53..2ceab76 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c @@ -313,7 +313,7 @@ static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, if (direct) r = amdgpu_job_submit_direct(job, ring, ); else - r = amdgpu_job_submit(job, >adev->vce.entity, + r = amdgpu_job_submit(job, >adev->uvd.entity, AMDGPU_FENCE_OWNER_UNDEFINED, ); if (r) goto err; diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c index a289f6a..31a9665 100644 --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c @@ -320,7 +320,7 @@ int uvd_v7_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, if (direct) r = amdgpu_job_submit_direct(job, ring, ); else - r = amdgpu_job_submit(job, >adev->vce.entity, + r = amdgpu_job_submit(job, >adev->uvd.entity, AMDGPU_FENCE_OWNER_UNDEFINED, ); if (r) goto err; -- 1.9.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
