Re: [PATCH] drm/amdgpu: Remove dead static variable
Am 20.11.18 um 11:48 schrieb Emil Velikov: > On Mon, 19 Nov 2018 at 11:19, Christian König > wrote: >> Am 19.11.18 um 12:07 schrieb Rex Zhu: >>> The static struct drm_driver *driver was >>> not used because drm_pci_init was deprecated >>> >>> Signed-off-by: Rex Zhu >> Reviewed-by: Christian König >> >> Can you of hand see what "pdriver" is used for? That looks suspicious >> like something deprecated as well. >> > Seeming copy/paste from the radeon driver. The latter used to support > UMS and KMS at some point in the past. Yeah, thought so. Rex cam up with a V2 where both variables are removed. Thanks, Christian. > > HTH > -Emil ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: Remove dead static variable
On Mon, 19 Nov 2018 at 11:19, Christian König wrote: > > Am 19.11.18 um 12:07 schrieb Rex Zhu: > > The static struct drm_driver *driver was > > not used because drm_pci_init was deprecated > > > > Signed-off-by: Rex Zhu > > Reviewed-by: Christian König > > Can you of hand see what "pdriver" is used for? That looks suspicious > like something deprecated as well. > Seeming copy/paste from the radeon driver. The latter used to support UMS and KMS at some point in the past. HTH -Emil ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: Remove dead static variable
Am 19.11.18 um 12:07 schrieb Rex Zhu:
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
Signed-off-by: Rex Zhu
Reviewed-by: Christian König
Can you of hand see what "pdriver" is used for? That looks suspicious
like something deprecated as well.
Regards,
Christian.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 3b7d511..fa33e31 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1235,7 +1235,6 @@ static int amdgpu_flush(struct file *f, fl_owner_t id)
.patchlevel = KMS_DRIVER_PATCHLEVEL,
};
-static struct drm_driver *driver;
static struct pci_driver *pdriver;
static struct pci_driver amdgpu_kms_pci_driver = {
@@ -1267,9 +1266,8 @@ static int __init amdgpu_init(void)
goto error_fence;
DRM_INFO("amdgpu kernel modesetting enabled.\n");
- driver = _driver;
pdriver = _kms_pci_driver;
- driver->num_ioctls = amdgpu_max_kms_ioctl;
+ kms_driver.num_ioctls = amdgpu_max_kms_ioctl;
amdgpu_register_atpx_handler();
/* Ignore KFD init failures. Normal when CONFIG_HSA_AMD is not set. */
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdgpu: Remove dead static variable
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 3b7d511..fa33e31 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1235,7 +1235,6 @@ static int amdgpu_flush(struct file *f, fl_owner_t id)
.patchlevel = KMS_DRIVER_PATCHLEVEL,
};
-static struct drm_driver *driver;
static struct pci_driver *pdriver;
static struct pci_driver amdgpu_kms_pci_driver = {
@@ -1267,9 +1266,8 @@ static int __init amdgpu_init(void)
goto error_fence;
DRM_INFO("amdgpu kernel modesetting enabled.\n");
- driver = _driver;
pdriver = _kms_pci_driver;
- driver->num_ioctls = amdgpu_max_kms_ioctl;
+ kms_driver.num_ioctls = amdgpu_max_kms_ioctl;
amdgpu_register_atpx_handler();
/* Ignore KFD init failures. Normal when CONFIG_HSA_AMD is not set. */
--
1.9.1
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
