Re: [PATCH] drm/amdgpu: add ip_block_mask user option for static builds
s/blokcs/blocks s/dyanamic/dynamic Regards Pratik On 8/21/2018 3:23 PM, Shirish S wrote: This patch extends amdgpu.ip_block_mask to a Kconfig option as well, that can be altered by user at build time for OS' that do not permit passing dyanamic loading of amdgpu driver and also passing command line arguments. Note: This option to be used purely for debugging purposes and amdgpu driver is not productised/tested extensively with any of its blokcs disabled. The default value of this option enables all IP's. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/Kconfig | 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index e8af1f5..3f94ae5 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -23,6 +23,13 @@ config DRM_AMDGPU_CIK radeon.cik_support=0 amdgpu.cik_support=1 +config DRM_AMDGPU_IP_BLOCK_MASK + hex "AMDGPU IP Block Mask" + depends on DRM_AMDGPU + default "0x" + help + Modify this option to disable any IP block of amdgpu. + config DRM_AMDGPU_USERPTR bool "Always enable userptr write support" depends on DRM_AMDGPU diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 2221f6b..bd0a876 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -93,7 +93,7 @@ int amdgpu_dpm = -1; int amdgpu_fw_load_type = -1; int amdgpu_aspm = -1; int amdgpu_runtime_pm = -1; -uint amdgpu_ip_block_mask = 0x; +uint amdgpu_ip_block_mask = CONFIG_DRM_AMDGPU_IP_BLOCK_MASK; int amdgpu_bapm = -1; int amdgpu_deep_color = 0; int amdgpu_vm_size = -1; ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: add ip_block_mask user option for static builds
On 2018-08-21 11:53 a.m., Shirish S wrote: > This patch extends amdgpu.ip_block_mask to a Kconfig option as > well, that can be altered by user at build time for OS' that > do not permit passing dyanamic loading of amdgpu driver and also > passing command line arguments. > > Note: This option to be used purely for debugging purposes and > amdgpu driver is not productised/tested extensively with any of its > blokcs disabled. > The default value of this option enables all IP's. > > Signed-off-by: Shirish S > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 7 +++ > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig > b/drivers/gpu/drm/amd/amdgpu/Kconfig > index e8af1f5..3f94ae5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig > @@ -23,6 +23,13 @@ config DRM_AMDGPU_CIK > > radeon.cik_support=0 amdgpu.cik_support=1 > > +config DRM_AMDGPU_IP_BLOCK_MASK > + hex "AMDGPU IP Block Mask" > + depends on DRM_AMDGPU > + default "0x" > + help > + Modify this option to disable any IP block of amdgpu. As I said before, IMO this doesn't belong upstream, as it's a workaround for a downstream issue. Also, this isn't generally usable on a system with multiple GPUs supported by amdgpu, as the same block mask value may have different effects with different GPUs. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdgpu: add ip_block_mask user option for static builds
This patch extends amdgpu.ip_block_mask to a Kconfig option as well, that can be altered by user at build time for OS' that do not permit passing dyanamic loading of amdgpu driver and also passing command line arguments. Note: This option to be used purely for debugging purposes and amdgpu driver is not productised/tested extensively with any of its blokcs disabled. The default value of this option enables all IP's. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/Kconfig | 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index e8af1f5..3f94ae5 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -23,6 +23,13 @@ config DRM_AMDGPU_CIK radeon.cik_support=0 amdgpu.cik_support=1 +config DRM_AMDGPU_IP_BLOCK_MASK + hex "AMDGPU IP Block Mask" + depends on DRM_AMDGPU + default "0x" + help + Modify this option to disable any IP block of amdgpu. + config DRM_AMDGPU_USERPTR bool "Always enable userptr write support" depends on DRM_AMDGPU diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 2221f6b..bd0a876 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -93,7 +93,7 @@ int amdgpu_dpm = -1; int amdgpu_fw_load_type = -1; int amdgpu_aspm = -1; int amdgpu_runtime_pm = -1; -uint amdgpu_ip_block_mask = 0x; +uint amdgpu_ip_block_mask = CONFIG_DRM_AMDGPU_IP_BLOCK_MASK; int amdgpu_bapm = -1; int amdgpu_deep_color = 0; int amdgpu_vm_size = -1; -- 2.7.4 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
