Re: [PATCH] drm/sched: Fix make htmldocs warnings.
On 6/3/19 3:24 AM, Daniel Vetter wrote: > On Thu, May 30, 2019 at 05:04:20PM +0200, Christian König wrote: >> Am 29.05.19 um 21:36 schrieb Daniel Vetter: >>> On Wed, May 29, 2019 at 04:43:45PM +, Grodzovsky, Andrey wrote: I don't, sorry. >>> Should we fix that? Seems like you do plenty of scheduler stuff, so would >>> make sense I guess ... >> Reviewed-by: Christian König for the patch. >> >> And +1 for giving Andrey commit rights to drm-misc-next. > If Andrey is on board too, pls file an issue with the legacy ssh account > requests template here: > https://gitlab.freedesktop.org/freedesktop/freedesktop/ > > And then ping on irc or here so drm-misc folks can ack > -Daniel Here is the ticket https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/152 Andrey > >> Christian. >> >>> -Daniel >>> Andrey On 5/29/19 12:42 PM, Alex Deucher wrote: > On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky > wrote: >> Signed-off-by: Andrey Grodzovsky > Reviewed-by: Alex Deucher > > I'll push it to drm-misc in a minute unless you have commit rights. > > Alex > >> --- >> drivers/gpu/drm/scheduler/sched_main.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/scheduler/sched_main.c >> b/drivers/gpu/drm/scheduler/sched_main.c >> index 49e7d07..c1058ee 100644 >> --- a/drivers/gpu/drm/scheduler/sched_main.c >> +++ b/drivers/gpu/drm/scheduler/sched_main.c >> @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); >> * drm_sched_stop - stop the scheduler >> * >> * @sched: scheduler instance >> + * @bad: job which caused the time out >> * >> * Stop the scheduler and also removes and frees all completed jobs. >> * Note: bad job will not be freed as it might be used later and so >> it's >> @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); >> * drm_sched_job_recovery - recover jobs after a reset >> * >> * @sched: scheduler instance >> + * @full_recovery: proceed with complete sched restart >> * >> */ >> void drm_sched_start(struct drm_gpu_scheduler *sched, bool >> full_recovery) >> -- >> 2.7.4 >> >> ___ >> dri-devel mailing list >> dri-de...@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
On Thu, May 30, 2019 at 05:04:20PM +0200, Christian König wrote: > Am 29.05.19 um 21:36 schrieb Daniel Vetter: > > On Wed, May 29, 2019 at 04:43:45PM +, Grodzovsky, Andrey wrote: > > > I don't, sorry. > > Should we fix that? Seems like you do plenty of scheduler stuff, so would > > make sense I guess ... > > Reviewed-by: Christian König for the patch. > > And +1 for giving Andrey commit rights to drm-misc-next. If Andrey is on board too, pls file an issue with the legacy ssh account requests template here: https://gitlab.freedesktop.org/freedesktop/freedesktop/ And then ping on irc or here so drm-misc folks can ack -Daniel > > Christian. > > > -Daniel > > > > > Andrey > > > > > > On 5/29/19 12:42 PM, Alex Deucher wrote: > > > > On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky > > > > wrote: > > > > > Signed-off-by: Andrey Grodzovsky > > > > Reviewed-by: Alex Deucher > > > > > > > > I'll push it to drm-misc in a minute unless you have commit rights. > > > > > > > > Alex > > > > > > > > > --- > > > > >drivers/gpu/drm/scheduler/sched_main.c | 2 ++ > > > > >1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c > > > > > b/drivers/gpu/drm/scheduler/sched_main.c > > > > > index 49e7d07..c1058ee 100644 > > > > > --- a/drivers/gpu/drm/scheduler/sched_main.c > > > > > +++ b/drivers/gpu/drm/scheduler/sched_main.c > > > > > @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); > > > > > * drm_sched_stop - stop the scheduler > > > > > * > > > > > * @sched: scheduler instance > > > > > + * @bad: job which caused the time out > > > > > * > > > > > * Stop the scheduler and also removes and frees all completed > > > > > jobs. > > > > > * Note: bad job will not be freed as it might be used later and > > > > > so it's > > > > > @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); > > > > > * drm_sched_job_recovery - recover jobs after a reset > > > > > * > > > > > * @sched: scheduler instance > > > > > + * @full_recovery: proceed with complete sched restart > > > > > * > > > > > */ > > > > >void drm_sched_start(struct drm_gpu_scheduler *sched, bool > > > > > full_recovery) > > > > > -- > > > > > 2.7.4 > > > > > > > > > > ___ > > > > > dri-devel mailing list > > > > > dri-de...@lists.freedesktop.org > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
Am 29.05.19 um 21:36 schrieb Daniel Vetter: On Wed, May 29, 2019 at 04:43:45PM +, Grodzovsky, Andrey wrote: I don't, sorry. Should we fix that? Seems like you do plenty of scheduler stuff, so would make sense I guess ... Reviewed-by: Christian König for the patch. And +1 for giving Andrey commit rights to drm-misc-next. Christian. -Daniel Andrey On 5/29/19 12:42 PM, Alex Deucher wrote: On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher I'll push it to drm-misc in a minute unless you have commit rights. Alex --- drivers/gpu/drm/scheduler/sched_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 49e7d07..c1058ee 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); * drm_sched_stop - stop the scheduler * * @sched: scheduler instance + * @bad: job which caused the time out * * Stop the scheduler and also removes and frees all completed jobs. * Note: bad job will not be freed as it might be used later and so it's @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); * drm_sched_job_recovery - recover jobs after a reset * * @sched: scheduler instance + * @full_recovery: proceed with complete sched restart * */ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) -- 2.7.4 ___ dri-devel mailing list dri-de...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
On Wed, May 29, 2019 at 04:43:45PM +, Grodzovsky, Andrey wrote: > I don't, sorry. Should we fix that? Seems like you do plenty of scheduler stuff, so would make sense I guess ... -Daniel > > Andrey > > On 5/29/19 12:42 PM, Alex Deucher wrote: > > On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky > > wrote: > >> Signed-off-by: Andrey Grodzovsky > > Reviewed-by: Alex Deucher > > > > I'll push it to drm-misc in a minute unless you have commit rights. > > > > Alex > > > >> --- > >> drivers/gpu/drm/scheduler/sched_main.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/scheduler/sched_main.c > >> b/drivers/gpu/drm/scheduler/sched_main.c > >> index 49e7d07..c1058ee 100644 > >> --- a/drivers/gpu/drm/scheduler/sched_main.c > >> +++ b/drivers/gpu/drm/scheduler/sched_main.c > >> @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); > >>* drm_sched_stop - stop the scheduler > >>* > >>* @sched: scheduler instance > >> + * @bad: job which caused the time out > >>* > >>* Stop the scheduler and also removes and frees all completed jobs. > >>* Note: bad job will not be freed as it might be used later and so it's > >> @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); > >>* drm_sched_job_recovery - recover jobs after a reset > >>* > >>* @sched: scheduler instance > >> + * @full_recovery: proceed with complete sched restart > >>* > >>*/ > >> void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) > >> -- > >> 2.7.4 > >> > >> ___ > >> dri-devel mailing list > >> dri-de...@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
On Wed, May 29, 2019 at 10:29:40AM -0400, Andrey Grodzovsky wrote: > Signed-off-by: Andrey Grodzovsky Thanks for quick fixing! Acked-by: Daniel Vetter > --- > drivers/gpu/drm/scheduler/sched_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c > b/drivers/gpu/drm/scheduler/sched_main.c > index 49e7d07..c1058ee 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); > * drm_sched_stop - stop the scheduler > * > * @sched: scheduler instance > + * @bad: job which caused the time out > * > * Stop the scheduler and also removes and frees all completed jobs. > * Note: bad job will not be freed as it might be used later and so it's > @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); > * drm_sched_job_recovery - recover jobs after a reset > * > * @sched: scheduler instance > + * @full_recovery: proceed with complete sched restart > * > */ > void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
I don't, sorry. Andrey On 5/29/19 12:42 PM, Alex Deucher wrote: > On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky > wrote: >> Signed-off-by: Andrey Grodzovsky > Reviewed-by: Alex Deucher > > I'll push it to drm-misc in a minute unless you have commit rights. > > Alex > >> --- >> drivers/gpu/drm/scheduler/sched_main.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/scheduler/sched_main.c >> b/drivers/gpu/drm/scheduler/sched_main.c >> index 49e7d07..c1058ee 100644 >> --- a/drivers/gpu/drm/scheduler/sched_main.c >> +++ b/drivers/gpu/drm/scheduler/sched_main.c >> @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); >>* drm_sched_stop - stop the scheduler >>* >>* @sched: scheduler instance >> + * @bad: job which caused the time out >>* >>* Stop the scheduler and also removes and frees all completed jobs. >>* Note: bad job will not be freed as it might be used later and so it's >> @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); >>* drm_sched_job_recovery - recover jobs after a reset >>* >>* @sched: scheduler instance >> + * @full_recovery: proceed with complete sched restart >>* >>*/ >> void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) >> -- >> 2.7.4 >> >> ___ >> dri-devel mailing list >> dri-de...@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/sched: Fix make htmldocs warnings.
On Wed, May 29, 2019 at 10:29 AM Andrey Grodzovsky wrote: > > Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher I'll push it to drm-misc in a minute unless you have commit rights. Alex > --- > drivers/gpu/drm/scheduler/sched_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c > b/drivers/gpu/drm/scheduler/sched_main.c > index 49e7d07..c1058ee 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); > * drm_sched_stop - stop the scheduler > * > * @sched: scheduler instance > + * @bad: job which caused the time out > * > * Stop the scheduler and also removes and frees all completed jobs. > * Note: bad job will not be freed as it might be used later and so it's > @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); > * drm_sched_job_recovery - recover jobs after a reset > * > * @sched: scheduler instance > + * @full_recovery: proceed with complete sched restart > * > */ > void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) > -- > 2.7.4 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
