Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Mark Brown]

On Wed, Aug 30, 2017 at 11:49:02AM -0700, Eric Anholt wrote:
> Mark Brown  writes:

> > You need to get someone from the DRM side to pay attention to the second
> > patch and you need to stop resending the first patch since as has been
> > pointed out a few times now you need to stop sending the first patch
> > which is already in Linus' tree.

> Alex *is* from the DRM side and has reviewed that patch.

*sigh*  Right, OK in that case it would have been really helpful to see
either some mention of this either in text or via a pull request (which
would show the patch having been applied).  It's difficult to keep track
of all the different people who might be DRM maintainers especially when
there's process things like the resend of the patch from Linus' tree
going on.


signature.asc
Description: PGP signature
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Deucher, Alexander]

> -Original Message-
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: Wednesday, August 30, 2017 5:10 PM
> To: Eric Anholt
> Cc: Alex Deucher; alsa-de...@alsa-project.org; Liam Girdwood; Maling list -
> DRI developers; rajeev kumar; amd-gfx list; Mukunda, Vijendar; Deucher,
> Alexander; pe...@perex.cz
> Subject: Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs
> 
> On Wed, Aug 30, 2017 at 11:49:02AM -0700, Eric Anholt wrote:
> > Mark Brown <broo...@kernel.org> writes:
> 
> > > You need to get someone from the DRM side to pay attention to the
> second
> > > patch and you need to stop resending the first patch since as has been
> > > pointed out a few times now you need to stop sending the first patch
> > > which is already in Linus' tree.
> 
> > Alex *is* from the DRM side and has reviewed that patch.
> 
> *sigh*  Right, OK in that case it would have been really helpful to see
> either some mention of this either in text or via a pull request (which
> would show the patch having been applied).  It's difficult to keep track
> of all the different people who might be DRM maintainers especially when
> there's process things like the resend of the patch from Linus' tree
> going on.

I sent one patch in the v2 patch set that had already gone upstream because I 
didn't know that it had landed in Linus' tree yet.  I had thought it had just 
landed in the audio tree.  I apologize for that.  On the v3 cover page, I 
mentioned that v3 was a resend of the patches that had not been applied to any 
tree yet; I did not resend any patches that were already applied.  I believe 
all the previous comments were addressed.  Now that we've clarified that, are 
there an outstanding objections to these patches?  The patches touch both drm 
and audio.  My preference would be to take them through the drm tree, but I'm 
happy to have them go through the audio tree if you prefer.

Thanks,

Alex

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Eric Anholt]

Mark Brown  writes:

> [ Unknown signature status ]
> On Wed, Aug 30, 2017 at 09:33:35AM -0400, Alex Deucher wrote:
>
>> Any comments?  Can this patch set go in?  This is the second time I've
>> resent it since the addressing the initial feedback.  Does anyone have
>> a preference on which tree?
>
> You need to get someone from the DRM side to pay attention to the second
> patch and you need to stop resending the first patch since as has been
> pointed out a few times now you need to stop sending the first patch
> which is already in Linus' tree.

Alex *is* from the DRM side and has reviewed that patch.


signature.asc
Description: PGP signature
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Mark Brown]

On Wed, Aug 30, 2017 at 09:33:35AM -0400, Alex Deucher wrote:

> Any comments?  Can this patch set go in?  This is the second time I've
> resent it since the addressing the initial feedback.  Does anyone have
> a preference on which tree?

You need to get someone from the DRM side to pay attention to the second
patch and you need to stop resending the first patch since as has been
pointed out a few times now you need to stop sending the first patch
which is already in Linus' tree.


signature.asc
Description: PGP signature
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Deucher, Alexander]

> -Original Message-
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: Wednesday, August 30, 2017 11:19 AM
> To: Alex Deucher
> Cc: amd-gfx list; Maling list - DRI developers; Dave Airlie; alsa-devel@alsa-
> project.org; Mukunda, Vijendar; rajeev kumar; pe...@perex.cz; Liam
> Girdwood; Takashi Iwai; Deucher, Alexander
> Subject: Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs
> 
> On Wed, Aug 30, 2017 at 09:33:35AM -0400, Alex Deucher wrote:
> 
> > Any comments?  Can this patch set go in?  This is the second time I've
> > resent it since the addressing the initial feedback.  Does anyone have
> > a preference on which tree?
> 
> You need to get someone from the DRM side to pay attention to the second
> patch and you need to stop resending the first patch since as has been
> pointed out a few times now you need to stop sending the first patch
> which is already in Linus' tree.

I didn't resent any patches that are already upstream in v3 of this patch set.  
The rest of the patches have dependencies between drm and audio.  I'd like to 
get them in all together via one tree or the other.

Alex

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Alex Deucher]

On Fri, Aug 18, 2017 at 2:10 PM, Alex Deucher  wrote:
> This patch set updates the AMD GPU and Audio CoProcessor (ACP)
> audio drivers and the designware i2s driver for Stoney (ST).
> ST is an APU similar to Carrizo (CZ) which already has ACP audio
> support.  The i2s controller and ACP audio DMA engine are part of
> the GPU and both need updating so I would like to upstream the
> whole patch set via one tree if possible.
>
> The current code is based on drm-next, but I'm happy to rebase on
> whatever tree this ends up going through if there are any problems
> applying.  These patches touch both audio and drm.
>
> The entire patch set can be viewed here:
> https://cgit.freedesktop.org/~agd5f/linux/log/?h=stoney_acp2
>

Any comments?  Can this patch set go in?  This is the second time I've
resent it since the addressing the initial feedback.  Does anyone have
a preference on which tree?

Thanks,

Alex

> Thanks!
>
> Alex
>
> v2:
> - Patch 1 is already applied to the audio tree, just including it for
>   completeness since it's required for this patch set and it's not yet
>   in the drm tree.
> - New patch to share asic types between gpu and audio drivers
> - ACPI ID changed for rt5650 machine driver
> - Integrate feedback on other patches
>
> v3:
> - resend remaining patches that have not been applied yet
>
> Akshu Agrawal (2):
>   drm/amdgpu Moving amdgpu asic types to a separate file
>   ASoC: AMD: Add machine driver for cz rt5650
>
> Vijendar Mukunda (4):
>   drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data
>   ASoC: AMD: disabling memory gating in stoney platform
>   ASoC: AMD: DMA driver changes for Stoney Platform
>   ASoC: AMD: Audio buffer related changes for Stoney
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c  |   2 +
>  drivers/gpu/drm/amd/include/amd_shared.h |  29 +---
>  include/drm/amd_asic_type.h  |  52 +++
>  sound/soc/amd/Kconfig|   7 +
>  sound/soc/amd/Makefile   |   2 +
>  sound/soc/amd/acp-pcm-dma.c  | 243 
> ---
>  sound/soc/amd/acp-rt5645.c   | 210 ++
>  sound/soc/amd/acp.h  |   9 ++
>  8 files changed, 472 insertions(+), 82 deletions(-)
>  create mode 100644 include/drm/amd_asic_type.h
>  create mode 100644 sound/soc/amd/acp-rt5645.c
>
> --
> 2.5.5
>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

[Alex Deucher]

This patch set updates the AMD GPU and Audio CoProcessor (ACP)
audio drivers and the designware i2s driver for Stoney (ST).
ST is an APU similar to Carrizo (CZ) which already has ACP audio
support.  The i2s controller and ACP audio DMA engine are part of
the GPU and both need updating so I would like to upstream the
whole patch set via one tree if possible.

The current code is based on drm-next, but I'm happy to rebase on
whatever tree this ends up going through if there are any problems
applying.  These patches touch both audio and drm.

The entire patch set can be viewed here:
https://cgit.freedesktop.org/~agd5f/linux/log/?h=stoney_acp2

Thanks!

Alex

v2:
- Patch 1 is already applied to the audio tree, just including it for
  completeness since it's required for this patch set and it's not yet
  in the drm tree.
- New patch to share asic types between gpu and audio drivers
- ACPI ID changed for rt5650 machine driver
- Integrate feedback on other patches

v3:
- resend remaining patches that have not been applied yet

Akshu Agrawal (2):
  drm/amdgpu Moving amdgpu asic types to a separate file
  ASoC: AMD: Add machine driver for cz rt5650

Vijendar Mukunda (4):
  drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data
  ASoC: AMD: disabling memory gating in stoney platform
  ASoC: AMD: DMA driver changes for Stoney Platform
  ASoC: AMD: Audio buffer related changes for Stoney

 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c  |   2 +
 drivers/gpu/drm/amd/include/amd_shared.h |  29 +---
 include/drm/amd_asic_type.h  |  52 +++
 sound/soc/amd/Kconfig|   7 +
 sound/soc/amd/Makefile   |   2 +
 sound/soc/amd/acp-pcm-dma.c  | 243 ---
 sound/soc/amd/acp-rt5645.c   | 210 ++
 sound/soc/amd/acp.h  |   9 ++
 8 files changed, 472 insertions(+), 82 deletions(-)
 create mode 100644 include/drm/amd_asic_type.h
 create mode 100644 sound/soc/amd/acp-rt5645.c

-- 
2.5.5

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx