Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
On Thu, 05 Nov 2020, Daniel Vetter wrote: > On Thu, Nov 5, 2020 at 7:10 PM Lee Jones wrote: > > > > On Thu, 05 Nov 2020, Thierry Reding wrote: > > > > > On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > There are 5000 warnings to work through. > > > > > > > > It will take a couple more sets. > > > > > > > > Lee Jones (19): > > > > gpu: host1x: bus: Add missing description for 'driver' > > > > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries > > > > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused > > > > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues > > > > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused > > > > gpu: drm: scheduler: sched_main: Provide missing description for > > > > 'sched' paramter > > > > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc > > > > headers > > > > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables > > > > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused > > > > variable 'fb' > > > > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of > > > > kernel-doc abuses > > > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > > 'analogix_dp_write_byte_to_dpcd' > > > > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses > > > > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct > > > > drm_dp_sideband_msg_req_body' onto the heap > > > > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' > > > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > > > > kernel-doc header > > > > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc > > > > misdemeanours > > > > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused > > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > > 'analogix_dp_start_aux_transaction' > > > > > > As commented on the other patches, the subject prefixes on most of these > > > look wrong, but it's generally a nice cleanup. > > > > The prefixes are automated. I'll add this to my list of awkward > > subsystems and go through them all manually again tomorrow. :D > > tbh for autmoation they look really good :-) Only the prefixes are automated unfortunately. :) > I'd say if you replace the intermediate ": " with just a / you'll be > perfectly in style for drivers/gpu. But really I think it's ok as-is, It's up to you. Make the call and I'll abide. > imo no need to change since this is a giantic tree wide effort. Yes, you're not kidding, and thanks for noticing. Only 10,000 (from 18,000) more to go though. :D GPU is a biggy (5,000), although one patch in [Set 2] fixes 2,000 in one hit, which is great! I'll probably submit that tomorrow. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
On Thu, 05 Nov 2020, Thierry Reding wrote: > On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are 5000 warnings to work through. > > > > It will take a couple more sets. > > > > Lee Jones (19): > > gpu: host1x: bus: Add missing description for 'driver' > > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries > > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused > > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues > > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused > > gpu: drm: scheduler: sched_main: Provide missing description for > > 'sched' paramter > > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc > > headers > > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables > > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused > > variable 'fb' > > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of > > kernel-doc abuses > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > 'analogix_dp_write_byte_to_dpcd' > > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses > > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct > > drm_dp_sideband_msg_req_body' onto the heap > > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > > kernel-doc header > > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc > > misdemeanours > > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > 'analogix_dp_start_aux_transaction' > > As commented on the other patches, the subject prefixes on most of these > look wrong, but it's generally a nice cleanup. The prefixes are automated. I'll add this to my list of awkward subsystems and go through them all manually again tomorrow. :D -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
On Thu, 05 Nov 2020, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > Thanks for looking into this. > > > There are 5000 warnings to work through. > > > > It will take a couple more sets. > :-) > > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > I have a patch here that inline the comments - and fix the warning as a > side effect. I will get it posted tonight as this is better. > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > 'analogix_dp_write_byte_to_dpcd' > When I looked at his I had another unused function after removing the > first. > > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > > kernel-doc header > Agree on this simple approch, will apply. > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > 'analogix_dp_start_aux_transaction' > OK, this was the one I referred to above. They should be squashed into > one patch. I can squash them if you prefer. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
On Thu, Nov 5, 2020 at 7:10 PM Lee Jones wrote: > > On Thu, 05 Nov 2020, Thierry Reding wrote: > > > On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > There are 5000 warnings to work through. > > > > > > It will take a couple more sets. > > > > > > Lee Jones (19): > > > gpu: host1x: bus: Add missing description for 'driver' > > > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries > > > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused > > > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues > > > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused > > > gpu: drm: scheduler: sched_main: Provide missing description for > > > 'sched' paramter > > > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc > > > headers > > > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables > > > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused > > > variable 'fb' > > > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of > > > kernel-doc abuses > > > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > 'analogix_dp_write_byte_to_dpcd' > > > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses > > > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct > > > drm_dp_sideband_msg_req_body' onto the heap > > > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' > > > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > > > kernel-doc header > > > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc > > > misdemeanours > > > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused > > > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > > > 'analogix_dp_start_aux_transaction' > > > > As commented on the other patches, the subject prefixes on most of these > > look wrong, but it's generally a nice cleanup. > > The prefixes are automated. I'll add this to my list of awkward > subsystems and go through them all manually again tomorrow. :D tbh for autmoation they look really good :-) I'd say if you replace the intermediate ": " with just a / you'll be perfectly in style for drivers/gpu. But really I think it's ok as-is, imo no need to change since this is a giantic tree wide effort. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are 5000 warnings to work through. > > It will take a couple more sets. > > Lee Jones (19): > gpu: host1x: bus: Add missing description for 'driver' > gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries > gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused > gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues > gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused > gpu: drm: scheduler: sched_main: Provide missing description for > 'sched' paramter > gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc > headers > gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables > gpu: drm: selftests: test-drm_framebuffer: Remove set but unused > variable 'fb' > gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of > kernel-doc abuses > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > 'analogix_dp_write_byte_to_dpcd' > gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses > gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct > drm_dp_sideband_msg_req_body' onto the heap > gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > kernel-doc header > gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc > misdemeanours > gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > 'analogix_dp_start_aux_transaction' As commented on the other patches, the subject prefixes on most of these look wrong, but it's generally a nice cleanup. Thanks! Thierry signature.asc Description: PGP signature ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
Hi Lee. On Thu, Nov 05, 2020 at 02:44:58PM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Thanks for looking into this. > There are 5000 warnings to work through. > > It will take a couple more sets. :-) > gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header I have a patch here that inline the comments - and fix the warning as a side effect. I will get it posted tonight as this is better. > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > 'analogix_dp_write_byte_to_dpcd' When I looked at his I had another unused function after removing the first. > gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant > kernel-doc header Agree on this simple approch, will apply. > gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function > 'analogix_dp_start_aux_transaction' OK, this was the one I referred to above. They should be squashed into one patch. Sam ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH 00/19] [Set 1] Rid W=1 warnings from GPU
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are 5000 warnings to work through. It will take a couple more sets. Lee Jones (19): gpu: host1x: bus: Add missing description for 'driver' gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb' gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd' gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction' drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 88 --- drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- drivers/gpu/drm/omapdrm/dss/dsi.c | 9 +- drivers/gpu/drm/omapdrm/omap_irq.c| 6 +- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 2 +- drivers/gpu/drm/panel/panel-simple.c | 2 + drivers/gpu/drm/radeon/radeon_device.c| 23 ++--- drivers/gpu/drm/radeon/radeon_drv.c | 3 +- drivers/gpu/drm/scheduler/sched_entity.c | 4 +- drivers/gpu/drm/scheduler/sched_main.c| 1 + .../drm/selftests/test-drm_dp_mst_helper.c| 29 +++--- .../gpu/drm/selftests/test-drm_framebuffer.c | 3 +- drivers/gpu/drm/selftests/test-drm_mm.c | 2 +- drivers/gpu/drm/ttm/ttm_bo.c | 23 ++--- drivers/gpu/drm/ttm/ttm_tt.c | 4 +- drivers/gpu/host1x/bus.c | 1 + drivers/gpu/ipu-v3/ipu-di.c | 4 - 18 files changed, 59 insertions(+), 153 deletions(-) Cc: Alex Deucher Cc: amd-gfx@lists.freedesktop.org Cc: Andrzej Hajda Cc: Christian Koenig Cc: "Christian König" Cc: Daniel Vetter Cc: David Airlie Cc: David Francis Cc: dri-de...@lists.freedesktop.org Cc: Fabio Estevam Cc: Gareth Hughes Cc: Huang Rui Cc: Jason Yan Cc: Jernej Skrabec Cc: Jingoo Han Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Laurent Pinchart Cc: Lee Jones Cc: linaro-mm-...@lists.linaro.org Cc: Linus Walleij Cc: linux-me...@vger.kernel.org Cc: linux-te...@vger.kernel.org Cc: Lyude Paul Cc: Neil Armstrong Cc: Nirmoy Das Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Rob Clark Cc: Sam Ravnborg Cc: Sascha Hauer Cc: Shawn Guo Cc: Sumit Semwal Cc: Thierry Reding Cc: Tomi Valkeinen -- 2.25.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
