Re: [PATCH 01/11] drm/amd/display: fix typo in function name

[Christian König]

Am 11.10.2017 um 16:06 schrieb Alex Deucher:

s/amdgpu_dm_find_first_crct_matching_connector/
amdgpu_dm_find_first_crtc_matching_connector/

And while here, make it static.

Signed-off-by: Alex Deucher 


Acked-by: Christian König 


---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++--
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  6 --
  2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 9bfe1f9..4357db8 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -568,10 +568,10 @@ static int dm_suspend(void *handle)
return ret;
  }
  
-struct amdgpu_dm_connector *amdgpu_dm_find_first_crct_matching_connector(

-   struct drm_atomic_state *state,
-   struct drm_crtc *crtc,
-   bool from_state_var)
+static struct amdgpu_dm_connector *
+amdgpu_dm_find_first_crtc_matching_connector(struct drm_atomic_state *state,
+struct drm_crtc *crtc,
+bool from_state_var)
  {
uint32_t i;
struct drm_connector_state *conn_state;
@@ -4114,7 +4114,7 @@ void amdgpu_dm_atomic_commit_tail(
  
  			new_stream = new_acrtc_state->stream;

aconnector =
-   amdgpu_dm_find_first_crct_matching_connector(
+   amdgpu_dm_find_first_crtc_matching_connector(
state,
_crtcs[i]->base,
false);
@@ -4402,7 +4402,7 @@ static int dm_update_crtcs_state(
new_acrtc_state = to_dm_crtc_state(crtc_state);
acrtc = to_amdgpu_crtc(crtc);
  
-		aconnector = amdgpu_dm_find_first_crct_matching_connector(state, crtc, true);

+   aconnector = 
amdgpu_dm_find_first_crtc_matching_connector(state, crtc, true);
  
  		/* TODO This hack should go away */

if (aconnector) {
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index 630e6cd..aca061a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -226,12 +226,6 @@ extern const struct amdgpu_ip_block_version dm_ip_block;
  void amdgpu_dm_update_connector_after_detect(
struct amdgpu_dm_connector *aconnector);
  
-struct amdgpu_dm_connector *amdgpu_dm_find_first_crct_matching_connector(

-   struct drm_atomic_state *state,
-   struct drm_crtc *crtc,
-   bool from_state_var);
-
-
  struct amdgpu_framebuffer;
  struct amdgpu_display_manager;
  struct dc_validation_set;



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 01/11] drm/amd/display: fix typo in function name

[Alex Deucher]

s/amdgpu_dm_find_first_crct_matching_connector/
amdgpu_dm_find_first_crtc_matching_connector/

And while here, make it static.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++--
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  6 --
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 9bfe1f9..4357db8 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -568,10 +568,10 @@ static int dm_suspend(void *handle)
return ret;
 }
 
-struct amdgpu_dm_connector *amdgpu_dm_find_first_crct_matching_connector(
-   struct drm_atomic_state *state,
-   struct drm_crtc *crtc,
-   bool from_state_var)
+static struct amdgpu_dm_connector *
+amdgpu_dm_find_first_crtc_matching_connector(struct drm_atomic_state *state,
+struct drm_crtc *crtc,
+bool from_state_var)
 {
uint32_t i;
struct drm_connector_state *conn_state;
@@ -4114,7 +4114,7 @@ void amdgpu_dm_atomic_commit_tail(
 
new_stream = new_acrtc_state->stream;
aconnector =
-   amdgpu_dm_find_first_crct_matching_connector(
+   amdgpu_dm_find_first_crtc_matching_connector(
state,
_crtcs[i]->base,
false);
@@ -4402,7 +4402,7 @@ static int dm_update_crtcs_state(
new_acrtc_state = to_dm_crtc_state(crtc_state);
acrtc = to_amdgpu_crtc(crtc);
 
-   aconnector = 
amdgpu_dm_find_first_crct_matching_connector(state, crtc, true);
+   aconnector = 
amdgpu_dm_find_first_crtc_matching_connector(state, crtc, true);
 
/* TODO This hack should go away */
if (aconnector) {
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index 630e6cd..aca061a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -226,12 +226,6 @@ extern const struct amdgpu_ip_block_version dm_ip_block;
 void amdgpu_dm_update_connector_after_detect(
struct amdgpu_dm_connector *aconnector);
 
-struct amdgpu_dm_connector *amdgpu_dm_find_first_crct_matching_connector(
-   struct drm_atomic_state *state,
-   struct drm_crtc *crtc,
-   bool from_state_var);
-
-
 struct amdgpu_framebuffer;
 struct amdgpu_display_manager;
 struct dc_validation_set;
-- 
2.5.5

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx