Re: [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
On 2020-06-19 11:27 a.m., Alex Deucher wrote: On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo wrote: when compiled with allmodconfig option, there are error messages as below: ERROR: modpost: "mod_color_is_table_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "mod_color_get_table" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "mod_color_set_table_init_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! To fix the issue, this commits removes CONFIG_DRM_AMD_DC_DCN guard in color/makefile. Signed-off-by: Qingqing Zhuo CC: Lewis Huang CC: Aric Cyr CC: Alexander Deucher CC: Harry Wentland CC: Nicholas Kazlauskas CC: Bhawanpreet Lakha CC: Stephen Rothwell Acked-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile index 3ee7f27ff93b..e66c19a840c2 100644 --- a/drivers/gpu/drm/amd/display/modules/color/Makefile +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile @@ -23,11 +23,7 @@ # Makefile for the color sub-module of DAL. # -MOD_COLOR = color_gamma.o - -ifdef CONFIG_DRM_AMD_DC_DCN -MOD_COLOR += color_table.o -endif +MOD_COLOR = color_gamma.o color_table.o AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR)) #$(info DAL COLOR MODULE MAKEFILE ) -- 2.17.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo wrote: > > when compiled with allmodconfig option, there are error > messages as below: > > ERROR: modpost: > "mod_color_is_table_init" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: > "mod_color_get_table" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: > "mod_color_set_table_init_state" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > To fix the issue, this commits removes > CONFIG_DRM_AMD_DC_DCN guard in color/makefile. > > Signed-off-by: Qingqing Zhuo > CC: Lewis Huang > CC: Aric Cyr > CC: Alexander Deucher > CC: Harry Wentland > CC: Nicholas Kazlauskas > CC: Bhawanpreet Lakha > CC: Stephen Rothwell Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile > b/drivers/gpu/drm/amd/display/modules/color/Makefile > index 3ee7f27ff93b..e66c19a840c2 100644 > --- a/drivers/gpu/drm/amd/display/modules/color/Makefile > +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile > @@ -23,11 +23,7 @@ > # Makefile for the color sub-module of DAL. > # > > -MOD_COLOR = color_gamma.o > - > -ifdef CONFIG_DRM_AMD_DC_DCN > -MOD_COLOR += color_table.o > -endif > +MOD_COLOR = color_gamma.o color_table.o > > AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR)) > #$(info DAL COLOR MODULE MAKEFILE ) > -- > 2.17.1 > > ___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
when compiled with allmodconfig option, there are error messages as below: ERROR: modpost: "mod_color_is_table_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "mod_color_get_table" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "mod_color_set_table_init_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! To fix the issue, this commits removes CONFIG_DRM_AMD_DC_DCN guard in color/makefile. Signed-off-by: Qingqing Zhuo CC: Lewis Huang CC: Aric Cyr CC: Alexander Deucher CC: Harry Wentland CC: Nicholas Kazlauskas CC: Bhawanpreet Lakha CC: Stephen Rothwell --- drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile index 3ee7f27ff93b..e66c19a840c2 100644 --- a/drivers/gpu/drm/amd/display/modules/color/Makefile +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile @@ -23,11 +23,7 @@ # Makefile for the color sub-module of DAL. # -MOD_COLOR = color_gamma.o - -ifdef CONFIG_DRM_AMD_DC_DCN -MOD_COLOR += color_table.o -endif +MOD_COLOR = color_gamma.o color_table.o AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR)) #$(info DAL COLOR MODULE MAKEFILE ) -- 2.17.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
