RE: [PATCH 1/1] drm/amdkfd: remove unused variable

2021-06-15 Thread Kim, Jonathan 
[AMD Official Use Only]

Thanks for the catch.
Reviewed-by: Jonathan Kim 

> -Original Message-
> From: Das, Nirmoy 
> Sent: Tuesday, June 15, 2021 6:35 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Kim, Jonathan ; Kuehling, Felix
> 
> Subject: Re: [PATCH 1/1] drm/amdkfd: remove unused variable
>
>
> On 6/15/2021 12:33 PM, Nirmoy Das wrote:
> > Remove it.
> >
> > CC: jonathan@amd.com
> > CC: felix.kuehl...@amd.com
> > Fixes: d7b132507384c("drm/amdkfd: fix circular locking on get_wave_state")
> > Signed-off-by: Nirmoy Das 
> > ---
> >   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > index e6366b408420..539212039876 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > @@ -997,7 +997,7 @@ static int start_nocpsch(struct
> device_queue_manager *dqm)
> >   {
> > pr_info("SW scheduler is used");
> > init_interrupts(dqm);
> > -
> > +
> Please ignore this extra space. I will push without it once I get a r-b.
> > if (dqm->dev->device_info->asic_family == CHIP_HAWAII)
> > return pm_init(>packets, dqm);
> > dqm->sched_running = true;
> > @@ -1674,7 +1674,6 @@ static int get_wave_state(struct
> device_queue_manager *dqm,
> >   u32 *save_area_used_size)
> >   {
> > struct mqd_manager *mqd_mgr;
> > -   int r;
> >
> > dqm_lock(dqm);
> >
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/1] drm/amdkfd: remove unused variable

2021-06-15 Thread Das, Nirmoy 



On 6/15/2021 12:33 PM, Nirmoy Das wrote:

Remove it.

CC: jonathan@amd.com
CC: felix.kuehl...@amd.com
Fixes: d7b132507384c("drm/amdkfd: fix circular locking on get_wave_state")
Signed-off-by: Nirmoy Das 
---
  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index e6366b408420..539212039876 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -997,7 +997,7 @@ static int start_nocpsch(struct device_queue_manager *dqm)
  {
pr_info("SW scheduler is used");
init_interrupts(dqm);
-   
+

Please ignore this extra space. I will push without it once I get a r-b.

if (dqm->dev->device_info->asic_family == CHIP_HAWAII)
return pm_init(>packets, dqm);
dqm->sched_running = true;
@@ -1674,7 +1674,6 @@ static int get_wave_state(struct device_queue_manager 
*dqm,
  u32 *save_area_used_size)
  {
struct mqd_manager *mqd_mgr;
-   int r;
  
  	dqm_lock(dqm);
  

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/1] drm/amdkfd: remove unused variable

2021-06-15 Thread Nirmoy Das 
Remove it.

CC: jonathan@amd.com
CC: felix.kuehl...@amd.com
Fixes: d7b132507384c("drm/amdkfd: fix circular locking on get_wave_state")
Signed-off-by: Nirmoy Das 
---
 drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index e6366b408420..539212039876 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -997,7 +997,7 @@ static int start_nocpsch(struct device_queue_manager *dqm)
 {
pr_info("SW scheduler is used");
init_interrupts(dqm);
-   
+
if (dqm->dev->device_info->asic_family == CHIP_HAWAII)
return pm_init(>packets, dqm);
dqm->sched_running = true;
@@ -1674,7 +1674,6 @@ static int get_wave_state(struct device_queue_manager 
*dqm,
  u32 *save_area_used_size)
 {
struct mqd_manager *mqd_mgr;
-   int r;
 
dqm_lock(dqm);
 
-- 
2.31.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 1/1] drm/amdkfd: Remove unused variable

2019-07-02 Thread Zeng, Oak 
Reviewed-by: Oak Zeng 

Regards,
Oak

-Original Message-
From: amd-gfx  On Behalf Of Kuehling, 
Felix
Sent: Wednesday, July 3, 2019 10:51 AM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Xiao, Jack 
Subject: [PATCH 1/1] drm/amdkfd: Remove unused variable

Fix an obvious compiler warning.

Fixes: b1e6639830bd0 ("drm/amdkfd: remove duplicated PCIE atomics request")
CC: Jack Xiao 
Signed-off-by: Felix Kuehling 
---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 24db82b61b0b..3322a443dfb2 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -487,7 +487,6 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd,
struct pci_dev *pdev, const struct kfd2kgd_calls *f2g)  {
struct kfd_dev *kfd;
-   int ret;
const struct kfd_device_info *device_info =
lookup_device_info(pdev->device);
 
--
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/1] drm/amdkfd: Remove unused variable

2019-07-02 Thread Kuehling, Felix 
Fix an obvious compiler warning.

Fixes: b1e6639830bd0 ("drm/amdkfd: remove duplicated PCIE atomics request")
CC: Jack Xiao 
Signed-off-by: Felix Kuehling 
---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 24db82b61b0b..3322a443dfb2 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -487,7 +487,6 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd,
struct pci_dev *pdev, const struct kfd2kgd_calls *f2g)
 {
struct kfd_dev *kfd;
-   int ret;
const struct kfd_device_info *device_info =
lookup_device_info(pdev->device);
 
-- 
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx