Re: [PATCH 1/2] drm/amd/powerplay: add more feature bits

2019-10-09 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang 

Best Regards,
Kevin


From: Alex Deucher 
Sent: Thursday, October 10, 2019 10:33 AM
To: Yuan, Xiaojie 
Cc: amd-gfx@lists.freedesktop.org ; Xiao, Jack 
; Quan, Evan ; Feng, Kenneth 
; Wang, Kevin(Yang) ; Zhang, Hawking 

Subject: Re: [PATCH 1/2] drm/amd/powerplay: add more feature bits

Acked-by: Alex Deucher 

On Wed, Oct 9, 2019 at 10:25 PM Yuan, Xiaojie  wrote:
>
> Ping ...
>
> BR,
> Xiaojie
> 
> From: Yuan, Xiaojie 
> Sent: Wednesday, October 9, 2019 7:08 PM
> To: amd-gfx@lists.freedesktop.org 
> Cc: Zhang, Hawking ; Xiao, Jack ; 
> Feng, Kenneth ; Quan, Evan ; Wang, 
> Kevin(Yang) ; Yuan, Xiaojie 
> Subject: [PATCH 1/2] drm/amd/powerplay: add more feature bits
>
> Signed-off-by: Xiaojie Yuan 
> ---
>  drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c 
> b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> index 5a34d01f7f7c..44152c1f01c7 100644
> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> @@ -337,19 +337,22 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,
>  | FEATURE_MASK(FEATURE_PPT_BIT)
>  | FEATURE_MASK(FEATURE_TDC_BIT)
>  | FEATURE_MASK(FEATURE_GFX_EDC_BIT)
> +   | FEATURE_MASK(FEATURE_APCC_PLUS_BIT)
>  | FEATURE_MASK(FEATURE_VR0HOT_BIT)
>  | FEATURE_MASK(FEATURE_FAN_CONTROL_BIT)
>  | FEATURE_MASK(FEATURE_THERMAL_BIT)
>  | FEATURE_MASK(FEATURE_LED_DISPLAY_BIT)
>  | FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT)
>  | FEATURE_MASK(FEATURE_DS_GFXCLK_BIT)
> +   | FEATURE_MASK(FEATURE_DS_LCLK_BIT)
>  | FEATURE_MASK(FEATURE_DS_DCEFCLK_BIT)
>  | FEATURE_MASK(FEATURE_FW_DSTATE_BIT)
>  | FEATURE_MASK(FEATURE_BACO_BIT)
>  | FEATURE_MASK(FEATURE_ACDC_BIT)
>  | FEATURE_MASK(FEATURE_GFX_SS_BIT)
>  | FEATURE_MASK(FEATURE_APCC_DFLL_BIT)
> -   | FEATURE_MASK(FEATURE_FW_CTF_BIT);
> +   | FEATURE_MASK(FEATURE_FW_CTF_BIT)
> +   | 
> FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT);
>
>  if (adev->pm.pp_feature & PP_MCLK_DPM_MASK)
>  *(uint64_t *)feature_mask |= 
> FEATURE_MASK(FEATURE_DPM_UCLK_BIT)
> --
> 2.20.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/2] drm/amd/powerplay: add more feature bits

2019-10-09 Thread Alex Deucher
Acked-by: Alex Deucher 

On Wed, Oct 9, 2019 at 10:25 PM Yuan, Xiaojie  wrote:
>
> Ping ...
>
> BR,
> Xiaojie
> 
> From: Yuan, Xiaojie 
> Sent: Wednesday, October 9, 2019 7:08 PM
> To: amd-gfx@lists.freedesktop.org 
> Cc: Zhang, Hawking ; Xiao, Jack ; 
> Feng, Kenneth ; Quan, Evan ; Wang, 
> Kevin(Yang) ; Yuan, Xiaojie 
> Subject: [PATCH 1/2] drm/amd/powerplay: add more feature bits
>
> Signed-off-by: Xiaojie Yuan 
> ---
>  drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c 
> b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> index 5a34d01f7f7c..44152c1f01c7 100644
> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
> @@ -337,19 +337,22 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,
>  | FEATURE_MASK(FEATURE_PPT_BIT)
>  | FEATURE_MASK(FEATURE_TDC_BIT)
>  | FEATURE_MASK(FEATURE_GFX_EDC_BIT)
> +   | FEATURE_MASK(FEATURE_APCC_PLUS_BIT)
>  | FEATURE_MASK(FEATURE_VR0HOT_BIT)
>  | FEATURE_MASK(FEATURE_FAN_CONTROL_BIT)
>  | FEATURE_MASK(FEATURE_THERMAL_BIT)
>  | FEATURE_MASK(FEATURE_LED_DISPLAY_BIT)
>  | FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT)
>  | FEATURE_MASK(FEATURE_DS_GFXCLK_BIT)
> +   | FEATURE_MASK(FEATURE_DS_LCLK_BIT)
>  | FEATURE_MASK(FEATURE_DS_DCEFCLK_BIT)
>  | FEATURE_MASK(FEATURE_FW_DSTATE_BIT)
>  | FEATURE_MASK(FEATURE_BACO_BIT)
>  | FEATURE_MASK(FEATURE_ACDC_BIT)
>  | FEATURE_MASK(FEATURE_GFX_SS_BIT)
>  | FEATURE_MASK(FEATURE_APCC_DFLL_BIT)
> -   | FEATURE_MASK(FEATURE_FW_CTF_BIT);
> +   | FEATURE_MASK(FEATURE_FW_CTF_BIT)
> +   | 
> FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT);
>
>  if (adev->pm.pp_feature & PP_MCLK_DPM_MASK)
>  *(uint64_t *)feature_mask |= 
> FEATURE_MASK(FEATURE_DPM_UCLK_BIT)
> --
> 2.20.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/2] drm/amd/powerplay: add more feature bits

2019-10-09 Thread Yuan, Xiaojie
Ping ...

BR,
Xiaojie

From: Yuan, Xiaojie 
Sent: Wednesday, October 9, 2019 7:08 PM
To: amd-gfx@lists.freedesktop.org 
Cc: Zhang, Hawking ; Xiao, Jack ; 
Feng, Kenneth ; Quan, Evan ; Wang, 
Kevin(Yang) ; Yuan, Xiaojie 
Subject: [PATCH 1/2] drm/amd/powerplay: add more feature bits

Signed-off-by: Xiaojie Yuan 
---
 drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c 
b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
index 5a34d01f7f7c..44152c1f01c7 100644
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -337,19 +337,22 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,
 | FEATURE_MASK(FEATURE_PPT_BIT)
 | FEATURE_MASK(FEATURE_TDC_BIT)
 | FEATURE_MASK(FEATURE_GFX_EDC_BIT)
+   | FEATURE_MASK(FEATURE_APCC_PLUS_BIT)
 | FEATURE_MASK(FEATURE_VR0HOT_BIT)
 | FEATURE_MASK(FEATURE_FAN_CONTROL_BIT)
 | FEATURE_MASK(FEATURE_THERMAL_BIT)
 | FEATURE_MASK(FEATURE_LED_DISPLAY_BIT)
 | FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT)
 | FEATURE_MASK(FEATURE_DS_GFXCLK_BIT)
+   | FEATURE_MASK(FEATURE_DS_LCLK_BIT)
 | FEATURE_MASK(FEATURE_DS_DCEFCLK_BIT)
 | FEATURE_MASK(FEATURE_FW_DSTATE_BIT)
 | FEATURE_MASK(FEATURE_BACO_BIT)
 | FEATURE_MASK(FEATURE_ACDC_BIT)
 | FEATURE_MASK(FEATURE_GFX_SS_BIT)
 | FEATURE_MASK(FEATURE_APCC_DFLL_BIT)
-   | FEATURE_MASK(FEATURE_FW_CTF_BIT);
+   | FEATURE_MASK(FEATURE_FW_CTF_BIT)
+   | FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT);

 if (adev->pm.pp_feature & PP_MCLK_DPM_MASK)
 *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DPM_UCLK_BIT)
--
2.20.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/2] drm/amd/powerplay: add more feature bits

2019-10-09 Thread Yuan, Xiaojie
Signed-off-by: Xiaojie Yuan 
---
 drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c 
b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
index 5a34d01f7f7c..44152c1f01c7 100644
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -337,19 +337,22 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,
| FEATURE_MASK(FEATURE_PPT_BIT)
| FEATURE_MASK(FEATURE_TDC_BIT)
| FEATURE_MASK(FEATURE_GFX_EDC_BIT)
+   | FEATURE_MASK(FEATURE_APCC_PLUS_BIT)
| FEATURE_MASK(FEATURE_VR0HOT_BIT)
| FEATURE_MASK(FEATURE_FAN_CONTROL_BIT)
| FEATURE_MASK(FEATURE_THERMAL_BIT)
| FEATURE_MASK(FEATURE_LED_DISPLAY_BIT)
| FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT)
| FEATURE_MASK(FEATURE_DS_GFXCLK_BIT)
+   | FEATURE_MASK(FEATURE_DS_LCLK_BIT)
| FEATURE_MASK(FEATURE_DS_DCEFCLK_BIT)
| FEATURE_MASK(FEATURE_FW_DSTATE_BIT)
| FEATURE_MASK(FEATURE_BACO_BIT)
| FEATURE_MASK(FEATURE_ACDC_BIT)
| FEATURE_MASK(FEATURE_GFX_SS_BIT)
| FEATURE_MASK(FEATURE_APCC_DFLL_BIT)
-   | FEATURE_MASK(FEATURE_FW_CTF_BIT);
+   | FEATURE_MASK(FEATURE_FW_CTF_BIT)
+   | FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT);
 
if (adev->pm.pp_feature & PP_MCLK_DPM_MASK)
*(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DPM_UCLK_BIT)
-- 
2.20.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx