Re: [PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo

2019-10-16 Thread James Zhu 
Thanks for your comments!

Alex has a new patch submit, I am verifying it.

Thanks!

James Zhu

On 2019-10-16 4:59 a.m., Christian König wrote:
> Am 16.10.19 um 00:08 schrieb Zhu, James:
>> Add uvd enc session bo for uvd encode IB test.
>>
>> Signed-off-by: James Zhu 
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 4 
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
>> index 5eb6328..1e39c8a 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
>> @@ -67,6 +67,10 @@ struct amdgpu_uvd {
>>   unsigned    harvest_config;
>>   /* store image width to adjust nb memory state */
>>   unsigned    decode_image_width;
>> +
>> +    struct amdgpu_bo *enc_session_bo;
>> +    void *enc_session_cpu_addr;
>> +    uint64_t  enc_session_gpu_addr;
>
> Please don't keep that allocated all the time, but rather only 
> allocate it on demand during the IB test.
>
> Regards,
> Christian.
>
>>   };
>>     int amdgpu_uvd_sw_init(struct amdgpu_device *adev);
>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo

2019-10-16 Thread Christian König 

Am 16.10.19 um 00:08 schrieb Zhu, James:

Add uvd enc session bo for uvd encode IB test.

Signed-off-by: James Zhu 
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 4 
  1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
index 5eb6328..1e39c8a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
@@ -67,6 +67,10 @@ struct amdgpu_uvd {
unsignedharvest_config;
/* store image width to adjust nb memory state */
unsigneddecode_image_width;
+
+   struct amdgpu_bo *enc_session_bo;
+   void *enc_session_cpu_addr;
+   uint64_t  enc_session_gpu_addr;


Please don't keep that allocated all the time, but rather only allocate 
it on demand during the IB test.


Regards,
Christian.


  };
  
  int amdgpu_uvd_sw_init(struct amdgpu_device *adev);


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo

2019-10-15 Thread Zhu, James 
Add uvd enc session bo for uvd encode IB test.

Signed-off-by: James Zhu 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
index 5eb6328..1e39c8a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
@@ -67,6 +67,10 @@ struct amdgpu_uvd {
unsignedharvest_config;
/* store image width to adjust nb memory state */
unsigneddecode_image_width;
+
+   struct amdgpu_bo *enc_session_bo;
+   void *enc_session_cpu_addr;
+   uint64_t  enc_session_gpu_addr;
 };
 
 int amdgpu_uvd_sw_init(struct amdgpu_device *adev);
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx