Re: [PATCH 1/3] drm/amdkfd: Adjust three dmesg printings during initialization

2020-04-17 Thread Alex Deucher
Patches 1, 2 are:
Reviewed-by: Alex Deucher 

On Fri, Apr 17, 2020 at 4:45 PM Yong Zhao  wrote:
>
> Delete two printings which are not very useful, and change one from
> pr_info() to pr_debug().
>
> Signed-off-by: Yong Zhao 
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index de9f68d5c312..1009a3b8dcc2 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -502,7 +502,7 @@ int kfd_parse_crat_table(void *crat_image, struct 
> list_head *device_list,
> num_nodes = crat_table->num_domains;
> image_len = crat_table->length;
>
> -   pr_info("Parsing CRAT table with %d nodes\n", num_nodes);
> +   pr_debug("Parsing CRAT table with %d nodes\n", num_nodes);
>
> for (node_id = 0; node_id < num_nodes; node_id++) {
> top_dev = kfd_create_topology_device(device_list);
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 5db42814dd51..46dcf74ee2e0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -787,7 +787,6 @@ static int kfd_topology_update_sysfs(void)
>  {
> int ret;
>
> -   pr_info("Creating topology SYSFS entries\n");
> if (!sys_props.kobj_topology) {
> sys_props.kobj_topology =
> kfd_alloc_struct(sys_props.kobj_topology);
> @@ -1048,7 +1047,6 @@ int kfd_topology_init(void)
> sys_props.generation_count++;
> kfd_update_system_properties();
> kfd_debug_print_topology();
> -   pr_info("Finished initializing topology\n");
> } else
> pr_err("Failed to update topology in sysfs ret=%d\n", ret);
>
> --
> 2.17.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH 1/3] drm/amdkfd: Adjust three dmesg printings during initialization

2020-04-17 Thread Yong Zhao
Delete two printings which are not very useful, and change one from
pr_info() to pr_debug().

Signed-off-by: Yong Zhao 
---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
 drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index de9f68d5c312..1009a3b8dcc2 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -502,7 +502,7 @@ int kfd_parse_crat_table(void *crat_image, struct list_head 
*device_list,
num_nodes = crat_table->num_domains;
image_len = crat_table->length;
 
-   pr_info("Parsing CRAT table with %d nodes\n", num_nodes);
+   pr_debug("Parsing CRAT table with %d nodes\n", num_nodes);
 
for (node_id = 0; node_id < num_nodes; node_id++) {
top_dev = kfd_create_topology_device(device_list);
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 5db42814dd51..46dcf74ee2e0 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -787,7 +787,6 @@ static int kfd_topology_update_sysfs(void)
 {
int ret;
 
-   pr_info("Creating topology SYSFS entries\n");
if (!sys_props.kobj_topology) {
sys_props.kobj_topology =
kfd_alloc_struct(sys_props.kobj_topology);
@@ -1048,7 +1047,6 @@ int kfd_topology_init(void)
sys_props.generation_count++;
kfd_update_system_properties();
kfd_debug_print_topology();
-   pr_info("Finished initializing topology\n");
} else
pr_err("Failed to update topology in sysfs ret=%d\n", ret);
 
-- 
2.17.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx