RE: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x
[AMD Official Use Only - General] Thanks Evan! Will do. Thanks, Lillian -Original Message- From: Quan, Evan Sent: Monday, March 20, 2023 4:26 AM To: Zhuo, Qingqing (Lillian) ; amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Deucher, Alexander ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: RE: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x [AMD Official Use Only - General] Better to update the subject with prefix as "drm/amd/pm" to align with other power changes. Either way the patch is Reviewed-by: Evan Quan BR Evan > -Original Message- > From: amd-gfx On Behalf Of > Qingqing Zhuo > Sent: Saturday, March 18, 2023 3:56 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) > ; Wentland, Harry ; Zhuo, > Qingqing (Lillian) ; Siqueira, Rodrigo > ; Li, Roman ; Chiu, > Solomon ; Pillai, Aurabindo > ; Lin, Wayne ; Deucher, > Alexander ; Lakha, Bhawanpreet > ; Gutierrez, Agustin > ; Kotarac, Pavle > Subject: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN > for navi1x > > From: Alex Deucher > > May help stability with some navi1x boards. > > Hopefully this helps with stability with multiple monitors and would > allow us to re-enable MPC_SPLIT_DYNAMIC in the DC code for better power > savings. > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2196 > > Reviewed-by: Rodrigo Siqueira > Acked-by: Qingqing Zhuo > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > index 95da6dd1cc65..c4000518dc56 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > @@ -304,7 +304,8 @@ navi10_get_allowed_feature_mask(struct > smu_context *smu, > | FEATURE_MASK(FEATURE_GFX_SS_BIT) > | FEATURE_MASK(FEATURE_APCC_DFLL_BIT) > | FEATURE_MASK(FEATURE_FW_CTF_BIT) > - | > FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT); > + | > FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT) > + | > FEATURE_MASK(FEATURE_TEMP_DEPENDENT_VMIN_BIT); > > if (adev->pm.pp_feature & PP_SCLK_DPM_MASK) > *(uint64_t *)feature_mask |= > FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT); > -- > 2.34.1
RE: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x
[AMD Official Use Only - General] Better to update the subject with prefix as "drm/amd/pm" to align with other power changes. Either way the patch is Reviewed-by: Evan Quan BR Evan > -Original Message- > From: amd-gfx On Behalf Of > Qingqing Zhuo > Sent: Saturday, March 18, 2023 3:56 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) > ; Wentland, Harry ; > Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo > ; Li, Roman ; Chiu, > Solomon ; Pillai, Aurabindo > ; Lin, Wayne ; Deucher, > Alexander ; Lakha, Bhawanpreet > ; Gutierrez, Agustin > ; Kotarac, Pavle > Subject: [PATCH 19/19] drm/amdgpu/smu11: enable > TEMP_DEPENDENT_VMIN for navi1x > > From: Alex Deucher > > May help stability with some navi1x boards. > > Hopefully this helps with stability with multiple monitors and would allow us > to re-enable MPC_SPLIT_DYNAMIC in the DC code for better power savings. > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2196 > > Reviewed-by: Rodrigo Siqueira > Acked-by: Qingqing Zhuo > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > index 95da6dd1cc65..c4000518dc56 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > @@ -304,7 +304,8 @@ navi10_get_allowed_feature_mask(struct > smu_context *smu, > | FEATURE_MASK(FEATURE_GFX_SS_BIT) > | FEATURE_MASK(FEATURE_APCC_DFLL_BIT) > | FEATURE_MASK(FEATURE_FW_CTF_BIT) > - | > FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT); > + | > FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT) > + | > FEATURE_MASK(FEATURE_TEMP_DEPENDENT_VMIN_BIT); > > if (adev->pm.pp_feature & PP_SCLK_DPM_MASK) > *(uint64_t *)feature_mask |= > FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT); > -- > 2.34.1
[PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x
From: Alex Deucher May help stability with some navi1x boards. Hopefully this helps with stability with multiple monitors and would allow us to re-enable MPC_SPLIT_DYNAMIC in the DC code for better power savings. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2196 Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c index 95da6dd1cc65..c4000518dc56 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c @@ -304,7 +304,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_GFX_SS_BIT) | FEATURE_MASK(FEATURE_APCC_DFLL_BIT) | FEATURE_MASK(FEATURE_FW_CTF_BIT) - | FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT); + | FEATURE_MASK(FEATURE_OUT_OF_BAND_MONITOR_BIT) + | FEATURE_MASK(FEATURE_TEMP_DEPENDENT_VMIN_BIT); if (adev->pm.pp_feature & PP_SCLK_DPM_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT); -- 2.34.1
