Re: [PATCH 2/2] drm/amdgpu/display: enable CONFIG_DRM_AMD_DC_DCN1_0 by default

2018-05-31 Thread Harry Wentland
On 2018-05-31 10:33 AM, Alex Deucher wrote:
> It's required for displays on Raven.  The DCN bandwidth calcs use
> floating point, but DCN is APU only and it already depends on
> X86.
> 
> Signed-off-by: Alex Deucher 

Series is
Reviewed-by: Harry Wentland 

Harry

> ---
>  drivers/gpu/drm/amd/display/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/Kconfig 
> b/drivers/gpu/drm/amd/display/Kconfig
> index 9d56889279b3..4c35625eb2c7 100644
> --- a/drivers/gpu/drm/amd/display/Kconfig
> +++ b/drivers/gpu/drm/amd/display/Kconfig
> @@ -12,6 +12,7 @@ config DRM_AMD_DC
>  config DRM_AMD_DC_DCN1_0
>   bool "DCN 1.0 Raven family"
>   depends on DRM_AMD_DC && X86
> + default y
>   help
> Choose this option if you want to have
> RV family for display engine
> 
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


Re: [PATCH 2/2] drm/amdgpu/display: enable CONFIG_DRM_AMD_DC_DCN1_0 by default

2018-05-31 Thread Harry Wentland
On 2018-05-31 12:08 PM, Michel Dänzer wrote:
> On 2018-05-31 04:33 PM, Alex Deucher wrote:
>> It's required for displays on Raven.  The DCN bandwidth calcs use
>> floating point, but DCN is APU only and it already depends on
>> X86.
>>
>> Signed-off-by: Alex Deucher 
>> ---
>>  drivers/gpu/drm/amd/display/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/Kconfig 
>> b/drivers/gpu/drm/amd/display/Kconfig
>> index 9d56889279b3..4c35625eb2c7 100644
>> --- a/drivers/gpu/drm/amd/display/Kconfig
>> +++ b/drivers/gpu/drm/amd/display/Kconfig
>> @@ -12,6 +12,7 @@ config DRM_AMD_DC
>>  config DRM_AMD_DC_DCN1_0
>>  bool "DCN 1.0 Raven family"
>>  depends on DRM_AMD_DC && X86
>> +default y
>>  help
>>Choose this option if you want to have
>>RV family for display engine
>>
> 
> Can CONFIG_DRM_AMD_DC_DCN1_0 just be replaced by (something like)
> CONFIG_X86 altogether?
> 
> 


Good idea.

Will have to check with some of the DC guys but it seems like a better option 
than the DCN1 one.

Harry
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


Re: [PATCH 2/2] drm/amdgpu/display: enable CONFIG_DRM_AMD_DC_DCN1_0 by default

2018-05-31 Thread Michel Dänzer
On 2018-05-31 04:33 PM, Alex Deucher wrote:
> It's required for displays on Raven.  The DCN bandwidth calcs use
> floating point, but DCN is APU only and it already depends on
> X86.
> 
> Signed-off-by: Alex Deucher 
> ---
>  drivers/gpu/drm/amd/display/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/Kconfig 
> b/drivers/gpu/drm/amd/display/Kconfig
> index 9d56889279b3..4c35625eb2c7 100644
> --- a/drivers/gpu/drm/amd/display/Kconfig
> +++ b/drivers/gpu/drm/amd/display/Kconfig
> @@ -12,6 +12,7 @@ config DRM_AMD_DC
>  config DRM_AMD_DC_DCN1_0
>   bool "DCN 1.0 Raven family"
>   depends on DRM_AMD_DC && X86
> + default y
>   help
> Choose this option if you want to have
> RV family for display engine
> 

Can CONFIG_DRM_AMD_DC_DCN1_0 just be replaced by (something like)
CONFIG_X86 altogether?


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH 2/2] drm/amdgpu/display: enable CONFIG_DRM_AMD_DC_DCN1_0 by default

2018-05-31 Thread Alex Deucher
It's required for displays on Raven.  The DCN bandwidth calcs use
floating point, but DCN is APU only and it already depends on
X86.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/display/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/Kconfig 
b/drivers/gpu/drm/amd/display/Kconfig
index 9d56889279b3..4c35625eb2c7 100644
--- a/drivers/gpu/drm/amd/display/Kconfig
+++ b/drivers/gpu/drm/amd/display/Kconfig
@@ -12,6 +12,7 @@ config DRM_AMD_DC
 config DRM_AMD_DC_DCN1_0
bool "DCN 1.0 Raven family"
depends on DRM_AMD_DC && X86
+   default y
help
  Choose this option if you want to have
  RV family for display engine
-- 
2.13.6

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx