Re: [PATCH 2/2] drm/amdgpu/powerplay: fix clock stretcher limits on polaris

2018-12-04 Thread Alex Deucher 
On Mon, Dec 3, 2018 at 9:39 PM Zhang, Jerry(Junwei)  wrote:
>
> On 12/4/18 12:21 AM, Alex Deucher wrote:
> > Adjust limits for newer polaris variants.
> >
> > Signed-off-by: Alex Deucher 
> > ---
> >   drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 17 
> > +++--
> >   1 file changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c 
> > b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
> > index 2b2c26616902..1f8736b8291d 100644
> > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
> > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
> > @@ -1528,8 +1528,21 @@ static int 
> > polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
> >   efuse = efuse >> 24;
> >
> >   if (hwmgr->chip_id == CHIP_POLARIS10) {
> > - min = 1000;
> > - max = 2300;
> > + if (hwmgr->is_kicker) {
> > + min = 1200;
> > + max = 2500;
> > + } else {
> > + min = 1000;
> > + max = 2300;
> > + }
> > + } else if (hwmgr->chip_id == CHIP_POLARIS11) {
> > + if (hwmgr->is_kicker) {
> > + min = 900;
> > + max = 2500;
>
> the max is 2100, I think.

Fixed locally.  Thanks!

Alex

>
> Apart from that, it's
> Reviewed-by: Junwei Zhang 
>
> Regards,
> Jerry
>
> > + } else {
> > + min = 1100;
> > + max = 2100;
> > + }
> >   } else {
> >   min = 1100;
> >   max = 2100;
>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/2] drm/amdgpu/powerplay: fix clock stretcher limits on polaris

2018-12-03 Thread Zhang, Jerry(Junwei) 

On 12/4/18 12:21 AM, Alex Deucher wrote:

Adjust limits for newer polaris variants.

Signed-off-by: Alex Deucher 
---
  drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 17 +++--
  1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c 
b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
index 2b2c26616902..1f8736b8291d 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
@@ -1528,8 +1528,21 @@ static int 
polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
efuse = efuse >> 24;
  
  	if (hwmgr->chip_id == CHIP_POLARIS10) {

-   min = 1000;
-   max = 2300;
+   if (hwmgr->is_kicker) {
+   min = 1200;
+   max = 2500;
+   } else {
+   min = 1000;
+   max = 2300;
+   }
+   } else if (hwmgr->chip_id == CHIP_POLARIS11) {
+   if (hwmgr->is_kicker) {
+   min = 900;
+   max = 2500;


the max is 2100, I think.

Apart from that, it's
Reviewed-by: Junwei Zhang 

Regards,
Jerry


+   } else {
+   min = 1100;
+   max = 2100;
+   }
} else {
min = 1100;
max = 2100;


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/2] drm/amdgpu/powerplay: fix clock stretcher limits on polaris

2018-12-03 Thread Alex Deucher 
Adjust limits for newer polaris variants.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c 
b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
index 2b2c26616902..1f8736b8291d 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
@@ -1528,8 +1528,21 @@ static int 
polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
efuse = efuse >> 24;
 
if (hwmgr->chip_id == CHIP_POLARIS10) {
-   min = 1000;
-   max = 2300;
+   if (hwmgr->is_kicker) {
+   min = 1200;
+   max = 2500;
+   } else {
+   min = 1000;
+   max = 2300;
+   }
+   } else if (hwmgr->chip_id == CHIP_POLARIS11) {
+   if (hwmgr->is_kicker) {
+   min = 900;
+   max = 2500;
+   } else {
+   min = 1100;
+   max = 2100;
+   }
} else {
min = 1100;
max = 2100;
-- 
2.13.6

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx