RE: [PATCH 2/2] drm/amdgpu: fix PTE defines

[Deucher, Alexander]

> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Monday, February 13, 2017 8:24 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 2/2] drm/amdgpu: fix PTE defines
> 
> From: Christian König <christian.koe...@amd.com>
> 
> Those should be 64bit, even on a 32bit system.
> 
> Signed-off-by: Christian König <christian.koe...@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> index 4d26e9b..51fa12f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
> @@ -53,19 +53,19 @@ struct amdgpu_bo_list_entry;
>  /* LOG2 number of continuous pages for the fragment field */
>  #define AMDGPU_LOG2_PAGES_PER_FRAG 4
> 
> -#define AMDGPU_PTE_VALID (1 << 0)
> -#define AMDGPU_PTE_SYSTEM(1 << 1)
> -#define AMDGPU_PTE_SNOOPED   (1 << 2)
> +#define AMDGPU_PTE_VALID (1ULL << 0)
> +#define AMDGPU_PTE_SYSTEM(1ULL << 1)
> +#define AMDGPU_PTE_SNOOPED   (1ULL << 2)
> 
>  /* VI only */
> -#define AMDGPU_PTE_EXECUTABLE(1 << 4)
> +#define AMDGPU_PTE_EXECUTABLE(1ULL << 4)
> 
> -#define AMDGPU_PTE_READABLE  (1 << 5)
> -#define AMDGPU_PTE_WRITEABLE (1 << 6)
> +#define AMDGPU_PTE_READABLE  (1ULL << 5)
> +#define AMDGPU_PTE_WRITEABLE (1ULL << 6)
> 
>  #define AMDGPU_PTE_FRAG(x)   ((x & 0x1f) << 7)
> 
> -#define AMDGPU_PTE_PRT   (1UL << 63)
> +#define AMDGPU_PTE_PRT   (1ULL << 63)
> 
>  /* How to programm VM fault handling */
>  #define AMDGPU_VM_FAULT_STOP_NEVER   0
> --
> 2.5.0
> 
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/2] drm/amdgpu: fix PTE defines

[Christian König]

From: Christian König 

Those should be 64bit, even on a 32bit system.

Signed-off-by: Christian König 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
index 4d26e9b..51fa12f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
@@ -53,19 +53,19 @@ struct amdgpu_bo_list_entry;
 /* LOG2 number of continuous pages for the fragment field */
 #define AMDGPU_LOG2_PAGES_PER_FRAG 4
 
-#define AMDGPU_PTE_VALID   (1 << 0)
-#define AMDGPU_PTE_SYSTEM  (1 << 1)
-#define AMDGPU_PTE_SNOOPED (1 << 2)
+#define AMDGPU_PTE_VALID   (1ULL << 0)
+#define AMDGPU_PTE_SYSTEM  (1ULL << 1)
+#define AMDGPU_PTE_SNOOPED (1ULL << 2)
 
 /* VI only */
-#define AMDGPU_PTE_EXECUTABLE  (1 << 4)
+#define AMDGPU_PTE_EXECUTABLE  (1ULL << 4)
 
-#define AMDGPU_PTE_READABLE(1 << 5)
-#define AMDGPU_PTE_WRITEABLE   (1 << 6)
+#define AMDGPU_PTE_READABLE(1ULL << 5)
+#define AMDGPU_PTE_WRITEABLE   (1ULL << 6)
 
 #define AMDGPU_PTE_FRAG(x) ((x & 0x1f) << 7)
 
-#define AMDGPU_PTE_PRT (1UL << 63)
+#define AMDGPU_PTE_PRT (1ULL << 63)
 
 /* How to programm VM fault handling */
 #define AMDGPU_VM_FAULT_STOP_NEVER 0
-- 
2.5.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx