RE: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

[Othman, Ahmad]

Hi Alex,

There are callers in the same file "info_packet.c" 

-Original Message-
From: Alex Deucher  
Sent: August 27, 2019 10:20
To: Wentland, Harry 
Cc: YueHaibing ; Wentland, Harry 
; Li, Sun peng (Leo) ; Deucher, 
Alexander ; Koenig, Christian 
; Zhou, David(ChunMing) ; 
airl...@linux.ie; dan...@ffwll.ch; Lakha, Bhawanpreet 
; Koo, Anthony ; Othman, Ahmad 
; Bernstein, Eric ; Cyr, Aric 
; alvin.l...@amd.com; Tatla, Harmanprit 
; dri-de...@lists.freedesktop.org; 
amd-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function 
setFieldWithMask

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland  wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), 
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot  Signed-off-by: 
> > YueHaibing 
>
> Reviewed-by: Harry Wentland 
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> > ---
> >  1 file changed, 19 deletions(-)
> >
> > diff --git 
> > a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >   ColorimetryYCC_DP_ITU2020YCbCr  = 7,  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, 
> > unsigned int value) -{
> > - unsigned int shift = 0;
> > -
> > - if (!mask || !dest)
> > - return;
> > -
> > - while (!((mask >> shift) & 1))
> > - shift++;
> > -
> > - //reset
> > - *dest = *dest & ~mask;
> > - //set
> > - //dont let value span past mask
> > - value = value & (mask >> shift);
> > - //insert value
> > - *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >   struct dc_info_packet *info_packet)  {
> >
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

[Alex Deucher]

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland  wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot  Signed-off-by: YueHaibing 
> > 
>
> Reviewed-by: Harry Wentland 
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> > ---
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >   ColorimetryYCC_DP_ITU2020YCbCr  = 7,
> >  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int 
> > value)
> > -{
> > - unsigned int shift = 0;
> > -
> > - if (!mask || !dest)
> > - return;
> > -
> > - while (!((mask >> shift) & 1))
> > - shift++;
> > -
> > - //reset
> > - *dest = *dest & ~mask;
> > - //set
> > - //dont let value span past mask
> > - value = value & (mask >> shift);
> > - //insert value
> > - *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >   struct dc_info_packet *info_packet)
> >  {
> >
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

[Harry Wentland]

On 2019-08-27 3:09 a.m., YueHaibing wrote:
> After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> there is no caller in tree.
> 
> Reported-by: Hulk Robot  Signed-off-by: YueHaibing 
> 

Reviewed-by: Harry Wentland 

Harry

> ---
>  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> ---
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> index 5f4b98d..d885d64 100644
> --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
>   ColorimetryYCC_DP_ITU2020YCbCr  = 7,
>  };
>  
> -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int 
> value)
> -{
> - unsigned int shift = 0;
> -
> - if (!mask || !dest)
> - return;
> -
> - while (!((mask >> shift) & 1))
> - shift++;
> -
> - //reset
> - *dest = *dest & ~mask;
> - //set
> - //dont let value span past mask
> - value = value & (mask >> shift);
> - //insert value
> - *dest = *dest | (value << shift);
> -}
> -
>  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
>   struct dc_info_packet *info_packet)
>  {
> 
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

[YueHaibing]

After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
there is no caller in tree.

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
---
 .../drm/amd/display/modules/info_packet/info_packet.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
index 5f4b98d..d885d64 100644
--- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
+++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
@@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
ColorimetryYCC_DP_ITU2020YCbCr  = 7,
 };
 
-void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int 
value)
-{
-   unsigned int shift = 0;
-
-   if (!mask || !dest)
-   return;
-
-   while (!((mask >> shift) & 1))
-   shift++;
-
-   //reset
-   *dest = *dest & ~mask;
-   //set
-   //dont let value span past mask
-   value = value & (mask >> shift);
-   //insert value
-   *dest = *dest | (value << shift);
-}
-
 void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
struct dc_info_packet *info_packet)
 {
-- 
2.7.4