Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default
On Fri, Aug 11, 2023 at 9:45 AM Jason Gunthorpe wrote: > > On Mon, Aug 07, 2023 at 06:05:41PM -0400, Alex Deucher wrote: > > We are dropping the IOMMUv2 path, so no need to enable this. > > It's often buggy on consumer platforms anyway. > > > > Signed-off-by: Alex Deucher > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 > > 1 file changed, 4 deletions(-) > > For the series, please can we go ahead with this ASAP? > > The iommu side desperately needs the removal of the iommu_v2 private > interface to the GPU. > > I'm really glad to see we can just delete the whole thing! Yes, that is the plan. Alex
Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default
On Mon, Aug 07, 2023 at 06:05:41PM -0400, Alex Deucher wrote: > We are dropping the IOMMUv2 path, so no need to enable this. > It's often buggy on consumer platforms anyway. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 > 1 file changed, 4 deletions(-) For the series, please can we go ahead with this ASAP? The iommu side desperately needs the removal of the iommu_v2 private interface to the GPU. I'm really glad to see we can just delete the whole thing! Thanks, Jason
Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default
On 2023-08-07 18:05, Alex Deucher wrote: We are dropping the IOMMUv2 path, so no need to enable this. It's often buggy on consumer platforms anyway. Signed-off-by: Alex Deucher The series is Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 49f40d9f16e86..f5a6f562e2a80 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -1543,11 +1543,7 @@ static bool kfd_ignore_crat(void) if (ignore_crat) return true; -#ifndef KFD_SUPPORT_IOMMU_V2 ret = true; -#else - ret = false; -#endif return ret; }
Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default
On Tue, 8 Aug 2023 at 15:59, Christian König wrote: > > Am 08.08.23 um 00:05 schrieb Alex Deucher: > > We are dropping the IOMMUv2 path, so no need to enable this. > > It's often buggy on consumer platforms anyway. > > > > Signed-off-by: Alex Deucher > > Bye ATC, it wasn't really nice with you :) > > Acked-by: Christian König for the whole series. > Tested-by: Mike Lothian
Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default
Am 08.08.23 um 00:05 schrieb Alex Deucher: We are dropping the IOMMUv2 path, so no need to enable this. It's often buggy on consumer platforms anyway. Signed-off-by: Alex Deucher Bye ATC, it wasn't really nice with you :) Acked-by: Christian König for the whole series. --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 49f40d9f16e86..f5a6f562e2a80 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -1543,11 +1543,7 @@ static bool kfd_ignore_crat(void) if (ignore_crat) return true; -#ifndef KFD_SUPPORT_IOMMU_V2 ret = true; -#else - ret = false; -#endif return ret; }
[PATCH V2 1/5] drm/amdkfd: ignore crat by default
We are dropping the IOMMUv2 path, so no need to enable this. It's often buggy on consumer platforms anyway. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 49f40d9f16e86..f5a6f562e2a80 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -1543,11 +1543,7 @@ static bool kfd_ignore_crat(void) if (ignore_crat) return true; -#ifndef KFD_SUPPORT_IOMMU_V2 ret = true; -#else - ret = false; -#endif return ret; } -- 2.41.0
