Re: [REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo
On Wed, May 17, 2017 at 11:08:23PM +0200, Nicolai Stange wrote:
> I'm experiencing a boot failure on next-20170515:
>
> BUG: unable to handle kernel NULL pointer dereference at 07cb
> IP: radeon_driver_load_kms+0xeb/0x230 [radeon]
[snip]
> Bisection lead to commit 7ffb0ce31cf9 ("drm/radeon: Don't register
> Thunderbolt eGPU with vga_switcheroo"). Reverting this commit on top of
> next-20170515 fixes the issue for me.
>
> My box is a Dell laptop which most certainly hasn't got any Thunderbolt
> circuitry.
Thanks a lot Nicolai for reporting this, my apologies for the breakage
which turns out to be a dereference of rdev->pdev before it's set. :-(
14: e8 e7 c0 0e 00 callq 0xec100 ; radeon_has_atpx()
19: 84 c0 test %al,%al
1b: 74 9a je 0xffb7
1d: 41 f7 c5 00 00 02 00test $0x2,%r13d ; flags & RADEON_IS_IGP
24: 75 91 jne0xffb7
26: 49 8b 44 24 10 mov0x10(%r12),%rax ; rax = rdev
2b:* 0f b6 90 cb 07 00 00movzbl 0x7cb(%rax),%edx <-- trapping
instruction
Could you verify if the patch below fixes the issue for you?
Thanks!
Lukas
-- >8 --
diff --git a/drivers/gpu/drm/radeon/radeon_kms.c
b/drivers/gpu/drm/radeon/radeon_kms.c
index e3e7cb1..4761f27 100644
--- a/drivers/gpu/drm/radeon/radeon_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_kms.c
@@ -116,7 +116,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned
long flags)
if ((radeon_runtime_pm != 0) &&
radeon_has_atpx() &&
((flags & RADEON_IS_IGP) == 0) &&
- !pci_is_thunderbolt_attached(rdev->pdev))
+ !pci_is_thunderbolt_attached(dev->pdev))
flags |= RADEON_IS_PX;
/* radeon_device_init should report only fatal error
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo
Hi,
I'm experiencing a boot failure on next-20170515:
BUG: unable to handle kernel NULL pointer dereference at 07cb
IP: radeon_driver_load_kms+0xeb/0x230 [radeon]
PGD 0
P4D 0
Oops: [#1] SMP
Modules linked in: amdkfd amd_iommu_v2 i915(+) radeon(+) i2c_algo_bit
drm_kms_helper ttm e1000e drm sdhci_pci sdhci_acpi ptp sdhci crc32c_intel
serio_raw mmc_core pps_core video i2c_hid hid_plantronics
CPU: 4 PID: 389 Comm: systemd-udevd Not tainted 4.12.0-rc1-next-20170515+ #1
Hardware name: Dell Inc. Latitude E6540/0725FP, BIOS A10 06/26/2014
task: 97d62c8f task.stack: b96f01478000
RIP: 0010:radeon_driver_load_kms+0xeb/0x230 [radeon]
RSP: 0018:b96f0147b9d0 EFLAGS: 00010246
RAX: RBX: 97d620085000 RCX: 00610037
RDX: RSI: 002b RDI:
RBP: b96f0147b9e8 R08: 0002 R09: b96f0147b924
R10: R11: 97d62edd2ec0 R12: 97d628d5c000
R13: 00610037 R14: c0698280 R15:
FS: 7f496363d8c0() GS:97d62eb0() knlGS:
CS: 0010 DS: ES: CR0: 80050033
CR2: 07cb CR3: 00022c14c000 CR4: 001406e0
Call Trace:
drm_dev_register+0x146/0x1d0 [drm]
drm_get_pci_dev+0x9a/0x180 [drm]
radeon_pci_probe+0xb8/0xe0 [radeon]
local_pci_probe+0x45/0xa0
pci_device_probe+0x14f/0x1a0
driver_probe_device+0x29c/0x450
__driver_attach+0xdf/0xf0
? driver_probe_device+0x450/0x450
bus_for_each_dev+0x6c/0xc0
driver_attach+0x1e/0x20
bus_add_driver+0x170/0x270
driver_register+0x60/0xe0
? 0xc0508000
__pci_register_driver+0x4c/0x50
drm_pci_init+0xeb/0x100 [drm]
? vga_switcheroo_register_handler+0x6a/0x90
? 0xc0508000
radeon_init+0x98/0xb6 [radeon]
do_one_initcall+0x52/0x1a0
? __vunmap+0x81/0xb0
? kmem_cache_alloc_trace+0x159/0x1b0
? do_init_module+0x27/0x1f8
do_init_module+0x5f/0x1f8
load_module+0x27ce/0x2be0
SYSC_finit_module+0xdf/0x110
? SYSC_finit_module+0xdf/0x110
SyS_finit_module+0xe/0x10
do_syscall_64+0x67/0x150
entry_SYSCALL64_slow_path+0x25/0x25
RIP: 0033:0x7f4962295679
RSP: 002b:7ffdd8c4f878 EFLAGS: 0246 ORIG_RAX: 0139
RAX: ffda RBX: 55c014ed8200 RCX: 7f4962295679
RDX: RSI: 7f4962dd19c5 RDI: 0010
RBP: 7f4962dd19c5 R08: R09: 7ffdd8c4f990
R10: 0010 R11: 0246 R12:
R13: 55c014ed81a0 R14: 0002 R15: 55c0149d1fca
Code: 5d 5d c3 8b 05 a7 05 14 00 49 81 cd 00 00 08 00 85 c0 74 a3 e8 e7 c0 0e
00 84 c0 74 9a 41 f7 c5 00 00 02 00 75 91 49 8b 44 24 10 <0f> b6 90 cb 07 00 00
f6 c2 20 74 1e e9 7b ff ff ff 48 8b 40 38
RIP: radeon_driver_load_kms+0xeb/0x230 [radeon] RSP: b96f0147b9d0
CR2: 07cb
---[ end trace 89cc4ba7e569c65c ]---
Bisection lead to commit 7ffb0ce31cf9 ("drm/radeon: Don't register
Thunderbolt eGPU with vga_switcheroo"). Reverting this commit on top of
next-20170515 fixes the issue for me.
My box is a Dell laptop which most certainly hasn't got any Thunderbolt
circuitry.
lspci says that my radeon card is a
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Mars XTX [Radeon HD 8790M] (rev ff) (prog-if ff)
or in raw form:
01:00.0 0300: 1002:6606 (rev ff)
Thanks,
Nicolai
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
