Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: Hi Esaki-san, On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the DRM core should handle this rather than open-coding in every driver. In this patch series, these drivers expose format modifiers based on the following suggestion[1]. Thanks for the series, it looks like the right thing to do. Can you please change the patch ordering though? At the moment there will be a bisection break at patch #1, because the legacy drivers will suddenly start gaining modifier support, before it is removed in patch #2. I think a better order would be: 1: add fb_modifiers_not_supported flag to core and drivers 2: add default modifiers (and set allow_fb_modifiers) if fb_modifiers_not_supported flag is not set 3: remove allow_fb_modifiers flag I agree to your proposal. I will fix these patches. -- -- 株式会社イーゲル 江崎 朋人 e...@igel.co.jp
Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Hi Esaki-san, On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: > Some drivers whose planes only support linear layout fb do not support format > modifiers. > These drivers should support modifiers, however the DRM core should handle > this > rather than open-coding in every driver. > > In this patch series, these drivers expose format modifiers based on the > following suggestion[1]. Thanks for the series, it looks like the right thing to do. Can you please change the patch ordering though? At the moment there will be a bisection break at patch #1, because the legacy drivers will suddenly start gaining modifier support, before it is removed in patch #2. I think a better order would be: 1: add fb_modifiers_not_supported flag to core and drivers 2: add default modifiers (and set allow_fb_modifiers) if fb_modifiers_not_supported flag is not set 3: remove allow_fb_modifiers flag Cheers, Daniel
[RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout
Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the DRM core should handle this rather than open-coding in every driver. In this patch series, these drivers expose format modifiers based on the following suggestion[1]. On Thu, Nov 18, 2021 at 01:02:11PM +, Daniel Stone wrote: > I think the best way forward here is: > - add a new mode_config.cannot_support_modifiers flag, and enable > this in radeon (plus any other drivers in the same boat) > - change drm_universal_plane_init() to advertise the LINEAR modifier > when NULL is passed as the modifier list (including installing a > default .format_mod_supported hook) > - remove the mode_config.allow_fb_modifiers hook and always > advertise modifier support, unless > mode_config.cannot_support_modifiers is set [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20190509054518.10781-1-e...@igel.co.jp/#24602575 v2: * rebase to the latest master branch (5.16.0+) + "drm/plane: Make format_mod_supported truly optional" patch [2] [2] https://patchwork.freedesktop.org/patch/467940/?series=98255=3 v1: https://www.spinics.net/lists/dri-devel/msg327352.html * The initial patch set Tomohito Esaki (3): drm: add support modifiers for drivers whose planes only support linear layout drm: set fb_modifiers_not_supported flag in legacy drivers drm: replace allow_fb_modifiers with fb_modifiers_not_supported drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 2 ++ drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++ drivers/gpu/drm/drm_framebuffer.c | 6 ++--- drivers/gpu/drm/drm_ioctl.c | 2 +- drivers/gpu/drm/drm_plane.c | 22 +-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++-- drivers/gpu/drm/radeon/radeon_display.c | 2 ++ .../gpu/drm/selftests/test-drm_framebuffer.c | 1 - include/drm/drm_mode_config.h | 18 +-- include/drm/drm_plane.h | 3 +++ 13 files changed, 40 insertions(+), 33 deletions(-) -- 2.25.1
