Re: [pull] amdgpu drm-fixes-5.2
On Wed, Jul 3, 2019 at 3:10 PM Alex Deucher wrote:
>
> On Wed, Jul 3, 2019 at 5:54 AM Daniel Vetter wrote:
> >
> > On Tue, Jul 02, 2019 at 08:57:05PM -0500, Alex Deucher wrote:
> > > Hi Dave, Daniel,
> > >
> > > 3 fixes all cc'ed to stable. Note that dim complains about the Fixes tag
> > > in one of the patches. The patch has:
> > > Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings
> > > only on needed")
> > > while dim recommends:
> >
> > This is the right format.
> >
> > > Fixes: commit 921935dc6404 ("drm/amd/powerplay: enforce display related
> > > settings only on needed")
> >
> > Adding a "commit" is wrong. And at least my dim here doesn't complain
> > about your pull. How did you test this?
>
> dim checkpatch 665d6d4e32313a7952bb3339647f74c3a6b0d78a
Hah, another one fell into the trap :-/
dim checkpatch is just a wrapper around scripts/checkpatch.pl, it's
not what's used when you push to a dim managed branch, or what we use
when processing a pull request.
> -:8: ERROR:GIT_COMMIT_ID: Please use git commit description style
> 'commit <12+ chars of sha1> ("")' - ie: 'commit
> 921935dc6404 ("drm/amd/powerplay: enforce display related settings
> only on needed")'
> #8:
> 921935dc6404 ("drm/amd/powerplay: enforce display related settings
> only on needed")
Because checkpatch is garbage. The real dim checks only get used for
dim push and dim apply-pull. There was a half-baked patch somewhere to
integrate that into dim checkpatch, but that still leaves the problem
that checkpatch.pl is useless. Other option is if you use dim push to
push to the drm-amd.git tree (it's still all set up from years back
when at least Harry seemed somewhat enthusiastic about
group-maintaining amd.git outside of the amd firewall instead of
inside).
> Alex
>
> > -Daniel
> >
> > > I feel like the former is the more common nomencleture (at least
> > > historically),
> > > but I'm happy to respin if you'd prefer.
> > >
> > > The following changes since commit
> > > 665d6d4e32313a7952bb3339647f74c3a6b0d78a:
> > >
> > > Merge tag 'drm-misc-fixes-2019-06-26' of
> > > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-06-27
> > > 11:34:52 +1000)
> > >
> > > are available in the Git repository at:
> > >
> > > git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.2-2019-07-02
> > >
> > > for you to fetch changes up to 25f09f858835b0e9a06213811031190a17d8ab78:
> > >
> > > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE (2019-07-01
> > > 12:16:26 -0500)
> > >
> > >
> > > drm-fixes-5.2-2019-07-02:
> > >
> > > Fixes for stable
> > >
> > > amdgpu:
> > > - stability fix for gfx9
> > > - regression fix for HG on some polaris boards
> > > - crash fix for some new OEM boards
> > >
> > >
> > > Alex Deucher (1):
> > > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE
> > >
> > > Evan Quan (1):
> > > drm/amd/powerplay: use hardware fan control if no powerplay fan
> > > table
> > >
> > > Lyude Paul (1):
> > > drm/amdgpu: Don't skip display settings in hwmgr_resume()
> > >
> > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19
> > > ---
> > > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +-
> > > .../drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +++-
> > > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 +
> > > .../gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4
> > > 5 files changed, 9 insertions(+), 21 deletions(-)
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [pull] amdgpu drm-fixes-5.2
On Wed, Jul 3, 2019 at 5:54 AM Daniel Vetter wrote:
>
> On Tue, Jul 02, 2019 at 08:57:05PM -0500, Alex Deucher wrote:
> > Hi Dave, Daniel,
> >
> > 3 fixes all cc'ed to stable. Note that dim complains about the Fixes tag
> > in one of the patches. The patch has:
> > Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings
> > only on needed")
> > while dim recommends:
>
> This is the right format.
>
> > Fixes: commit 921935dc6404 ("drm/amd/powerplay: enforce display related
> > settings only on needed")
>
> Adding a "commit" is wrong. And at least my dim here doesn't complain
> about your pull. How did you test this?
dim checkpatch 665d6d4e32313a7952bb3339647f74c3a6b0d78a
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style
'commit <12+ chars of sha1> ("")' - ie: 'commit
921935dc6404 ("drm/amd/powerplay: enforce display related settings
only on needed")'
#8:
921935dc6404 ("drm/amd/powerplay: enforce display related settings
only on needed")
Alex
> -Daniel
>
> > I feel like the former is the more common nomencleture (at least
> > historically),
> > but I'm happy to respin if you'd prefer.
> >
> > The following changes since commit 665d6d4e32313a7952bb3339647f74c3a6b0d78a:
> >
> > Merge tag 'drm-misc-fixes-2019-06-26' of
> > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-06-27
> > 11:34:52 +1000)
> >
> > are available in the Git repository at:
> >
> > git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.2-2019-07-02
> >
> > for you to fetch changes up to 25f09f858835b0e9a06213811031190a17d8ab78:
> >
> > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE (2019-07-01
> > 12:16:26 -0500)
> >
> >
> > drm-fixes-5.2-2019-07-02:
> >
> > Fixes for stable
> >
> > amdgpu:
> > - stability fix for gfx9
> > - regression fix for HG on some polaris boards
> > - crash fix for some new OEM boards
> >
> >
> > Alex Deucher (1):
> > drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE
> >
> > Evan Quan (1):
> > drm/amd/powerplay: use hardware fan control if no powerplay fan table
> >
> > Lyude Paul (1):
> > drm/amdgpu: Don't skip display settings in hwmgr_resume()
> >
> > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19
> > ---
> > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +-
> > .../drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +++-
> > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 +
> > .../gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4
> > 5 files changed, 9 insertions(+), 21 deletions(-)
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [pull] amdgpu drm-fixes-5.2
On Tue, Jul 02, 2019 at 08:57:05PM -0500, Alex Deucher wrote:
> Hi Dave, Daniel,
>
> 3 fixes all cc'ed to stable. Note that dim complains about the Fixes tag
> in one of the patches. The patch has:
> Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings
> only on needed")
> while dim recommends:
This is the right format.
> Fixes: commit 921935dc6404 ("drm/amd/powerplay: enforce display related
> settings only on needed")
Adding a "commit" is wrong. And at least my dim here doesn't complain
about your pull. How did you test this?
-Daniel
> I feel like the former is the more common nomencleture (at least
> historically),
> but I'm happy to respin if you'd prefer.
>
> The following changes since commit 665d6d4e32313a7952bb3339647f74c3a6b0d78a:
>
> Merge tag 'drm-misc-fixes-2019-06-26' of
> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-06-27
> 11:34:52 +1000)
>
> are available in the Git repository at:
>
> git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.2-2019-07-02
>
> for you to fetch changes up to 25f09f858835b0e9a06213811031190a17d8ab78:
>
> drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE (2019-07-01 12:16:26
> -0500)
>
>
> drm-fixes-5.2-2019-07-02:
>
> Fixes for stable
>
> amdgpu:
> - stability fix for gfx9
> - regression fix for HG on some polaris boards
> - crash fix for some new OEM boards
>
>
> Alex Deucher (1):
> drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE
>
> Evan Quan (1):
> drm/amd/powerplay: use hardware fan control if no powerplay fan table
>
> Lyude Paul (1):
> drm/amdgpu: Don't skip display settings in hwmgr_resume()
>
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +-
> .../drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +++-
> drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 +
> .../gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4
> 5 files changed, 9 insertions(+), 21 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[pull] amdgpu drm-fixes-5.2
Hi Dave, Daniel,
3 fixes all cc'ed to stable. Note that dim complains about the Fixes tag
in one of the patches. The patch has:
Fixes: 921935dc6404 ("drm/amd/powerplay: enforce display related settings only
on needed")
while dim recommends:
Fixes: commit 921935dc6404 ("drm/amd/powerplay: enforce display related
settings only on needed")
I feel like the former is the more common nomencleture (at least historically),
but I'm happy to respin if you'd prefer.
The following changes since commit 665d6d4e32313a7952bb3339647f74c3a6b0d78a:
Merge tag 'drm-misc-fixes-2019-06-26' of
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-06-27 11:34:52
+1000)
are available in the Git repository at:
git://people.freedesktop.org/~agd5f/linux tags/drm-fixes-5.2-2019-07-02
for you to fetch changes up to 25f09f858835b0e9a06213811031190a17d8ab78:
drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE (2019-07-01 12:16:26
-0500)
drm-fixes-5.2-2019-07-02:
Fixes for stable
amdgpu:
- stability fix for gfx9
- regression fix for HG on some polaris boards
- crash fix for some new OEM boards
Alex Deucher (1):
drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE
Evan Quan (1):
drm/amd/powerplay: use hardware fan control if no powerplay fan table
Lyude Paul (1):
drm/amdgpu: Don't skip display settings in hwmgr_resume()
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19 ---
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +-
.../drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 +++-
drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 +
.../gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4
5 files changed, 9 insertions(+), 21 deletions(-)
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [pull] amdgpu drm-fixes-5.2
On Fri, Jun 14, 2019 at 5:49 PM Daniel Vetter wrote:
>
> On Wed, Jun 12, 2019 at 09:18:56PM -0500, Alex Deucher wrote:
> > Hi Dave, Daniel,
> >
> > Fixes for 5.2:
> > - Extend previous vce fix for resume to uvd and vcn
> > - Fix bounds checking in ras debugfs interface
> > - Fix a regression on SI using amdgpu
> >
> > The following changes since commit 671e2ee5ee2127179ca884b439ab6001a623edd6:
> >
> > Merge branch 'linux-5.2' of git://github.com/skeggsb/linux into drm-fixes
> > (2019-06-07 17:16:00 +1000)
>
> Somehow missed this one, but just found it before I wanted to push out the
> -fixes pull to Linus ...
>
> > are available in the Git repository at:
> >
> > git://people.freedesktop.org/~agd5f/linux drm-fixes-5.2
>
> Pulled, thanks.
Was a bit a lie, the script was still running, and complained that I
didn't add a proper merge commit message. Can you pls use annotated
tags, then the tooling we use makes this happen automatically? dim
pull-request for cheatsheet, if you need one.
Cheers, Daniel
> -Daniel
>
> >
> > for you to fetch changes up to f3a5231c8f14acd42845e9e60f506b4e948f0e68:
> >
> > drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware
> > (2019-06-12 20:39:49 -0500)
> >
> >
> > Alex Deucher (1):
> > drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware
> >
> > Dan Carpenter (1):
> > drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()
> >
> > Shirish S (1):
> > drm/amdgpu/{uvd,vcn}: fetch ring's read_ptr after alloc
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 ++
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +++-
> > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 -
> > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 5 -
> > 5 files changed, 15 insertions(+), 5 deletions(-)
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [pull] amdgpu drm-fixes-5.2
On Wed, Jun 12, 2019 at 09:18:56PM -0500, Alex Deucher wrote:
> Hi Dave, Daniel,
>
> Fixes for 5.2:
> - Extend previous vce fix for resume to uvd and vcn
> - Fix bounds checking in ras debugfs interface
> - Fix a regression on SI using amdgpu
>
> The following changes since commit 671e2ee5ee2127179ca884b439ab6001a623edd6:
>
> Merge branch 'linux-5.2' of git://github.com/skeggsb/linux into drm-fixes
> (2019-06-07 17:16:00 +1000)
Somehow missed this one, but just found it before I wanted to push out the
-fixes pull to Linus ...
> are available in the Git repository at:
>
> git://people.freedesktop.org/~agd5f/linux drm-fixes-5.2
Pulled, thanks.
-Daniel
>
> for you to fetch changes up to f3a5231c8f14acd42845e9e60f506b4e948f0e68:
>
> drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware (2019-06-12
> 20:39:49 -0500)
>
>
> Alex Deucher (1):
> drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware
>
> Dan Carpenter (1):
> drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()
>
> Shirish S (1):
> drm/amdgpu/{uvd,vcn}: fetch ring's read_ptr after alloc
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +++-
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 -
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 5 -
> 5 files changed, 15 insertions(+), 5 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[pull] amdgpu drm-fixes-5.2
Hi Dave, Daniel,
Fixes for 5.2:
- Extend previous vce fix for resume to uvd and vcn
- Fix bounds checking in ras debugfs interface
- Fix a regression on SI using amdgpu
The following changes since commit 671e2ee5ee2127179ca884b439ab6001a623edd6:
Merge branch 'linux-5.2' of git://github.com/skeggsb/linux into drm-fixes
(2019-06-07 17:16:00 +1000)
are available in the Git repository at:
git://people.freedesktop.org/~agd5f/linux drm-fixes-5.2
for you to fetch changes up to f3a5231c8f14acd42845e9e60f506b4e948f0e68:
drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware (2019-06-12
20:39:49 -0500)
Alex Deucher (1):
drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware
Dan Carpenter (1):
drm/amdgpu: Fix bounds checking in amdgpu_ras_is_supported()
Shirish S (1):
drm/amdgpu/{uvd,vcn}: fetch ring's read_ptr after alloc
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +++-
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 5 -
5 files changed, 15 insertions(+), 5 deletions(-)
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[pull] amdgpu drm-fixes-5.2
Hi Dave, Daniel, Fixes for 5.2: - A fix to make VCE resume more reliable - Updates for new raven variants The following changes since commit 2a3e0b716296a504d9e65fea7acb379c86fe4283: Merge tag 'imx-drm-fixes-2019-05-29' of git://git.pengutronix.de/git/pza/linux into drm-fixes (2019-05-31 09:15:25 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-5.2 for you to fetch changes up to 1929059893022a3bbed43934c7313e66aad7346b: drm/amd/amdgpu: add RLC firmware to support raven1 refresh (2019-06-05 11:14:15 -0500) Chengming Gui (1): drm/amd/powerplay: add set_power_profile_mode for raven1_refresh Louis Li (1): drm/amdgpu: fix ring test failure issue during s3 in vce 3.0 (V2) Prike Liang (1): drm/amd/amdgpu: add RLC firmware to support raven1 refresh drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 12 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 4 ++- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 - drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 1 + drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 31 --- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + 8 files changed, 63 insertions(+), 14 deletions(-) ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[pull] amdgpu drm-fixes-5.2
Hi Dave, Daniel, Fixes for 5.2: - Respin the Raven DMCU patch with the ifdef fixed - Fix for a clean display when loading the driver on Raven The following changes since commit c074989171801171af6c5f53dd16b27f36b31deb: Revert "drm/amd/display: Don't load DMCU for Raven 1" (2019-05-24 19:56:50 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-5.2 for you to fetch changes up to 02122753f1d0ac39d8c89f20f541a519a3002e92: drm/amdgpu: reserve stollen vram for raven series (2019-05-29 09:52:10 -0500) Flora Cui (1): drm/amdgpu: reserve stollen vram for raven series Harry Wentland (1): drm/amd/display: Don't load DMCU for Raven 1 (v2) drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +-- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
