RE: [PATCH] drm/amd/amdgpu: Cancel the hrtimer in sw_fini

2021-05-09 Thread Deng, Emily
Reviewed-by: Emily Deng 

>-Original Message-
>From: amd-gfx  On Behalf Of Sun, Roy
>Sent: Saturday, May 8, 2021 12:35 PM
>To: Sun, Roy ; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH] drm/amd/amdgpu: Cancel the hrtimer in sw_fini
>
>[AMD Official Use Only - Internal Distribution Only]
>
>Ping
>
>-Original Message-
>From: Roy Sun 
>Sent: Tuesday, April 6, 2021 8:21 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Sun, Roy 
>Subject: [PATCH] drm/amd/amdgpu: Cancel the hrtimer in sw_fini
>
>Move the process of cancelling hrtimer to sw_fini
>
>Signed-off-by: Roy Sun 
>---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>index 5c11144da051..33324427b555 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>@@ -421,6 +421,11 @@ static int dce_virtual_sw_init(void *handle)  static int
>dce_virtual_sw_fini(void *handle)  {
>   struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>+  int i = 0;
>+
>+  for (i = 0; i < adev->mode_info.num_crtc; i++)
>+  if (adev->mode_info.crtcs[i])
>+  hrtimer_cancel(>mode_info.crtcs[i]-
>>vblank_timer);
>
>   kfree(adev->mode_info.bios_hardcoded_edid);
>
>@@ -480,13 +485,6 @@ static int dce_virtual_hw_init(void *handle)
>
> static int dce_virtual_hw_fini(void *handle)  {
>-  struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>-  int i = 0;
>-
>-  for (i = 0; imode_info.num_crtc; i++)
>-  if (adev->mode_info.crtcs[i])
>-  hrtimer_cancel(>mode_info.crtcs[i]-
>>vblank_timer);
>-
>   return 0;
> }
>
>--
>2.29.0
>___
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>edesktop.org%2Fmailman%2Flistinfo%2Famd-
>gfxdata=04%7C01%7CEmily.Deng%40amd.com%7Cc36a726027e043366d
>9308d911daafc6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637
>560453220959024%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
>CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=tgM
>OtVhydrjPcZCF%2BZwE04DKVdYfTDDwl%2Bl0mHa0HOo%3Dreserved=0
<>___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


RE: [PATCH] drm/amd/amdgpu: Cancel the hrtimer in sw_fini

2021-05-07 Thread Sun, Roy
[AMD Official Use Only - Internal Distribution Only]

Ping

-Original Message-
From: Roy Sun  
Sent: Tuesday, April 6, 2021 8:21 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sun, Roy 
Subject: [PATCH] drm/amd/amdgpu: Cancel the hrtimer in sw_fini

Move the process of cancelling hrtimer to sw_fini

Signed-off-by: Roy Sun 
---
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c 
b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 5c11144da051..33324427b555 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -421,6 +421,11 @@ static int dce_virtual_sw_init(void *handle)  static int 
dce_virtual_sw_fini(void *handle)  {
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
+   int i = 0;
+
+   for (i = 0; i < adev->mode_info.num_crtc; i++)
+   if (adev->mode_info.crtcs[i])
+   hrtimer_cancel(>mode_info.crtcs[i]->vblank_timer);
 
kfree(adev->mode_info.bios_hardcoded_edid);
 
@@ -480,13 +485,6 @@ static int dce_virtual_hw_init(void *handle)
 
 static int dce_virtual_hw_fini(void *handle)  {
-   struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-   int i = 0;
-
-   for (i = 0; imode_info.num_crtc; i++)
-   if (adev->mode_info.crtcs[i])
-   hrtimer_cancel(>mode_info.crtcs[i]->vblank_timer);
-
return 0;
 }
 
--
2.29.0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx