RE: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.

2019-12-05 Thread Quan, Evan 
Reviewed-by: Evan Quan 

> -Original Message-
> From: amd-gfx  On Behalf Of Andrey
> Grodzovsky
> Sent: Friday, December 6, 2019 3:30 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Grodzovsky, Andrey
> 
> Subject: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.
> 
> BACO feature must be kept enabled to allow entry into BACO state in SMU
> during runtime suspend.
> 
> Signed-off-by: Andrey Grodzovsky 
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index c30f9a2..678 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -1383,7 +1383,7 @@ static int smu_suspend(void *handle)
>   if (ret)
>   return ret;
> 
> - if (adev->in_gpu_reset && baco_feature_is_enabled) {
> + if (baco_feature_is_enabled) {
>   ret = smu_feature_set_enabled(smu,
> SMU_FEATURE_BACO_BIT, true);
>   if (ret) {
>   pr_warn("set BACO feature enabled failed,
> return %d\n", ret);
> --
> 2.7.4
> 
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free
> desktop.org%2Fmailman%2Flistinfo%2Famd-
> gfxdata=02%7C01%7Cevan.quan%40amd.com%7C30207edddf64470488
> b808d779b97bb1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637
> 111710023605585sdata=9vXWJjskRpnlbPR5baJa%2BDt4KZiycSiUyB8Fl2b
> vsnk%3Dreserved=0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.

2019-12-05 Thread Deucher, Alexander 
> -Original Message-
> From: Andrey Grodzovsky 
> Sent: Thursday, December 5, 2019 2:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Grodzovsky,
> Andrey 
> Subject: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.
> 
> BACO feature must be kept enabled to allow entry into BACO state in SMU
> during runtime suspend.
> 
> Signed-off-by: Andrey Grodzovsky 

Reviewed-by: Alex Deucher 
Tested-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index c30f9a2..678 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -1383,7 +1383,7 @@ static int smu_suspend(void *handle)
>   if (ret)
>   return ret;
> 
> - if (adev->in_gpu_reset && baco_feature_is_enabled) {
> + if (baco_feature_is_enabled) {
>   ret = smu_feature_set_enabled(smu,
> SMU_FEATURE_BACO_BIT, true);
>   if (ret) {
>   pr_warn("set BACO feature enabled failed, return
> %d\n", ret);
> --
> 2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx