RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Public Use]
Good catch, I'll update my habit with this
From: Chen, Guchun
Sent: Friday, January 3, 2020 4:33 PM
To: Clements, John ; Zhang, Hawking
; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Public Use]
Thanks John.
+for (retry_loop = 0; retry_loop < 10; retry_loop++)
+{
The same coding style problem that "{" should not start at one new line. With
this fixed, the patch is:
Reviewed-by: Guchun Chen mailto:guchun.c...@amd.com>>
Regards,
Guchun
From: Clements, John mailto:john.cleme...@amd.com>>
Sent: Friday, January 3, 2020 4:13 PM
To: Chen, Guchun mailto:guchun.c...@amd.com>>; Zhang,
Hawking mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Hello GuChun,
I have updated the patch with your suggestion, and added back in the delay.
I can potentially investigate its removal in another patch
Thank you,
John Clements
From: Chen, Guchun mailto:guchun.c...@amd.com>>
Sent: Friday, January 3, 2020 3:44 PM
To: Clements, John mailto:john.cleme...@amd.com>>;
Zhang, Hawking mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
- /* there might be handshake issue with hardware which needs delay
*/
- mdelay(20);
To be safety, I don't think we should remove this delay. And this actually do
nothing with the code refine in this patch.
Regards,
Guchun
From: amd-gfx
mailto:amd-gfx-boun...@lists.freedesktop.org>>
On Behalf Of Clements, John
Sent: Friday, January 3, 2020 3:29 PM
To: Zhang, Hawking mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Added dedicated function to wait for PSP BL availability.
Increased driver wait time for PSP BL availability.
Thank you,
John Clements
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Public Use]
Thanks John.
+for (retry_loop = 0; retry_loop < 10; retry_loop++)
+{
The same coding style problem that "{" should not start at one new line. With
this fixed, the patch is:
Reviewed-by: Guchun Chen
Regards,
Guchun
From: Clements, John
Sent: Friday, January 3, 2020 4:13 PM
To: Chen, Guchun ; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Hello GuChun,
I have updated the patch with your suggestion, and added back in the delay.
I can potentially investigate its removal in another patch
Thank you,
John Clements
From: Chen, Guchun mailto:guchun.c...@amd.com>>
Sent: Friday, January 3, 2020 3:44 PM
To: Clements, John mailto:john.cleme...@amd.com>>;
Zhang, Hawking mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
- /* there might be handshake issue with hardware which needs delay
*/
- mdelay(20);
To be safety, I don't think we should remove this delay. And this actually do
nothing with the code refine in this patch.
Regards,
Guchun
From: amd-gfx
mailto:amd-gfx-boun...@lists.freedesktop.org>>
On Behalf Of Clements, John
Sent: Friday, January 3, 2020 3:29 PM
To: Zhang, Hawking mailto:hawking.zh...@amd.com>>;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only]
Added dedicated function to wait for PSP BL availability.
Increased driver wait time for PSP BL availability.
Thank you,
John Clements
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only] Hello GuChun, I have updated the patch with your suggestion, and added back in the delay. I can potentially investigate its removal in another patch Thank you, John Clements From: Chen, Guchun Sent: Friday, January 3, 2020 3:44 PM To: Clements, John ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability [AMD Official Use Only - Internal Distribution Only] - /* there might be handshake issue with hardware which needs delay */ - mdelay(20); To be safety, I don't think we should remove this delay. And this actually do nothing with the code refine in this patch. Regards, Guchun From: amd-gfx mailto:amd-gfx-boun...@lists.freedesktop.org>> On Behalf Of Clements, John Sent: Friday, January 3, 2020 3:29 PM To: Zhang, Hawking mailto:hawking.zh...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability [AMD Official Use Only - Internal Distribution Only] Added dedicated function to wait for PSP BL availability. Increased driver wait time for PSP BL availability. Thank you, John Clements 0001-drm-amdgpu-added-function-to-wait-for-PSP-BL-availab.patch Description: 0001-drm-amdgpu-added-function-to-wait-for-PSP-BL-availab.patch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH] drm/amdgpu: added function to wait for PSP BL availability
[AMD Official Use Only - Internal Distribution Only] - /* there might be handshake issue with hardware which needs delay */ - mdelay(20); To be safety, I don't think we should remove this delay. And this actually do nothing with the code refine in this patch. Regards, Guchun From: amd-gfx On Behalf Of Clements, John Sent: Friday, January 3, 2020 3:29 PM To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: added function to wait for PSP BL availability [AMD Official Use Only - Internal Distribution Only] Added dedicated function to wait for PSP BL availability. Increased driver wait time for PSP BL availability. Thank you, John Clements ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
