Re: [PATCH 1/2] drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE

2019-07-01 Thread Yuan, Xiaojie
Reviewed-by: Xiaojie Yuan 

BR,
Xiaojie


From: amd-gfx  on behalf of Alex Deucher 

Sent: Monday, July 1, 2019 10:00 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE

Recommended by the hw team.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 9b413f6fa588..5bdd7c42b00e 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -1960,25 +1960,6 @@ static void gfx_v9_0_constants_init(struct amdgpu_device 
*adev)
mutex_unlock(&adev->srbm_mutex);

gfx_v9_0_init_compute_vmid(adev);
-
-   mutex_lock(&adev->grbm_idx_mutex);
-   /*
-* making sure that the following register writes will be broadcasted
-* to all the shaders
-*/
-   gfx_v9_0_select_se_sh(adev, 0x, 0x, 0x);
-
-   WREG32_SOC15_RLC(GC, 0, mmPA_SC_FIFO_SIZE,
-  (adev->gfx.config.sc_prim_fifo_size_frontend <<
-   PA_SC_FIFO_SIZE__SC_FRONTEND_PRIM_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_prim_fifo_size_backend <<
-   PA_SC_FIFO_SIZE__SC_BACKEND_PRIM_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_hiz_tile_fifo_size <<
-   PA_SC_FIFO_SIZE__SC_HIZ_TILE_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_earlyz_tile_fifo_size <<
-   PA_SC_FIFO_SIZE__SC_EARLYZ_TILE_FIFO_SIZE__SHIFT));
-   mutex_unlock(&adev->grbm_idx_mutex);
-
 }

 static void gfx_v9_0_wait_for_rlc_serdes(struct amdgpu_device *adev)
--
2.20.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 1/2] drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE

2019-07-01 Thread Huang, Ray
Series are Reviewed-and-Tested-by: Huang Rui 

-Original Message-
From: amd-gfx  On Behalf Of Alex Deucher
Sent: Monday, July 1, 2019 9:00 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander 
Subject: [PATCH 1/2] drm/amdgpu/gfx9: use reset default for PA_SC_FIFO_SIZE

Recommended by the hw team.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 9b413f6fa588..5bdd7c42b00e 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -1960,25 +1960,6 @@ static void gfx_v9_0_constants_init(struct amdgpu_device 
*adev)
mutex_unlock(&adev->srbm_mutex);
 
gfx_v9_0_init_compute_vmid(adev);
-
-   mutex_lock(&adev->grbm_idx_mutex);
-   /*
-* making sure that the following register writes will be broadcasted
-* to all the shaders
-*/
-   gfx_v9_0_select_se_sh(adev, 0x, 0x, 0x);
-
-   WREG32_SOC15_RLC(GC, 0, mmPA_SC_FIFO_SIZE,
-  (adev->gfx.config.sc_prim_fifo_size_frontend <<
-   PA_SC_FIFO_SIZE__SC_FRONTEND_PRIM_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_prim_fifo_size_backend <<
-   PA_SC_FIFO_SIZE__SC_BACKEND_PRIM_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_hiz_tile_fifo_size <<
-   PA_SC_FIFO_SIZE__SC_HIZ_TILE_FIFO_SIZE__SHIFT) |
-  (adev->gfx.config.sc_earlyz_tile_fifo_size <<
-   PA_SC_FIFO_SIZE__SC_EARLYZ_TILE_FIFO_SIZE__SHIFT));
-   mutex_unlock(&adev->grbm_idx_mutex);
-
 }
 
 static void gfx_v9_0_wait_for_rlc_serdes(struct amdgpu_device *adev)
-- 
2.20.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx