[Public] Reviewed-by: Roman Li <roman...@amd.com>
> -----Original Message----- > From: SHANMUGAM, SRINIVASAN <srinivasan.shanmu...@amd.com> > Sent: Wednesday, May 31, 2023 1:46 PM > To: Pillai, Aurabindo <aurabindo.pil...@amd.com>; Mahfooz, Hamza > <hamza.mahf...@amd.com>; Siqueira, Rodrigo > <rodrigo.sique...@amd.com>; Wentland, Harry > <harry.wentl...@amd.com>; Li, Roman <roman...@amd.com> > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > <srinivasan.shanmu...@amd.com> > Subject: [PATCH v2] drm/amd/display: Drop unused DCN_BASE variable in > dcn314_resource.c > > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_resource.c:12 > 8:29: warning: ‘DCN_BASE’ defined but not used [-Wunused-const-variable=] > 128 | static const struct IP_BASE DCN_BASE = { { { { 0x00000012, > 0x000000C0, 0x000034C0, 0x00009000, 0x02403C00, 0, 0, 0 } }, > | ^~~~~~~~ > > Suggested-by: Roman Li <roman...@amd.com> > Cc: Hamza Mahfooz <hamza.mahf...@amd.com> > Cc: Rodrigo Siqueira <rodrigo.sique...@amd.com> > Cc: Harry Wentland <harry.wentl...@amd.com> > Cc: Aurabindo Pillai <aurabindo.pil...@amd.com> > Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com> > --- > > v2: > - Remove even unused IP_BASE_INSTANCE and IP_BASE struct definitions > altogether (Roman) > > .../drm/amd/display/dc/dcn314/dcn314_resource.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > index 3592efcc7fae..837884c4f03a 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c > @@ -117,23 +117,6 @@ > #define regBIF_BX2_BIOS_SCRATCH_6 0x003e > #define regBIF_BX2_BIOS_SCRATCH_6_BASE_IDX 1 > > -struct IP_BASE_INSTANCE { > - unsigned int segment[MAX_SEGMENT]; > -}; > - > -struct IP_BASE { > - struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; > -}; > - > -static const struct IP_BASE DCN_BASE = { { { { 0x00000012, 0x000000C0, > 0x000034C0, 0x00009000, 0x02403C00, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0, 0, 0 } } } }; > - > - > #define DC_LOGGER_INIT(logger) > > enum dcn31_clk_src_array_id { > -- > 2.25.1