RE: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
[AMD Official Use Only - Internal Distribution Only] Hi Michel and Alex, Ok, let us abandon the patch, wish user mode driver could fix those issues encountered after resolution bigger than 16384. Best wishes Emily Deng >-Original Message- >From: Michel Dänzer >Sent: Monday, January 11, 2021 7:52 PM >To: Deng, Emily ; Alex Deucher > >Cc: amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display > >On 2021-01-11 12:50 p.m., Michel Dänzer wrote: >> On 2021-01-11 5:55 a.m., Deng, Emily wrote: >>> [AMD Official Use Only - Internal Distribution Only] >>> >>> Yes, it just won't report bigger than 16384 mode to user mode, as it >>> won't work properly. >> >> ... with Xorg / glamor. It doesn't affect other user-space. > >Let me rephrase: This would artificially limit other user-space. > > >-- >Earthling Michel Dänzer | >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredha >t.com%2Fdata=04%7C01%7CEmily.Deng%40amd.com%7Cae76e0607c >d84ddba1c308d8b6275595%7C3dd8961fe4884e608e11a82d994e183d%7C0% >7C0%7C637459627355417401%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 >wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000 >mp;sdata=DoZlNXoNACkAbfn%2FcobBOM3D6Q60TgMz0bMSdCIgAVk%3D >mp;reserved=0 >Libre software enthusiast | Mesa and X developer ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
On 2021-01-11 12:50 p.m., Michel Dänzer wrote: On 2021-01-11 5:55 a.m., Deng, Emily wrote: [AMD Official Use Only - Internal Distribution Only] Yes, it just won't report bigger than 16384 mode to user mode, as it won't work properly. ... with Xorg / glamor. It doesn't affect other user-space. Let me rephrase: This would artificially limit other user-space. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
On 2021-01-11 5:55 a.m., Deng, Emily wrote: [AMD Official Use Only - Internal Distribution Only] Yes, it just won't report bigger than 16384 mode to user mode, as it won't work properly. ... with Xorg / glamor. It doesn't affect other user-space. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
[AMD Official Use Only - Internal Distribution Only]
Yes, it just won't report bigger than 16384 mode to user mode, as it won't work
properly.
Best wishes
Emily Deng
>-Original Message-
>From: Alex Deucher
>Sent: Friday, January 8, 2021 11:14 PM
>To: Deng, Emily
>Cc: amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
>
>On Thu, Jan 7, 2021 at 8:45 PM Deng, Emily wrote:
>>
>> [AMD Official Use Only - Internal Distribution Only]
>>
>> Ping ..
>>
>
>It's not clear what problem this solves.
>
>Alex
>
>
>> Best wishes
>> Emily Deng
>>
>>
>>
>> >-Original Message-
>> >From: Emily Deng
>> >Sent: Thursday, January 7, 2021 11:29 AM
>> >To: amd-gfx@lists.freedesktop.org
>> >Cc: Deng, Emily
>> >Subject: [PATCH v2] drm/amdgpu:Limit the resolution for
>> >virtual_display
>> >
>> >From: "Emily.Deng"
>> >
>> >Limit the resolution not bigger than 16384, which means
>> >dev->mode_info.num_crtc * common_modes[i].w not bigger than 16384.
>> >
>> >v2:
>> > Refine the code
>> >
>> >Signed-off-by: Emily.Deng
>> >---
>> > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 7 +--
>> > 1 file changed, 5 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> >b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> >index 2b16c8faca34..fd2b3a6dfd60 100644
>> >--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> >+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> >@@ -319,6 +319,7 @@ dce_virtual_encoder(struct drm_connector
>> >*connector) static int dce_virtual_get_modes(struct drm_connector
>> >*connector) {
>> > struct drm_device *dev = connector->dev;
>> >+struct amdgpu_device *adev = dev->dev_private;
>> > struct drm_display_mode *mode = NULL; unsigned i; static const
>> >struct mode_size { @@ -350,8 +351,10 @@ static int
>> >dce_virtual_get_modes(struct drm_connector *connector) };
>> >
>> > for (i = 0; i < ARRAY_SIZE(common_modes); i++) { -mode =
>> >drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false,
>> >false, false); -drm_mode_probed_add(connector, mode);
>> >+if (adev->mode_info.num_crtc * common_modes[i].w <=
>> >16384) {
>> >+mode = drm_cvt_mode(dev, common_modes[i].w,
>> >common_modes[i].h, 60, false, false, false);
>> >+drm_mode_probed_add(connector, mode); }
>> > }
>> >
>> > return 0;
>> >--
>> >2.25.1
>>
>> ___
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>>
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
>reedesktop.org%2Fmailman%2Flistinfo%2Famd-
>gfxdata=04%7C01%7CEmily.Deng%40amd.com%7C74bdfb637c914153
>938508d8b3e81705%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7
>C637457156687621480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
>MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sda
>ta=nDMymiTnfGo3ScIogcE8bch6ptCULS2GXSnuLcYQZEA%3Dreserved=
>0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
On Thu, Jan 7, 2021 at 8:45 PM Deng, Emily wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Ping ..
>
It's not clear what problem this solves.
Alex
> Best wishes
> Emily Deng
>
>
>
> >-Original Message-
> >From: Emily Deng
> >Sent: Thursday, January 7, 2021 11:29 AM
> >To: amd-gfx@lists.freedesktop.org
> >Cc: Deng, Emily
> >Subject: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
> >
> >From: "Emily.Deng"
> >
> >Limit the resolution not bigger than 16384, which means
> >dev->mode_info.num_crtc * common_modes[i].w not bigger than 16384.
> >
> >v2:
> > Refine the code
> >
> >Signed-off-by: Emily.Deng
> >---
> > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 7 +--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >index 2b16c8faca34..fd2b3a6dfd60 100644
> >--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >@@ -319,6 +319,7 @@ dce_virtual_encoder(struct drm_connector
> >*connector) static int dce_virtual_get_modes(struct drm_connector
> >*connector) {
> > struct drm_device *dev = connector->dev;
> >+struct amdgpu_device *adev = dev->dev_private;
> > struct drm_display_mode *mode = NULL;
> > unsigned i;
> > static const struct mode_size {
> >@@ -350,8 +351,10 @@ static int dce_virtual_get_modes(struct
> >drm_connector *connector)
> > };
> >
> > for (i = 0; i < ARRAY_SIZE(common_modes); i++) {
> >-mode = drm_cvt_mode(dev, common_modes[i].w,
> >common_modes[i].h, 60, false, false, false);
> >-drm_mode_probed_add(connector, mode);
> >+if (adev->mode_info.num_crtc * common_modes[i].w <=
> >16384) {
> >+mode = drm_cvt_mode(dev, common_modes[i].w,
> >common_modes[i].h, 60, false, false, false);
> >+drm_mode_probed_add(connector, mode);
> >+}
> > }
> >
> > return 0;
> >--
> >2.25.1
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
[AMD Official Use Only - Internal Distribution Only]
Ping ..
Best wishes
Emily Deng
>-Original Message-
>From: Emily Deng
>Sent: Thursday, January 7, 2021 11:29 AM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily
>Subject: [PATCH v2] drm/amdgpu:Limit the resolution for virtual_display
>
>From: "Emily.Deng"
>
>Limit the resolution not bigger than 16384, which means
>dev->mode_info.num_crtc * common_modes[i].w not bigger than 16384.
>
>v2:
> Refine the code
>
>Signed-off-by: Emily.Deng
>---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>index 2b16c8faca34..fd2b3a6dfd60 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>@@ -319,6 +319,7 @@ dce_virtual_encoder(struct drm_connector
>*connector) static int dce_virtual_get_modes(struct drm_connector
>*connector) {
> struct drm_device *dev = connector->dev;
>+struct amdgpu_device *adev = dev->dev_private;
> struct drm_display_mode *mode = NULL;
> unsigned i;
> static const struct mode_size {
>@@ -350,8 +351,10 @@ static int dce_virtual_get_modes(struct
>drm_connector *connector)
> };
>
> for (i = 0; i < ARRAY_SIZE(common_modes); i++) {
>-mode = drm_cvt_mode(dev, common_modes[i].w,
>common_modes[i].h, 60, false, false, false);
>-drm_mode_probed_add(connector, mode);
>+if (adev->mode_info.num_crtc * common_modes[i].w <=
>16384) {
>+mode = drm_cvt_mode(dev, common_modes[i].w,
>common_modes[i].h, 60, false, false, false);
>+drm_mode_probed_add(connector, mode);
>+}
> }
>
> return 0;
>--
>2.25.1
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
