Re: [PATCH] drm/amdgpu: Declare Unpin BO api as static

[Alex Deucher]

I sent my RB, last week, but maybe it never made it to the list?

Reviewed-by: Alex Deucher 

On Mon, Nov 22, 2021 at 2:58 PM Errabolu, Ramesh
 wrote:
>
> [AMD Official Use Only]
>
> Request review
>
> Regards,
> Ramesh
>
> -Original Message-
> From: amd-gfx  On Behalf Of Ramesh 
> Errabolu
> Sent: Thursday, November 18, 2021 4:12 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Errabolu, Ramesh ; kernel test robot 
> 
> Subject: [PATCH] drm/amdgpu: Declare Unpin BO api as static
>
> [CAUTION: External Email]
>
> Fixes warning report from kernel test robot
>
> Reported-by: kernel test robot 
> Signed-off-by: Ramesh Errabolu 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 90b985436878..3463e0d4e5ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1332,7 +1332,7 @@ static int amdgpu_amdkfd_gpuvm_pin_bo(struct amdgpu_bo 
> *bo, u32 domain)
>   *   - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
>   * PIN count decremented. Calls to UNPIN must balance calls to PIN
>   */
> -void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
> +static void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
>  {
> int ret = 0;
>
> --
> 2.31.1

RE: [PATCH] drm/amdgpu: Declare Unpin BO api as static

[Errabolu, Ramesh]

[AMD Official Use Only]

Request review

Regards,
Ramesh

-Original Message-
From: amd-gfx  On Behalf Of Ramesh 
Errabolu
Sent: Thursday, November 18, 2021 4:12 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh ; kernel test robot 

Subject: [PATCH] drm/amdgpu: Declare Unpin BO api as static

[CAUTION: External Email]

Fixes warning report from kernel test robot

Reported-by: kernel test robot 
Signed-off-by: Ramesh Errabolu 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 90b985436878..3463e0d4e5ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1332,7 +1332,7 @@ static int amdgpu_amdkfd_gpuvm_pin_bo(struct amdgpu_bo 
*bo, u32 domain)
  *   - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
  * PIN count decremented. Calls to UNPIN must balance calls to PIN
  */
-void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
+static void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
 {
int ret = 0;

--
2.31.1

Re: [PATCH] drm/amdgpu: Declare Unpin BO api as static

[Deucher, Alexander]

[Public]

Reviewed-by: Alex Deucher 

From: amd-gfx  on behalf of Ramesh 
Errabolu 
Sent: Thursday, November 18, 2021 5:11 PM
To: amd-gfx@lists.freedesktop.org 
Cc: Errabolu, Ramesh ; kernel test robot 

Subject: [PATCH] drm/amdgpu: Declare Unpin BO api as static

Fixes warning report from kernel test robot

Reported-by: kernel test robot 
Signed-off-by: Ramesh Errabolu 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 90b985436878..3463e0d4e5ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1332,7 +1332,7 @@ static int amdgpu_amdkfd_gpuvm_pin_bo(struct amdgpu_bo 
*bo, u32 domain)
  *   - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
  * PIN count decremented. Calls to UNPIN must balance calls to PIN
  */
-void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
+static void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
 {
 int ret = 0;

--
2.31.1