Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[Wang, Ken]

It fixes some headless board VBIOS which will be failed to load.


From: Alex Deucher <alexdeuc...@gmail.com>
Sent: Wednesday, November 8, 2017 10:38:37 PM
To: Wang, Ken
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain 
VBIOS

On Wed, Nov 8, 2017 at 1:49 AM,  <ken.w...@amd.com> wrote:
> From: Ken Wang <ken.w...@amd.com>

What cases does this fix?  I'm guessing VFCT or some other platform
method for getting the vbios?

Acked-by: Alex Deucher <alexander.deuc...@amd.com>

>
> Signed-off-by: Ken Wang <ken.w...@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 --
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index c21adf6..057e1ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -59,12 +59,6 @@ static bool check_atom_bios(uint8_t *bios, size_t size)
> return false;
> }
>
> -   tmp = bios[0x18] | (bios[0x19] << 8);
> -   if (bios[tmp + 0x14] != 0x0) {
> -   DRM_INFO("Not an x86 BIOS ROM\n");
> -   return false;
> -   }
> -
> bios_header_start = bios[0x48] | (bios[0x49] << 8);
> if (!bios_header_start) {
> DRM_INFO("Can't locate bios header\n");
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[Alex Deucher]

On Wed, Nov 8, 2017 at 1:49 AM,   wrote:
> From: Ken Wang 

What cases does this fix?  I'm guessing VFCT or some other platform
method for getting the vbios?

Acked-by: Alex Deucher 

>
> Signed-off-by: Ken Wang 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 --
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index c21adf6..057e1ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -59,12 +59,6 @@ static bool check_atom_bios(uint8_t *bios, size_t size)
> return false;
> }
>
> -   tmp = bios[0x18] | (bios[0x19] << 8);
> -   if (bios[tmp + 0x14] != 0x0) {
> -   DRM_INFO("Not an x86 BIOS ROM\n");
> -   return false;
> -   }
> -
> bios_header_start = bios[0x48] | (bios[0x49] << 8);
> if (!bios_header_start) {
> DRM_INFO("Can't locate bios header\n");
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx